tyler.durden
/
icinga2
mirror of https://github.com/Icinga/icinga2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Elasticsearch: Improve error handling/logging 

- Missing content-type
- Wrong content-type shouldn't hide the error message
- Error message should include more details (request URL, etc.)
This commit is contained in:
Michael Friedrich 2019-03-18 16:41:01 +01:00
parent 00b8fb1f49
commit 816a935b3d
1 changed files with 10 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
lib/perfdata/elasticsearchwriter.cpp
View File

@ -512,15 +512,13 @@ void ElasticsearchWriter::SendRequest(const String& body)
return;
}
Log(LogWarning, "ElasticsearchWriter")
<< "Unexpected response code " << resp.StatusCode;
std::ostringstream msgbuf;
msgbuf << "Unexpected response code " << resp.StatusCode << " from URL '" << req.RequestUrl->Format() << "'";
String contentType = resp.Headers->Get("content-type");
if (contentType != "application/json") {
Log(LogWarning, "ElasticsearchWriter")
<< "Unexpected Content-Type: " << contentType;
return;
if (contentType != "application/json" && contentType != "application/json; charset=utf-8") {
msgbuf << "; Unexpected Content-Type: '" << contentType << "'";
}
size_t responseSize = resp.GetBodySize();
@ -528,6 +526,11 @@ void ElasticsearchWriter::SendRequest(const String& body)
resp.ReadBody(buffer.get(), responseSize);
buffer.get()[responseSize] = '\0';
#ifdef I2_DEBUG
msgbuf << "; Response body: '" << buffer.get() << "'";
#endif /* I2_DEBUG */
/* {"statusCode":404,"error":"Not Found","message":"Not Found"} */
Dictionary::Ptr jsonResponse;
try {
jsonResponse = JsonDecode(buffer.get());
@ -540,7 +543,7 @@ void ElasticsearchWriter::SendRequest(const String& body)
String error = jsonResponse->Get("error");
Log(LogCritical, "ElasticsearchWriter")
<< "Elasticsearch error message:\n" << error;
<< "Error: '" << error << "'. " << msgbuf.str();
return;
}