tyler.durden
/
icinga2
mirror of https://github.com/Icinga/icinga2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix CA2202 code analysis warning in the Windows wizard

This commit is contained in:
Gunnar Beutner 2014-11-13 20:18:41 +01:00
parent 979b99ea6f
commit 98d81ffc85
1 changed files with 22 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
agent/windows-setup-agent/SetupWizard.cs
View File

@ -83,10 +83,16 @@ namespace Icinga
private void EnableFeature(string feature) private void EnableFeature(string feature)
{ {
using (FileStream fp = File.Open(Icinga2InstallDir + String.Format("\\etc\\icinga2\\features-enabled\\{0}.conf", feature), FileMode.Create)) { FileStream fp = null;
try {
fp = File.Open(Icinga2InstallDir + String.Format("\\etc\\icinga2\\features-enabled\\{0}.conf", feature), FileMode.Create);
using (StreamWriter sw = new StreamWriter(fp, Encoding.ASCII)) { using (StreamWriter sw = new StreamWriter(fp, Encoding.ASCII)) {
fp = null;
sw.Write(String.Format("include \"../features-available/{0}.conf\"\n", feature)); sw.Write(String.Format("include \"../features-available/{0}.conf\"\n", feature));
} }
} finally {
if (fp != null)
fp.Dispose();
} }
} }
@ -164,8 +170,8 @@ namespace Icinga
if (!File.Exists(pathPrefix + ".crt")) { if (!File.Exists(pathPrefix + ".crt")) {
if (!RunProcess(Icinga2InstallDir + "\\sbin\\icinga2.exe", if (!RunProcess(Icinga2InstallDir + "\\sbin\\icinga2.exe",
"pki new-cert --cn \"" + txtInstanceName.Text + "\" --key \"" + pathPrefix + ".key\" --cert \"" + pathPrefix + ".crt\"", "pki new-cert --cn \"" + txtInstanceName.Text + "\" --key \"" + pathPrefix + ".key\" --cert \"" + pathPrefix + ".crt\"",
out output)) { out output)) {
ShowErrorText(output); ShowErrorText(output);
return; return;
} }
@ -176,8 +182,8 @@ namespace Icinga
_TrustedFile = Path.GetTempFileName(); _TrustedFile = Path.GetTempFileName();
if (!RunProcess(Icinga2InstallDir + "\\sbin\\icinga2.exe", if (!RunProcess(Icinga2InstallDir + "\\sbin\\icinga2.exe",
"pki save-cert --host \"" + host + "\" --port \"" + port + "\" --key \"" + pathPrefix + ".key\" --cert \"" + pathPrefix + ".crt\" --trustedcert \"" + _TrustedFile + "\"", "pki save-cert --host \"" + host + "\" --port \"" + port + "\" --key \"" + pathPrefix + ".key\" --cert \"" + pathPrefix + ".crt\" --trustedcert \"" + _TrustedFile + "\"",
out output)) { out output)) {
ShowErrorText(output); ShowErrorText(output);
return; return;
} }
@ -221,8 +227,8 @@ namespace Icinga
args += " --cn " + txtInstanceName.Text; args += " --cn " + txtInstanceName.Text;
if (!RunProcess(Icinga2InstallDir + "\\sbin\\icinga2.exe", if (!RunProcess(Icinga2InstallDir + "\\sbin\\icinga2.exe",
"agent setup" + args, "agent setup" + args,
out output)) { out output)) {
ShowErrorText(output); ShowErrorText(output);
return; return;
} }
@ -231,27 +237,27 @@ namespace Icinga
DirectoryInfo di = new DirectoryInfo(Icinga2InstallDir); DirectoryInfo di = new DirectoryInfo(Icinga2InstallDir);
DirectorySecurity ds = di.GetAccessControl(); DirectorySecurity ds = di.GetAccessControl();
FileSystemAccessRule rule = new FileSystemAccessRule("NT AUTHORITY\\NetworkService", FileSystemAccessRule rule = new FileSystemAccessRule("NT AUTHORITY\\NetworkService",
FileSystemRights.ReadAndExecute | FileSystemRights.Write | FileSystemRights.ListDirectory, FileSystemRights.ReadAndExecute | FileSystemRights.Write | FileSystemRights.ListDirectory,
InheritanceFlags.ObjectInherit | InheritanceFlags.ContainerInherit, PropagationFlags.None, AccessControlType.Allow); InheritanceFlags.ObjectInherit | InheritanceFlags.ContainerInherit, PropagationFlags.None, AccessControlType.Allow);
ds.AddAccessRule(rule); ds.AddAccessRule(rule);
di.SetAccessControl(ds); di.SetAccessControl(ds);
SetConfigureStatus(75, "Installing the Icinga 2 service..."); SetConfigureStatus(75, "Installing the Icinga 2 service...");
RunProcess(Icinga2InstallDir + "\\sbin\\icinga2.exe", RunProcess(Icinga2InstallDir + "\\sbin\\icinga2.exe",
"--scm-uninstall", "--scm-uninstall",
out output); out output);
if (!RunProcess(Icinga2InstallDir + "\\sbin\\icinga2.exe", if (!RunProcess(Icinga2InstallDir + "\\sbin\\icinga2.exe",
"daemon --validate", "daemon --validate",
out output)) { out output)) {
ShowErrorText(output); ShowErrorText(output);
return; return;
} }
if (!RunProcess(Icinga2InstallDir + "\\sbin\\icinga2.exe", if (!RunProcess(Icinga2InstallDir + "\\sbin\\icinga2.exe",
"--scm-install daemon", "--scm-install daemon",
out output)) { out output)) {
ShowErrorText(output); ShowErrorText(output);
return; return;
} }
@ -372,7 +378,7 @@ namespace Icinga
} }
/*if (tbcPages.SelectedTab == tabParameters && /*if (tbcPages.SelectedTab == tabParameters &&
!File.Exists(Icinga2InstallDir + "\\etc\\icinga2\\pki\\agent\\agent.crt")) { !File.Exists(Icinga2InstallDir + "\\etc\\icinga2\\pki\\agent\\agent.crt")) {
byte[] bytes = Convert.FromBase64String(txtBundle.Text); byte[] bytes = Convert.FromBase64String(txtBundle.Text);
MemoryStream ms = new MemoryStream(bytes); MemoryStream ms = new MemoryStream(bytes);
GZipStream gz = new GZipStream(ms, CompressionMode.Decompress); GZipStream gz = new GZipStream(ms, CompressionMode.Decompress);