tyler.durden/icinga2
1
0
Fork 0
mirror of https://github.com/Icinga/icinga2.git synced 2025-07-27 07:34:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix logical error with zero dependencies in IsReachable()

Browse Source
This commit is contained in:
Michael Friedrich 2020-02-10 16:16:12 +01:00
parent 76d531b4f0
commit 9b0365ab43
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/icinga/checkable-dependency.cpp
View File

@ -74,6 +74,7 @@ bool Checkable::IsReachable(DependencyType dt, Dependency::Ptr *failedDependency
auto deps = GetDependencies(); auto deps = GetDependencies();
int countDeps = deps.size();
int countFailed = 0; int countFailed = 0;
for (const Dependency::Ptr& dep : deps) { for (const Dependency::Ptr& dep : deps) {
@ -85,7 +86,8 @@ bool Checkable::IsReachable(DependencyType dt, Dependency::Ptr *failedDependency
} }
} }
if (countFailed == deps.size()) { /* If there are dependencies, and all of them failed, mark as unreachable. */
if (countDeps > 0 && countFailed == countDeps) {
Log(LogDebug, "Checkable") Log(LogDebug, "Checkable")
<< "All dependencies have failed for checkable '" << GetName() << "': Marking as unreachable."; << "All dependencies have failed for checkable '" << GetName() << "': Marking as unreachable.";