tyler.durden/icinga2
1
0
Fork 0
mirror of https://github.com/Icinga/icinga2.git synced 2025-07-25 14:44:32 +02:00
Code Issues Packages Projects Releases Wiki Activity

Address comments from review

Browse Source
This commit is contained in:
William Calliari 2025-04-16 12:04:53 +02:00
parent abf2fb392b
commit 9d40de78eb
No known key found for this signature in database
GPG Key ID: DBFD45030805358F
1 changed files with 10 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
lib/icinga/checkable-check.cpp
View File

@ -344,14 +344,21 @@ Checkable::ProcessingResult Checkable::ProcessCheckResult(const CheckResult::Ptr
cr->SetVarsAfter(vars_after); cr->SetVarsAfter(vars_after);
bool problem_change = false;
if (service) { if (service) {
SetLastCheckResult(cr); SetLastCheckResult(cr);
} else { } else {
bool wasProblem = GetProblem(); bool wasProblem = GetProblem();
SetLastCheckResult(cr); SetLastCheckResult(cr);
problem_change = GetProblem() != wasProblem;
if (GetProblem() != wasProblem) {
auto services = host->GetServices();
for (auto& service : services) {
Service::OnHostProblemChanged(service, cr, origin);
}
}
} }
bool was_flapping = IsFlapping(); bool was_flapping = IsFlapping();
UpdateFlappingStatus(cr->GetState()); UpdateFlappingStatus(cr->GetState());
@ -501,13 +508,7 @@ Checkable::ProcessingResult Checkable::ProcessCheckResult(const CheckResult::Ptr
if ((stateChange || hardChange) && !children.empty() && (affectsPreviousStateChildren || AffectsChildren())) if ((stateChange || hardChange) && !children.empty() && (affectsPreviousStateChildren || AffectsChildren()))
OnReachabilityChanged(this, cr, children, origin); OnReachabilityChanged(this, cr, children, origin);
olock->Unlock(); olock.Unlock();
if (!service && problem_change) {
auto services = host->GetServices();
for (auto& service : services) {
Service::OnHostProblemChanged(service, cr, origin);
}
}
if (recovery) { if (recovery) {
for (auto& child : children) { for (auto& child : children) {