tyler.durden/icinga2
1
0
Fork 0
mirror of https://github.com/Icinga/icinga2.git synced 2025-11-03 21:25:56 +01:00
Code Issues Packages Projects Releases Wiki Activity

DB IDO: Make sure that all result sets are processed before sending another query

Browse Source 
fixes #12597
This commit is contained in:
Michael Friedrich 2016-11-22 15:54:56 +01:00
parent 56e9a23a65
commit b028ff2c33
2 changed files with 26 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
lib/db_ido_mysql/idomysqlconnection.cpp
View File

@ -513,20 +513,21 @@ void IdoMysqlConnection::FinishAsyncQueries(void)
); );
} }
std::vector<IdoMysqlResultInfo> resultSets;
for (std::vector<IdoAsyncQuery>::size_type i = offset; i < offset + count; i++) { for (std::vector<IdoAsyncQuery>::size_type i = offset; i < offset + count; i++) {
const IdoAsyncQuery& aq = queries[i]; const IdoAsyncQuery& aq = queries[i];
MYSQL_RES *result = mysql_store_result(&m_Connection); MYSQL_RES *result = mysql_store_result(&m_Connection);
m_AffectedRows = mysql_affected_rows(&m_Connection); int affectedRows = mysql_affected_rows(&m_Connection);
IdoMysqlResult iresult; IdoMysqlResult iresult;
if (!result) { if (!result) {
if (mysql_field_count(&m_Connection) > 0) { if (mysql_field_count(&m_Connection) > 0) {
std::ostringstream msgbuf; std::ostringstream msgbuf;
String message = mysql_error(&m_Connection); String message = mysql_error(&m_Connection);
msgbuf << "Error \"" << message << "\" when executing query \"" << aq.Query << "\""; msgbuf << "Error \"" << message << "\" when checking field count \"" << aq.Query << "\"";
Log(LogCritical, "IdoMysqlConnection", msgbuf.str()); Log(LogCritical, "IdoMysqlConnection", msgbuf.str());
BOOST_THROW_EXCEPTION( BOOST_THROW_EXCEPTION(
@ -538,8 +539,11 @@ void IdoMysqlConnection::FinishAsyncQueries(void)
} else } else
iresult = IdoMysqlResult(result, std::ptr_fun(mysql_free_result)); iresult = IdoMysqlResult(result, std::ptr_fun(mysql_free_result));
if (aq.Callback) IdoMysqlResultInfo resultInfo;
aq.Callback(iresult); resultInfo.Result = iresult;
resultInfo.AffectedRows = affectedRows;
resultSets.push_back(resultInfo);
if (mysql_next_result(&m_Connection) > 0) { if (mysql_next_result(&m_Connection) > 0) {
std::ostringstream msgbuf; std::ostringstream msgbuf;
@ -555,6 +559,17 @@ void IdoMysqlConnection::FinishAsyncQueries(void)
} }
} }
for (std::vector<IdoAsyncQuery>::size_type i = offset; i < offset + count; i++) {
const IdoAsyncQuery& aq = queries[i];
const IdoMysqlResultInfo ri = resultSets[i - offset];
m_AffectedRows = ri.AffectedRows;
if (aq.Callback)
aq.Callback(ri.Result);
}
offset += count; offset += count;
} }
} }

6
lib/db_ido_mysql/idomysqlconnection.hpp
View File

@ -39,6 +39,12 @@ struct IdoAsyncQuery
IdoAsyncCallback Callback; IdoAsyncCallback Callback;
}; };
struct IdoMysqlResultInfo
{
IdoMysqlResult Result;
int AffectedRows;
};
/** /**
* An IDO MySQL database connection. * An IDO MySQL database connection.
* *