tyler.durden
/
icinga2
mirror of https://github.com/Icinga/icinga2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Performance improvements for Value -> double conversions.

This commit is contained in:
Gunnar Beutner 2013-03-27 06:26:42 +00:00
parent 604b57da43
commit babc948cd0
2 changed files with 10 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
lib/base/value.cpp
View File

@ -59,7 +59,7 @@ Value::Value(const char *value)
*/ */
bool Value::IsEmpty(void) const bool Value::IsEmpty(void) const
{ {
return (m_Value.type() == typeid(boost::blank)); return (GetType() == ValueEmpty);
} }
/** /**
@ -79,16 +79,17 @@ bool Value::IsScalar(void) const
*/ */
bool Value::IsObject(void) const bool Value::IsObject(void) const
{ {
return !IsEmpty() && (m_Value.type() == typeid(Object::Ptr)); return !IsEmpty() && (GetType() == ValueObject);
} }
Value::operator double(void) const Value::operator double(void) const
{ {
if (m_Value.type() != typeid(double)) { const double *value = boost::get<double>(&m_Value);
return boost::lexical_cast<double>(m_Value);
} else { if (value)
return boost::get<double>(m_Value); return *value;
}
return boost::lexical_cast<double>(m_Value);
} }
Value::operator String(void) const Value::operator String(void) const

4
lib/base/value.h
View File

@ -85,7 +85,7 @@ public:
return object; return object;
} }
bool IsEmpty(void) const; bool IsEmpty(void) const;
bool IsScalar(void) const; bool IsScalar(void) const;
bool IsObject(void) const; bool IsObject(void) const;
@ -107,7 +107,7 @@ bool IsEmpty(void) const;
ValueType GetType(void) const; ValueType GetType(void) const;
private: private:
mutable boost::variant<boost::blank, double, String, Object::Ptr> m_Value; boost::variant<boost::blank, double, String, Object::Ptr> m_Value;
}; };
static Value Empty; static Value Empty;