From ce814853c36e043b57921e7bae97f74908e5fb8a Mon Sep 17 00:00:00 2001 From: Julian Brost Date: Tue, 28 Jun 2022 12:18:11 +0200 Subject: [PATCH] Icinga DB Check: don't check runtime update backlog during full sync --- lib/icingadb/icingadbchecktask.cpp | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/lib/icingadb/icingadbchecktask.cpp b/lib/icingadb/icingadbchecktask.cpp index 225168ce5..c2f1a3699 100644 --- a/lib/icingadb/icingadbchecktask.cpp +++ b/lib/icingadb/icingadbchecktask.cpp @@ -346,8 +346,9 @@ void IcingadbCheckTask::ScriptFunc(const Checkable::Ptr& checkable, const CheckR double runtimeBacklog = 0; - if (weResponsible) { - // These streams are only processed by one instance, it's fine for the other instance to have some backlog. + if (weResponsible && !syncOngoingSince) { + // These streams are only processed by the responsible instance after the full sync finished, + // it's fine for some backlog to exist otherwise. runtimeBacklog = getBacklog(xReadRuntimeBacklog); if (!icingadbBacklogThresholds.Critical.IsEmpty() && runtimeBacklog > icingadbBacklogThresholds.Critical) { @@ -359,7 +360,7 @@ void IcingadbCheckTask::ScriptFunc(const Checkable::Ptr& checkable, const CheckR } } - // Also report the perfdata value on the other instance (as 0 in this case). + // Also report the perfdata value on the standby instance or during a full sync (as 0 in this case). perfdata->Add(new PerfdataValue("icingadb_runtime_update_backlog", runtimeBacklog, false, "seconds", icingadbBacklogThresholds.Warning, icingadbBacklogThresholds.Critical, 0)); }