tyler.durden
/
icinga2
mirror of https://github.com/Icinga/icinga2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Simplify `DependencyGraph:RemoveDependency()` method

This commit is contained in:
Julian Brost 2024-12-19 12:24:26 +01:00 committed by Yonas Habteab
parent ff0e12e6ac
commit cf125dd8d5
1 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
lib/base/dependencygraph.cpp
View File

@ -20,15 +20,14 @@ void DependencyGraph::RemoveDependency(ConfigObject* child, ConfigObject* parent
std::unique_lock<std::mutex> lock(m_Mutex); std::unique_lock<std::mutex> lock(m_Mutex);
if (auto it(m_Dependencies.find(Edge(parent, child))); it != m_Dependencies.end()) { if (auto it(m_Dependencies.find(Edge(parent, child))); it != m_Dependencies.end()) {
// A number <= 1 means, this isn't referenced by anyone and should be erased from the container. if (it->count > 1) {
if (it->count == 1) { // Remove a duplicate edge from child to node, i.e. decrement the corresponding counter.
m_Dependencies.erase(it);
return;
}
// Otherwise, each remove operation will should decrement this by 1 till it reaches <= 1
// and causes the edge to completely be erased from the container.
m_Dependencies.modify(it, [](Edge& e) { e.count--; }); m_Dependencies.modify(it, [](Edge& e) { e.count--; });
} else {
// Remove the last edge from child to node (decrementing the counter would set it to 0),
// thus remove that connection from the data structure completely.
m_Dependencies.erase(it);
}
} }
} }