tyler.durden/icinga2
1
0
Fork 0
mirror of https://github.com/Icinga/icinga2.git synced 2025-07-27 07:34:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

ElasticsearchWriter#Pause(): call Flush() only once

Browse Source 
The first Flush() is redundant and may access m_DataBuffer at the same time as some Flush() in m_WorkQueue (race condition) which isn't joined, yet.
This commit is contained in:
Alexander Aleksandrovič Klimov 2023-06-29 10:42:12 +02:00 committed by GitHub
parent a2926b8604
commit d5e6ecec8a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/perfdata/elasticsearchwriter.cpp
View File

@ -118,8 +118,6 @@ void ElasticsearchWriter::Pause()
m_HandleNotifications.disconnect(); m_HandleNotifications.disconnect();
m_FlushTimer->Stop(true); m_FlushTimer->Stop(true);
Flush();
m_WorkQueue.Join(); m_WorkQueue.Join();
Flush(); Flush();