tyler.durden
/
icinga2
mirror of https://github.com/Icinga/icinga2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Call Endpoint::GetByName only once

This commit is contained in:
Mattia Codato 2020-06-26 16:38:40 +02:00
parent 50693d7ea9
commit da82c17891
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/icinga/apiactions.cpp
View File

@ -588,7 +588,8 @@ Dictionary::Ptr ApiActions::ExecuteCommand(const ConfigObject::Ptr& object,
);
/* Check if endpoint exists */
if (!Endpoint::GetByName(resolved_endpoint))
Endpoint::Ptr endpointPtr = Endpoint::GetByName(resolved_endpoint);
if (!endpointPtr)
return ApiActions::CreateResult(404, "Can't find a valid endpoint for '" + resolved_endpoint + "'.");
/* Get command_type */
@ -660,8 +661,7 @@ Dictionary::Ptr ApiActions::ExecuteCommand(const ConfigObject::Ptr& object,
executions->Set(uuid, pending_execution);
checkable->SetExecutions(executions);
Endpoint::Ptr endpointPtr = Endpoint::GetByName(resolved_endpoint);
bool local = !endpointPtr || endpointPtr == Endpoint::GetLocalEndpoint();
bool local = endpointPtr == Endpoint::GetLocalEndpoint();
if (local) {
/* TODO */
} else {