From c7293de91d795d48228e7e0788a91d0b035fca72 Mon Sep 17 00:00:00 2001 From: Eric Lippmann Date: Thu, 8 Feb 2024 12:09:06 +0100 Subject: [PATCH] IoEngine: Always log coroutine exception diagnostics While analyzing a possible memory leak, we encountered several coroutine exception messages, which unfortunately do not provide any information about what exactly went wrong, as exception diagnostics were previously only logged at the notice level. --- lib/base/io-engine.hpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/base/io-engine.hpp b/lib/base/io-engine.hpp index 684d3ac39..326f04fdc 100644 --- a/lib/base/io-engine.hpp +++ b/lib/base/io-engine.hpp @@ -109,8 +109,7 @@ public: // https://github.com/boostorg/coroutine/issues/39 throw; } catch (const std::exception& ex) { - Log(LogCritical, "IoEngine", "Exception in coroutine!"); - Log(LogDebug, "IoEngine") << "Exception in coroutine: " << DiagnosticInformation(ex); + Log(LogCritical, "IoEngine") << "Exception in coroutine: " << DiagnosticInformation(ex); } catch (...) { Log(LogCritical, "IoEngine", "Exception in coroutine!"); }