From 82a5c5a62465c27492e2d1ca7996f19384d67174 Mon Sep 17 00:00:00 2001
From: "Marianne M. Spiller" <github@spiller.me>
Date: Wed, 5 Apr 2017 12:29:23 +0200
Subject: [PATCH 1/3] Add notification command parameters to the default mail
 notification script

Replace the previous notification scheme - now using getops in place of ENV
variables, giving the ability to integrate with the Icinga Director.

refs #5170

Signed-off-by: Michael Friedrich <michael.friedrich@icinga.com>
---
 etc/icinga2/conf.d/commands.conf              | 138 ++++++++++++++----
 etc/icinga2/conf.d/notifications.conf         |   6 +-
 etc/icinga2/conf.d/templates.conf             |  15 +-
 etc/icinga2/scripts/mail-host-notification.sh | 121 +++++++++++++--
 .../scripts/mail-service-notification.sh      | 126 ++++++++++++++--
 5 files changed, 354 insertions(+), 52 deletions(-)

diff --git a/etc/icinga2/conf.d/commands.conf b/etc/icinga2/conf.d/commands.conf
index e97b087af..d40fb84e8 100644
--- a/etc/icinga2/conf.d/commands.conf
+++ b/etc/icinga2/conf.d/commands.conf
@@ -3,36 +3,124 @@
 object NotificationCommand "mail-host-notification" {
   command = [ SysconfDir + "/icinga2/scripts/mail-host-notification.sh" ]
 
-  env = {
-    NOTIFICATIONTYPE = "$notification.type$"
-    HOSTALIAS = "$host.display_name$"
-    HOSTADDRESS = "$address$"
-    HOSTSTATE = "$host.state$"
-    LONGDATETIME = "$icinga.long_date_time$"
-    HOSTOUTPUT = "$host.output$"
-    NOTIFICATIONAUTHORNAME = "$notification.author$"
-    NOTIFICATIONCOMMENT = "$notification.comment$"
-    HOSTDISPLAYNAME = "$host.display_name$"
-    USEREMAIL = "$user.email$"
+  arguments += {
+    "-4" = {
+      required = true
+      value = "$notification_address$"
+    }
+    "-6" = "$notification_address6$"
+    "-b" = "$notification_author$"
+    "-c" = "$notification_comment$"
+    "-d" = {
+      required = true
+      value = "$notification_date$"
+    }
+    "-f" = "$notification_from$"
+    "-i" = "$notification_icingaweb2url$"
+    "-l" = {
+      required = true
+      value = "$notification_hostname$"
+    }
+    "-n" = {
+      required = true
+      value = "$notification_hostdisplayname$"
+    }
+    "-o" = {
+      required = true
+      value = "$notification_hostoutput$"
+    }
+    "-r" = {
+      required = true
+      value = "$notification_useremail$"
+    }
+    "-s" = {
+      required = true
+      value = "$notification_hoststate$"
+    }
+    "-t" = {
+      required = true
+      value = "$notification_type$"
+    }
+    "-v" = "$notification_logtosyslog$"
+  }
+
+  vars += {
+    notification_address = "$address$"
+    notification_address6 = "$address6$"
+    notification_author = "$notification.author$"
+    notification_comment = "$notification.comment$"
+    notification_type = "$notification.type$"
+    notification_date = "$icinga.long_date_time$"
+    notification_hostname = "$host.name$"
+    notification_hostdisplayname = "$host.display_name$"
+    notification_hostoutput = "$host.output$"
+    notification_hoststate = "$host.state$"
+    notification_useremail = "$user.email$"
   }
 }
 
 object NotificationCommand "mail-service-notification" {
   command = [ SysconfDir + "/icinga2/scripts/mail-service-notification.sh" ]
 
-  env = {
-    NOTIFICATIONTYPE = "$notification.type$"
-    SERVICEDESC = "$service.name$"
-    HOSTALIAS = "$host.display_name$"
-    HOSTADDRESS = "$address$"
-    SERVICESTATE = "$service.state$"
-    LONGDATETIME = "$icinga.long_date_time$"
-    SERVICEOUTPUT = "$service.output$"
-    NOTIFICATIONAUTHORNAME = "$notification.author$"
-    NOTIFICATIONCOMMENT = "$notification.comment$"
-    HOSTDISPLAYNAME = "$host.display_name$"
-    SERVICEDISPLAYNAME = "$service.display_name$"
-    USEREMAIL = "$user.email$"
+  arguments += {
+    "-4" = {
+      required = true
+      value = "$notification_address$"
+        }
+    "-6" = "$notification_address6$"
+    "-b" = "$notification_author$"
+    "-c" = "$notification_comment$"
+    "-d" = {
+      required = true
+      value = "$notification_date$"
+    }
+    "-e" = {
+      required = true
+      value = "$notification_servicename$"
+    }
+    "-f" = "$notification_from$"
+    "-i" = "$notification_icingaweb2url$"
+    "-l" = {
+      required = true
+      value = "$notification_hostname$"
+    }
+    "-n" = {
+      required = true
+      value = "$notification_hostdisplayname$"
+    }
+    "-o" = {
+      required = true
+      value = "$notification_serviceoutput$"
+    }
+    "-r" = {
+      required = true
+      value = "$notification_useremail$"
+    }
+    "-s" = {
+      required = true
+      value = "$notification_servicestate$"
+    }
+    "-t" = "$notification_type$"
+    "-u" = {
+      required = true
+      value = "$notification_servicedisplayname$"
+    }
+    "-v" = "$notification_logtosyslog$"
+  }
+
+  vars += {
+    notification_address = "$address$"
+    notification_address6 = "$address6$"
+    notification_author = "$notification.author$"
+    notification_comment = "$notification.comment$"
+    notification_type = "$notification.type$"
+    notification_date = "$icinga.long_date_time$"
+    notification_hostname = "$host.name$"
+    notification_hostdisplayname = "$host.display_name$"
+    notification_servicename = "$service.name$"
+    notification_serviceoutput = "$service.output$"
+    notification_servicestate = "$service.state$"
+    notification_useremail = "$user.email$"
+    notification_servicedisplayname = "$service.display_name$"
   }
 }
-
diff --git a/etc/icinga2/conf.d/notifications.conf b/etc/icinga2/conf.d/notifications.conf
index 73f0f5f66..62057b937 100644
--- a/etc/icinga2/conf.d/notifications.conf
+++ b/etc/icinga2/conf.d/notifications.conf
@@ -10,18 +10,20 @@
 
 apply Notification "mail-icingaadmin" to Host {
   import "mail-host-notification"
-
   user_groups = host.vars.notification.mail.groups
   users = host.vars.notification.mail.users
+  interval = 2h
 
+  vars.notification_logtosyslog = true
   assign where host.vars.notification.mail
 }
 
 apply Notification "mail-icingaadmin" to Service {
   import "mail-service-notification"
-
   user_groups = host.vars.notification.mail.groups
   users = host.vars.notification.mail.users
+  interval = 2h
 
+  vars.notification_logtosyslog = true
   assign where host.vars.notification.mail
 }
diff --git a/etc/icinga2/conf.d/templates.conf b/etc/icinga2/conf.d/templates.conf
index 3588f7fcf..1a8ea8328 100644
--- a/etc/icinga2/conf.d/templates.conf
+++ b/etc/icinga2/conf.d/templates.conf
@@ -51,6 +51,12 @@ template Notification "mail-host-notification" {
             FlappingStart, FlappingEnd,
             DowntimeStart, DowntimeEnd, DowntimeRemoved ]
 
+  vars += {
+    // notification_icingaweb2url = "https://www.example.com/icingaweb2"
+    // notification_from = "Icinga 2 Host Monitoring <icinga@example.com>"
+    notification_logtosyslog = false
+  }
+
   period = "24x7"
 }
 
@@ -62,11 +68,16 @@ template Notification "mail-host-notification" {
 template Notification "mail-service-notification" {
   command = "mail-service-notification"
 
-  states = [ OK, Warning, Critical, Unknown ]
+  states = [ Critical, OK, Unknown, Warning ]
   types = [ Problem, Acknowledgement, Recovery, Custom,
             FlappingStart, FlappingEnd,
             DowntimeStart, DowntimeEnd, DowntimeRemoved ]
 
+  vars += {
+    // notification_icingaweb2url = "https://www.example.com/icingaweb2"
+    // notification_from = "Icinga 2 Service Monitoring <icinga@example.com>"
+    notification_logtosyslog = false
+  }
+
   period = "24x7"
 }
-
diff --git a/etc/icinga2/scripts/mail-host-notification.sh b/etc/icinga2/scripts/mail-host-notification.sh
index e1ac71664..b67b3db6b 100755
--- a/etc/icinga2/scripts/mail-host-notification.sh
+++ b/etc/icinga2/scripts/mail-host-notification.sh
@@ -1,20 +1,119 @@
 #!/bin/sh
-template=`cat <<TEMPLATE
-***** Icinga  *****
 
-Notification Type: $NOTIFICATIONTYPE
+PROG="`basename $0`"
+HOSTNAME="`hostname`"
+MAILBIN="mail"
 
-Host: $HOSTALIAS
-Address: $HOSTADDRESS
-State: $HOSTSTATE
+if [ -z "`which $MAILBIN`" ] ; then
+  echo "$MAILBIN not in \$PATH. Consider installing it."
+  exit 1
+fi
 
-Date/Time: $LONGDATETIME
+Usage() {
+cat << EOF
 
-Additional Info: $HOSTOUTPUT
+The following are mandatory:
+  -4 HOSTADDRESS (\$address$)
+  -6 HOSTADDRESS6 (\$address6$)
+  -d LONGDATETIME (\$icinga.long_date_time$)
+  -l HOSTALIAS (\$host.name$)
+  -n HOSTDISPLAYNAME (\$host.display_name$)
+  -o HOSTOUTPUT (\$host.output$)
+  -r USEREMAIL (\$user.email$)
+  -s HOSTSTATE (\$host.state$)
+  -t NOTIFICATIONTYPE (\$notification.type$)
 
-Comment: [$NOTIFICATIONAUTHORNAME] $NOTIFICATIONCOMMENT
-TEMPLATE
+And these are optional:
+  -b NOTIFICATIONAUTHORNAME (\$notification.author$)
+  -c NOTIFICATIONCOMMENT (\$notification.comment$)
+  -i ICINGAWEB2URL (\$notification_icingaweb2url$, Default: unset)
+  -f MAILFROM (\$notification_mailfrom$, requires GNU mailutils)
+  -v (\$notification_sendtosyslog$, Default: false)
+
+EOF
+
+exit 1;
+}
+
+while getopts 4:6::b:c:d:f:hi:l:n:o:r:s:t:v: opt
+do
+  case "$opt" in
+    4) HOSTADDRESS=$OPTARG ;;
+    6) HOSTADDRESS6=$OPTARG ;;
+    b) NOTIFICATIONAUTHORNAME=$OPTARG ;;
+    c) NOTIFICATIONCOMMENT=$OPTARG ;;
+    d) LONGDATETIME=$OPTARG ;;
+    f) MAILFROM=$OPTARG ;;
+    h) Usage ;;
+    i) ICINGAWEB2URL=$OPTARG ;;
+    l) HOSTALIAS=$OPTARG ;;
+    n) HOSTDISPLAYNAME=$OPTARG ;;
+    o) HOSTOUTPUT=$OPTARG ;;
+    r) USEREMAIL=$OPTARG ;;
+    s) HOSTSTATE=$OPTARG ;;
+    t) NOTIFICATIONTYPE=$OPTARG ;;
+    v) VERBOSE=$OPTARG ;;
+   \?) echo "ERROR: Invalid option -$OPTARG" >&2
+       Usage ;;
+    :) echo "Missing option argument for -$OPTARG" >&2
+       Usage ;;
+    *) echo "Unimplemented option: -$OPTARG" >&2
+       Usage ;;
+  esac
+done
+
+shift $((OPTIND - 1))
+
+## Build the message's subject
+SUBJECT="[$NOTIFICATIONTYPE] Host $HOSTDISPLAYNAME is $HOSTSTATE!"
+
+## Build the notification message
+NOTIFICATION_MESSAGE=`cat << EOF
+***** Icinga 2 Host Monitoring on $HOSTNAME *****
+
+==> $HOSTDISPLAYNAME ($HOSTALIAS) is $HOSTSTATE! <==
+
+Info?    $HOSTOUTPUT
+
+When?    $LONGDATETIME
+Host?    $HOSTALIAS (aka "$HOSTDISPLAYNAME")
+IPv4?	 $HOSTADDRESS
+EOF
 `
 
-/usr/bin/printf "%b" "$template" | mail -s "$NOTIFICATIONTYPE - $HOSTDISPLAYNAME is $HOSTSTATE" $USEREMAIL
+## Is this host IPv6 capable? Put its address into the message.
+if [ -n "$HOSTADDRESS6" ] ; then
+  NOTIFICATION_MESSAGE="$NOTIFICATION_MESSAGE
+IPv6?	 $HOSTADDRESS6"
+fi
 
+## Are there any comments? Put them into the message.
+if [ -n "$NOTIFICATIONCOMMENT" ] ; then
+  NOTIFICATION_MESSAGE="$NOTIFICATION_MESSAGE
+
+Comment by $NOTIFICATIONAUTHORNAME:
+  $NOTIFICATIONCOMMENT"
+fi
+
+## Are we using Icinga Web 2? Put the URL into the message.
+if [ -n "$ICINGAWEB2URL" ] ; then
+  NOTIFICATION_MESSAGE="$NOTIFICATION_MESSAGE
+
+Get live status:
+  $ICINGAWEB2URL/monitoring/host/show?host=$HOSTALIAS"
+fi
+
+## Are we verbose? Then put a message to syslog.
+if [ "$VERBOSE" == "true" ] ; then
+  logger "$PROG sends $SUBJECT => $USEREMAIL"
+fi
+
+## And finally: send the message using $MAILBIN command.
+## Do we have an explicit sender? Then we'll use it.
+if [ -n "$MAILFROM" ] ; then
+  /usr/bin/printf "%b" "$NOTIFICATION_MESSAGE" \
+  | $MAILBIN -a "From: $MAILFROM" -s "$SUBJECT" $USEREMAIL
+else
+  /usr/bin/printf "%b" "$NOTIFICATION_MESSAGE" \
+  | $MAILBIN -s "$SUBJECT" $USEREMAIL
+fi
diff --git a/etc/icinga2/scripts/mail-service-notification.sh b/etc/icinga2/scripts/mail-service-notification.sh
index 8574036b3..5b490527e 100755
--- a/etc/icinga2/scripts/mail-service-notification.sh
+++ b/etc/icinga2/scripts/mail-service-notification.sh
@@ -1,21 +1,123 @@
 #!/bin/sh
-template=`cat <<TEMPLATE
-***** Icinga  *****
 
-Notification Type: $NOTIFICATIONTYPE
+PROG="`basename $0`"
+HOSTNAME="`hostname`"
+MAILBIN="mail"
 
-Service: $SERVICEDESC
-Host: $HOSTALIAS
-Address: $HOSTADDRESS
-State: $SERVICESTATE
+if [ -z "`which $MAILBIN`" ] ; then
+  echo "$MAILBIN not in \$PATH. Consider installing it."
+  exit 1
+fi
 
-Date/Time: $LONGDATETIME
+Usage() {
+cat << EOF
 
-Additional Info: $SERVICEOUTPUT
+The following are mandatory:
+  -4 HOSTADDRESS (\$address$)
+  -6 HOSTADDRESS (\$address6$)
+  -d LONGDATETIME (\$icinga.long_date_time$)
+  -e SERVICENAME (\$service.name$)
+  -l HOSTALIAS (\$host.name$)
+  -n HOSTDISPLAYNAME (\$host.display_name$)
+  -o SERVICEOUTPUT (\$service.output$)
+  -r USEREMAIL (\$user.email$)
+  -s SERVICESTATE (\$service.state$)
+  -t NOTIFICATIONTYPE (\$notification.type$)
+  -u SERVICEDISPLAYNAME (\$service.display_name$)
 
-Comment: [$NOTIFICATIONAUTHORNAME] $NOTIFICATIONCOMMENT
-TEMPLATE
+And these are optional:
+  -b NOTIFICATIONAUTHORNAME (\$notification.author$)
+  -c NOTIFICATIONCOMMENT (\$notification.comment$)
+  -i ICINGAWEB2URL (\$notification_icingaweb2url$, Default: unset)
+  -f MAILFROM (\$notification_mailfrom$, requires GNU mailutils)
+e -v (\$notification_sendtosyslog$, Default: false)
+
+EOF
+exit 1;
+}
+
+while getopts 4:6:b:c:d:e:f:hi:l:n:o:r:s:t:u:v: opt
+do
+  case "$opt" in
+    4) HOSTADDRESS=$OPTARG ;;
+    6) HOSTADDRESS6=$OPTARG ;;
+    b) NOTIFICATIONAUTHORNAME=$OPTARG ;;
+    c) NOTIFICATIONCOMMENT=$OPTARG ;;
+    d) LONGDATETIME=$OPTARG ;;
+    e) SERVICENAME=$OPTARG ;;
+    f) MAILFROM=$OPTARG ;;
+    h) Usage ;;
+    i) ICINGAWEB2URL=$OPTARG ;;
+    l) HOSTALIAS=$OPTARG ;;
+    n) HOSTDISPLAYNAME=$OPTARG ;;
+    o) SERVICEOUTPUT=$OPTARG ;;
+    r) USEREMAIL=$OPTARG ;;
+    s) SERVICESTATE=$OPTARG ;;
+    t) NOTIFICATIONTYPE=$OPTARG ;;
+    u) SERVICEDISPLAYNAME=$OPTARG ;;
+    v) VERBOSE=$OPTARG ;;
+   \?) echo "ERROR: Invalid option -$OPTARG" >&2
+       Usage ;;
+    :) echo "Missing option argument for -$OPTARG" >&2
+       Usage ;;
+    *) echo "Unimplemented option: -$OPTARG" >&2
+       Usage ;;
+  esac
+done
+
+shift $((OPTIND - 1))
+
+## Build the message's subject
+SUBJECT="[$NOTIFICATIONTYPE] $SERVICEDISPLAYNAME on $HOSTDISPLAYNAME is $SERVICESTATE!"
+
+## Build the notification message
+NOTIFICATION_MESSAGE=`cat << EOF
+***** Icinga 2 Service Monitoring on $HOSTNAME *****
+
+==> $SERVICEDISPLAYNAME on $HOSTDISPLAYNAME is $SERVICESTATE! <==
+
+Info?    $SERVICEOUTPUT
+
+When?    $LONGDATETIME
+Service? $SERVICENAME (aka "$SERVICEDISPLAYNAME")
+Host?    $HOSTALIAS (aka "$HOSTDISPLAYNAME")
+IPv4?	 $HOSTADDRESS
+EOF
 `
 
-/usr/bin/printf "%b" "$template" | mail -s "$NOTIFICATIONTYPE - $HOSTDISPLAYNAME - $SERVICEDISPLAYNAME is $SERVICESTATE" $USEREMAIL
+## Is this host IPv6 capable? Put its address into the message.
+if [ -n "$HOSTADDRESS6" ] ; then
+  NOTIFICATION_MESSAGE="$NOTIFICATION_MESSAGE
+IPv6?    $HOSTADDRESS6"
+fi
 
+## Are there any comments? Put them into the message.
+if [ -n "$NOTIFICATIONCOMMENT" ] ; then
+  NOTIFICATION_MESSAGE="$NOTIFICATION_MESSAGE
+
+Comment by $NOTIFICATIONAUTHORNAME:
+  $NOTIFICATIONCOMMENT"
+fi
+
+## Are we using Icinga Web 2? Put the URL into the message.
+if [ -n "$ICINGAWEB2URL" ] ; then
+  NOTIFICATION_MESSAGE="$NOTIFICATION_MESSAGE
+
+Get live status:
+  $ICINGAWEB2URL/monitoring/service/show?host=$HOSTALIAS&service=$SERVICENAME"
+fi
+
+## Are we verbose? Then put a message to syslog.
+if [ "$VERBOSE" == "true" ] ; then
+  logger "$PROG sends $SUBJECT => $USEREMAIL"
+fi
+
+## And finally: send the message using $MAILBIN command.
+## Do we have an explicit sender? Then we'll use it.
+if [ -n "$MAILFROM" ] ; then
+  /usr/bin/printf "%b" "$NOTIFICATION_MESSAGE" \
+  | $MAILBIN -a "From: $MAILFROM" -s "$SUBJECT" $USEREMAIL
+else
+  /usr/bin/printf "%b" "$NOTIFICATION_MESSAGE" \
+  | $MAILBIN -s "$SUBJECT" $USEREMAIL
+fi

From 91ab8551c76e18673a8343d1af9deb134ce68874 Mon Sep 17 00:00:00 2001
From: Michael Friedrich <michael.friedrich@icinga.com>
Date: Fri, 28 Apr 2017 17:40:42 +0200
Subject: [PATCH 2/3] First review of notification script changes

refs #5170
---
 etc/icinga2/conf.d/notifications.conf          |  8 ++++++--
 etc/icinga2/conf.d/templates.conf              |  2 +-
 etc/icinga2/scripts/mail-host-notification.sh  | 18 +++++++++---------
 .../scripts/mail-service-notification.sh       | 16 ++++++++--------
 4 files changed, 24 insertions(+), 20 deletions(-)

diff --git a/etc/icinga2/conf.d/notifications.conf b/etc/icinga2/conf.d/notifications.conf
index 62057b937..99746da07 100644
--- a/etc/icinga2/conf.d/notifications.conf
+++ b/etc/icinga2/conf.d/notifications.conf
@@ -12,9 +12,11 @@ apply Notification "mail-icingaadmin" to Host {
   import "mail-host-notification"
   user_groups = host.vars.notification.mail.groups
   users = host.vars.notification.mail.users
-  interval = 2h
+
+  //interval = 2h
 
   vars.notification_logtosyslog = true
+
   assign where host.vars.notification.mail
 }
 
@@ -22,8 +24,10 @@ apply Notification "mail-icingaadmin" to Service {
   import "mail-service-notification"
   user_groups = host.vars.notification.mail.groups
   users = host.vars.notification.mail.users
-  interval = 2h
+
+  //interval = 2h
 
   vars.notification_logtosyslog = true
+
   assign where host.vars.notification.mail
 }
diff --git a/etc/icinga2/conf.d/templates.conf b/etc/icinga2/conf.d/templates.conf
index 1a8ea8328..5655e3f2d 100644
--- a/etc/icinga2/conf.d/templates.conf
+++ b/etc/icinga2/conf.d/templates.conf
@@ -68,7 +68,7 @@ template Notification "mail-host-notification" {
 template Notification "mail-service-notification" {
   command = "mail-service-notification"
 
-  states = [ Critical, OK, Unknown, Warning ]
+  states = [ OK, Warning, Critical, Unknown ]
   types = [ Problem, Acknowledgement, Recovery, Custom,
             FlappingStart, FlappingEnd,
             DowntimeStart, DowntimeEnd, DowntimeRemoved ]
diff --git a/etc/icinga2/scripts/mail-host-notification.sh b/etc/icinga2/scripts/mail-host-notification.sh
index b67b3db6b..34d0ced7e 100755
--- a/etc/icinga2/scripts/mail-host-notification.sh
+++ b/etc/icinga2/scripts/mail-host-notification.sh
@@ -12,7 +12,7 @@ fi
 Usage() {
 cat << EOF
 
-The following are mandatory:
+Required parameters:
   -4 HOSTADDRESS (\$address$)
   -6 HOSTADDRESS6 (\$address6$)
   -d LONGDATETIME (\$icinga.long_date_time$)
@@ -23,7 +23,7 @@ The following are mandatory:
   -s HOSTSTATE (\$host.state$)
   -t NOTIFICATIONTYPE (\$notification.type$)
 
-And these are optional:
+Optional parameters:
   -b NOTIFICATIONAUTHORNAME (\$notification.author$)
   -c NOTIFICATIONCOMMENT (\$notification.comment$)
   -i ICINGAWEB2URL (\$notification_icingaweb2url$, Default: unset)
@@ -71,20 +71,20 @@ SUBJECT="[$NOTIFICATIONTYPE] Host $HOSTDISPLAYNAME is $HOSTSTATE!"
 NOTIFICATION_MESSAGE=`cat << EOF
 ***** Icinga 2 Host Monitoring on $HOSTNAME *****
 
-==> $HOSTDISPLAYNAME ($HOSTALIAS) is $HOSTSTATE! <==
+==> $HOSTDISPLAYNAME ($HOSTNAME) is $HOSTSTATE! <==
 
-Info?    $HOSTOUTPUT
+Info:    $HOSTOUTPUT
 
-When?    $LONGDATETIME
-Host?    $HOSTALIAS (aka "$HOSTDISPLAYNAME")
-IPv4?	 $HOSTADDRESS
+When:    $LONGDATETIME
+Host:    $HOSTNAME (Display Name: "$HOSTDISPLAYNAME")
+IPv4:    $HOSTADDRESS
 EOF
 `
 
 ## Is this host IPv6 capable? Put its address into the message.
 if [ -n "$HOSTADDRESS6" ] ; then
   NOTIFICATION_MESSAGE="$NOTIFICATION_MESSAGE
-IPv6?	 $HOSTADDRESS6"
+IPv6:	 $HOSTADDRESS6"
 fi
 
 ## Are there any comments? Put them into the message.
@@ -99,7 +99,7 @@ fi
 if [ -n "$ICINGAWEB2URL" ] ; then
   NOTIFICATION_MESSAGE="$NOTIFICATION_MESSAGE
 
-Get live status:
+URL:
   $ICINGAWEB2URL/monitoring/host/show?host=$HOSTALIAS"
 fi
 
diff --git a/etc/icinga2/scripts/mail-service-notification.sh b/etc/icinga2/scripts/mail-service-notification.sh
index 5b490527e..c37b45ac9 100755
--- a/etc/icinga2/scripts/mail-service-notification.sh
+++ b/etc/icinga2/scripts/mail-service-notification.sh
@@ -12,7 +12,7 @@ fi
 Usage() {
 cat << EOF
 
-The following are mandatory:
+Required parameters:
   -4 HOSTADDRESS (\$address$)
   -6 HOSTADDRESS (\$address6$)
   -d LONGDATETIME (\$icinga.long_date_time$)
@@ -25,7 +25,7 @@ The following are mandatory:
   -t NOTIFICATIONTYPE (\$notification.type$)
   -u SERVICEDISPLAYNAME (\$service.display_name$)
 
-And these are optional:
+Optional parameters:
   -b NOTIFICATIONAUTHORNAME (\$notification.author$)
   -c NOTIFICATIONCOMMENT (\$notification.comment$)
   -i ICINGAWEB2URL (\$notification_icingaweb2url$, Default: unset)
@@ -76,19 +76,19 @@ NOTIFICATION_MESSAGE=`cat << EOF
 
 ==> $SERVICEDISPLAYNAME on $HOSTDISPLAYNAME is $SERVICESTATE! <==
 
-Info?    $SERVICEOUTPUT
+Info:    $SERVICEOUTPUT
 
-When?    $LONGDATETIME
-Service? $SERVICENAME (aka "$SERVICEDISPLAYNAME")
-Host?    $HOSTALIAS (aka "$HOSTDISPLAYNAME")
-IPv4?	 $HOSTADDRESS
+When:    $LONGDATETIME
+Service: $SERVICENAME (Display Name: "$SERVICEDISPLAYNAME")
+Host:    $HOSTNAME (Display Name: "$HOSTDISPLAYNAME")
+IPv4:    $HOSTADDRESS
 EOF
 `
 
 ## Is this host IPv6 capable? Put its address into the message.
 if [ -n "$HOSTADDRESS6" ] ; then
   NOTIFICATION_MESSAGE="$NOTIFICATION_MESSAGE
-IPv6?    $HOSTADDRESS6"
+IPv6:    $HOSTADDRESS6"
 fi
 
 ## Are there any comments? Put them into the message.

From 7b9f478bc19eac8d69c70272f71495839220fb9e Mon Sep 17 00:00:00 2001
From: Michael Friedrich <michael.friedrich@icinga.com>
Date: Wed, 10 May 2017 13:22:44 +0200
Subject: [PATCH 3/3] Check for required parameters in notification scripts;
 add error helpers

refs #5170
---
 etc/icinga2/scripts/mail-host-notification.sh | 94 +++++++++++-------
 .../scripts/mail-service-notification.sh      | 96 ++++++++++++-------
 2 files changed, 118 insertions(+), 72 deletions(-)

diff --git a/etc/icinga2/scripts/mail-host-notification.sh b/etc/icinga2/scripts/mail-host-notification.sh
index 34d0ced7e..fba41c890 100755
--- a/etc/icinga2/scripts/mail-host-notification.sh
+++ b/etc/icinga2/scripts/mail-host-notification.sh
@@ -5,65 +5,87 @@ HOSTNAME="`hostname`"
 MAILBIN="mail"
 
 if [ -z "`which $MAILBIN`" ] ; then
-  echo "$MAILBIN not in \$PATH. Consider installing it."
+  echo "$MAILBIN not found in \$PATH. Consider installing it."
   exit 1
 fi
 
+## Function helpers
 Usage() {
 cat << EOF
 
 Required parameters:
-  -4 HOSTADDRESS (\$address$)
-  -6 HOSTADDRESS6 (\$address6$)
-  -d LONGDATETIME (\$icinga.long_date_time$)
-  -l HOSTALIAS (\$host.name$)
-  -n HOSTDISPLAYNAME (\$host.display_name$)
-  -o HOSTOUTPUT (\$host.output$)
-  -r USEREMAIL (\$user.email$)
-  -s HOSTSTATE (\$host.state$)
-  -t NOTIFICATIONTYPE (\$notification.type$)
+  -4 HOSTADDRESS (\$address\$)
+  -d LONGDATETIME (\$icinga.long_date_time\$)
+  -l HOSTNAME (\$host.name\$)
+  -n HOSTDISPLAYNAME (\$host.display_name\$)
+  -o HOSTOUTPUT (\$host.output\$)
+  -r USEREMAIL (\$user.email\$)
+  -s HOSTSTATE (\$host.state\$)
+  -t NOTIFICATIONTYPE (\$notification.type\$)
 
 Optional parameters:
-  -b NOTIFICATIONAUTHORNAME (\$notification.author$)
-  -c NOTIFICATIONCOMMENT (\$notification.comment$)
-  -i ICINGAWEB2URL (\$notification_icingaweb2url$, Default: unset)
-  -f MAILFROM (\$notification_mailfrom$, requires GNU mailutils)
-  -v (\$notification_sendtosyslog$, Default: false)
+  -6 HOSTADDRESS6 (\$address6\$)
+  -b NOTIFICATIONAUTHORNAME (\$notification.author\$)
+  -c NOTIFICATIONCOMMENT (\$notification.comment\$)
+  -i ICINGAWEB2URL (\$notification_icingaweb2url\$, Default: unset)
+  -f MAILFROM (\$notification_mailfrom\$, requires GNU mailutils)
+  -v (\$notification_sendtosyslog\$, Default: false)
 
 EOF
-
-exit 1;
 }
 
+Help() {
+  Usage;
+  exit 0;
+}
+
+Error() {
+  if [ "$1" ]; then
+    echo $1
+  fi
+  Usage;
+  exit 1;
+}
+
+## Main
 while getopts 4:6::b:c:d:f:hi:l:n:o:r:s:t:v: opt
 do
   case "$opt" in
-    4) HOSTADDRESS=$OPTARG ;;
+    4) HOSTADDRESS=$OPTARG ;; # required
     6) HOSTADDRESS6=$OPTARG ;;
     b) NOTIFICATIONAUTHORNAME=$OPTARG ;;
     c) NOTIFICATIONCOMMENT=$OPTARG ;;
-    d) LONGDATETIME=$OPTARG ;;
+    d) LONGDATETIME=$OPTARG ;; # required
     f) MAILFROM=$OPTARG ;;
-    h) Usage ;;
+    h) Help ;;
     i) ICINGAWEB2URL=$OPTARG ;;
-    l) HOSTALIAS=$OPTARG ;;
-    n) HOSTDISPLAYNAME=$OPTARG ;;
-    o) HOSTOUTPUT=$OPTARG ;;
-    r) USEREMAIL=$OPTARG ;;
-    s) HOSTSTATE=$OPTARG ;;
-    t) NOTIFICATIONTYPE=$OPTARG ;;
+    l) HOSTNAME=$OPTARG ;; # required
+    n) HOSTDISPLAYNAME=$OPTARG ;; # required
+    o) HOSTOUTPUT=$OPTARG ;; # required
+    r) USEREMAIL=$OPTARG ;; # required
+    s) HOSTSTATE=$OPTARG ;; # required
+    t) NOTIFICATIONTYPE=$OPTARG ;; # required
     v) VERBOSE=$OPTARG ;;
    \?) echo "ERROR: Invalid option -$OPTARG" >&2
-       Usage ;;
+       Error ;;
     :) echo "Missing option argument for -$OPTARG" >&2
-       Usage ;;
+       Error ;;
     *) echo "Unimplemented option: -$OPTARG" >&2
-       Usage ;;
+       Error ;;
   esac
 done
 
 shift $((OPTIND - 1))
 
+## Check required parameters (TODO: better error message)
+## Keep formatting in sync with mail-service-notification.sh
+if [ ! "$HOSTADDRESS" ] || [ ! "$LONGDATETIME" ] \
+|| [ ! "$HOSTNAME" ] || [ ! "$HOSTDISPLAYNAME" ] \
+|| [ ! "$HOSTOUTPUT" ] || [ ! "$HOSTSTATE" ] \
+|| [ ! "$USEREMAIL" ] || [ ! "$NOTIFICATIONTYPE" ]; then
+  Error "Requirement parameters are missing."
+fi
+
 ## Build the message's subject
 SUBJECT="[$NOTIFICATIONTYPE] Host $HOSTDISPLAYNAME is $HOSTSTATE!"
 
@@ -81,13 +103,13 @@ IPv4:    $HOSTADDRESS
 EOF
 `
 
-## Is this host IPv6 capable? Put its address into the message.
+## Check whether IPv6 was specified.
 if [ -n "$HOSTADDRESS6" ] ; then
   NOTIFICATION_MESSAGE="$NOTIFICATION_MESSAGE
 IPv6:	 $HOSTADDRESS6"
 fi
 
-## Are there any comments? Put them into the message.
+## Check whether author and comment was specified.
 if [ -n "$NOTIFICATIONCOMMENT" ] ; then
   NOTIFICATION_MESSAGE="$NOTIFICATION_MESSAGE
 
@@ -95,21 +117,21 @@ Comment by $NOTIFICATIONAUTHORNAME:
   $NOTIFICATIONCOMMENT"
 fi
 
-## Are we using Icinga Web 2? Put the URL into the message.
+## Check whether Icinga Web 2 URL was specified.
 if [ -n "$ICINGAWEB2URL" ] ; then
   NOTIFICATION_MESSAGE="$NOTIFICATION_MESSAGE
 
 URL:
-  $ICINGAWEB2URL/monitoring/host/show?host=$HOSTALIAS"
+  $ICINGAWEB2URL/monitoring/host/show?host=$HOSTNAME"
 fi
 
-## Are we verbose? Then put a message to syslog.
+## Check whether verbose mode was enabled and log to syslog.
 if [ "$VERBOSE" == "true" ] ; then
   logger "$PROG sends $SUBJECT => $USEREMAIL"
 fi
 
-## And finally: send the message using $MAILBIN command.
-## Do we have an explicit sender? Then we'll use it.
+## Send the mail using the $MAILBIN command.
+## If an explicit sender was specified, try to set it.
 if [ -n "$MAILFROM" ] ; then
   /usr/bin/printf "%b" "$NOTIFICATION_MESSAGE" \
   | $MAILBIN -a "From: $MAILFROM" -s "$SUBJECT" $USEREMAIL
diff --git a/etc/icinga2/scripts/mail-service-notification.sh b/etc/icinga2/scripts/mail-service-notification.sh
index c37b45ac9..48fe42043 100755
--- a/etc/icinga2/scripts/mail-service-notification.sh
+++ b/etc/icinga2/scripts/mail-service-notification.sh
@@ -5,56 +5,70 @@ HOSTNAME="`hostname`"
 MAILBIN="mail"
 
 if [ -z "`which $MAILBIN`" ] ; then
-  echo "$MAILBIN not in \$PATH. Consider installing it."
+  echo "$MAILBIN not found in \$PATH. Consider installing it."
   exit 1
 fi
 
+## Function helpers
 Usage() {
 cat << EOF
 
 Required parameters:
-  -4 HOSTADDRESS (\$address$)
-  -6 HOSTADDRESS (\$address6$)
-  -d LONGDATETIME (\$icinga.long_date_time$)
-  -e SERVICENAME (\$service.name$)
-  -l HOSTALIAS (\$host.name$)
-  -n HOSTDISPLAYNAME (\$host.display_name$)
-  -o SERVICEOUTPUT (\$service.output$)
-  -r USEREMAIL (\$user.email$)
-  -s SERVICESTATE (\$service.state$)
-  -t NOTIFICATIONTYPE (\$notification.type$)
-  -u SERVICEDISPLAYNAME (\$service.display_name$)
+  -4 HOSTADDRESS (\$address\$)
+  -d LONGDATETIME (\$icinga.long_date_time\$)
+  -e SERVICENAME (\$service.name\$)
+  -l HOSTNAME (\$host.name\$)
+  -n HOSTDISPLAYNAME (\$host.display_name\$)
+  -o SERVICEOUTPUT (\$service.output\$)
+  -r USEREMAIL (\$user.email\$)
+  -s SERVICESTATE (\$service.state\$)
+  -t NOTIFICATIONTYPE (\$notification.type\$)
+  -u SERVICEDISPLAYNAME (\$service.display_name\$)
 
 Optional parameters:
-  -b NOTIFICATIONAUTHORNAME (\$notification.author$)
-  -c NOTIFICATIONCOMMENT (\$notification.comment$)
-  -i ICINGAWEB2URL (\$notification_icingaweb2url$, Default: unset)
-  -f MAILFROM (\$notification_mailfrom$, requires GNU mailutils)
-e -v (\$notification_sendtosyslog$, Default: false)
+  -6 HOSTADDRESS6 (\$address6\$)
+  -b NOTIFICATIONAUTHORNAME (\$notification.author\$)
+  -c NOTIFICATIONCOMMENT (\$notification.comment\$)
+  -i ICINGAWEB2URL (\$notification_icingaweb2url\$, Default: unset)
+  -f MAILFROM (\$notification_mailfrom\$, requires GNU mailutils)
+  -v (\$notification_sendtosyslog\$, Default: false)
 
 EOF
-exit 1;
 }
 
+Help() {
+  Usage;
+  exit 0;
+}
+
+Error() {
+  if [ "$1" ]; then
+    echo $1
+  fi
+  Usage;
+  exit 1;
+}
+
+## Main
 while getopts 4:6:b:c:d:e:f:hi:l:n:o:r:s:t:u:v: opt
 do
   case "$opt" in
-    4) HOSTADDRESS=$OPTARG ;;
+    4) HOSTADDRESS=$OPTARG ;; # required
     6) HOSTADDRESS6=$OPTARG ;;
     b) NOTIFICATIONAUTHORNAME=$OPTARG ;;
     c) NOTIFICATIONCOMMENT=$OPTARG ;;
-    d) LONGDATETIME=$OPTARG ;;
-    e) SERVICENAME=$OPTARG ;;
+    d) LONGDATETIME=$OPTARG ;; # required
+    e) SERVICENAME=$OPTARG ;; # required
     f) MAILFROM=$OPTARG ;;
     h) Usage ;;
     i) ICINGAWEB2URL=$OPTARG ;;
-    l) HOSTALIAS=$OPTARG ;;
-    n) HOSTDISPLAYNAME=$OPTARG ;;
-    o) SERVICEOUTPUT=$OPTARG ;;
-    r) USEREMAIL=$OPTARG ;;
-    s) SERVICESTATE=$OPTARG ;;
-    t) NOTIFICATIONTYPE=$OPTARG ;;
-    u) SERVICEDISPLAYNAME=$OPTARG ;;
+    l) HOSTNAME=$OPTARG ;; # required
+    n) HOSTDISPLAYNAME=$OPTARG ;; # required
+    o) SERVICEOUTPUT=$OPTARG ;; # required
+    r) USEREMAIL=$OPTARG ;; # required
+    s) SERVICESTATE=$OPTARG ;; # required
+    t) NOTIFICATIONTYPE=$OPTARG ;; # required
+    u) SERVICEDISPLAYNAME=$OPTARG ;; # required
     v) VERBOSE=$OPTARG ;;
    \?) echo "ERROR: Invalid option -$OPTARG" >&2
        Usage ;;
@@ -67,6 +81,16 @@ done
 
 shift $((OPTIND - 1))
 
+## Check required parameters (TODO: better error message)
+## Keep formatting in sync with mail-host-notification.sh
+if [ ! "$HOSTADDRESS" ] || [ ! "$LONGDATETIME" ] \
+|| [ ! "$HOSTNAME" ] || [ ! "$HOSTDISPLAYNAME" ] \
+|| [ ! "$SERVICENAME" ] || [ ! "$SERVICEDISPLAYNAME" ] \
+|| [ ! "$SERVICEOUTPUT" ] || [ ! "$SERVICESTATE" ] \
+|| [ ! "$USEREMAIL" ] || [ ! "$NOTIFICATIONTYPE" ]; then
+  Error "Requirement parameters are missing."
+fi
+
 ## Build the message's subject
 SUBJECT="[$NOTIFICATIONTYPE] $SERVICEDISPLAYNAME on $HOSTDISPLAYNAME is $SERVICESTATE!"
 
@@ -85,13 +109,13 @@ IPv4:    $HOSTADDRESS
 EOF
 `
 
-## Is this host IPv6 capable? Put its address into the message.
+## Check whether IPv6 was specified.
 if [ -n "$HOSTADDRESS6" ] ; then
   NOTIFICATION_MESSAGE="$NOTIFICATION_MESSAGE
 IPv6:    $HOSTADDRESS6"
 fi
 
-## Are there any comments? Put them into the message.
+## Check whether author and comment was specified.
 if [ -n "$NOTIFICATIONCOMMENT" ] ; then
   NOTIFICATION_MESSAGE="$NOTIFICATION_MESSAGE
 
@@ -99,21 +123,21 @@ Comment by $NOTIFICATIONAUTHORNAME:
   $NOTIFICATIONCOMMENT"
 fi
 
-## Are we using Icinga Web 2? Put the URL into the message.
+## Check whether Icinga Web 2 URL was specified.
 if [ -n "$ICINGAWEB2URL" ] ; then
   NOTIFICATION_MESSAGE="$NOTIFICATION_MESSAGE
 
-Get live status:
-  $ICINGAWEB2URL/monitoring/service/show?host=$HOSTALIAS&service=$SERVICENAME"
+URL:
+  $ICINGAWEB2URL/monitoring/service/show?host=$HOSTNAME&service=$SERVICENAME"
 fi
 
-## Are we verbose? Then put a message to syslog.
+## Check whether verbose mode was enabled and log to syslog.
 if [ "$VERBOSE" == "true" ] ; then
   logger "$PROG sends $SUBJECT => $USEREMAIL"
 fi
 
-## And finally: send the message using $MAILBIN command.
-## Do we have an explicit sender? Then we'll use it.
+## Send the mail using the $MAILBIN command.
+## If an explicit sender was specified, try to set it.
 if [ -n "$MAILFROM" ] ; then
   /usr/bin/printf "%b" "$NOTIFICATION_MESSAGE" \
   | $MAILBIN -a "From: $MAILFROM" -s "$SUBJECT" $USEREMAIL