5162 Commits

Author SHA1 Message Date
Mattia Codato
a64d902866 Add overrideMacros property to MacroResolver 2020-11-20 17:38:26 +01:00
Mattia Codato
edd32b4e26 AuthenticatedApiUser name refactor 2020-11-20 17:38:26 +01:00
Mattia Codato
ef3ed6b826 Make authenticatedApiUser a static property of ActionsHandler 2020-11-20 17:38:26 +01:00
Mattia Codato
cb8a083e11 Get API user from ActionsHandler 2020-11-20 17:38:26 +01:00
Mattia Codato
3b7bb0d9cc Get last CheckResult 2020-11-20 17:38:26 +01:00
Mattia Codato
469d553f15 Fix indentation 2020-11-20 17:38:26 +01:00
Mattia Codato
6eed0838f1 Call notificationCommand->Execute 2020-11-20 17:38:26 +01:00
Mattia Codato
97ef265e88 Update execMacros 2020-11-20 17:38:26 +01:00
Mattia Codato
cc0529d578 Move some checks. Add macros parameters to ExecuteCommand message 2020-11-20 17:38:26 +01:00
Mattia Codato
d8f48e459a Update status code 2020-11-20 17:38:26 +01:00
Mattia Codato
f0fe777eb0 Use RelayMessage to broadcast the updated executions 2020-11-20 17:38:26 +01:00
Mattia Codato
e36644c7d9 Remove unnecessary check 2020-11-20 17:38:26 +01:00
Mattia Codato
a7a5b94a6f Use HttpUtility::GetLastParameter to get endpoint 2020-11-20 17:38:26 +01:00
Mattia Codato
cf2168d7d0 Fix response strings 2020-11-20 17:38:26 +01:00
Mattia Codato
d58cbf233b Use dynamic_pointer_cast 2020-11-20 17:38:26 +01:00
Mattia Codato
20dab6669b Unify how to take macros parameter 2020-11-20 17:38:26 +01:00
Mattia Codato
00a4d2c2eb Get local endpoint if FromClient is not set and origin is local 2020-11-20 17:38:26 +01:00
Mattia Codato
291a9c7bd2 Use SyncSendMessage for remote endpoint and call ExecuteCommandAPIHandler for local endpoint 2020-11-20 17:38:26 +01:00
Mattia Codato
895b587db0 Use the right method to get the notification command 2020-11-20 17:38:26 +01:00
Mattia Codato
932b7162a4 Use RelayMessage instead of SyncSendMessage 2020-11-20 17:38:26 +01:00
Mattia Codato
8444cccd37 Call Endpoint::GetByName only once 2020-11-20 17:38:26 +01:00
Mattia Codato
c1f3356754 Add newline at the end of file 2020-11-20 17:38:26 +01:00
Mattia Codato
fd071f9512 Unify result status strings 2020-11-20 17:38:26 +01:00
Mattia Codato
a8256ab422 Code format 2020-11-20 17:38:26 +01:00
Mattia Codato
7659d3c19d Implement ClusterEvents::UpdateExecutionsAPIHandler 2020-11-20 17:38:26 +01:00
Mattia Codato
bce57821de Fix resolve macros. Check if endpoint is local or remote 2020-11-20 17:38:26 +01:00
Mattia Codato
5442092218 Remove wait parameter, ttl is required, remove unnecessary checks 2020-11-20 17:38:26 +01:00
Benjamin Groeber
8bd829b4ae Allow apiactions to return sucecss http codes different from 200 2020-11-20 17:38:26 +01:00
Benjamin Groeber
b3a504bc9c Use tabs instead of spaces 2020-11-20 17:38:26 +01:00
Benjamin Groeber
7544f7c3f3 Fix formatting of long fn 2020-11-20 17:38:26 +01:00
Benjamin Groeber
a11f3d0101 Remove superfluous else clause 2020-11-20 17:38:26 +01:00
Andrea Avancini
317b20c48e Parameter evaluation, macro resolution, update executions, send ExecuteCommand message for ExecuteCommand Endpoint 2020-11-20 17:38:26 +01:00
Alexander A. Klimov
a959ae01c1 Add stub for event::UpdateExecutions
refs #8034
2020-11-20 17:38:26 +01:00
Alexander A. Klimov
b9ab01f6d2 Introduce Checkable#executions
refs #8034
2020-11-20 17:38:26 +01:00
Alexander A. Klimov
1228d751fe Introduce Checkable#pending_executions
refs #8034
2020-11-20 17:38:26 +01:00
Alexander A. Klimov
50a9e30560 Add stub for event::ExecutedCommand
refs #8034
2020-11-20 17:38:26 +01:00
Alexander A. Klimov
476da0b2c2 Add stub for event::ExecuteCommand w/ source
refs #8034
2020-11-20 17:38:25 +01:00
Alexander A. Klimov
f5b9905161 Add stub for /v1/actions/execute-command
refs #8034
2020-11-20 17:38:25 +01:00
Julian Brost
6b8a018afb
Merge pull request #8486 from Icinga/bugfix/config-sync-only-remove-files-if-timestamp-changed
Config sync: Only remove files, if timestamp changed
2020-11-16 17:36:42 +01:00
Noah Hilverling
f184c1bc57 Config sync: Only remove files, if timestamp changed 2020-11-16 17:33:20 +01:00
Noah Hilverling
c40a4c5cbc
Merge pull request #8475 from Icinga/bugfix/replay-log-blocks
Start ApiListener#SyncClient() in the thread pool
2020-11-16 14:34:40 +01:00
Noah Hilverling
cd819e3801
Merge pull request #8473 from Icinga/bugfix/message-routing-for-global-zones-2.11
Fix cluster message routing for global zones
2020-11-16 14:32:52 +01:00
Julian Brost
de44bf5e71 Close anonymous connections after 10 seconds
Anonymous connections are normally only used for requesting a
certificate and are closed after this request is received. However, the
request is only sent if the child has successfully verified the
certificate of its parent so that it is an authenticated connection from
its perspective. In case this verification fails, both ends view it as
an anonymous connection and never actually use it but attempt a
reconnect after 10 seconds leaking the connection. Therefore close it
after a timeout.
2020-11-13 16:33:04 +01:00
Alexander A. Klimov
ba87ae8109 Start ApiListener#SyncClient() in the thread pool
... not hosting the coroutines not to block them.

Otherwise a large replay log would block messages sending
until the peer disconnects us.
2020-11-12 14:14:20 +01:00
Julian Brost
1adfe851b1 Fix cluster message routing for global zones
RelayMessageOne used to relay the message only to one other endpoint for
other zones, which is fine, as long as the target zone is a child/parent
zone but breaks if the target zone is a global one. In this case, the
message has to be forwarded within the local zone as well as to one node
in each child zone.
2020-11-12 09:49:56 +01:00
Noah Hilverling
d80eb89908
Merge pull request #8457 from Icinga/bugfix/replay-object-deletion-2.11
Log config object deletions to replay log
2020-11-10 11:31:49 +01:00
Alexander Aleksandrovič Klimov
97cda44e7d
Merge pull request #8399 from Icinga/feature/one-connection
ApiListener#NewClientHandlerInternal(): reject connections from already connected endpoints
2020-11-10 11:17:21 +01:00
Alexander Aleksandrovič Klimov
3c97ab6d47
Merge pull request #8454 from Icinga/feature/http-status-codes-in-icinga-mainlog-7053
Include HTTP status codes in log
2020-11-10 11:13:26 +01:00
Noah Hilverling
b2a235c54a API: Don't accept object updates for unknown zone 2020-11-09 16:21:40 +01:00
Julian Brost
b330d8a74e Log config object deletions to replay log
The initial config object sync for each new connection (in
`ApiListener::SendRuntimeConfigObjects()`) only considers currently
existing objects and has no way to pass the information that objects
were deleted in the meantime.

This commit logs config object deletions to the replay log if required
so that there is a chance that it will be propagated to nodes that were
offline when the deletion happened.

Note that this can only be considered a workaround as the replay log
might be pruned or could even be completely disabled. Also, there still
seems to be a race-condition between the config sync and replay log of
multiple new connections at the same time.
2020-11-09 15:55:51 +01:00