12058 Commits

Author SHA1 Message Date
Julian Brost
009d03fde9 Stacktrace test: try to prevent inlining even harder
- Explicitly disable optimizations for MSVC
- Make stack_test_func_a bigger
2021-03-01 16:26:58 +01:00
Julian Brost
d320b6ac50 Add comments to stack trace formatter and test case 2021-03-01 16:26:58 +01:00
Julian Brost
4f178e3e4d Compile with -D_GNU_SOURCE
Needed by `boost::stacktrace` for `_Unwind_Backtrace()`.
2021-03-01 16:26:58 +01:00
Julian Brost
b1f0a94b62 CMakeLists: use HAVE_LIBEXECINFO only after actually checking for it
So far, the check that actually sets HAVE_LIBEXECINFO was executed after
it was already used to add dependencies.
2021-03-01 16:26:58 +01:00
Julian Brost
e4255a0616 Add a test case for the stack trace formatter 2021-03-01 16:26:58 +01:00
Julian Brost
3c5da0ba3c Use backtrace_symbols() when printing stack traces on FreeBSD
Unfortunately, the symbol resolution of boost::stacktrace is broken on
FreeBSD, therefore fall back to using backtrace_symbols() to print the
stack trace saved by Boost.

Additionally, -D_GNU_SOURCE is required on FreeBSD for the
_Unwind_Backtrace function used by boost::stacktrace.
2021-03-01 16:26:58 +01:00
Julian Brost
5b915965be Crash handlers: use more compact string representation 2021-03-01 16:26:58 +01:00
Julian Brost
7f278f1a59 Begin crash log for SIGABRT with error message and timestamp
This makes the format more similar to what the uncaught C++ and SEH
exception handlers write. Previously there was no indication in the
crash log that a SIGABRT happened.
2021-03-01 16:26:58 +01:00
Julian Brost
8a8e56fb17 Windows: require at least MSVC 19.20 to build
Older versions of MSVC fail to rethrow an unhandled C++ exception (using
`throw;`) in the termination handler (`std::set_terminate`), however
Icinga relies on this behavior in its crash handler
(`Application::ExceptionHandler`).
2021-03-01 16:26:58 +01:00
Julian Brost
6668d2b064 docs: mention use of boost::stacktrace 2021-03-01 16:26:58 +01:00
Julian Brost
12e97d2bcf Add some comments to __cxa_throw
Maybe this will save the next person who has to look at this code some
time. Please don't blame me for the implementation, I'm just trying to
reconstruct what it does.
2021-03-01 16:26:58 +01:00
Julian Brost
c2181ae325 Restructure stack and context trace selection in DiagnosticInformation and document behavior
The logic for selecting the traces to print stays the same, but there
are fewer nested ifs now. This changes the format of the returned string
a bit by adding a heading for both traces.
2021-03-01 16:26:58 +01:00
Julian Brost
9513752761 Add documentation for cast_exception function 2021-03-01 16:26:58 +01:00
Julian Brost
ac3952ea07 Pass fallback stacktrace to DiagnosticInformation in terminate handler
By default, DiagnosticInformation uses the stack trace saved when the
exception was thrown, but this mechanism is not in use on Windows.
Gathering a stacktrace in the terminate handler serves as a fallback.
2021-03-01 16:26:58 +01:00
Julian Brost
c959835339 Replace icinga::StackTrace with boost::stacktrace::stacktrace
Provides roughly the same functionality but works better on certain
platforms (especially Windows) and is less code to maintain.
2021-03-01 16:26:58 +01:00
Julian Brost
723201f97e Print details in uncaught SEH exception handler 2021-03-01 16:26:58 +01:00
Julian Brost
930d09a140 Move error message and time to the beginning of the SEH crash log
This is more similar to the normal exception crashlog which also states
the problem and time at the beginning of the file.
2021-03-01 16:26:58 +01:00
Julian Brost
55cbe11a3d Use boost::stacktrace instead of custom implementation in Windows SEH filter 2021-03-01 16:26:58 +01:00
Julian Brost
659d5dc1dd Run termination handler for uncaught C++ exceptions on Windows
On Windows, the termination handler is executed for uncaught C++
exceptions unless a SEH unhandled exception filter is also set. In this
case, this filter has to explicitly chain the default filter to keep
this behavior.
2021-03-01 16:26:58 +01:00
Julian Brost
74a4f6cdec Try to log useful information for exceptions thrown by RunWorker 2021-03-01 16:26:55 +01:00
Julian Brost
333c635354 Catch exceptions thrown by RunWorker on Windows
The same is already done on other platforms in line 529.
2021-03-01 16:26:55 +01:00
Noah Hilverling
2cb995e937
Merge pull request from GHSA-pcmr-2p2f-r7j6
Verify certificates against CRL before renewing them (2.12)
v2.12.3
2020-12-15 12:30:19 +01:00
Noah Hilverling
a995dc0577
Merge pull request #8542 from Icinga/bugfix/openssl-error-buffer-2.12
Use proper buffer size for OpenSSL error messages (support/2.12)
2020-12-15 12:13:56 +01:00
Noah Hilverling
61c78311b7 Add security fix to CHANGELOG 2020-12-15 10:49:01 +01:00
Julian Brost
abbd7d5494 Allow specifying a CRL in icinga2 pki verify 2020-12-15 10:33:38 +01:00
Julian Brost
cae22a89da Verify certificates against CRL before renewing them
When a CRL is specified in the ApiListener configuration, Icinga 2 only
used it when connections were established so far, but not when a
certificate is requested. This allows a node to automatically renew a
revoked certificate if it meets the other conditions for auto-renewal
(issued before 2017 or expires in less than 30 days).
2020-12-15 10:33:38 +01:00
Alexander Aleksandrovič Klimov
3b862fe9ee
Merge pull request #8565 from Icinga/feature/changelog-2.12.3
Add 2.12.3 changelog & change VERSION file
2020-12-15 10:30:15 +01:00
Noah Hilverling
4db8654bf8 Add 2.12.3 changelog & change VERSION file 2020-12-15 10:28:20 +01:00
Julian Brost
c868010884 Use ERR_error_string_n() instead of ERR_error_string()
Explicitly pass the actual length of the buffer to avoid overflows.
2020-12-15 08:29:37 +01:00
Julian Brost
1f945add50 Increase size of buffer for OpenSSL error messages
According to man 3 ERR_error_string, "buf must be at least 256 bytes
long", therefore increase the buffer size to 256 everywhere.
2020-12-15 08:29:37 +01:00
Julian Brost
159ccced65 Remove std::string to_string(const errinfo_openssl_error& e)
The function was never used and it's implementation contains a bug where
a buffer of too small size is used as a paramter to ERR_error_string.
According to the `man 3 ERR_error_info`, the buffer has to be at least
256 bytes in size.

Also the function seems of limited use as it allows to output the tag
object used with additional error information for exceptions in Boost.
However, you boost::get_error_info<>() just returns the value type but
not the full tag object from the exception.
2020-12-15 08:29:37 +01:00
Noah Hilverling
c89636fcaa
Merge pull request #8549 from Icinga/bugfix/unable-to-toggle-notifications-from-icingaweb2-8533-2.12
Fix runtime config updates not working for objects without zone
2020-12-14 13:28:51 +01:00
Alexander Aleksandrovič Klimov
2ed72c0947
Merge pull request #8506 from Icinga/bugfix/children-recover-too-late
On recovery: re-check children
2020-12-11 15:41:49 +01:00
Noah Hilverling
11486faeba Fix runtime config updates not working for objects without zone
refs #8533
2020-12-11 09:36:39 +01:00
Noah Hilverling
1e71ab8819
Merge pull request #8551 from Icinga/feature/also-drop-distributions-in-2.12.x
Also drop distributions on support/2.12
2020-12-11 09:23:08 +01:00
Alexander A. Klimov
cc8ad5172c GitHub actions: drop Fedora 30 2020-12-10 17:26:18 +01:00
Alexander A. Klimov
1aa2b25b25 GitHub actions: drop CentOS 6 2020-12-10 17:26:03 +01:00
Alexander A. Klimov
3e0176b02b GitHub actions: drop Fedora 29 2020-12-10 17:25:57 +01:00
Alexander A. Klimov
340c50d8a8 GitHub actions: drop openSUSE 15.0 2020-12-10 17:25:49 +01:00
Alexander A. Klimov
a803be65fa GitHub actions: drop SLES 15.0 2020-12-10 17:25:44 +01:00
Alexander A. Klimov
173801b389 GitHub actions: drop SLES 12.4 2020-12-10 17:25:39 +01:00
Alexander A. Klimov
854939a8ce On recovery: re-check children 2020-12-02 12:24:40 +01:00
Alexander A. Klimov
668bf06424 Don't fire suppressed notifications if last parent recovery >= last check result 2020-12-02 12:03:19 +01:00
Alexander Aleksandrovič Klimov
f3f3a946c1
Merge pull request #8511 from Icinga/feature/improve-config-sync-locking-2.12
Improve config sync locking (support/2.12)
2020-11-27 17:53:29 +01:00
Julian Brost
e7d9c5138b Remove SpinLock
No longer needed as its only user now uses std::mutex.
2020-11-27 11:32:11 +01:00
Julian Brost
9dab8644d1 ApiListener: merge new config validation and actication functions
Merge AsyncTryActivateZonesStage and TryActivateZonesStageCallback and
name the result TryActivateZonesStage. The old split was a leftover from
the one being a callback function with no actual meaningful separation.
2020-11-27 11:32:11 +01:00
Julian Brost
07b9c62c98 Use std::mutex instead of Spinlock 2020-11-27 11:32:11 +01:00
Julian Brost
c5d8248e78 API filesync: wait for validation process to exit
This avoid having to pass a lock implictly using the captured variables
of a lambda.
2020-11-27 11:32:10 +01:00
Julian Brost
867a3c0216 Add Process::WaitForResult to allow waiting for the process to finish 2020-11-27 11:32:10 +01:00
Alexander Aleksandrovič Klimov
0364041b95
Merge pull request #8503 from Icinga/bugfix/missing-changelog-item-2.12.2
Add #8495 to the changelog for version 2.12.2
v2.12.2
2020-11-24 15:37:34 +01:00