5455 Commits

Author SHA1 Message Date
Julian Brost
9f8ff26d88
Merge pull request #8496 from Icinga/bugfix/replay-log-blocks
Start ApiListener#SyncClient() in the thread pool
2020-11-23 13:28:46 +01:00
Julian Brost
e589257d1b
Merge pull request #8495 from Icinga/bugfix/config-sync-only-remove-files-if-timestamp-changed
Config sync: Only remove files, if timestamp changed
2020-11-23 12:37:20 +01:00
Alexander A. Klimov
748993af8a Start ApiListener#SyncClient() in the thread pool
... not hosting the coroutines not to block them.

Otherwise a large replay log would block messages sending
until the peer disconnects us.
2020-11-23 12:07:08 +01:00
Julian Brost
91119c8946
Merge pull request #8465 from Icinga/feature/one-connection
ApiListener#NewClientHandlerInternal(): reject connections from already connected endpoints
2020-11-23 12:03:18 +01:00
Julian Brost
611aa39468
Merge pull request #8467 from Icinga/feature/http-status-codes-in-icinga-mainlog-7053
Include HTTP status codes in log
2020-11-23 11:59:05 +01:00
Alexander Aleksandrovič Klimov
a5dc71ebab
Merge pull request #8474 from Icinga/bugfix/message-routing-for-global-zones-2.12
Fix cluster message routing for global zones
2020-11-23 11:55:23 +01:00
Alexander Aleksandrovič Klimov
9fb776bb0f
Merge pull request #8461 from Icinga/bugfix/do-not-accept-api-updates-for-unknown-zone-2.12.2
API: Don't accept object updates for unknown zone
2020-11-23 11:54:08 +01:00
Noah Hilverling
7f232d6007 Config sync: Only remove files, if timestamp changed 2020-11-23 11:39:46 +01:00
Julian Brost
b9f0f6ed40 Close anonymous connections after 10 seconds
Anonymous connections are normally only used for requesting a
certificate and are closed after this request is received. However, the
request is only sent if the child has successfully verified the
certificate of its parent so that it is an authenticated connection from
its perspective. In case this verification fails, both ends view it as
an anonymous connection and never actually use it but attempt a
reconnect after 10 seconds leaking the connection. Therefore close it
after a timeout.
2020-11-13 16:33:40 +01:00
Julian Brost
0e98a52763 Fix cluster message routing for global zones
RelayMessageOne used to relay the message only to one other endpoint for
other zones, which is fine, as long as the target zone is a child/parent
zone but breaks if the target zone is a global one. In this case, the
message has to be forwarded within the local zone as well as to one node
in each child zone.
2020-11-12 09:50:35 +01:00
Julian Brost
5cf90805c8 Log config object deletions to replay log
The initial config object sync for each new connection (in
`ApiListener::SendRuntimeConfigObjects()`) only considers currently
existing objects and has no way to pass the information that objects
were deleted in the meantime.

This commit logs config object deletions to the replay log if required
so that there is a chance that it will be propagated to nodes that were
offline when the deletion happened.

Note that this can only be considered a workaround as the replay log
might be pruned or could even be completely disabled. Also, there still
seems to be a race-condition between the config sync and replay log of
multiple new connections at the same time.
2020-11-10 17:42:43 +01:00
Noah Hilverling
a2d14dcdd2 API: Don't accept object updates for unknown zone 2020-11-09 16:37:25 +01:00
Alexander A. Klimov
29e5d7def7 Include HTTP status codes in log
refs #7053
2020-11-09 10:20:13 +01:00
Alexander A. Klimov
38110e55d3 ApiListener#NewClientHandlerInternal(): reject connections from already connected endpoints 2020-10-26 15:20:58 +01:00
Alexander Aleksandrovič Klimov
cdee5a6069
Merge pull request #8379 from Icinga/bugfix/ido-do-not-log-if-paused-2.12
IDO: Do not log, if paused
2020-10-15 11:42:40 +02:00
Alexander Aleksandrovič Klimov
494f52b115
Merge pull request #8376 from Icinga/bugfix/docker-memory-leak
icinga2 daemon: reap remaining child processes after reload
2020-10-15 11:26:50 +02:00
Noah Hilverling
ceb00ba8c3 IDO: Do not log stats, if paused 2020-10-15 10:39:21 +02:00
Alexander A. Klimov
91265a5b0e icinga2 daemon: reap remaining child processes after reload
... as we may be PID 1.
2020-10-15 10:25:14 +02:00
Noah Hilverling
47a6daf341
Merge pull request #8293 from Icinga/bugfix/icinga2-doesn-t-close-connections-7203
Add timeout for boost::asio::ssl::stream#async_shutdown()
2020-10-14 09:44:12 +02:00
Noah Hilverling
5297cb0cd7
Merge pull request #8349 from Icinga/bugfix/ido-commit-25000-212
IDO MySQL: actually COMMIT after 25000 async queries
2020-10-14 09:23:02 +02:00
Alexander Aleksandrovič Klimov
3e9a177c34
Merge pull request #8320 from Icinga/bugfix/ido-hash-groups
*DbObject#CalculateConfigHash(): sort groups to be hashed
2020-10-14 09:09:18 +02:00
Alexander Aleksandrovič Klimov
912a63d089
Merge pull request #8345 from Icinga/bugfix/exceptions-in-config-sync-2.12
Catch exceptions in the thread running HandleConfigUpdate
2020-10-14 09:09:08 +02:00
Alexander Aleksandrovič Klimov
0d939712bd
Merge pull request #8348 from Icinga/bugfix/configsyncstagelock-unlock-owner-212
Make ApiListener::m_ConfigSyncStageLock a SpinLock
2020-10-14 09:08:57 +02:00
Alexander Aleksandrovič Klimov
b3c5d26310
Merge pull request #8330 from Icinga/bugfix/program-status-not-inserted-2.12
IDO: Make sure to insert program status
2020-10-13 18:13:50 +02:00
Alexander Aleksandrovič Klimov
f27436e8a7
Merge pull request #8328 from Icinga/feature/improve-ido-logging-2.12.0
Improve new IDO logging
2020-10-13 18:13:36 +02:00
Alexander Aleksandrovič Klimov
81393bdda3
Merge pull request #8327 from Icinga/bugfix/do-not-update-customvar-status-on-heavy-config-update
Do not upsert customvar status on heavy config update
2020-10-13 18:13:17 +02:00
Alexander A. Klimov
b3931ff6c4 IDO MySQL: actually COMMIT after 25000 async queries 2020-10-13 17:50:38 +02:00
Alexander A. Klimov
b559bf1735 Make ApiListener::m_ConfigSyncStageLock a SpinLock 2020-10-13 17:45:37 +02:00
Alexander A. Klimov
639c426cf3 Introduce SpinLock 2020-10-13 17:45:37 +02:00
Julian Brost
7d22cdf81e Catch exceptions in the thread running HandleConfigUpdate
With dc3062a9b06fed69cdbb1508ace6eb2f77f87553, exceptions in this code
path were no longer caught properly. This commit restores exception
handling for this function.
2020-10-13 17:38:01 +02:00
Alexander A. Klimov
cb00a7fd6a *DbObject#CalculateConfigHash(): sort groups to be hashed
... to ensure consistent hashes across config reloads.

This will likely cause a heavy update once for all objects in >1 group,
but it will ensure that this happens the last time.
2020-10-13 13:47:49 +02:00
Noah Hilverling
59d066ec2a IDO: Make sure to insert program status during reconnect() 2020-10-13 10:42:44 +02:00
Noah Hilverling
3404dd3ee7 IDO-Logging: Increase logging threshold for nearly empty queue 2020-10-13 09:16:36 +02:00
Noah Hilverling
89fcd41e08 IDO-Logging: Don't log when not connected 2020-10-13 09:16:31 +02:00
Noah Hilverling
5592d9eaf1 IDO-Logging: Remove useless ETA 2020-10-13 09:16:26 +02:00
Noah Hilverling
777c48e549 IDO-Logging: Add log timeout to log every 5 minutes 2020-10-13 09:16:20 +02:00
Noah Hilverling
22c14fd964 IDO: Always insert customvar status on heavy config update 2020-10-13 08:54:58 +02:00
Noah Hilverling
8df78bcc46
Merge pull request #8299 from Icinga/bugfix/reminder-notifications-before-suppressed-8201
Don't send reminder notifications before suppressed ones
2020-10-07 10:17:46 +02:00
Alexander A. Klimov
0a1a286913 Don't send reminder notifications before suppressed ones
refs #8201
2020-09-30 10:30:21 +02:00
Alexander Aleksandrovič Klimov
24d4292f2e
Merge pull request #8271 from Icinga/feature/improve-ido-logging-2.12
Improve IDO queue stats logging
2020-09-24 16:43:30 +02:00
Noah Hilverling
41c3178560
Merge pull request #8276 from Icinga/bugfix/latency-8196
Call Process::InitializeSpawnHelper() ASAP
2020-09-24 16:30:08 +02:00
Alexander A. Klimov
177f930375 Call Process::InitializeSpawnHelper() ASAP
refs #8196
2020-09-23 11:49:13 +02:00
Henrik Triem
329192975e IDO: Implement more accurate logging for query stats 2020-09-22 14:41:11 +02:00
Henrik Triem
38eb2b6bc8 WorkQueue: Allow choosing stats log level 2020-09-22 14:41:11 +02:00
Noah Hilverling
7a7726c20f
Merge pull request #8174 from Icinga/bugfix/7567
Revert "MacroProcessor::ResolveArguments(): skip null argument values"
2020-09-21 13:59:10 +02:00
Noah Hilverling
38063d1756
Merge pull request #8211 from Icinga/bugfix/reload-hang-8173
Application#RunEventLoop(): don't wait for the thread pool to stop on shutdown
2020-09-15 17:16:22 +02:00
Noah Hilverling
7ec7cae4b1
Merge pull request #8189 from Icinga/bugfix/last-zone-sync-stage-validation-failed-7642
Clear ApiListener#last_failed_zones_stage_validation on config::Update if config not changed
2020-09-14 09:41:05 +02:00
Noah Hilverling
cde3db70d1
Merge pull request #8228 from Icinga/bugfix/downtime-checkable-getname
Check !!downtime->GetCheckable() before downtime->GetCheckable()->GetName()
2020-09-14 09:38:28 +02:00
Alexander A. Klimov
8b0ba2275a Check !!downtime->GetCheckable() before downtime->GetCheckable()->GetName()
... not to crash while removing a downtime from a disappeared checkable.
2020-09-11 14:47:46 +02:00
Alexander A. Klimov
934fb89e03 Clear ApiListener#last_failed_zones_stage_validation on config::Update if config not changed
refs #7642
2020-09-11 13:38:35 +02:00