12310 Commits

Author SHA1 Message Date
Alexander A. Klimov
0cca93543c Checkable::NotifyDowntimeEnd(): don't send Downtime end notification unless triggered
... for fixed Downtimes as well.
2021-07-07 15:42:20 +02:00
Alexander A. Klimov
2bcd249efb On ScheduledDowntime change: remove future downtimes created before change
refs #8309
2021-07-07 15:42:18 +02:00
Alexander A. Klimov
c7ad5f6e2e On ScheduledDowntime change: ignore downtimes created before change
... while creating new downtimes.

refs #8309
2021-07-07 15:42:18 +02:00
Alexander A. Klimov
2dcba12765 Introduce Downtime#config_owner_hash
refs #8309
2021-07-07 15:42:18 +02:00
Alexander A. Klimov
c203716ff3 ScheduledDowntime: ignore not related Downtimes while creating Downtimes 2021-07-07 15:42:18 +02:00
Alexander A. Klimov
13d3d18a7f Downtime#Start(): trigger fixed downtimes immediately instead of waiting for the timer
... not to cause e.g. notifications if a problem occurs
between the downtime start time and the timer routine.
2021-07-07 15:31:46 +02:00
Julian Brost
2fd8e13ebf Windows build scripts: allow setting BITS=32 to use 32 bit dependency paths by default 2021-07-07 14:54:27 +02:00
Alexander A. Klimov
e7aa9dd3ed Bump OpenSSL to 1.1.1k 2021-07-07 14:50:23 +02:00
Noah Hilverling
7df2620bda
Merge pull request #8864 from Icinga/bugfix/downtime-for-host-service-with-long-name-8022-212
ConfigObjectUtility::GetObjectConfigPath(): hash names of not already existing objects
2021-07-07 10:39:52 +02:00
Noah Hilverling
4fb27a45cb
Merge pull request #8863 from Icinga/bugfix/harden-scheduled-downtimes-212
ScheduledDowntime::TimerProc(): Catch exceptions to make sure other downtimes are still created
2021-07-07 10:39:44 +02:00
Noah Hilverling
a79f4f9108
Merge pull request #8866 from Icinga/bugfix/new-connection-timeout-212
Add timeout for full Icinga connection handshake
2021-07-07 10:39:38 +02:00
Alexander Aleksandrovič Klimov
bd9ab5ab93
Merge pull request #8876 from Icinga/probot/sync-changelog/9898ccf63fc76ad9ec29d279d20f20cadae86dce
CHANGELOG.md: add v2.11.9
2021-07-06 17:37:21 +02:00
Noah Hilverling
7e0eab3767 ScheduledDowntime::TimerProc(): Catch exceptions to make sure other downtimes are still created 2021-07-06 12:27:16 +02:00
Julian Brost
ecbaa5db67 Add timeout for all new connections
This commit adds a timeout for both establishing new outgoing and incoming
connections. This timeout applies to everything until the connection is in a
state where either JsonRpcConnection or HttpServerConnection takes over.
2021-07-06 11:32:41 +02:00
Julian Brost
49c546ff4c CHANGELOG.md: add v2.11.9 2021-07-06 08:24:45 +00:00
Alexander Aleksandrovič Klimov
9898ccf63f
Merge pull request #8862 from Icinga/feature/gha-windows-212
GitHub actions: build Windows
2021-07-06 10:24:32 +02:00
Julian Brost
97d70daa57 GetObjectConfigPath: only truncate and hash comment and downtime filenames
This partially reverts 68a0079c26686363b6202a8abd2712d2bf96d9f2 and keeps the
fix only for comment and downtime objects for now. For reasoning, please see
the comment in the code.
2021-07-05 16:18:57 +02:00
Julian Brost
eaee629047 GetObjectPath: ensure use of escaped name in all cases and use TruncateUsingHash()
68a0079c26686363b6202a8abd2712d2bf96d9f2 introduced two problems that are fixed
with this commit:
1. The new truncated/hashed name did not use EscapeName()
2. There was a possible collision of names when creating objects with a full
   name of format "[80 characters]...[40 hex digits]" (i.e. the same as the
   truncated/hashed variant but short enough that it isn't hashed)
2021-07-05 16:18:57 +02:00
Julian Brost
bdbe35b42d Utility: add a function to truncate strings while avoiding collisions 2021-07-05 16:18:57 +02:00
Alexander A. Klimov
3788f9170a ConfigObjectUtility::GetObjectConfigPath(): hash names of not already existing objects
... to avoid too long file names.

refs #8022
2021-07-05 16:18:57 +02:00
Alexander A. Klimov
e94044f8aa GitHub actions: build Windows 2021-07-05 14:19:09 +02:00
Alexander A. Klimov
4a0d1a0c96 Don't use Appveyor 2021-07-05 14:18:51 +02:00
Alexander A. Klimov
045c439940 Docs: provide shorter and batch-ier instructions on how to setup a Windows dev env 2021-07-05 14:18:34 +02:00
Julian Brost
0a918c463a Update AppVeyor Config to use Visual Studio 2019 2021-07-05 14:18:15 +02:00
Julian Brost
954da11a96 Update Windows build scripts for Visual Studio 2019
$env:CMAKE_GENERATOR_PLATFORM is only used in configure-dev.ps1 but now
is also required in configure.ps1 to allow the build pipeline to be
upgraded to Visual Studio 2019.

Additionally bump the versions in paths for Boost and OpenSSL.
2021-07-05 14:17:55 +02:00
Julian Brost
1d714a887c
Merge pull request #8861 from Icinga/bugfix/gha-cancel-212
GitHub actions: auto-cancel previous jobs for the same PR
2021-07-05 11:33:58 +02:00
Alexander A. Klimov
6b5130e913 GitHub actions: auto-cancel previous jobs for the same PR
https://github.com/marketplace/actions/auto-cancellation-running-action
2021-07-02 18:12:21 +02:00
Julian Brost
685cc5c155
Merge pull request #8801 from Icinga/feature/release-v2.12.4
Version update and changelog for v2.12.4
v2.12.4
2021-05-27 09:26:57 +02:00
Alexander Aleksandrovič Klimov
b7ff749c77
Merge pull request #8809 from Icinga/bugfix/mysql-one-transaction-for-programstatus-2.12
IDO: Use own transaction for program status and make sure InternalNewTransaction() gets executed
2021-05-26 17:50:29 +02:00
Alexander Aleksandrovič Klimov
f2cd24b437
Merge pull request #8771 from Icinga/bugfix/retry-rename-on-windows-2.12
Retry file rename operations on Windows for some errors (2.12)
2021-05-26 17:50:22 +02:00
Alexander Aleksandrovič Klimov
6ceba45739
Merge pull request #8777 from Icinga/bugfix/runworker-exceptions-2.12
Improve handling of exceptions thrown by RunWorker (2.12)
2021-05-26 16:44:54 +02:00
Julian Brost
c1cee03833 Version update and changelog for v2.12.4 2021-05-26 16:09:30 +02:00
Alexander Aleksandrovič Klimov
8f0b7910b9
Merge pull request #8775 from Icinga/bugfix/problem-notification-at-downtime-end-2.12
Send problem notifications after downtime end for checkables in child zones (2.12)
2021-05-26 11:04:56 +02:00
Alexander Aleksandrovič Klimov
bb4356cc83
Merge pull request #8782 from Icinga/bugfix/concurent-notification-send-and-delete-2.12
Fix crash when notifications are sent while the notification object is deleted (2.12)
2021-05-26 11:01:55 +02:00
Alexander Aleksandrovič Klimov
c18cb90f27
Merge pull request #8785 from Icinga/bugfix/concurrent-schedule-downtime-delete-host-2.12
Fix null pointer dereferences when deleting objects while scheduling downtimes (2.12)
2021-05-26 11:00:03 +02:00
Alexander Aleksandrovič Klimov
204bac296e
Merge pull request #8787 from Icinga/bugfix/api-put-object-deletion-212-7726
ConfigObjectUtility#CreateObject(): check config objects for duplicates
2021-05-26 10:44:38 +02:00
Alexander Aleksandrovič Klimov
195ae0a2ce
Merge pull request #8808 from Icinga/bugfix/reminder-notification-after-timeperiod-with-interval-0-2.12
Make sure not to send reminder notification, if problem notification has been suppressed by TimePeriod
2021-05-26 10:44:21 +02:00
Noah Hilverling
24cbd0685b IDO-MySQL: Make sure InternalNewTransaction() and FinishAsyncQueries() get executed during high load 2021-05-25 17:22:26 +02:00
Noah Hilverling
7d8be5ee69 IDO: Use own transaction for programstatus 2021-05-25 17:13:21 +02:00
Noah Hilverling
511f6bd6b5 Notifications: Make sure not to send reminder notification, if problem notification has been suppressed 2021-05-25 16:59:38 +02:00
Alexander A. Klimov
817fe3fcac ConfigObjectUtility#CreateObject(): check config objects for duplicates
... not to delete already existing objects during a trial of re-creation.

refs #7726
2021-05-25 16:29:58 +02:00
Julian Brost
35c9c656a0 AddDowntime: return Downtime::Ptr instead of String containing the name
At numerous places in the code, something like this is performed:

    String name = Downtime::AddDowntime(...);
    Downtime::Ptr downtime = Downtime::GetByName(name);

However, `downtime` can be a `nullptr` after this as it is possible that
the downtime is deleted in between.

This commit changes the return type of `Downtime::AddDowntime` to return
a Downtime::Ptr instead of the full name of the downtime. `AddDowntime`
performs the very same `GetByName()` operation internally, but handles
the `nullptr` case correctly and throws an exception.
2021-05-25 15:59:55 +02:00
Julian Brost
0cef85cf83 Properly handle service downtime referencing a deleted host
Only two out of three cases were handled properly by the code: host
downtimes referencing a deleted host and service downtimes referencing a
deleted service worked fine. However, if a service downtime references a
deleted host, `Host::GetByName()` returns `nullptr` which isn't
accounted for. Use `Service::GetByNamePair()` instead as this performs a
check for the host being null internally.
2021-05-25 15:59:55 +02:00
Julian Brost
30b7a1e65b Use reference-counted pointer in notification callback
`this` could be deleted after `Notification::BeginExecuteNotification`
exited and before `Notification::ExecuteNotificationHelper` finished.
This is fixed by constructing a `Notification::Ptr` and operate on that
one as it is properly reference-counted.
2021-05-25 15:59:29 +02:00
Julian Brost
c4e58477a0 Try to log useful information for exceptions thrown by RunWorker 2021-05-25 15:58:53 +02:00
Julian Brost
b98a96258c Catch exceptions thrown by RunWorker on Windows
The same is already done on other platforms in line 529.
2021-05-25 15:58:53 +02:00
Julian Brost
ddafaa0add Only handle event::SetSuppressed{Notifications,NotificationTypes} within the local zone
Note that even when passing `nullptr` as target zone to `RelayMessage()`, the
cluster message will still be sent to the parent zone. These incoming messages
will now be rejected by the parent nodes. At the moment, there's no way to only
send within the local zone.
2021-05-25 15:58:17 +02:00
Julian Brost
d109dfcb78 Retry file rename operations on Windows for some errors 2021-05-25 15:57:41 +02:00
Alexander Aleksandrovič Klimov
da1dd05dca
Merge pull request #8792 from Icinga/bugfix/212boost174
Support Boost 1.74
2021-05-25 15:51:13 +02:00
Julian Brost
31077fa99f
Merge pull request #8806 from Icinga/probot/sync-changelog/86c43e86255aa35813284f80af5cbda6165c01a7
CHANGELOG.md: add v2.11.8
2021-05-25 15:25:21 +02:00