13582 Commits

Author SHA1 Message Date
Julian Brost
a2926b8604
Merge pull request #9794 from Icinga/round-notification-times-begin-end-not-to-crash-go-daemon
IcingaDB::PrepareObject(): round Notification#times.{begin,end} not to crash Go daemon
2023-06-27 17:08:41 +02:00
Alexander A. Klimov
dccb678882 IcingaDB::PrepareObject(): cut off (null) negative Notification#times.{begin,end} not to crash Go daemon
At least our PostgreSQL schema enforces positive values.
2023-06-27 12:58:08 +02:00
Alexander A. Klimov
415b810abf IcingaDB::PrepareObject(): round Notification#times.{begin,end} not to crash Go daemon
The latter expects ints, not floats - not to mention strings.
Luckily Icinga already enforces numeric strings so that we can cast it to number.
2023-06-27 12:53:08 +02:00
Julian Brost
9cf519316e
Merge pull request #9805 from Icinga/checkcommand-timeout-0-crashes-icinga-db-daemon-9804
IcingaDB::PrepareObject(): cut off (0) negative Command#timeout for Redis
2023-06-27 10:45:02 +02:00
Julian Brost
c08d3beeb1
Merge pull request #9785 from Icinga/Al2Klimov-patch-8
Icinga DB: also write ConfigObject#original_attributes into Redis
2023-06-27 10:24:41 +02:00
Julian Brost
bd11bc2eb4
Merge pull request #9793 from Icinga/unmarshal-number-42-5-into-go-struct-field-notification-notification_interval
IcingaDB::PrepareObject(): round Notification#interval and limit it to >=0
2023-06-27 10:12:13 +02:00
Alexander A. Klimov
d641a3c799 IcingaDB::PrepareObject(): cut off (0) negative Command#timeout for Redis
not to crash the Go daemon which expects positive values there.
2023-06-26 15:36:47 +02:00
Julian Brost
5350aa3c72
Merge pull request #9792 from Icinga/icingadb-conversion-of-strings-to-number-types-to-avoid-crashes-9791
IcingaDB::PrepareObject(): convert non-null Checkable#check_timeout to number
2023-06-26 15:03:21 +02:00
Mathias Aerts
006ab1fe70
Fix typo 2023-06-26 09:17:26 +02:00
Julian Brost
eddd4c7bf7
Merge pull request #9783 from Icinga/restore_attrs
POST /v1/objects: allow array of attrs to undo modifications of
2023-06-20 10:16:40 +02:00
Alexander A. Klimov
273aa6f997 IcingaDB::PrepareObject(): round Notification#interval and limit it to >=0
otherwise, e.g. with -42.5, the Go daemon crashes. It expects uints there.
2023-06-19 12:46:40 +02:00
Alexander A. Klimov
9f08bad395 IcingaDB::PrepareObject(): convert non-null Checkable#check_timeout to number
and, in case of null, fall back to Checkable#check_command.timeout, just like
IcingaDB#SerializeState(). Otherwise the Go daemon crashes. It expects a number.
2023-06-15 12:29:42 +02:00
Alexander A. Klimov
c070e95b03 Windows: bump OpenSSL v1.1 (soon EOL) -> v3.0 2023-06-14 12:03:22 +02:00
Alexander A. Klimov
1587431945 POST /v1/objects: allow array of attrs to undo modifications of 2023-06-13 16:40:33 +02:00
Alexander A. Klimov
385fe2fd76 Icinga DB: also write ConfigObject#original_attributes into Redis
for the case the Go daemon decides to sync them into DB.
2023-06-12 12:53:25 +02:00
Alexander Aleksandrovič Klimov
a3dabde28a
Doc: Troubleshooting: recommend reducing concurrency for more speed (#9777) 2023-06-05 16:30:06 +00:00
Julian Brost
7c381ae12f
Merge pull request #9779 from Icinga/macroprocessor-resolvemacro-quasi-cv-object-icingaapplication
MacroProcessor::ResolveMacro(): treat quasi-CV-object IcingaApplication as real CV-object
2023-05-31 20:41:31 +02:00
Julian Brost
e2bfd21bae
Merge pull request #9767 from Icinga/doc-ifw
Doc: recommend IfW more prominently
2023-05-31 16:36:04 +02:00
Alexander A. Klimov
a9c80ffb2e MacroProcessor::ResolveMacro(): treat quasi-CV-object IcingaApplication as real CV-object
As MacroProcessor checked just for CustomVarObject base class, but
IcingaApplication provided the vars attribute by itself, it had to also
resolve CV macros by itself. That logic diverged from MacroProcessor so that
macros inside IcingaApplication CVs weren't resolved. Until now.
2023-05-31 16:35:09 +02:00
Julian Brost
bc492cc3ce
Merge pull request #9688 from Icinga/bugfix/selinux-sudo-logging
Add syslog logging to SELinux
2023-05-31 15:19:39 +02:00
Alexander A. Klimov
bbcde92dc6 Doc: recommend IfW more prominently
to make it the users' preferred choice.
2023-05-31 12:44:26 +02:00
Julian Brost
8a42c3bf18
Merge pull request #9775 from Icinga/icingadb-service-crashes-on-negative-downtime-duration-or-end-before-start-9774
Icinga DB: don't write negative Downtime durations into Redis
2023-05-31 11:37:42 +02:00
Alexander A. Klimov
75eaa81c06 Icinga DB: don't write negative Downtime durations into Redis
via `std::max(0, x)` not to crash the Go daemon which can't handle such.
2023-05-30 17:56:03 +02:00
Julian Brost
b0899d9ab4
Merge pull request #8429 from Icinga/bugfix/last-reload-attempt-failed-8428
Share "Last reload attempt failed" time across Icinga process tree on *nix
2023-05-30 11:42:21 +02:00
Julian Brost
d871c5c837
Merge pull request #9772 from Icinga/icinga-db-feature-should-normalize-command-arguments-required-skip_key-repeat_key-to-boolean-9576
Icinga DB feature: normalize *Command.arguments[*].{required,skip_key…
2023-05-25 11:54:01 +02:00
Julian Brost
68cebc6bd5
Merge pull request #9769 from Icinga/docs/parse-performance-data
Fix documentation for parse_performance_data DSL function
2023-05-25 11:01:39 +02:00
Alexander A. Klimov
ad618e9716 Icinga DB feature: normalize *Command.arguments[*].{required,skip_key,repeat_key} to boolean
At the moment, the Icinga DB feature will use that value as-is and
serialize it to JSON, resulting in a crash in Icinga DB down the road
because it expects a boolean.
2023-05-24 16:04:14 +02:00
Julian Brost
07d2527c7f
Merge pull request #9703 from Icinga/NSClient++
Windows MSI: don't bundle NSClient++
2023-05-24 14:49:54 +02:00
Julian Brost
2470e930eb
Merge pull request #9643 from Icinga/hardware_concurrency
Always use Configuration#Concurrency, not `std:🧵:hardware_concurrency()`
2023-05-23 19:23:14 +02:00
Alexander A. Klimov
3fae41ef22 Restart thread pool after freezing Configuration
The user (-D) or we could have changed Configuration.Concurrency,
so correct the thread pool's thread amount.
2023-05-23 14:41:35 +02:00
Julian Brost
0e25644151
Merge pull request #8969 from Icinga/bugfix/perfdata-dont-get-parsed-correctly-8912
PluginUtility: Fix PerfData parsing for values separated with multiple spaces
2023-05-22 17:16:31 +02:00
Julian Brost
9463c937e6
Fix documentation for parse_performance_data DSL function
The function does not support parsing multiple values at once but instead
generates labels like "foo=1 bar":

  Icinga 2 (version: v2.13.0-729-g8fe957bc2)
  Type $help to view available commands.
  <1> => parse_performance_data("foo=1 bar=2")
  {
  	counter = false
  	crit = null
  	label = "foo=1 bar"
  	max = null
  	min = null
  	type = "PerfdataValue"
  	unit = ""
  	value = 2.000000
  	warn = null
  }

While a function with the documented behavior would probably be more useful,
that change can't be made in a compatible way as this would have to change the
return type from PerfdataValue to Array.
2023-05-22 16:56:43 +02:00
Alexander Aleksandrovič Klimov
8fe957bc26
Merge pull request #9763 from Icinga/Al2Klimov-patch-6
Doc: don't mix up check_mysql and check_disk
2023-05-20 09:42:57 +02:00
Julian Brost
2fcc3e00ac
Merge pull request #9764 from Icinga/probot/update-authors/master/bead025b9cf7d20e931bca4d40599c2fa3952959
Update AUTHORS
2023-05-19 20:33:34 +02:00
icinga-probot[bot]
a3f6ce512c
Update AUTHORS 2023-05-19 14:34:51 +00:00
Julian Brost
bead025b9c
Merge pull request #9713 from Tqnsls/Tqnsls-updated-mail-notifications
Updated mail-host-notification and mail-service-notification
2023-05-19 16:34:21 +02:00
Alexander A. Klimov
9376a311ea Fix file endings
git ls-files -z \
	|grep -zEe '^lib/' \
	|grep -zEe '\.[ch]pp$' \
	|xargs -0 perl -p0i -e 's/\n*(?!(?:.|\n))/\n/'
2023-05-17 18:05:13 +02:00
Alexander Aleksandrovič Klimov
23e50a1f64
Doc: don't mix up check_mysql and check_disk 2023-05-17 15:21:53 +02:00
Alexander A. Klimov
32eb1680f7 Configuration.Concurrency: default to 1 until Configuration freeze
not to start many threads before the user could override their amount (-D).
2023-05-11 16:59:47 +02:00
Julian Brost
3276cc9412
Merge pull request #9705 from Icinga/windows-doc-off
On Windows don't ship docs and images
2023-05-11 16:13:55 +02:00
Alexander A. Klimov
8fb5d53118 Track Configuration.Concurrency modifications 2023-05-11 15:41:35 +02:00
Julian Brost
0320431bc2
Merge pull request #9761 from Icinga/boost182
Bump Boost shipped for Windows to v1.82
2023-05-11 15:27:12 +02:00
Alexander Aleksandrovič Klimov
d1c7f3d7da GHA: Linux: add Fedora 38, Ubuntu 23.04 2023-05-11 10:24:59 +02:00
Alexander A. Klimov
d552d0779e Bump Boost shipped for Windows to v1.82 2023-05-10 16:40:46 +02:00
Henrik Triem
6febbdc19a
Add syslog logging to SELinux during usage of sudo 2023-05-10 09:16:13 +02:00
Alexander Aleksandrovič Klimov
9f5ba58a1c
Merge pull request #9706 from Icinga/Al2Klimov-patch-3
Require CMake s/2.8.8/2.8.12/
2023-05-09 10:20:28 +02:00
Julian Brost
517b291a94
Merge pull request #9757 from Icinga/Al2Klimov-patch-6
Fix typo
2023-05-08 20:10:40 +02:00
Julian Brost
e9fa037983
Merge pull request #9754 from Icinga/cmake3
GHA: use a CMake version which can set(CMAKE_CXX_STANDARD 17) where possible
2023-05-08 18:52:42 +02:00
Didier 'OdyX' Raboud
0b8f65d562
ssl_cert allow HTTP request URL setting
This is available in check_ssl_cert since 2021-02-18 Version 1.137.0
2023-05-08 17:00:45 +02:00
Alexander Aleksandrovič Klimov
ae0a4fb464
Fix typo
which leaves a string open and prevents the code which should be outside it from running.
2023-05-08 15:23:06 +02:00