tyler.durden
/
icinga2
mirror of https://github.com/Icinga/icinga2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
9,827 Commits 347 Branches 117 Tags 181 MiB
Commit Graph

4284 Commits

Author SHA1 Message Date
Jean Flach 2e3a1ff0c6
Merge pull request #6498 from Icinga/bugfix/match-regex-match-any-regression 
Fix regression with MatchAny false conditions on match/regex/cidr_match
 2018-07-27 17:28:13 +02:00
Jean Flach a5afaf5b40
Merge pull request #6497 from Icinga/bugfix/match-dictionary-error-handling 
Improve error logging for match/regex/cidr_match functions and unsupported dictionary usage
 2018-07-27 17:26:12 +02:00
Michael Friedrich 72c0f07661 Fix regression with MatchAny false conditions on match/regex/cidr_match 
fixes #6496
 2018-07-27 16:55:37 +02:00
Michael Friedrich 8e682ce9b1 Improve error logging for match/regex/cidr_match functions and unsupported dictionary usage 
fixes #6442
 2018-07-27 16:34:50 +02:00
Michael Friedrich 1d22b6e176
Merge pull request #6410 from Icinga/remove-dead-code 
Remove unused code
 2018-07-27 15:56:52 +02:00
Michael Friedrich b16d96d197
Merge pull request #6489 from Icinga/feature/object-packer 
Implement object packer for consistent hashing
 2018-07-27 12:49:28 +02:00
Alexander A. Klimov dd8cb42969 Implement object packer for consistent hashing 2018-07-26 17:36:48 +02:00
Markus Frosch ddc5b951b3
Revert "Implement support for the --env command-line argument" 2018-07-26 17:09:06 +02:00
Michael Friedrich 46e71a83dc
Merge pull request #6414 from Icinga/feature/icinga-envs 
Implement support for the --env command-line argument
 2018-07-26 10:09:42 +02:00
Michael Friedrich e519d6bbc6
Merge pull request #6110 from gunnarbeutner/feature/for-loop-var 
Implement support for optionally specifying the 'var' keyword in 'for' loops
 2018-07-26 10:05:17 +02:00
Michael Friedrich 272176e2d0
Merge pull request #6475 from dh-harald/master 
lib->compat->statusdatawriter: fix notifications_enabled
 2018-07-26 10:03:57 +02:00
Michael Friedrich 3fc3d86fbb
Merge pull request #6386 from Icinga/fix/timeperiods-do-not-clear-after-restart 
Fix that TimePeriod segments are not cleared on restart
 2018-07-26 10:02:46 +02:00
Michael Friedrich 020bd86b4c
Merge pull request #6408 from Icinga/bugfix/objectlock-unlock-m_lockowner 
ObjectLock#Unlock(): don't reset m_Object->m_LockOwner too early
 2018-07-26 10:02:26 +02:00
Michael Friedrich 038b2fb94c
Merge pull request #6379 from Icinga/global-zone-validation 
Throw config error when using global zones as parent
 2018-07-26 10:01:46 +02:00
Michael Friedrich fcc32957cb
Merge pull request #6455 from Icinga/feature/filelogger-started 
Log something when the Filelogger has been started
 2018-07-26 10:01:06 +02:00
Michael Friedrich 62e91e1891
Merge pull request #6430 from Icinga/fix/workqueue-log-message 
Fix negative 'empty in' value in WorkQueue log message
 2018-07-26 09:59:53 +02:00
Michael Friedrich 89d42fee72
Merge pull request #6440 from Icinga/bugfix/typo 
Fix typo
 2018-07-26 09:59:20 +02:00
Michael Friedrich b1adad0a42
Merge pull request #6456 from Icinga/feature/logger-flush-dev 
Keep notes for immediately log flushing
 2018-07-26 09:58:59 +02:00
Michael Friedrich 45a0518c78
Merge pull request #6458 from Icinga/bugfix/configitem-debug-log 
Fix debug build log entry for ConfigItem activation priority
 2018-07-26 09:57:19 +02:00
Michael Friedrich 5a8e98213c
Merge pull request #6487 from Icinga/bugfix/discard-warning-6485 
Fix "Discard" message being warning
 2018-07-26 09:52:33 +02:00
Jean Flach 2b44eff8da Fix "Discard" message being warning 2018-07-26 09:39:03 +02:00
dh.harald d9d701a05c
lib->compat->statusdatawriter: fix notifications_enabled 2018-07-23 22:28:09 +01:00
Michael Friedrich 14d88d90a0
Merge pull request #6470 from sebastic/spelling-errors 
Fix spelling errors.
 2018-07-23 17:59:45 +02:00
Bas Couwenberg 0891380789 Fix spelling errors. 
* occured -> occurred
 * dosen't -> doesn't
 2018-07-21 10:38:09 +02:00
Alexander A. Klimov f71bad96d5 Start and stop the timer thread lazily 
refs #6461
 2018-07-20 15:36:15 +02:00
Michael Friedrich 7519d23892 Add debug logging for daemonize/timers 
The previous commit is 1:1 the same I've implemented
here already. Great teamwork with Alex :)

refs #6445
 2018-07-19 13:34:12 +02:00
Alexander A. Klimov d15e1006f3 Re-introduce Timer::Initialize() 
refs #6445
 2018-07-19 13:22:37 +02:00
Michael Friedrich fc2da5047c Fix debug build log entry for ConfigItem activation priority 
This is not visible in release builds, minor fix.
 2018-07-19 12:53:28 +02:00
Michael Friedrich fd381ff5e0 Keep notes for immediately log flushing 
Disabled, but kept for future debugging sessions.
Helps with things like #6455
 2018-07-19 12:51:30 +02:00
Michael Friedrich 7c2e999f1f Log something when the Filelogger has been started 
Helps to see whether the logger object is active,
spotted during #6445
 2018-07-19 12:48:29 +02:00
Alexander A. Klimov 030afee8b0 Fix typo 2018-07-17 14:23:20 +02:00
Michael Insel 4170bd5205 Fix negative 'empty in' value in WorkQueue log message 
This fixes a negative 'empty in' value in WorkQueue log messages.
 2018-07-10 19:21:04 +02:00
Alexander A. Klimov ac6afadb5a Make HttpServerConnection#m_DataHandlerMutex a boost::recursive_mutex 
refs #6428
 2018-07-09 14:40:32 +02:00
Gunnar Beutner 2eb46f1203 Implement support for optionally specifying the 'var' keyword in 'for' loops 2018-07-03 11:03:22 +02:00
Michael Friedrich ab9a32d67d Fix missing next check update causing the scheduler to execute checks too often 
Regression from #6217, only in git master.

fixes #6421
 2018-07-02 16:17:53 +02:00
Michael Friedrich 601c54e44e Add more debug logging for check scheduling 2018-07-02 16:17:33 +02:00
Gunnar Beutner c577554073 Implement support for the --env command-line argument 2018-06-27 13:15:52 +02:00
Jean Flach 4159682cf8 Remove unused code 
These methods and types were used only by the Icinga Studio
 2018-06-25 10:09:30 +02:00
Alexander A. Klimov 02645c59ff ObjectLock#Unlock(): don't reset m_Object->m_LockOwner too early 2018-06-22 14:13:09 +02:00
Michael Friedrich ba680dc829
Merge pull request #6405 from Icinga/bugfix/windows-reload-behaviour-6378 
TcpSocket#Bind(): reuse socket addresses on Windows, too
 2018-06-22 12:25:28 +02:00
Alexander A. Klimov 79878ea286 TcpSocket#Bind(): reuse socket addresses on Windows, too 
refs #6378
 2018-06-22 10:33:31 +02:00
Michael Friedrich 0ffb8af8e3 Conform to RFC for CRLF in HTTP requests 
refs #6242
 2018-06-21 16:53:44 +02:00
Michael Friedrich 1b2af3f0c4
Merge pull request #6402 from Icinga/fix/tls-stream-read-pending 
Use SSL_pending() for remaining TLS stream data
 2018-06-21 16:43:03 +02:00
Michael Friedrich 257ad12646 Use SSL_pending() for remaining TLS stream data 
We've used this previously, and according to the OpenSSL
docs we should just use it. From our experience everything
done different to the API functions from OpenSSL causes
undefined behaviour in the worst case.

This commit also breaks the packet size limit into a more
readable version, including logs for development debug builds.

refs #6242
 2018-06-21 15:58:05 +02:00
Michael Friedrich 9ea0650edc Fix connection error handling in Elasticsearch and InfluxDB features 
Previously this would just throw the entire exception stack trace
which is not needed here.

fixes #6394
 2018-06-21 15:41:40 +02:00
Michael Friedrich cc294e14d2
Merge pull request #6393 from Icinga/bugfix/elasticsearchwriter-not-writing-6354 
Stream#ReadLine(): fix false positive buffer underflow indicator
 2018-06-21 15:06:21 +02:00
Alexander A. Klimov 1c213877a4 Stream#ReadLine(): simplify algorithm 
refs #6354
 2018-06-20 17:28:52 +02:00
Alexander A. Klimov 3c7851107c TlsStream#IsEof(): fix false positive EOF indicator 
refs #6242
 2018-06-20 16:55:33 +02:00
Alexander A. Klimov 02d1f1cc57 Stream#ReadLine(): fix false positive buffer underflow indicator 
refs #6354
 2018-06-20 09:59:18 +02:00
Michael Friedrich cfd6c79a03
Merge pull request #6387 from Icinga/fix/remove-broken-api-user-hash 
Remove ApiUser password_hash functionality
 2018-06-19 14:26:32 +02:00
Michael Friedrich 2fd6709952 Remove ApiUser password_hash functionality 
This affects and fixes

- Windows reload
- Config validation
- RHEL 7.5 OpenSSL memory corruption
- Hash algorithm, requested changes

refs #6378
refs #6279
refs #6278
 2018-06-19 11:32:03 +02:00
Noah Hilverling ea08c85424 Fix that TimePeriod segments are not cleared on restart 
refs #6282
 2018-06-19 10:30:34 +02:00
Noah Hilverling 233d00d648
Merge pull request #6311 from Reamer/timeperiod_bugfix 
refs #6282
 2018-06-19 10:29:27 +02:00
Michael Friedrich 9b99c9d106 Remove leftover for sysconfig file parsing 
refs #6255
 2018-06-18 19:25:48 +02:00
Alexander A. Klimov a0fca599da HttpRequest#ParseBody(): indicate success on complete body 
refs #6184
 2018-06-18 16:02:22 +02:00
Michael Friedrich eb1f37905d
Merge pull request #6368 from Icinga/fix/program-options-parsing-6365 
Fix program option parsing
 2018-06-15 16:09:13 +02:00
Jean Flach ee9be90fa7 Throw config error when using global zones as parent 2018-06-15 14:40:09 +02:00
Michael Friedrich 8c3c4704d2
Merge pull request #6371 from Icinga/bugfix/socket-io-handling-with-http-json-rpc-6361 
ApiListener#NewClientHandlerInternal(): Explicitly close the TLS stream on any failure
 2018-06-15 14:35:48 +02:00
Michael Friedrich b9bfe70444 Fix missing name for workqueue while creating runtime objects via API 
fixes #6364
 2018-06-15 14:25:03 +02:00
Alexander A. Klimov 7741517df7 ApiListener#NewClientHandlerInternal(): Explicitly close the TLS stream on any failure 
refs #6361
 2018-06-14 15:03:04 +02:00
Michael Insel e885cf71c6 Fix program option parsing 
This fixes the program option parsing.
 2018-06-12 19:02:48 +02:00
Jean Flach 9a5d464448 Revert "Fix Windows reload" 
This reverts commit 691e3cfd57.
 2018-06-12 12:19:16 +02:00
Jean Flach 0fc5db82dd Fix ScheduledDowntimes replicating on restart 
fixes #4272
 2018-06-08 10:54:06 +02:00
Jean Flach ee37c8c68e
Merge pull request #6343 from Icinga/fix/checks-via-command_endpoint-are-not-executed-6337 
Fix that checks with command_endpoint don't return any check results
 2018-06-07 11:42:40 +02:00
Michael Friedrich 447dad91c0 Increase header size to 8KB for HTTP requests 
This is the default for Tomcat and Apache too
and avoids problems with cookies and long URLs.

fixes #6355
 2018-06-06 20:25:36 +02:00
Michael Friedrich bf0737ded5
Merge pull request #6328 from Icinga/sysconfig-env 
Rework sysconfig file/startup environment
 2018-06-05 13:27:36 +02:00
Noah Hilverling d8b400dc17 Fix that checks with command_endpoint don't return any check results 
fixes #6337
 2018-05-29 13:51:34 +02:00
Michael Insel d868780e6d Fix unnecessary blank in log message 
This fixes an unnecessary blank in the updating configuraiton log message.

information/cli: Updating ' "conf.d"' include in '/etc/icinga2/icinga2.conf'.

Should be:

information/cli: Updating '"conf.d"' include in '/etc/icinga2/icinga2.conf'.
 2018-05-24 19:35:52 +02:00
Jean Flach ed4e008e79 Rework sysconfig file 
The sysconfig file now only contains the defaults as comments, changes
made there are given to the init.d script, prepare-dirs, safe-reload and
Icinga 2 itself. If nothing is set in the sysconfig file (as is the
default as all lines are commented out) the defaults are used.

fixes #6255
 2018-05-23 15:18:42 +02:00
Michael Friedrich 4a6320d7f7 Update log message for skipped certificate renewal 
Users kept asking about it, still it is just an "information"
that this isn't needed yet.
 2018-05-23 15:18:38 +02:00
Michael Friedrich 653a2b4e7d
Merge pull request #6324 from Icinga/fix/6279-api-user-crash 
Ensure that password hash generation from OpenSSL is atomic
 2018-05-23 11:25:52 +02:00
Jean Flach 08a14cd136 Ensure that password hash generation from OpenSSL is atomic 
This is supposed to solve a problem with segfaults caused by
race conditions withing the random byte generation of OpenSSL.

fixes #6279
 2018-05-23 10:55:14 +02:00
Michael Friedrich 2d8158ec29
Merge pull request #6290 from jre3brg/opentsdb-metric-names 
Fixed opentsdb metric name with colon chars
 2018-05-22 15:46:04 +02:00
Michael Friedrich f788878f79 Update log message for skipped certificate renewal 
Users kept asking about it, still it is just an "information"
that this isn't needed yet.
 2018-05-18 17:04:03 +02:00
Michael Friedrich 4a68ed9a5f Ensure that icinga_min_version parameter is optional 
Seen that here: https://github.com/Icinga/icinga2/issues/6319#issuecomment-390195058

refs #5960
refs #3998
 2018-05-18 15:11:56 +02:00
Noah Hilverling a5a2194fa2
Merge pull request #6292 from Icinga/fix/flapping-reminder-notification 
Fix problem with reminder notifications if the checkable is flapping
 2018-05-17 13:52:29 +02:00
Philipp Dallig 8e124e2abe Do not add the old timeperiod segment, if we cut it in the middle 2018-05-16 12:04:38 +02:00
Michael Friedrich 120eb070d2
Merge pull request #6309 from Icinga/fix/compiler-warning-in-checkercomponent-ti 
Fix compiler warning in checkercomponent.ti
 2018-05-16 10:42:31 +02:00
Michael Friedrich 04af51b866
Merge pull request #6306 from Icinga/feature/checkresultreader-deprecated 
Adjust message for CheckResultReader deprecation
 2018-05-15 14:05:16 +02:00
Michael Friedrich 7f579db9af
Merge pull request #6305 from gunnarbeutner/feature/environment-variable 
Introduce the 'Environment' variable
 2018-05-15 14:04:50 +02:00
Gunnar Beutner 9c1e00eb94 Introduce the 'Environment' variable 2018-05-15 12:02:15 +02:00
Noah Hilverling ead1f262e6 Fix compiler warning 
fixes #6081
 2018-05-15 11:25:28 +02:00
Michael Friedrich ead3f0a227 Adjust message for CheckResultReader deprecation 
refs #6031
 2018-05-15 10:44:06 +02:00
Michael Friedrich 119965fe24 Adjust deprecation removal for compat features 
As discussed with @lippserd :)

refs #6032
refs #6033
 2018-05-14 15:55:30 +02:00
Michael Friedrich 5b19784b25 Change log level for failed event command execution 
refs #5692
 2018-05-11 15:24:37 +02:00
Michael Friedrich 2d87b667ab Execute event commands only on actively checked host/service objects in an HA zone 
fixes #3431
 2018-05-11 12:58:33 +02:00
Michael Friedrich 964a5ebd57 Deprecate compatlog feature 
fixes #6032
 2018-05-09 17:37:28 +02:00
Michael Friedrich f070d2136a Ensure that user input for groups is unique on API object creation 
refs #4732
 2018-05-09 17:26:10 +02:00
Michael Friedrich 88d99094bf Ensure that added group members are unique 
refs #4732
 2018-05-09 17:26:07 +02:00
Michael Friedrich 6660a45c41 Implement Array::Unique() and add unit tests 
refs #4732
 2018-05-09 17:25:55 +02:00
Michael Friedrich 16e8e3cf4b Fix problem with reminder notifications if the checkable is flapping 2018-05-09 09:54:48 +02:00
Michael Friedrich f0f0b47057 Fix style and logging from review; enhance output 
refs #4508
 2018-05-08 16:59:09 +02:00
Jean Flach b8fc3a3ffa Small changes to node wizard/command 
refs #4508
 2018-05-08 16:33:06 +02:00
Michael Insel 662d36fd16 Warn in case of failed conf.d exclusion also on master setup 
refs #4508
 2018-05-08 16:33:04 +02:00
Jean Flach 026359d404 Rename "dont-disable-confd" 
Double negation is confusing. Also this would change the default
behaviour and could lead to problems in automated environments.

refs #4508
 2018-05-08 16:32:56 +02:00
Jean Flach a43cf8e9ef Warn in case of failed conf.d exclusion 
refs #4508
 2018-05-08 16:32:53 +02:00
Michael Insel 58f923f5f7 Allow to disable conf.d inclusion through node wizard/setup 
This implements a function to disable the conf.d directory through the node wizard/setup.

refs #4508
 2018-05-08 16:31:59 +02:00
jre3brg 2fd94073ba Fixed opentsdb metric name with colon chars 2018-05-08 09:40:13 +02:00
Jean Flach c54e042942 Add activation priorities for config object types 
This patch ensures that specific configuration types
are pre-activated and post-activated. In general,
logging is first, then common configuration objects
like host/service, downtimes, etc.
In the end, all features are activated after to ensure
that notifications are only sent once downtimes are applied.
A similar thing happens for starting with checks too early.
The ApiListener feature runs first to allow cluster connections
at first glance.

fixes #6057
fixes #6231
 2018-05-04 11:25:47 +02:00
Jean Flach 88dc230294
Merge pull request #6285 from Icinga/feature/config-validation-timestamps 
Add support for config validation log timestamps
 2018-05-03 14:22:39 +02:00