Michael Friedrich
d4277b4d70
Require that max_check_attempts is greater than 0
...
fixes #4832
2017-02-07 13:27:27 +01:00
Michael Friedrich
b51a2c1c25
MacroProcessor: Add the argument name for set_if error messages
...
fixes #13345
2017-01-11 12:26:09 +01:00
Michael Friedrich
b7caf0820d
Ensure that *.icinga.com is used everywhere
...
fixes #13897
fixes #13277
2017-01-10 17:19:12 +01:00
Gunnar Beutner
56e9a23a65
Don't try to delete Downtime objects that were statically configured
...
fixes #13275
2016-11-22 15:13:43 +01:00
Michael Friedrich
a13e6b3e87
Fix that custom notifications do not reset force_next_notification
...
This attribute is stored in the state file forever as well.
Will cause forced notifications ignoring state/type filters.
fixes #12670
2016-11-17 11:53:35 +01:00
Gunnar Beutner
23e30ccb67
Revert "Implement the 'evaluate-macros' API action"
...
This reverts commit 851135d3a1
.
fixes #13091
2016-11-17 10:39:27 +01:00
Michael Friedrich
35ce166bd2
Fix that recovery notifications are sent if notified for !Problem type before
...
fixes #13205
2016-11-17 10:35:16 +01:00
Michael Friedrich
1bfb91f065
Ensure that DowntimeStart notifications are not immediately sent
...
fixes #12549
2016-11-11 19:36:19 +01:00
Michael Friedrich
e7a6124924
Fix crash in CheckResult cluster handlers
...
fixes #13151
2016-11-11 16:29:51 +01:00
Michael Friedrich
7e0c48643b
Fix Flapping{Start,End} notifications in SOFT states or downtimes
...
fixes #12560
fixes #12892
2016-11-10 14:16:02 +01:00
Gunnar Beutner
06e4b4e9da
Fix crash in Checkable::OnAllConfigLoaded
...
fixes #13103
2016-11-10 13:42:50 +01:00
Gunnar Beutner
851135d3a1
Implement the 'evaluate-macros' API action
...
fixes #13091
2016-11-09 09:13:42 +01:00
Michael Friedrich
09658f6d0e
Add child_options for API action 'schedule-downtime'
...
fixes #10896
fixes #10897
2016-11-02 09:54:48 +01:00
Michael Friedrich
ea1f8727da
Implement GetAllChildren() for dependency resolution
...
refs #10896
refs #10897
2016-11-02 08:55:11 +01:00
Michael Friedrich
86f162af85
Add SCHEDULE_AND_PROPAGATE{,_TRIGGERED}_HOST_DOWNTIME external commands
...
refs #10896
refs #10897
2016-11-02 08:54:32 +01:00
Gunnar Beutner
5fdc874377
Don't generate 'UNKNOWN' results when the endpoint's log is still being resynced
...
fixes #12844
2016-10-24 08:38:58 +02:00
Michael Friedrich
3571965fef
Fix SOFT/HARD state counting logic for check attempts <= 2
...
fixes #12592
2016-09-27 11:30:57 +02:00
Gunnar Beutner
8fd454fbb1
Fix crash in ClusterEvents::SendNotificationsAPIHandler
...
fixes #12718
2016-09-13 22:14:11 +02:00
Gunnar Beutner
efbdce803f
Fix incorrect attribute name on the validator for the Notification class
...
fixes #12633
2016-09-04 17:50:44 +02:00
Michael Friedrich
ae75575874
Remove unused last_in_downtime field
...
fixes #12602
2016-08-31 15:21:26 +02:00
Gunnar Beutner
903db81fe0
Make sure that libmethods is automatically loaded even when not using the ITL
...
fixes #12578
2016-08-28 17:03:08 +02:00
Gunnar Beutner
78cd56e277
Implement support for default templates
...
fixes #12575
2016-08-28 10:27:43 +02:00
Gunnar Beutner
e8b0797ec4
Use 'auto' keyword for iterator declarations (part 2)
...
refs #12561
2016-08-27 19:56:12 +02:00
Gunnar Beutner
8f2477db46
Fix incorrect variable type in the FilterArrayToInt function
...
refs #12509
2016-08-27 12:23:09 +02:00
Gunnar Beutner
6e384f81a0
Remove unused #includes
...
refs #12481
2016-08-27 10:59:52 +02:00
Gunnar Beutner
b5b09216c6
Use lambda functions for INITIALIZE_ONCE
...
fixes #12562
2016-08-27 09:48:36 +02:00
Gunnar Beutner
5058c5d75b
Use 'auto' for iterator declarations
...
fixes #12561
2016-08-27 08:37:19 +02:00
Gunnar Beutner
30762e5330
Set versions for all internal libraries
...
fixes #12552
2016-08-25 17:56:18 +02:00
Gunnar Beutner
288413f046
Replace BOOST_FOREACH with range-based for loops
...
fixes #12538
2016-08-25 06:46:17 +02:00
Gunnar Beutner
429d11daa8
Fix compiler warnings
...
fixes #12534
2016-08-24 20:33:34 +02:00
Gunnar Beutner
ae1ab5f865
Implement unit tests for state changes
...
fixes #12530
2016-08-24 19:45:52 +02:00
Gunnar Beutner
deb938d412
Fix incorrect notifications for soft recoveries
...
fixes #12529
2016-08-24 12:22:08 +02:00
Gunnar Beutner
82b6ef4301
Don't update TimePeriod ranges for inactive objects
...
fixes #12511
2016-08-23 15:01:40 +02:00
Gunnar Beutner
218e780a44
Avoid unnecessary string copies
...
fixes #12509
2016-08-23 15:01:40 +02:00
Gunnar Beutner
43a4acd5a2
Remove deprecated functions
...
fixes #12507
2016-08-23 15:01:40 +02:00
Michael Friedrich
cd1b2cdddd
Fix that recovery notifications are sent in SOFT NOT-OK states
...
fixes #12517
2016-08-23 14:58:24 +02:00
Michael Friedrich
b8d3bcad6a
Cluster: Fix notified users for NotificationSentToAllUsers event
...
refs #12449
refs #12444
2016-08-22 10:47:09 +02:00
Michael Friedrich
e5566a6bd8
API: Fix missing attributes for DowntimeTriggered event
...
fixes #12464
2016-08-17 16:57:22 +02:00
Michael Friedrich
520be9513b
API: Fix that schedule-downtime action requires duration for fixed=true
...
fixes #12454
2016-08-16 17:09:25 +02:00
Gunnar Beutner
b7a1b58069
Improve performance for type lookups
...
fixes #12448
2016-08-16 11:02:33 +02:00
Michael Friedrich
a34e01d0bb
Fix NotificationSentToAllUsers cluster event
...
refs #12444
2016-08-16 09:30:10 +02:00
Michael Friedrich
d909c0945c
Add an explicit flag for disabling reminder notifications
...
refs #12402
2016-08-15 18:32:51 +02:00
Michael Friedrich
17544d7b54
Fix: ClusterEvents::NotificationSentAllUsersAPIHandler() does not set notified_users
...
fixes #12444
2016-08-15 17:26:01 +02:00
Michael Friedrich
d341783a51
API: Implement 'generate-ticket' action and update distributed monitoring docs
...
fixes #12433
2016-08-15 15:19:28 +02:00
Gunnar Beutner
ebaf239d3b
Replace GetType()->GetName() calls with GetReflectionType()->GetName()
...
fixes #12438
2016-08-15 14:42:03 +02:00
Gunnar Beutner
8ced75b7d2
Fix the load order for Host/Service vs. Endpoint/Zone
...
refs #12432
2016-08-14 23:04:55 +02:00
Gunnar Beutner
39ded04e1a
Improve validation for the command_endpoint attribute
...
fixes #12432
2016-08-14 22:11:29 +02:00
Gunnar Beutner
fda032c0c4
Fix incorrect return values for some of the CompatUtility methods
...
fixes #12425
2016-08-14 17:06:50 +02:00
Gunnar Beutner
9f8cb8dd36
Clean up the code a bit
...
refs #11423
2016-08-13 21:43:59 +02:00
Michael Friedrich
8f03adf76f
Remove Downtime objects w/o reference to ScheduledDowntime objects
...
fixes #11423
2016-08-13 15:18:50 +02:00
Gunnar Beutner
99f944ac28
Remove extraneous space in a log message
...
refs #12304
2016-08-12 16:38:05 +02:00
Michael Friedrich
e28f30a727
Enhance log messages for {,reminder} notifications
...
refs #12402
2016-08-12 14:49:29 +02:00
Gunnar Beutner
31f816562f
Add namespace qualifier for some assert() calls
...
refs #12408
2016-08-12 13:44:51 +02:00
Gunnar Beutner
24431b3dab
Register deprecated methods in the 'Deprecated' namespace
...
refs #12408
2016-08-12 13:42:22 +02:00
Gunnar Beutner
c5a170a972
Implement support for namespaces
...
fixes #12408
2016-08-12 11:32:16 +02:00
Michael Friedrich
f5d5eaf344
Add log message if notifications are forced (i.e. filters are not checked)
...
fixes #12404
2016-08-11 16:23:58 +02:00
Michael Friedrich
8389d01998
Fix flexible downtimes expiry time and removal
...
fixes #12395
2016-08-10 17:15:27 +02:00
Gunnar Beutner
e09fb88cae
Make sure functions are registered with the correct prefix
...
refs #12393
2016-08-10 16:33:17 +02:00
Michael Friedrich
42818ab758
Fix downtime notification events and missing author/comment
...
fixes #12333
fixes #11851
2016-08-10 16:04:37 +02:00
Gunnar Beutner
54bbaf9f7d
Implement support for marking functions as deprecated
...
fixes #12393
2016-08-10 15:48:05 +02:00
Gunnar Beutner
dc06209e4a
Move internal script functions into the 'Internal' namespace
...
fixes #12338
2016-08-10 06:55:44 +02:00
Gunnar Beutner
4c7e2994a7
Handle I/O errors while writing the Icinga state file more gracefully
...
fixes #12334
2016-08-09 10:59:08 +02:00
Gunnar Beutner
1beef64dc4
Fix crash in Checkable::ProcessCheckResult when cr is NULL
...
refs #12329
2016-08-08 14:17:44 +02:00
Gunnar Beutner
c7602a0f34
Implement process_check_result script method for the Checkable class
...
fixes #12329
2016-08-08 14:14:45 +02:00
Gunnar Beutner
8deeb73bb8
Register a new script frame in Function::Invoke
...
fixes #9848
2016-08-08 14:12:08 +02:00
Gunnar Beutner
597dc0dea2
Fix incorrect behavior for max_check_attempts
...
fixes #11898
2016-08-08 11:02:08 +02:00
Gunnar Beutner
d0658c465b
Fix incorrect parameter name for NotificationSentAllUsersHandler
...
fixes #12310
2016-08-05 06:57:50 +02:00
Michael Friedrich
43a177fb16
Fix that notifications with empty times.{begin,end} are not sent
...
fixes #10363
2016-08-04 17:27:35 +02:00
Michael Friedrich
3f89a6dd09
Disable immediate hard state for first check result
...
fixes #7354
2016-08-04 16:16:58 +02:00
Gunnar Beutner
905380b436
Fix duplicate notifications on HA failover
...
fixes #12267
2016-08-04 10:12:55 +02:00
Michael Friedrich
34655d77d3
Ensure to send recovery notifications if the was a problem notification before a downtime
...
fixes #12293
2016-08-03 18:28:09 +02:00
Michael Friedrich
83f07c7ee2
Add the notification type into the log message
...
fixes #12304
2016-08-03 17:32:55 +02:00
Michael Friedrich
5498dc5e4f
Fix that the first notification interval is incorrect
...
fixes #12257
2016-08-02 18:41:01 +02:00
Conrad Clement
3f0b6ec003
Optimize two ObjectLocks into one in Notification::BeginExecuteNotification method
...
object is locked twice to update values of
NotificationNumber, LastNotification and LastProblemNotification.
LastNotificaiton is updated inside each ObjectLock
merge two ObjectLocks into one and remove duplicate update
fixes #12188
Signed-off-by: Michael Friedrich <michael.friedrich@netways.de>
2016-08-02 18:36:29 +02:00
Rune Darrud
54eb9540b1
Fix min/max execution_time
...
fixes #12225
Signed-off-by: Gunnar Beutner <gunnar.beutner@netways.de>
2016-07-26 09:56:21 +02:00
Rune Darrud
730d959374
Set min_latency and min_execution_time to 0 when there have been no checkresults processed
...
fixes #12216
Signed-off-by: Gunnar Beutner <gunnar.beutner@netways.de>
2016-07-26 09:54:08 +02:00
Michael Friedrich
743a726752
state_filters_real shouldn't be visible in the API
...
fixes #12171
2016-07-19 20:09:39 +02:00
Gunnar Beutner
9075de67b1
Fix message routing for command_endpoint checks in satellite zones with >2 instances
...
refs #12179
2016-07-19 18:32:01 +02:00
Michael Friedrich
3d06df96bc
Fix duplicate CheckResult messages for command_endpoint
...
fixes #12179
2016-07-19 17:36:14 +02:00
Michael Friedrich
c73e4d3328
Fix Downtime validation function signature
...
refs #11483
2016-07-05 13:17:18 +02:00
Michael Friedrich
c688a94f8a
API: Add missing downtime_depth attribute
...
fixes #12041
2016-06-25 17:32:12 +02:00
Michael Friedrich
ab4ba18238
Allow strings in Dependency states filter
...
refs #11445
2016-06-24 14:17:24 +02:00
Michael Friedrich
14fdb794e2
Allow strings in state and type filters (config, API)
...
fixes #11445
2016-06-23 14:52:45 +02:00
Gunnar Beutner
e3f1c1ec6f
Make sure timestamps are formatted as integers in macro strings
...
refs #11483
2016-06-21 11:29:12 +02:00
Gunnar Beutner
b5a38f6707
Fix compatibility issue with the $icinga.timet$ macro
...
fixes #11483
2016-06-21 08:23:31 +02:00
Michael Friedrich
b4c56e5f47
Remove duplicate last_check runtime macro
...
Already available as {host,service}.last_check attribute.
refs #11483
2016-06-16 17:39:59 +02:00
Gunnar Beutner
bc6f7d7a21
Fix incorrect formatting for some macro values
...
fixes #11483
2016-06-16 15:14:35 +02:00
Michael Friedrich
cdd858a0ec
Flapping{Start,End} notifications must not depend on state changes
...
fixes #11899
2016-06-15 17:43:37 +02:00
Michael Friedrich
399ae42a8c
DB IDO: Fix comment/downtime entry_time reset
...
fixes #11182
2016-06-15 11:28:57 +02:00
Gunnar Beutner
8a714d66f1
Ensure that sent notifications are synced between Icinga instances
...
fixes #11562
2016-06-15 11:27:01 +02:00
Michael Friedrich
f7f976b962
DB IDO: Ensure that SOFT state changes with the same state are logged
...
fixes #11933
2016-06-14 11:08:28 +02:00
Gunnar Beutner
a8209c1a1a
Change which instance is responsible for initiating notifications in a HA setup
...
refs #9242
2016-06-14 07:57:52 +02:00
Gunnar Beutner
eb4aa4415c
Fix cluster permissions for SendNotifications messages
...
refs #9242
2016-06-13 11:13:25 +02:00
Gunnar Beutner
cb01f96dad
Don't forward SendNotifications messages to non-local zones
...
refs #9242
2016-06-13 10:48:59 +02:00
Markus Frosch
8808e709c9
Make change to OK always a hard state
...
refs #11654
2016-06-13 10:43:57 +02:00
Gunnar Beutner
0eb0992d5e
Fix custom notifications in a HA zone
...
fixes #9242
2016-06-07 12:44:12 +02:00
Gunnar Beutner
aeb7a4a70b
Fix incorrect check interval for SOFT->HARD transitions
...
fixes #11825
2016-05-24 11:05:29 +02:00
Philipp Dallig
54e1c8a9d5
Implement exclude and include ability for TimePeriod objects
...
This feature allows to exclude and include specific time period
objects and their time ranges from an existing time period object.
This comes in handy when e.g. excluding holidays.
fixes #7355
Signed-off-by: Michael Friedrich <michael.friedrich@netways.de>
2016-05-21 20:33:09 +02:00
Michael Friedrich
d49b63d2ab
Fix: First HARD state does not change retry_interval to check_interval
...
refs #11825
2016-05-21 18:58:19 +02:00
Michael Friedrich
3f1a9f150b
Silence compiler warnings
...
refs #11823
2016-05-21 14:16:47 +02:00