39337fbeae
docs: Add `$` to the escape sequences section
...
feat: Add the `$` character to the escape sequences table.
2024-10-21 12:41:32 +02:00
f4e61ef9bd
Merge pull request #10177 from Icinga/log-noop-fix
...
Log: fix some parts of messages not being discarded early
2024-10-21 09:31:19 +02:00
7d0a43f926
Use `Checkable::GetStateBeforeSuppression()` only where relevant
...
This fixes an issue where recovery notifications get lost if they happen
outside of a notification time period.
Not all calls to `Checkable::NotificationReasonApplies()` need
`GetStateBeforeSuppression()` to be checked. In fact, for one caller,
`FireSuppressedNotifications()` in
`lib/notification/notificationcomponent.cpp`, the state before suppression may
not even be initialized properly, so that the default value of OK is used which
can lead to incorrect return values. Note the difference between suppressions
happening on the level of the `Checkable` object level and the `Notification`
object level. Only the first sets the state before suppression in the
`Checkable` object, but so far, also the latter used that value incorrectly.
This commit moves the check of `GetStateBeforeSuppression()` from
`Checkable::NotificationReasonApplies()` to the one place where it's actually
relevant: `Checkable::FireSuppressedNotifications()`. This made the existing
call to `NotificationReasonApplies()` unneccessary as it would always return
true: the `type` argument is computed based on the current check result, so
there's no need to check it against the current check result.
2024-10-11 13:21:10 +02:00
5e9e0bbcdf
Merge pull request #10059 from Icinga/IcingaDB-TimestampToMilliseconds-limit
...
IcingaDB::TimestampToMilliseconds(): limit output to four year digits
2024-10-02 09:19:03 +02:00
dc4869c3aa
IcingaDB::TimestampToMilliseconds(): limit output to four year digits
...
Too high timestamps may overflow uint64_t (and the YYYY format) and negative
ones don't fit into uint64_t. Those may crash our Go daemon.
2024-09-30 16:54:40 +02:00
f0e084d530
Log: fix some parts of messages not being discarded early
...
`m_IsNoOp` was introduced to avoid building up log messages that will later be
discarded, like debug messages if no debug logging is configured. However, it
looks like the template operator<< implemented in the header file was forgotten
when adding this feature, all other places writing into `m_Buffer` already have
an if guard like added by this commit.
2024-09-27 14:23:05 +02:00
2bbeaec916
Fix build on Mac with -DICINGA2_UNITY_BUILD=OFF -DICINGA2_WITH_LIVESTATUS=ON
...
error: no matching function for call to 'intrusive_ptr_release'
...
candidate function not viable: cannot convert argument of incomplete type 'icinga::Notification *' to 'Object *' for 1st argument
void intrusive_ptr_release(Object *object);
2024-09-27 12:41:11 +02:00
b6b1506bda
Merge pull request #10140 from Icinga/drop-cpu-bound-work-usage-from-ifwapi
...
Don't use thread-local var in coroutine & drop superfluous `CpuBoundWork` usage
2024-09-27 11:31:58 +02:00
92df9ef8c3
Merge pull request #10148 from Icinga/enhanced-sort-types-by-load-dependencies
...
Sort config types by their load dependencies once
2024-09-26 15:27:41 +02:00
0fff4153ef
Merge pull request #10174 from open-i-gmbh/fix/influxdbwriter-validator-add-closing-quotation-marks
...
Add closing quotationmarks in Validator for influxdb writer config
2024-09-26 11:46:11 +02:00
90c76ad89c
Update Authors
2024-09-26 10:04:02 +02:00
8c68c6e9d8
Add closing quotationmarks in Validator for influxdb writer config
2024-09-25 13:03:00 +02:00
01d3a1d382
Merge pull request #10170 from Icinga/OpenSSL3015
...
Bump OpenSSL shipped for Windows to v3.0.15
2024-09-24 12:43:56 +02:00
7216220de1
Bump OpenSSL shipped for Windows to v3.0.15
2024-09-20 17:39:26 +02:00
eb97676d69
Add basic test cases for `Type::GetConfigTypesSortedByLoadDependencies()`
2024-09-20 16:18:12 +02:00
467e8b18e7
Type: Simplify sort by load dependencies algorithm
2024-09-20 16:18:12 +02:00
31f3acaa13
ConfigItem::CommitNewItems(): pre-sort types by their load dependencies once
...
to avoid complicated nested loops, iterating over the same types and
checking dependencies over and over, skipping already completed ones.
2024-09-20 16:18:12 +02:00
b848934d57
Introduce Type::GetConfigTypesSortedByLoadDependencies()
2024-09-20 16:18:12 +02:00
4f690a6fde
Merge pull request #10169 from Icinga/Type-GetLoadDependencies-ConfigObject
...
Type#GetLoadDependencies(): VERIFY() that only config object types are returned
2024-09-20 16:11:17 +02:00
b6517c6973
Type#GetLoadDependencies(): VERIFY() that only config object types are returned
2024-09-20 14:35:19 +02:00
4b20121dcf
Type#GetLoadDependencies(): group operations by type
2024-09-20 14:35:19 +02:00
dac747f9d4
Merge pull request #10155 from Icinga/Type-GetLoadDependencies-nullptr
...
Type#GetLoadDependencies(): VERIFY() that no nullptr is returned
2024-09-20 12:29:48 +02:00
c24713ac10
Type#GetLoadDependencies(): VERIFY() that no nullptr is returned
2024-09-19 16:43:00 +02:00
36742c27b9
Don't override Type#GetLoadDependencies() if latter is sufficient
...
If a specific type shall return no deps, the base method already does that.
2024-09-19 15:47:25 +02:00
e678f0977d
Merge pull request #10151 from Icinga/bugfix/do-not-sync-partially-initialised-objects
...
IcingaDB: Don't sync partially initialised objects
2024-09-18 15:48:42 +02:00
3ffec77ae5
Merge pull request #10135 from Icinga/centos
...
doc/: don't mention CentOS
2024-09-18 10:22:09 +02:00
7b12a8feeb
Merge pull request #10156 from Icinga/Al2Klimov-patch-7
...
Linux Dev Environment: fix /usr/local/icinga2/etc ownership
2024-09-16 17:51:34 +02:00
6da948c830
doc/: don't mention CentOS
...
It's EOL.
2024-09-16 17:08:42 +02:00
f3ed85171e
Linux Dev Environment: fix /usr/local/icinga2/etc ownership
...
We instruct the users to build as root and chown just /usr/local/icinga2/var, but at least `icinga2 api setup` also needs to modify /usr/local/icinga2/etc.
2024-09-16 16:13:02 +02:00
0b8f70bbba
Merge pull request #10152 from Josef-Friedrich/remove-trailing-whitespaces
...
Remove trailing whitespaces in the markdown files of the documentation
2024-09-13 10:06:45 +02:00
b62326d30c
Merge pull request #10153 from Josef-Friedrich/typo-api-docs
...
Fix typo in the api documentation
2024-09-12 10:37:06 +02:00
1cd515ef8a
Fix typo in the api documentation
2024-09-12 08:46:27 +02:00
1f31f725f8
Remove trailing whitespaces in the markdown files of the documentation
2024-09-12 08:39:15 +02:00
26f43b0b48
IcingaDB: Don't sync partially initialised objects
2024-09-11 14:08:27 +02:00
8beb0b74ab
Merge pull request #10149 from Icinga/fix-format-datetime-tests-on-darwin
...
tests: Fix test `FormatDateTime` with invalid formats on macOS/*BSD
2024-09-10 18:48:26 +02:00
b8932e67fc
tests: Fix test `FormatDateTime` with invalid formats on macOS/*BSD
2024-09-10 17:11:20 +02:00
c0b047b1aa
Merge pull request #10035 from Icinga/check_systemd_name_fix
...
check_systemd: Fix executable name and include latest arguments
2024-09-06 11:57:33 +02:00
e7670e9ba9
check_systemd: harmonize ITL w/ upstream
...
Harmonize the arguments with the upstream CheckCommand[0], including a
patch to use the ITL variables[1].
[0]: https://github.com/Josef-Friedrich/check_systemd/blob/main/contrib/icinga2/command.conf
[1]: https://github.com/Josef-Friedrich/check_systemd/pull/38
Co-Authored-By: RincewindsHat <12514511+RincewindsHat@users.noreply.github.com>
2024-09-06 10:21:30 +02:00
74009f0fcb
Don't use thread-local variable in coroutine & process final `cr` in global thread pool
2024-09-05 17:36:03 +02:00
c9159494c0
HttpServerConnection: Drop yet another superfluous `CpuBoundWork` usage
2024-09-05 15:10:14 +02:00
5cc034b38f
Merge pull request #10147 from Icinga/Al2Klimov-patch-7
...
Utility::ReleaseHelper(): remove detection of EOL distros
2024-09-05 09:27:51 +02:00
79e3cb2a95
Utility::ReleaseHelper(): remove detection of EOL distros
...
We only support /etc/os-release owners.
2024-09-04 10:26:50 +02:00
0951230ce1
Merge pull request #9991 from Icinga/JsonRpcConnection-9985
...
JsonRpcConnection#Send*(): discard messages ASAP once shutting down
2024-09-03 15:13:30 +02:00
4c6b93d617
Merge pull request #10011 from Icinga/next-check-cluster-sync-issue
...
Checkable: Don't recalculate `next_check` for remotely generated `cr`
2024-08-30 13:37:41 +02:00
ba200f74e1
Add check_curl to ITL ( #9205 )
...
* Add check_curl to ITL
* small fixes and boolean defaults
* Add documentation for check_curl
* Replace dash with underscore in variables
* Add link to documentation
* Change order of argument attributes to adhere to style guide
* Shorten description of tls option in itl
* Just remove information for check_curl options
* itl - check_curl: document -4 and -6
* itl - check_curl: Add haproxy option for check_curl
* itl - check_curl: add cookie-jar option
* itl - check_curl: add continue_after_certificate option
* itl - check_curl: replace dashes with underscores in macros
* Update itl/command-plugins.conf
Co-authored-by: alvar <8402811+oxzi@users.noreply.github.com>
* Update itl/command-plugins.conf
Co-authored-by: alvar <8402811+oxzi@users.noreply.github.com>
* itl - check_curl: add missing option documentation and reorder options
* itl - check_curl: Split certificate lifetime in two parameters
* itl - check_curl: replace remaining instances of single parameter for remaining valid time
* check_curl: allow assignements for host without address set
* check_curl: fix typo expext -> expect
* itl - check_curl: add state-regex option and documentation
* Add Tls options with version and without
* itl - check_curl: fix indentation
* itl - check_curl: Set v4/v6 variables
* itl - check_curl: Edit description for --sni
* doc - check_curl: fix singular-plural typo for curl_max_redir(s)
* doc/check_curl: sni description
* itl - check_curl: remove superfluous brace
* itl - check_curl: add extra-opts parameter
---------
Co-authored-by: alvar <8402811+oxzi@users.noreply.github.com>
2024-08-30 10:25:27 +00:00
73d3e5b1c7
Merge pull request #10136 from Icinga/icinga-archive-keyring
...
.deb: let user install icinga-archive-keyring package
2024-08-29 17:36:20 +02:00
9f84c1516e
ApiListener: Reorder logging in `ApiTimerHandler()`
2024-08-28 16:53:53 +02:00
e062ceb901
ApiListener: Catch & supress clients runtime errors
2024-08-28 16:53:53 +02:00
894d6aa290
Merge pull request #9974 from tbauriedel/fix/itl-http-definition
...
Fix ITL for http CheckCommand definition
2024-08-27 15:45:00 +02:00
88e79ea41a
Merge pull request #10111 from Icinga/unregister-invalid-objects-properly
...
Unregister invalid config objects properly
2024-08-27 14:30:38 +02:00
Yonas Habteab
Julian Brost
Alexander A. Klimov
Sebastian Grund
Josef Friedrich
Alvar Penning
Lorenz Kästle