tyler.durden
/
icinga2
mirror of https://github.com/Icinga/icinga2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
7,493 Commits 347 Branches 117 Tags 199 MiB
Commit Graph

1075 Commits

Author SHA1 Message Date
Jean Flach 360e0ad548 Fix external commands comments crashing icinga 
Now an exception will be thrown when AddSvcComment or AddHostComment are
run with and empty Author or comment

fixes #11112
 2016-04-25 16:58:00 +02:00
Michael Friedrich 7442cd94f5 Fix crash with empty ScheduledDowntime 'ranges' attribute 
fixes #11158
 2016-04-22 11:00:21 +02:00
Gunnar Beutner c6a015e317 Fix crash in Checkable::ExecuteCheck 
fixes #11582
 2016-04-19 09:37:04 +02:00
Gunnar Beutner 974ca9f38b Fix crash in Downtime::DowntimesExpireTimerHandler 
fixes #11534
fixes #11559
 2016-04-12 12:05:43 +02:00
Michael Friedrich 2b2e250def Implement support for overriding check command timeout 
fixes #9283
 2016-04-07 15:07:17 +02:00
Michael Friedrich 83e0bcddce IDO: Ensure that the notification insert id is passed to contactnotification inserts 
We cannot add the notification insert id directly
to the following contactnotifications queries. Instead
we need to pass a DbValue reference which gets set after
the notification insert id is calculated.
The contactnotifications insert queries are fired as query
group calling CanExecuteQuery() and FieldToEscapedString().
If the notification id does not exist yet, the queries are
moved to the end of the queue.
Once the contactnotifications queries are fired the DbValue
reference is destroyed.

This patch also removes the old notification insert id cache
which was broken in many ways.

fixes #11387
 2016-03-29 15:12:24 +02:00
Michael Friedrich 12dadfdfb3 Fix: Downtimes/Comments not being synced to child zones 
fixes #11227
 2016-03-29 12:09:51 +02:00
Gunnar Beutner 5de9a988d9 Improve validation for arrays 
fixes #11434
 2016-03-24 09:15:39 +01:00
Michael Friedrich 0447e81d99 Ensure that the legacy_id attribute for comment/downtime objects is restored on restart 
This has been changed when moving comments/downtimes to config objects
in 050c520b2a

It may cause trouble with DB IDO DELETE and UPDATE statements
depending on the old value.

refs #11382
 2016-03-23 14:05:09 +01:00
Michael Friedrich a30cb86ca1 Only call UpdateNextCheck() for soft states 
refs #11336
 2016-03-15 14:02:19 +01:00
Michael Friedrich d682f56c38 Use UpdateNextCheck() for determining the retry_interval in ProcessCheckResult() 
This patch also moves the next check updates for passive
check results into ProcessCheckResult(). That way the
next check status updates for DB IDO work in a sane way
again.

refs #11336
 2016-03-15 13:02:38 +01:00
Michael Friedrich 3bd6848763 Refactor patch for host recovery notifications 
refs #10225
 2016-03-15 09:47:59 +01:00
Gunnar Beutner a8ee6b2009 Fix crash in ScheduledDowntime::TimerProc 
fixes #11352
 2016-03-14 08:37:13 +01:00
Michael Friedrich 3e050bd0cd Fix: Volatile transitions from HARD NOT-OK->NOT-OK do not trigger notifications 
fixes #11320
 2016-03-11 13:19:03 +01:00
Michael Friedrich 7fb8bcd933 Use retry_interval on first OK -> NOT-OK state change 
Only valid for active check results. The API actions were
missing that marker similar to the external command processor.

The initial OK -> NOT-OK transition should use the retry_interval
but nothing else.

fixes #11336
 2016-03-11 12:00:30 +01:00
Michael Friedrich 5b6a6f86b1 Fix host recovery notifications for warning states 
fixes  #10225
 2016-03-11 09:29:07 +01:00
Julian Brost 7439633965 Fix max number of args for DEL_DOWNTIME_BY_HOST_NAME 
The RegisterCommand call for DEL_DOWNTIME_BY_HOST_NAME was missing the
max args parameter. This prevented the optional service name, start time
and comment arguments to be passed.

Signed-off-by: Michael Friedrich <michael.friedrich@netways.de>

fixes #11240
 2016-03-05 18:43:02 +01:00
Michael Friedrich ef532f20eb Revert "Fix check scheduling w/ retry_interval" 
This reverts commit a51e647cc7.

This patch causes trouble with check results received
1) passively 2) throughout the cluster. A proper patch
for setting the retry_interval on NOT-OK state changes
is required.

refs #11248
refs #11257
refs #11273

(the old issue)
refs #7287
 2016-03-05 18:16:49 +01:00
Michael Friedrich b8e3d61820 Revert "Properly set the next check time for active and passive checks" 
This reverts commit 2a11b27972.

This patch does not properly work and breaks the check_interval setting
for passive checks. Requires a proper patch.

refs #11248
refs #11257
refs #11273

(the old issue)
refs #7287
 2016-03-05 18:15:03 +01:00
Vytenis Darulis 6729679f38 Try to queue all PROCESS_FILE commands instead of exploding the stack 
fixes #10426

Signed-off-by: Michael Friedrich <michael.friedrich@netways.de>
 2016-02-24 23:25:22 +01:00
Michael Friedrich 894aaaecb1 Ensure that config files are readable by the daemon 
refs #11212
refs #11211
 2016-02-24 14:24:08 +01:00
Michael Friedrich 47c5425137 Fix permissions for temporary files 
fixes #11212
fixes #11211
 2016-02-24 11:00:44 +01:00
Sebastian Chrostek 83845e609e Fix problem notifications while flapping is active 
fixes #9969
fixes #9642
 2016-02-23 16:27:22 +01:00
Michael Friedrich 4cb5b97e52 Fix unique creation of temp files 
fixes #10948
 2016-02-23 12:30:59 +01:00
Adam James e04b70856b Fix parsing of YYYY-MM-DD in LegacyTimePeriod::ParseTimeSpec 
fixes #11132

Signed-off-by: Jean Flach <jean-marcel.flach@netways.de>
 2016-02-10 16:24:36 +01:00
Jean Flach 8dbd84daed Remove unused variable 2016-02-08 16:40:34 +01:00
Jean Flach 964cfcebd3 Make schedule-downtime default fixed 
fixes #10923
 2016-02-08 16:04:41 +01:00
Gunnar Beutner e224e74994 Make sure the "syncing" attribute is set to false 
refs #11083
 2016-02-08 13:15:24 +01:00
Gunnar Beutner 6d5014b610 Increase grace period for agent-based checks 
refs #11020
 2016-02-08 09:46:01 +01:00
Michael Friedrich 7a3848af1e Remove debug output 
refs #11014
 2016-01-29 14:03:58 +01:00
Michael Friedrich b960850ce3 DB IDO: Only update 'next_check' column when manually scheduling a check 
Otherwise the changes from #7287 already take care of setting
the proper next check time from inside ProcessCheckResult().

There is no need to use the generic OnNextCheckChanged signal
but instead we're using a new one, locally just for DB IDO.

fixes #11019
 2016-01-22 18:42:15 +01:00
Michael Friedrich 2a11b27972 Properly set the next check time for active and passive checks 
fixes #7287
refs #11019
 2016-01-22 18:40:14 +01:00
Michael Friedrich 730db0cba1 Fix: Modified attributes do not work for the IcingaApplication object w/ external commands 
fixes #10974
 2016-01-21 19:07:54 +01:00
Gunnar Beutner 6ca054e618 Ensure that checks are not scheduled for command_endpoint fake hosts 
refs #10963
 2016-01-21 16:37:52 +01:00
Gunnar Beutner 72c3b6d75b Make sure we're not running command_endpoint-based checks more than once 
refs #10963
 2016-01-21 10:37:47 +01:00
Michael Friedrich a51e647cc7 Fix check scheduling w/ retry_interval 
fixes #7287
 2016-01-20 16:29:01 +01:00
Michael Friedrich d9fac2b613 Raise a config error for "Checkable" objects in global zones 
fixes #10807
 2016-01-14 15:34:38 +01:00
Gunnar Beutner 599929b0f6 Update copyright headers for 2016 2016-01-12 08:29:59 +01:00
Michael Friedrich 737c574cdf Fix missing num_hosts_pending in /v1/status/CIB 
fixes #10736
 2015-11-26 20:03:46 +01:00
Michael Friedrich 9289971829 Remove IcingaStatusWriter feature 
fixes #10140
 2015-11-26 19:30:40 +01:00
Michael Friedrich 6518f78af0 Fix attribute validation for PUT queries 
fixes #10601
 2015-11-12 10:13:46 +01:00
Gunnar Beutner e3c75faabc Implement support for recursive object locks 
fixes #10596
 2015-11-11 10:21:30 +01:00
Michael Friedrich f5da37b7df Remove obsolete checks from API actions 
refs #10561
 2015-11-10 16:13:14 +01:00
Gunnar Beutner 2cc33b7fb3 Don't validate arguments/parameters that aren't strings 
refs #10539
 2015-11-10 07:59:10 +01:00
Michael Friedrich 1d2606cbfe Add filter targets for remove-{comment,downtime} actions 
Drop remove-all-{comments,downtimes}. This is provided
by using host and service filters.

fixes #10561
 2015-11-08 14:22:10 +01:00
Michael Friedrich 64c936d387 API Actions: Remove -by-id from actions and require names for comments and downtimes 
The documentation is updated as well. Furthermore actions provide
detailed error information in case of an exception.
Includes DB IDO schema updates.

fixes #10512
 2015-11-06 17:06:12 +01:00
Gunnar Beutner 09b2b054f5 Don't validate custom attributes that aren't strings 
fixes #10539
 2015-11-04 19:04:33 +01:00
Michael Friedrich 7589c61b38 Add missing override 
refs #10508
refs #10509
 2015-11-02 17:36:13 +01:00
Michael Friedrich 43976d3989 Add host.last_state_{up,down} and last_check attribute, hide *_raw attributes 
fixes #10508
fixes #10509
 2015-11-02 14:10:44 +01:00
Michael Friedrich 439dad5d6a API actions: Check if removal of comments and downtimes was succesful 
refs #9080
 2015-11-01 16:33:43 +01:00
Gunnar Beutner 15addb4e7c Use the correct zone name for parent_zone when running 'icinga2 node update-config' 
fixes #10479
 2015-10-29 08:14:55 +01:00
Gunnar Beutner 0013d26425 Build fix for Windows 
refs #9777
 2015-10-29 08:14:55 +01:00
Gunnar Beutner 050c520b2a Convert Comment/Downtime to config objects 
fixes #9777
 2015-10-28 17:56:29 +01:00
Jean Flach 2fc042e231 Update API actions and documentation 
refs #9080 #9105
 2015-10-27 14:15:07 +01:00
Gunnar Beutner dd77863910 Implement Array::ToString and Dictionary::ToString 
fixes #10329
 2015-10-26 11:05:24 +01:00
Jean Flach be320b2f77 Update API actions 
fixes #10180
refs #9080
 2015-10-22 11:33:26 +02:00
Gunnar Beutner 4aa0165701 Add getter for endpoint 'connected' attribute 
fixes #10394
 2015-10-22 10:52:38 +02:00
Gunnar Beutner 3473731034 Remove api.cpp and api.hpp 
fixes #10407
 2015-10-22 10:26:56 +02:00
Gunnar Beutner fd5d6de52e Improve performance for Livestatus queries 
refs #10428
 2015-10-22 08:28:40 +02:00
Michael Friedrich 62c3607531 Fix compiler warnings 
refs #9078
 2015-10-21 15:50:32 +02:00
Michael Friedrich 286538c17e Implement api event streams 
Documentation is not yet complete.

refs #9078
 2015-10-21 15:34:26 +02:00
Gunnar Beutner d01f09f3ef Hide internal attributes in the API 
fixes #10393
 2015-10-20 08:25:10 +02:00
Michael Friedrich 6cc4f85c66 Disallow modify attribute for certain object attributes 
fixes #9095
 2015-10-16 12:44:08 +02:00
Gunnar Beutner e92b7beeb4 Fix parsing performance data labels which contain '=' 
fixes #10254
 2015-10-13 09:38:31 +02:00
Gunnar Beutner 8136cda367 Implement the ignore_on_error keyword 
fixes #9960
 2015-10-05 12:44:11 +02:00
Michael Friedrich 00712f1902 Use a temporary file for modified-attributes.conf updates 
fixes #10238
 2015-09-29 18:40:04 +02:00
Michael Friedrich 487ef513cf Remove dead code from old mod attrs in the cluster 
refs #9851
 2015-09-29 14:24:39 +02:00
Michael Friedrich 1813c0932c Remove dead code from old modified attributes 
refs #9851
 2015-09-29 14:24:39 +02:00
Gunnar Beutner 0c10d64094 Fix incorrect error messages for apply-for 
fixes #10205
 2015-09-24 08:30:03 +02:00
Jean-Marcel Flach 4ef9761fee Implement status api handler 
Global statistics, features, etc.

fixes #10116
 2015-09-23 16:59:07 +02:00
Michael Friedrich 84536da221 Implement global modified attributes for the IcingaApplication class 
fixes #9859
 2015-09-23 15:02:53 +02:00
Gunnar Beutner 1a6b41787a Implement joins for status queries 
fixes #10060
 2015-09-22 09:45:23 +02:00
Gunnar Beutner 6fa58a520c Implement config object sync 
Adds object version.

refs #9927
 2015-09-17 14:20:43 +02:00
Michael Friedrich fcf2f0ef5d Deprecate IcingaStatusWriter feature 
fixes #8741
 2015-09-14 10:36:06 +02:00
Michael Friedrich 3403765900 Use the command_endpoint name as check_source value if defined 
fixes #9218
 2015-09-05 15:18:10 +02:00
Michael Friedrich 50cd694142 Fix wrong calculation for host compat state UNREACHABLE 
fixes #10058
 2015-09-04 13:24:41 +02:00
Michael Friedrich da83bae660 Rename config/modules to config/packages 
fixes #9953
 2015-09-01 20:09:04 +02:00
Jean Flach f1a1dfb26e Update use of String::Trim() 
fixes #9704
 2015-08-27 18:06:20 +02:00
Gunnar Beutner 63a1ff77c3 Implement the resolve_arguments function 
fixes #10006
 2015-08-27 09:02:21 +02:00
Gunnar Beutner 6ef9d3c4db Missing macros in nested macro() calls should not cause the outer macro resolution to fail 
fixes #10003
 2015-08-27 09:02:21 +02:00
Jean Flach 01ced1549a Implement all actions except modified attributes 
refs #9080 #9979
 2015-08-26 13:53:17 +02:00
Gunnar Beutner f45f6ccd82 Implement support for tracking dependencies between config objects 
refs #9096
 2015-08-25 13:54:05 +02:00
Michael Friedrich 981ed591e9 API: Return comment/downtime ids, refactor code 
refs #9080
 2015-08-21 12:49:51 +02:00
Jean Flach c5fe46a300 Experimental actions without types 
refs #9080
 2015-08-21 12:48:32 +02:00
Jean Flach afd6af39d5 Implement external commands as api actions 
refs #9080
 2015-08-21 12:48:32 +02:00
Gunnar Beutner d118b71a2a Fix compiler warnings 
fixes #9929
 2015-08-18 07:46:04 +02:00
Gunnar Beutner 7fc7cde6a1 Build fix for Windows 2015-08-17 19:36:27 +02:00
Michael Friedrich 0f5287c2b1 Add module attribute for ConfigObject and set its origin 
fixes #9852
 2015-08-17 16:08:57 +02:00
Gunnar Beutner 071d2f18fb Rename DynamicObject/DynamicType to ConfigObject/ConfigType 
fixes #9914
 2015-08-15 20:40:41 +02:00
Gunnar Beutner ce2735f10b Fix validation errors when creating objects with the API 
refs #9101
 2015-08-15 20:07:11 +02:00
Gunnar Beutner e2290d5012 Implement support for unregistering objects 
refs #9101
 2015-08-15 20:07:11 +02:00
Gunnar Beutner 3d78870339 Implement support for modified attributes in the API 
refs #9081
 2015-08-15 20:07:11 +02:00
Gunnar Beutner a092c13ace Implement support for persisting modified attributes 
fixes #9093
 2015-08-15 20:07:10 +02:00
Michael Friedrich d7970f5bb1 Implement modified attributes v2 
refs #9081
refs #9093
 2015-08-15 20:07:10 +02:00
Jean Flach 60f86d01fe Implement /v1/actions/process-check-result 
Requires error handling.

refs #9080
 2015-07-31 17:18:49 +02:00
Michael Friedrich 0712a02d1b Add a warning if EventCommand is not found when using command_endpoint 
fixes #9773
 2015-07-31 16:04:03 +02:00
Michael Friedrich 766e2d73f4 Implement external command DEL_DOWNTIME_BY_HOST_NAME 
Required by Classic UI 1.x, this will hopefully reduce
the noise on non-working commands with the old legacy stuff.

fixes #8979
 2015-07-31 14:50:17 +02:00
Jean-Marcel Flach 9b6ebbc69b Implement basic actions framework 
refs #9080
 2015-07-30 17:50:17 +02:00
Gunnar Beutner a97782b3e5 Implement support for limiting output attributes 
refs #9077
fixes #9614
 2015-07-28 17:12:51 +02:00
Gunnar Beutner 8dedd47b89 Fix incorrect return value for the macro() function 
fixes #9584
 2015-07-13 08:25:19 +02:00