3831 Commits

Author SHA1 Message Date
Gunnar Beutner
492b590a29 Remove debug output in ApiUserCommand::Run 2018-02-23 13:07:56 +01:00
Gunnar Beutner
ed1dd36f09 Properly escape strings in ApiUserCommand::Run 2018-02-23 13:07:56 +01:00
Jean Flach
aad44dfbb2 Improve api user command
--oneline can now be used to print out only the password hash string.
This can be used to update ApiUser passwords through the API. There is
also now a validation to make use salt does not contain a '$' which
would break verification.
2018-02-23 13:07:56 +01:00
Jean Flach
2e5aedd28a Fix crash when using incorrectly formatted password hash 2018-02-23 13:07:55 +01:00
Jean Flach
6387f5442e Move new password functions into tlsutility 2018-02-23 13:06:22 +01:00
Jean Flach
6504606e23 Hash API password and comparison
fixes #4920
2018-02-23 11:23:19 +01:00
Jean Flach
adc054097d Build/Merge fixes 2018-02-23 10:27:55 +01:00
Jean Flach
c5b92defec Minor codestyle and doc changes 2018-02-23 10:09:28 +01:00
Noah Hilverling
4b77afedcd Limit HTTP body size 2018-02-23 10:09:28 +01:00
Noah Hilverling
3fe818b44b Fix requests not being closed correctly 2018-02-23 10:09:28 +01:00
Jean Flach
70c81734c5 Add timeout for TLS handshakes 2018-02-23 10:09:26 +01:00
Jean Flach
aa1ccd7ada Authenticate API user before parsing body 2018-02-23 10:08:24 +01:00
Jean Flach
a46dc64e6a Only read body from authenticated connections
This means we are not allowing unauthenticated requests anymore
2018-02-23 09:52:54 +01:00
Jean Flach
e1c46cedd1 Fix nullptr deref 2018-02-23 08:34:10 +01:00
Gunnar Beutner
f5f8b90ec8 Add HTTP Header size limits 2018-02-23 08:31:28 +01:00
Gunnar Beutner
0339a2b827 Add validation for HTTP connection sizes 2018-02-23 08:31:28 +01:00
Jean Flach
9de36c0999 Rename macro RequireNotNull to REQUIRE_NOT_NULL 2018-02-22 15:07:36 +01:00
Noah Hilverling
71c420d501 Fix nullptr deref in cluster events 2018-02-22 14:55:44 +01:00
Noah Hilverling
3ba5090867 Add marco RequireNotNull
This is used to fix a number of possible nullptr dereferences
2018-02-22 14:55:42 +01:00
Gunnar Beutner
5dab779df6 Fix incorrect ::Start call 2018-01-24 12:04:53 +01:00
Noah Hilverling
6dba6a0bfb Add missing string escaping
fixes #5987
2018-01-17 15:02:33 +01:00
Noah Hilverling
157358c24f Fix HTTP response parsing for HTTP 1.1
refs #5987
2018-01-17 15:02:33 +01:00
Gunnar Beutner
7f92016e38 Fix performance issues for InfluxdbWriter 2018-01-17 15:02:33 +01:00
Gunnar Beutner
680939a289 Fix incorrect socket handling for the HTTP client 2018-01-17 15:02:33 +01:00
Michael Friedrich
b4a0495239 Revert "Fix performance issues for InfluxdbWriter"
This reverts commit eea451ee94be7310e63ab6b7e5e94924b295e974.

refs #5764
2018-01-16 10:45:20 +01:00
Michael Friedrich
c3fe1a6323 Revert "Fix incorrect socket handling for the HTTP client"
This reverts commit 59da943548c7c1be5f4b27dce73a0ad27cf0de5d.

refs #5760
2018-01-16 10:44:31 +01:00
Michael Friedrich
2901c77d65 Fix wrong schema constraint for fresh 2.8.0 installations
This fix is only needed for a fresh 2.8.0 setup, older versions
and upgrades to current do not need this (can be applied as idempotent
update).

fixes #5947

refs #5986
2018-01-16 10:15:38 +01:00
Michael Friedrich
1256fb3356 Revert "Fix newline terminator for bulk requests in ElasticsearchWriter"
This reverts commit 806eb0d2d2b077a9a4bac073bfbb27c2af369008.

refs #5840
2017-12-22 09:53:56 +01:00
Gunnar Beutner
59da943548 Fix incorrect socket handling for the HTTP client 2017-12-12 11:18:09 +01:00
Gunnar Beutner
eea451ee94 Fix performance issues for InfluxdbWriter 2017-12-12 10:36:45 +01:00
Michael Friedrich
806eb0d2d2 Fix newline terminator for bulk requests in ElasticsearchWriter
This enables compatibility with 6.x.

This commit also fixes an incorrect HTTP response parsing
which could lead into false positives.

Analysis and fix in https://github.com/Icinga/icinga2/issues/5795#issuecomment-349920587

fixes #5795

refs #5840
2017-12-07 17:07:44 +01:00
Sven Nierlein
9ba5f30afa livestatus: custom variables return empty arrays instead of strings
livestatus queries for custom variables should return an empty list, ex: []
instead of an empty string if there are no variables.

Signed-off-by: Sven Nierlein <sven@nierlein.de>

refs #5746
2017-12-07 13:29:11 +01:00
Paolo Schiro
3a7c54c3d1 add a bogus zero reply in livestatus if aggregate filter does not match, fix I#5626
refs #5716
2017-12-07 13:28:16 +01:00
Michael Friedrich
5b231147fe Silence UpdateRepository message errors
Mixed setups with 2.8 and 2.7 will log this error every time
a new message is received. While this is truly an error,
it just fills the log to infinity. Should be used for debug only.

fixes #5776

refs #5804
2017-11-28 11:27:39 +01:00
Gunnar Beutner
a18fbcb27a Fix missing variable name which can lead to segfaults
refs #5808
refs #5807

Signed-off-by: Michael Friedrich <michael.friedrich@icinga.com>
2017-11-28 11:14:32 +01:00
Michael Friedrich
35f0df3fe5 Disable Flapping detection on Windows 2017-11-17 12:59:07 +01:00
Michael Friedrich
7c0a09cfb6 Rename ElasticWriter to ElasticsearchWriter
This better reflects its purpose as otherwise it would imply
that you need Elastic Stack for it. Graylog also reads from
Elasticsearch instances, this could serve as additional integration
here.
2017-11-09 15:33:10 +01:00
Jean Flach
f4a1747e14
Merge pull request #5732 from Icinga/fix/flapping
Fix flapping calculation and events

fixes #5720
2017-11-08 15:10:55 +01:00
Michael Friedrich
41d54029c8 Fix log messages for flapping 2017-11-08 12:12:27 +01:00
Michael Friedrich
42b1e7ce79 Use the entry_time for icinga_comments updates
This follows all other queries in their where condition
using entry_time for comments/downtimes.
2017-11-07 16:37:12 +01:00
Michael Friedrich
e0e7f9ae6b DB IDO: Force users to upgrade the schema to avoid workaround fixes/missing indexes 2017-11-07 16:37:12 +01:00
Jean Flach
e83ddbd8b2 Remove unnecessary keys from where clauses 2017-11-07 16:37:12 +01:00
Eric Lippmann
6f6703042e ido: Drop unused instance_id indices from comments, downtimes and their related history tables 2017-11-07 16:37:12 +01:00
Jean Flach
1632415370 Fix commenthistory
refs #5492
2017-11-07 16:37:12 +01:00
Jean Flach
30be02bcae Alter DowntimeRemoval behaviour
This adds an additional index to the downtimehistory and updates the
dbevents in a way that it uses that index
2017-11-07 16:37:12 +01:00
Jean Flach
872d4895f0 Fix flapping endianness and events
fixes #5720
2017-11-07 11:13:17 +01:00
Michael Friedrich
260c6d7438 Node setup: ticket parameter is now optional
refs #5681
2017-11-03 14:10:45 +01:00
Michael
86cdc5bc53 Include default global zones during node wizard/setup
This changes the GenerateNodeMasterIcingaConfig and GenerateNodeIcingaConfig
functions inside the nodeutillity class to the effect, that the default global
zones global-templates and director-global will be written to the generated
zones.conf that is created during the node wizard/setup.

refs #5707

Signed-off-by: Michael Friedrich <michael.friedrich@icinga.com>
2017-10-31 12:07:12 +01:00
Jean Flach
9ba5b4f4b7 Merge pull request #5693 from Icinga/fix/flapping-old-4982
Re-implement flapping

fixes #4982
2017-10-24 16:58:59 +02:00
Jean Flach
a21ffd6fe4 Fix flapping
Re-implement flapping following the 'old way' of just observing the last
20 stage changes.

refs #4982
2017-10-24 15:54:05 +02:00