tyler.durden
/
icinga2
mirror of https://github.com/Icinga/icinga2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
9,393 Commits 347 Branches 117 Tags 197 MiB
Commit Graph

4101 Commits

Author SHA1 Message Date
Gunnar Beutner ac155d1dda Apply clang-tidy fix 'modernize-redundant-void-arg' 2018-01-04 12:24:57 +01:00
Gunnar Beutner 41f0fbfd30 Add the final keyword to methods 2018-01-04 05:45:40 +00:00
Gunnar Beutner efe99a3e5e Add the final keyword to classes 2018-01-04 05:20:20 +00:00
Gunnar Beutner 6a1ac6a902 Fix incorrect ::Start call 2018-01-03 18:57:01 +01:00
Michael Friedrich cd33b8b508
Merge pull request #5936 from Icinga/feature/source-lists 
Clean up source lists in the CMakeLists.txt files
 2018-01-03 11:59:35 +01:00
Gunnar Beutner 75e2473616 Clean up source lists in the CMakeLists.txt files 2018-01-03 11:47:46 +01:00
Michael Friedrich 0e6f4b1966
Merge pull request #5939 from Icinga/fix/build-fix-wheezy 
Build fix for Debian wheezy
 2018-01-03 11:28:57 +01:00
Gunnar Beutner fe8572d75b Remove inline methods and use explicit template instantiation to minimize the number of weak symbols 2018-01-03 11:04:58 +01:00
Michael Friedrich 27a2d95338
Merge pull request #5932 from Icinga/feature/copyright-header 
Fix copyright header in cli/troubleshootcommand.hpp
 2018-01-03 10:56:07 +01:00
Gunnar Beutner abe3f8a959 Build fix for Debian wheezy 2018-01-03 10:32:33 +01:00
Gunnar Beutner 803dc0c05d Fix copyright header in cli/troubleshootcommand.hpp 2018-01-03 01:19:02 +01:00
Gunnar Beutner 2f953d6204 Implement shim for libmysqlclient and libpq 2018-01-02 23:29:48 +01:00
Gunnar Beutner 90496b5456 Build libraries as static libraries 2018-01-02 23:29:48 +01:00
Michael Friedrich f843f92ee3
Merge pull request #5928 from Icinga/fix/build-fix-msvc 
Fix build problem with MSVC
 2018-01-02 14:01:15 +01:00
Michael Friedrich 1a7e7be6a4
Merge pull request #5925 from Icinga/fix/missing-variable-name 
Fix missing variable name in ApiListener::Start
 2018-01-02 13:48:30 +01:00
Michael Friedrich e08da4267b
Merge pull request #5930 from Icinga/feature/boost-function 
Replace boost::function with std::function
 2018-01-02 13:46:23 +01:00
Michael Insel 158ae2188e Change copyright header for 2018 2018-01-02 12:08:55 +01:00
Gunnar Beutner dac71b3960 Replace boost::function with std::function 2018-01-02 08:55:50 +01:00
Gunnar Beutner 6737a0fa8f Make MSVC happy 2018-01-01 09:24:28 +01:00
Gunnar Beutner 4ed19d5cf6 Fix missing variable name in ApiListener::Start 
fixes #5924
refs #5807
 2017-12-31 19:12:33 +01:00
Michael Friedrich 8bdd16bb42 Do not replace colons in plugin output 
This affects all interfaces which are using the CompatUtility class
format helpers for short and long output.

fixes #4785
 2017-12-21 09:49:34 +01:00
Jean Flach 2636e6a77a Whitespace fix 
What does this change?
* Remove use of spaces for formatting
These could be found by using `grep -r -l -P '^\t+ +[^*]'
* Removal of training whitespaces
* A few lines longer than 120 chars
 2017-12-20 14:53:52 +01:00
Jean Flach f40f366e9e Remove unnecessary inline statements 
fixes #5886
 2017-12-20 13:22:38 +01:00
Jean Flach 6d9a0fe3a9 Remove string_iless 
It's unused
 2017-12-20 11:18:28 +01:00
Jean Flach 0791a8ddde
Merge pull request #5887 from Icinga/fix/windows-build-fix 
Windows build fix
 2017-12-20 10:50:27 +01:00
Gunnar Beutner b63caaa756 Workaround for GCC bug 51494 2017-12-20 08:02:17 +01:00
Gunnar Beutner 02dc3a9507 Workaround for GCC bug 61321 2017-12-20 08:02:17 +01:00
Gunnar Beutner adc892bde7 Windows build fix 2017-12-20 08:01:04 +01:00
Gunnar Beutner 4866f777cc Avoid unnecessary allocations for script frames 2017-12-18 13:40:29 +01:00
Gunnar Beutner 80b72cfb1c Avoid allocations in ScriptUtils::Match 2017-12-18 13:40:21 +01:00
Jean Flach e0bd3d183f Fix package error message 
fixes #5879
 2017-12-18 11:04:40 +01:00
Michael Friedrich 5b44bfb125
Merge pull request #5868 from Icinga/feature/expression-ptr 
Use std::unique_ptr for Expression objects
 2017-12-18 09:54:30 +01:00
Gunnar Beutner 5d96196f08 Replace incorrect fclose() call with pclose() 2017-12-15 22:25:08 +01:00
Gunnar Beutner ab8386cf5c Use std::unique_ptr for Expression objects 2017-12-15 10:44:54 +01:00
Michael Friedrich 20d7221dfe
Merge pull request #5865 from Icinga/fix/uuid 
Add missing initializer in Utility::NewUniqueID()
 2017-12-15 09:08:26 +01:00
Gunnar Beutner 85f3865718
Merge pull request #5861 from Icinga/fix/invalid-memory-access 
Fix incorrect memory access
 2017-12-15 06:25:10 +01:00
Gunnar Beutner 3403844b74
Merge pull request #5863 from Icinga/fix/glob-5859 
Fix glob error handling
 2017-12-14 19:08:54 +01:00
Gunnar Beutner a6887b1ae9 Add missing initializer in Utility::NewUniqueID() 2017-12-14 19:07:14 +01:00
Jean Flach e45ede6271 Fix glob error handling 
fixes #5859
 2017-12-14 17:04:35 +01:00
Gunnar Beutner 1ad83886ac Replace a few more NULLs with nullptr 2017-12-14 15:37:20 +01:00
Gunnar Beutner 0629ea0a98 Fix incorrect memory access 2017-12-14 15:05:04 +01:00
Gunnar Beutner 1bf12c9685
Merge pull request #5857 from Icinga/fix/compiler-warnings 
Fix compiler warnings
 2017-12-14 13:49:25 +01:00
Gunnar Beutner 3c5af89d5f Fix compiler warnings 2017-12-14 09:15:37 +01:00
Gunnar Beutner ff0b6ba630 Fix build problems with Visual Studio 2017 2017-12-14 08:55:36 +01:00
Gunnar Beutner 42744fde5b Remove extraneous whitespace 2017-12-14 08:50:09 +01:00
Gunnar Beutner 96e214221d Remove unused variables 2017-12-14 08:50:09 +01:00
Gunnar Beutner d42f81ed11 Fix compiler warning introduced by #5753 2017-12-12 11:55:30 +01:00
Gunnar Beutner 3ce68b49c7 Fix compiler warning introduced by #5811 2017-12-12 11:54:47 +01:00
Gunnar Beutner 75def4b074
Merge pull request #5753 from Icinga/fix/ringbuffer-does-not-get-updated-if-nothing-is-written-5750 
Fix that RingBuffer does not get updated and add metrics about communication between endpoints
 2017-12-12 11:32:18 +01:00
Gunnar Beutner 40f9431413 Fix performance issues for InfluxdbWriter 2017-12-12 10:39:55 +01:00
Noah Hilverling 5519626f84 Add metrics about communication between endpoints 
refs #5509
 2017-12-11 10:20:25 +01:00
Michael Friedrich a72a7b7c89
Merge pull request #5760 from Icinga/fix/http-client-bugs 
Fix incorrect socket handling for the HTTP client
 2017-12-08 12:51:50 +01:00
Michael Friedrich aec231b119
Merge pull request #5811 from Icinga/feature/update-constants-conf-api-setup 
Update NodeName/ZoneName constants with 'api setup'
 2017-12-07 17:35:46 +01:00
Michael Friedrich f8e102c15a Fix newline terminator for bulk requests in ElasticsearchWriter 
This enables compatibility with 6.x.

This commit also fixes an incorrect HTTP response parsing
which could lead into false positives.

Analysis and fix in https://github.com/Icinga/icinga2/issues/5795#issuecomment-349920587

fixes #5795
 2017-12-07 11:11:03 +01:00
Michael Friedrich da056b052b
Merge pull request #5827 from Icinga/feature/replace-statsfunction-with-function 
Replace StatsFunction with Function
 2017-11-30 21:28:32 +01:00
Michael Friedrich a238613fdc
Merge pull request #5825 from Icinga/feature/boost-assign 
Replace boost::assign::list_of with initializer lists
 2017-11-30 21:20:46 +01:00
Gunnar Beutner a344f11e6c Replace StatsFunction with Function 2017-11-30 19:02:25 +01:00
Gunnar Beutner 83f17b5bfa Replace boost::assign::list_of with initializer lists 2017-11-30 18:09:38 +01:00
Gunnar Beutner 325e4a2fb9 Use nullptr instead of <Type>::Ptr() 2017-11-30 17:47:09 +01:00
Gunnar Beutner 3c60fbf75d Use std::vector::emplace_back instead of std::vector::push_back 2017-11-30 17:47:09 +01:00
Gunnar Beutner 59fca5d5ac Use std::vector instead of std::set where appropriate 2017-11-30 17:47:09 +01:00
Gunnar Beutner 2e87c280ed Use initializer lists instead of std::vector::push_back 2017-11-30 17:47:09 +01:00
Gunnar Beutner ebc11d41a5 Tidy up INITIALIZE_ONCE use in console.cpp a bit 2017-11-30 17:47:09 +01:00
Gunnar Beutner 63fd6e3905 Get rid of INITIALIZE_ONCE for the ExternalCommandProcessor 2017-11-30 17:47:09 +01:00
Gunnar Beutner 9ce950b0f1 Replace boost::ref/boost::cref with std::ref/std::cref 2017-11-30 17:47:09 +01:00
Gunnar Beutner df8266631d Replace boost::tuple with std::tuple 2017-11-30 17:41:02 +01:00
Gunnar Beutner 160ab21e59 Replace CheckResult::StaticInitialize with a lambda function 2017-11-30 17:41:02 +01:00
Gunnar Beutner 6739023678 Dynamically create and destroy the timer thread 2017-11-30 17:41:02 +01:00
Gunnar Beutner 6d09efc907 Use std::shared_ptr instead of boost::shared_ptr 2017-11-30 17:41:00 +01:00
Gunnar Beutner 245feca0e7 Move the Timer::Holder class to timer.cpp 2017-11-30 17:39:22 +01:00
Gunnar Beutner 300d424459 Use std::promise instead of boost::promise 2017-11-30 17:39:22 +01:00
Gunnar Beutner 7d7eaa8dd3 Replace boost::thread with std::thread 2017-11-30 17:39:20 +01:00
Gunnar Beutner c6e36723d5
Merge pull request #5819 from Icinga/feature/avoid-func-call-allocations 
Avoid unnecessary allocations in the FunctionCallExpression class
 2017-11-29 14:24:46 +01:00
Gunnar Beutner db6a1fcdb7 Avoid unnecessary allocations in the FunctionCallExpression class 2017-11-29 14:11:09 +01:00
Gunnar Beutner d5961bb76c Re-implement WrapFunction() using C++11 features 2017-11-29 11:53:45 +01:00
Gunnar Beutner f3c825cb86
Merge pull request #5803 from Icinga/feature/cxx11-std-bind 
Replace boost::bind/boost::function with std::bind/std::function
 2017-11-29 08:28:44 +01:00
Michael Friedrich f267135711 Update NodeName/ZoneName constants with 'api setup' 
This commit also moves the constants.conf backup logic
into NodeUtility::UpdateConstant() where it belongs.

Logging has been slightly adopted too.

fixes #5763
 2017-11-28 13:38:53 +01:00
Michael Friedrich 8e65aa0677
Merge pull request #5804 from Icinga/fix/update-repository-message-error 
Silence UpdateRepository message errors
 2017-11-28 11:27:12 +01:00
Gunnar Beutner 1006ea0433 Fix missing variable name which can lead to segfaults 2017-11-27 16:06:59 +01:00
Gunnar Beutner 858873b940 Replace boost::bind/boost::function with std::bind/std::function 2017-11-27 15:15:11 +01:00
Gunnar Beutner 6b3931973e
Merge pull request #5555 from Icinga/feature/ecc-certs 
Implement support for ECC certificates
 2017-11-27 15:11:04 +01:00
Jean Flach 27aaa10ee9
Merge pull request #5718 from Icinga/fix/verify-error-codes-and-returned-log-messages-in-api-actions-5550 
API: Fix http status codes
 2017-11-27 14:41:29 +01:00
Noah Hilverling e31b236cba API: Fix http status codes 
fixes #5550
 2017-11-27 14:06:38 +01:00
Michael Friedrich cf16324320 Silence UpdateRepository message errors 
Mixed setups with 2.8 and 2.7 will log this error every time
a new message is received. While this is truly an error,
it just fills the log to infinity. Should be used for debug only.

fixes #5776
 2017-11-27 12:09:42 +01:00
Gunnar Beutner 3a8d4c5920
Merge pull request #5716 from spaolo/fix/livestatus-empty-result-with-nonmatch-filter-5626 
add bogus zero reply in livestatus when aggregate and non matching filter
 2017-11-27 10:35:05 +01:00
Gunnar Beutner 4fcb1af8fa
Merge pull request #5746 from sni/livestatus_should_return_empty_lists 
livestatus: custom variables return empty arrays instead of strings
 2017-11-27 10:33:32 +01:00
Gunnar Beutner 57e74372d3
Merge pull request #5675 from froehl/feature/influxdbwriter-perf-unit-5627 
Add pdv unit to influxdbwriter if not empty + doc
 2017-11-27 10:32:44 +01:00
Gunnar Beutner 55b1cce248
Merge pull request #5744 from Icinga/feature/embedded-dummy-check 
Implement DummyCheckTask and move dummy into embedded in-memory checks
 2017-11-27 10:25:43 +01:00
Gunnar Beutner 734efb3569
Replace spaces with tabs 2017-11-27 10:24:12 +01:00
Gunnar Beutner 81ae14cd17
Merge pull request #5729 from Icinga/fix/correct-node-wizard-output-formatting 
Correct node wizard output formatting
 2017-11-27 10:19:12 +01:00
Gunnar Beutner 1b4206e5b1
Merge pull request #5725 from Icinga/feature/proper-uuids 
Use real UUIDs for Utility::NewUniqueID
 2017-11-27 10:18:52 +01:00
Gunnar Beutner 093e08e3da
Merge pull request #5388 from leeclemens/fix/clang-misdetection 
Handle mis-detection with clang on RHEL/CentOS 7
 2017-11-27 10:17:52 +01:00
Gunnar Beutner 65bc62266d Fix error reporting for 'icinga2 console -r' 2017-11-24 12:56:42 +01:00
Michael Friedrich 35f0df3fe5 Disable Flapping detection on Windows 2017-11-17 12:59:07 +01:00
Gunnar Beutner 52692a008e Fix incorrect socket handling for the HTTP client 2017-11-15 09:53:38 +01:00
Noah Hilverling c10f0a639b RingBuffer: Add CalculateRate() 
refs #5750
 2017-11-14 11:06:56 +01:00
Noah Hilverling 054faa54d5 Return bytes sent/written in SendMessage() and WriteStringToStream() 
refs #5509
 2017-11-14 08:18:23 +01:00
Noah Hilverling 2acaccd028 Fix that RingBuffer does not get updated if nothing is written 
refs #5750
 2017-11-13 16:17:59 +01:00
Sven Nierlein 7bf5b3ff42 livestatus: custom variables return empty arrays instead of strings 
livestatus queries for custom variables should return an empty list, ex: []
instead of an empty string if there are no variables.

Signed-off-by: Sven Nierlein <sven@nierlein.de>
 2017-11-10 14:53:37 +01:00
Michael Friedrich 6d9a0b7145 Implement DummyCheckTask and move dummy into embedded in-memory checks 
This replaces the previous "dummy" CheckCommand, and the user won't
notice it. Provided performance data will be parsed the same way.

This saves a shell fork and check_dummy execution.

We're relying on this when creating cluster checks with Icinga 2 DSL
and more. If one does not have the plugins installed, this then also works.

fixes #5740
 2017-11-09 20:19:31 +01:00
Michael Friedrich 7c0a09cfb6 Rename ElasticWriter to ElasticsearchWriter 
This better reflects its purpose as otherwise it would imply
that you need Elastic Stack for it. Graylog also reads from
Elasticsearch instances, this could serve as additional integration
here.
 2017-11-09 15:33:10 +01:00
Paolo Schiro 490b822f38 add a bogus zero reply in livestatus if aggregate filter does not match, fix I#5626 2017-11-09 01:32:30 +01:00
Jean Flach f4a1747e14
Merge pull request #5732 from Icinga/fix/flapping 
Fix flapping calculation and events

fixes #5720
 2017-11-08 15:10:55 +01:00
Michael Friedrich 41d54029c8 Fix log messages for flapping 2017-11-08 12:12:27 +01:00
Noah Hilverling e6f94ff203 Correct node wizard output formatting 2017-11-08 09:04:25 +01:00
Lee Clemens 9fdfa5ee10 Handle mis-detection with clang on RHEL/CentOS 7 
C++11 features available: BOOST_NO_CXX11_HDR_TUPLE

refs #5257
 2017-11-08 08:34:45 +01:00
Michael Friedrich 42b1e7ce79 Use the entry_time for icinga_comments updates 
This follows all other queries in their where condition
using entry_time for comments/downtimes.
 2017-11-07 16:37:12 +01:00
Michael Friedrich e0e7f9ae6b DB IDO: Force users to upgrade the schema to avoid workaround fixes/missing indexes 2017-11-07 16:37:12 +01:00
Jean Flach e83ddbd8b2 Remove unnecessary keys from where clauses 2017-11-07 16:37:12 +01:00
Eric Lippmann 6f6703042e ido: Drop unused instance_id indices from comments, downtimes and their related history tables 2017-11-07 16:37:12 +01:00
Jean Flach 1632415370 Fix commenthistory 
refs #5492
 2017-11-07 16:37:12 +01:00
Jean Flach 30be02bcae Alter DowntimeRemoval behaviour 
This adds an additional index to the downtimehistory and updates the
dbevents in a way that it uses that index
 2017-11-07 16:37:12 +01:00
Gunnar Beutner 6f8b62333f Use real UUIDs for Utility::NewUniqueID 2017-11-07 13:53:04 +01:00
Jean Flach 872d4895f0 Fix flapping endianness and events 
fixes #5720
 2017-11-07 11:13:17 +01:00
Michael Friedrich 260c6d7438 Node setup: ticket parameter is now optional 
refs #5681
 2017-11-03 14:10:45 +01:00
Michael 86cdc5bc53 Include default global zones during node wizard/setup 
This changes the GenerateNodeMasterIcingaConfig and GenerateNodeIcingaConfig
functions inside the nodeutillity class to the effect, that the default global
zones global-templates and director-global will be written to the generated
zones.conf that is created during the node wizard/setup.

refs #5707

Signed-off-by: Michael Friedrich <michael.friedrich@icinga.com>
 2017-10-31 12:07:12 +01:00
Jean Flach 9ba5b4f4b7 Merge pull request #5693 from Icinga/fix/flapping-old-4982 
Re-implement flapping

fixes #4982
 2017-10-24 16:58:59 +02:00
Jean Flach a21ffd6fe4 Fix flapping 
Re-implement flapping following the 'old way' of just observing the last
20 stage changes.

refs #4982
 2017-10-24 15:54:05 +02:00
Gunnar Beutner 2bbb5366fd Merge pull request #5620 from Icinga/fix/api-staging-3668 
WIP: Ensure that the REST API config package/stage creation is atomic
 2017-10-24 12:51:09 +02:00
Noah Hilverling 3e8f78e2cc Process: Fix fork error handling 
refs #5617
 2017-10-23 11:01:42 +02:00
Noah Hilverling 7930ae5094 Process: Remove log message from child process 2017-10-23 11:01:16 +02:00
Gunnar Beutner f2d437e96c Implement support for migrating certificates to /var/lib/icinga2/certs 
This commit includes documentation too.

Signed-off-by: Michael Friedrich <michael.friedrich@icinga.com>
 2017-10-20 14:06:02 +02:00
Jean Flach aad96d6b09 Improve error message for unknow functions 
refs #5686
 2017-10-18 11:25:38 +02:00
Michael Friedrich 9d68ae9f1f Merge pull request #5602 from Icinga/fix/config-validation-fails-on-windows-with-unprivileged-account-5515 
Add windows process elevation and log message if user does not have privileges to read/write files
 2017-10-13 16:31:12 +02:00
Fabian Röhl 82794474e6 Add pdv unit to influxdbwriter if not empty + doc 
refs #5627
 2017-10-13 14:54:00 +02:00
Michael Friedrich 0b1ce7111c Merge pull request #5231 from Al2Klimov/bugfix/failure-to-kill-check-command-after-exceeding-timeout-is-not-reported-4981 
Report failure to kill check command after exceeding timeout
 2017-10-13 13:57:26 +02:00
Michael Friedrich 77ecdbd85c Merge pull request #5581 from Icinga/fix/api-crash-race-condition 
Fix possible race condition in ApiListener locking
 2017-10-12 13:40:59 +02:00
Michael Friedrich 87979fd0a1 Merge pull request #5637 from Icinga/fix/influxdb-unnecessary-string-casts 
Fix unnecessary String() casts in InfluxdbWriter
 2017-10-12 13:22:43 +02:00
Michael Friedrich 9a04a99400 Merge pull request #5554 from Icinga/feature/cn-check-for-san 
Add subjectAltName extension for all non-CA certificates
 2017-10-10 17:50:01 +02:00
Michael Friedrich ff570ad060 Merge pull request #5636 from Icinga/fix/db-ido-comments-downtimes-constraint-on-legacy-id-change 
Fix unique constraint matching for UPDATE downtime/comment runtime tables in DB IDO
 2017-10-10 17:47:47 +02:00
Michael Friedrich 06403c1147 Merge pull request #5635 from Icinga/fix/match-with-empty-array 
Fix match(), regex(), cidr_match() behaviour with MatchAll and empty arrays
 2017-10-10 17:46:51 +02:00
Michael Friedrich a521f49803 Fix debug builds on Apple Clang 9.0.0 (macOS High Sierra) 2017-10-02 13:49:42 +02:00
Michael Friedrich b9cfd4d2e9 Fix unnecessary String() casts in InfluxdbWriter 
fixes #5629
 2017-09-29 16:33:08 +02:00
Michael Friedrich 6061d56a7c Fix unique constraint matching for UPDATE downtime/comment runtime tables in DB IDO 
fixes #5623
fixes #5603
 2017-09-29 16:12:38 +02:00
Michael Friedrich c0a3de64fb Fix match(), regex(), cidr_match() behaviour with MatchAll and empty arrays 
fixes #5634
 2017-09-29 14:45:15 +02:00
Gunnar Beutner 92727d13c7 Fix a build warning 
refs #5443
 2017-09-25 12:15:59 +02:00
Michael Friedrich 953d840cc1 Fix certificate paths for installers 
refs #5450
 2017-09-22 15:00:45 +02:00
Michael Friedrich 11c41cd747 Drop unused code from NodeUtility class 
refs #4799
 2017-09-22 14:05:08 +02:00
Michael Friedrich 68cae91378 Remove bottom-up cluster messages 
refs #4799
 2017-09-22 14:04:53 +02:00
Michael Friedrich 601c10b997 Remove bottom-up CLI commands 
refs #4799
 2017-09-22 14:04:43 +02:00
Noah Hilverling aab50f669c Add process elevation & log message if user does not have enough privileges 
refs #5515
 2017-09-22 10:25:17 +02:00
Jean Flach 79166a31d4 Revert "Add Log Warning in case active-stage is empty" 
This reverts commit 287f72b0a0.
 2017-09-21 13:54:29 +02:00
Jean Flach 287f72b0a0 Add Log Warning in case active-stage is empty 
Maybe Critical instead? Throwing an exception seems unnecessary.

refs #3668
 2017-09-20 17:57:14 +02:00
Michael Friedrich 74d13345dc Merge pull request #5587 from Icinga/feature/custom-syslog-facility-option-on-sysloglogger-object-3964 
SyslogLogger: Implement option to set syslog facility
 2017-09-20 17:25:58 +02:00
Jean Flach ef5013b903 Use locks in api config staging 
refs #3668
 2017-09-20 16:45:09 +02:00
ryanohnemus 1cb39994a5 API: Add optional reload parameter to config stage upload 
You can now specify a boolean `reload` attribute that
will allow you to skip the icinga2 reload after config
validation. By default this is set to true.

The response text has been updated to show if icinga2
will reload or if it was requested to be skipped.

fixes #4769
 2017-09-20 14:16:55 +02:00
Noah Hilverling ea24af6590 SyslogLogger: Implement option to set syslog facility 
fixes #3964
 2017-09-20 14:09:51 +02:00
Michael Friedrich 7bdeeeadcf Silence log level for configuration file updates 
This only helps with debugging the configuration sync, but seems
to be highlighted quite often in default configurations (where
the timestamp is equal).

refs #5566
 2017-09-20 13:30:02 +02:00
Noah Hilverling 94fe1b2292 HttpServerConnection: Implement CORS support 
fixes #4326
 2017-09-20 13:18:29 +02:00
Jean Flach 1b54772b85 Fix where clauses for downtime/comment DB IDO queries using a non-matching legacy id before 
fixes #5458 #5492
 2017-09-20 12:13:14 +02:00
Jean Flach 4df1125114 Fix Windows build error 
fixes #5584
 2017-09-18 17:47:08 +02:00
Michael Friedrich 9948bee51c Fix API crash with race condition on locks 
This was split from #5416 and #5419.

More patches from #5419 are pending.

refs #5419
refs #5418
refs #5416

refs #5408
refs #5148
refs #5007
refs #4968
refs #4910
 2017-09-18 15:25:29 +02:00
Gunnar Beutner 5179faceab Implement new script functions: path_exists, glob and glob_recursive 2017-09-18 13:59:03 +02:00
Gunnar Beutner 80421e4619 Build fix for OpenSSL < 1.0.2 
refs #5450
 2017-09-12 13:09:16 +02:00
Michael Friedrich 578dcbe861 Add some more verbose logging details 
refs #5450
 2017-09-12 12:52:50 +02:00
Michael Friedrich 501ade374c Remove debug logging, fix ticket path, enhance logging 
refs #5450
 2017-09-12 12:52:49 +02:00
Gunnar Beutner 043106242d Remove API stubs for now 
refs #5450
 2017-09-12 12:52:49 +02:00
Gunnar Beutner 88e57f7fd4 Implement support for cleaning up certificate requests 
refs #5450
 2017-09-12 12:52:49 +02:00
Michael Friedrich 0a85977831 Node Wizard: Tell the user to put ca.crt if no connection to parent is selected 
This also fixes the choice tree for connection-less questions
and prevents empty tickets being stored on disk.

refs #5450
 2017-09-12 12:52:49 +02:00
Gunnar Beutner 2fec16952d Remove unused code 
refs #5450
 2017-09-12 12:52:49 +02:00
Gunnar Beutner f43516a097 Implement the --verbose option for "node wizard" 
refs #5450
 2017-09-12 12:52:49 +02:00
Michael Friedrich e424017c15 Refactor the node wizard/setup CLI commands 
refs #5450
 2017-09-12 12:52:49 +02:00
Michael Friedrich 181b91b759 Enhance logging for certificate requests 
Examples:
https://github.com/Icinga/icinga2/issues/5450#issuecomment-327479874

This also adds code comments where applicable.

refs #5450
 2017-09-12 12:52:49 +02:00
Michael Friedrich ce88e89cc0 Fix wrong cert path for CLI commands 
refs #5450
 2017-09-12 12:52:49 +02:00
Gunnar Beutner a7fe6467ba Improve log messages for the 'pki save-cert' command 
refs #5450
 2017-09-12 12:52:49 +02:00
Michael Friedrich 8040bda2e1 Change directory layout to /var/lib/icinga2/{ca,certs,certificate_requests} 
refs #5450
 2017-09-12 12:52:49 +02:00
Michael Friedrich 88b4a54e6b Fix ticket hash calculation for indirectly connected clients 
refs #5450
 2017-09-12 12:52:49 +02:00
Gunnar Beutner c02742925e Refactor PkiUtility class 
refs #5450
 2017-09-12 12:52:49 +02:00
Michael Friedrich 1e7860f2b1 Implement ApiListener::Get*Dir() functions 
refs #5450
 2017-09-12 12:52:49 +02:00
Gunnar Beutner 6a533796e5 Update output format for the new CLI commands 
refs #5450
 2017-09-12 12:52:49 +02:00
Gunnar Beutner 774936bfe8 Implement support for pki::UpdateCertificate messages 
refs #5450
 2017-09-12 12:52:49 +02:00
Gunnar Beutner 623208d617 Implement support for forwarding certificate requests 
refs #5450
 2017-09-12 12:52:49 +02:00
Gunnar Beutner 03f5ccd252 Implement support for cleaning up expired API callbacks 
refs #5450
 2017-09-12 12:52:49 +02:00
Gunnar Beutner cc43dc734b Refuse to sign certificate if it already has the correct chain and doesn’t expire soon 
refs #5450
 2017-09-12 12:52:49 +02:00
Gunnar Beutner 440f848c7c Improve error handling for JSON-RPC calls 
refs #5450
 2017-09-12 12:52:49 +02:00
Gunnar Beutner a8cc0a601b Add missing _unlink() calls for Windows 
refs #5450
 2017-09-12 12:52:49 +02:00
Gunnar Beutner cb49ac1264 Delete ticket file once we have a signed certificate 
refs #5450
 2017-09-12 12:52:49 +02:00
Gunnar Beutner 4cfbf6eb17 Disconnect all clients when we update our own certificate 
refs #5450
 2017-09-12 12:52:49 +02:00
Gunnar Beutner 439251532e Implement support for saving client tickets 
refs #5450
 2017-09-12 12:52:49 +02:00
Gunnar Beutner 192502f9e5 Implement support for reloading SSL certificates without a restart 
refs #5450
 2017-09-12 12:52:49 +02:00
Gunnar Beutner 0ec07bce51 Implement support for updating client certificates 
refs #5450
 2017-09-12 12:52:49 +02:00
Gunnar Beutner cdff792c11 Make the ticket optional in 'icinga2 node wizard' 
refs #5450
 2017-09-12 12:52:49 +02:00
Gunnar Beutner 8d05fc99c9 Improve message formatting for the 'icinga2 node wizard' command 
refs #5450
 2017-09-12 12:52:49 +02:00
Gunnar Beutner a4684d1bfd Implement support for sending pki::RequestCertificate messages in the cluster 
refs #5450
 2017-09-12 12:52:49 +02:00
Gunnar Beutner b08f5477dc Change PKI path from /etc/icinga2/pki to /var/lib/icinga2/pki 
refs #5450
 2017-09-12 12:52:49 +02:00
Gunnar Beutner abdd4b307b Implement the 'ca list' and 'ca sign' CLI commands 
refs #5450
 2017-09-12 12:52:49 +02:00
Gunnar Beutner 510e2d622a Implement support for ticket-less certificate requests 
refs #5450
 2017-09-12 12:52:49 +02:00
Michael Friedrich 1d75a15d8e ElasticWriter: Implement support for TLS connections (HTTP proxy) 
This commit also enhances the log messages.

refs #5538
 2017-09-12 12:52:49 +02:00
Michael Friedrich 95fbd75df8 ElasticWriter: Add basic auth support for Elasticsearch behind an HTTP proxy 
refs #5538
 2017-09-12 12:52:49 +02:00
Michael Friedrich 344b047ea0 Move Base64 class into libbase 
refs #5538
 2017-09-12 12:52:49 +02:00
Michael Friedrich 386b9de042 Drop obsolete code 
refs #4054
 2017-09-12 12:52:49 +02:00
Jean Flach e19d3f57c7 Add ElasticWriter 
fixes #5538
 2017-09-12 12:52:49 +02:00
Michael Friedrich 9e17ff874b Logs: Change config sync update to highlight an information, not an error 
fixes #5484
 2017-09-12 12:52:49 +02:00
Gunnar Beutner b316de8aea Implement additional logging for the JsonRpc class 2017-09-12 12:52:49 +02:00
Jean Flach de51966f52 Don't sent scheme and hostname in request 2017-09-06 16:01:02 +02:00
Gunnar Beutner 10691db5b1 Implement support for ECC certificates 2017-09-06 12:29:30 +02:00
Gunnar Beutner 3385122bc3 Add subjectAltName extension for all non-CA certificates 2017-09-06 12:25:36 +02:00
Federico Cuello a6b4bd48e2 Fix parameter order for Acknowledge{,Svc,Host}Problem in API actions/external commands 
It was preventing email notifications with default settings, as `persistent` defaults to false and therefore `notify` was not set.

Signed-off-by: Michael Friedrich <michael.friedrich@icinga.com>
 2017-09-05 08:50:22 +02:00
Michael Friedrich 261bd93c0b Implement get_services(host {name,object}) and add host object support for get_service() 
This includes some debug console examples too which involve advanced
map() and filter examples for better readability.

refs #4912
 2017-08-28 19:54:26 +02:00
Michael ac0fdd7144 Change more loglines for checkables so checkable is quoted 
refs #5528
 2017-08-24 13:35:55 +02:00
Thomas Widhalm de9a097a97 Change loglines for checkables so checkable is quoted 2017-08-23 19:11:46 +02:00
Michael Friedrich e88b97079c API: Add execution_{start,end} attribute to 'process-check-result' action 
fixes #5002
 2017-08-21 17:20:56 +02:00
Michael Friedrich 445ee949da Merge pull request #5523 from Icinga/feature/enhance-client-connect-logging 
Enhance client connect/sync logging and include bytes/zone in logs
 2017-08-21 11:36:52 +02:00
Michael Friedrich 778c742b75 Merge pull request #5524 from Icinga/fix/cluster-fifo-optimize 
Change FIFO::Optimize() frequency for large messages
 2017-08-21 11:36:32 +02:00
Michael Friedrich 873a553a4f Enhance client connect/sync logging and include bytes/zone in logs 
refs #5513
 2017-08-21 11:31:24 +02:00
Michael Friedrich 732a5849d5 Change FIFO::Optimize() frequency for large messages 
refs #5513
 2017-08-21 11:24:39 +02:00
Michael Friedrich d075665d1b Merge pull request #5486 from Icinga/feature/remove-deprecated-graphite-legacy-mode 
Graphite: Remove deprecated legacy schema mode
 2017-08-17 20:06:47 +02:00
Michael Friedrich cb94b218a6 Merge pull request #5504 from spjmurray/fix/influxdb_timeouts_5460_5469 
Fix TLS Race Connecting to InfluxDB
 2017-08-17 18:25:17 +02:00
Michael Friedrich 52dcce972f Livestatus: Fix crash with empty stats columns 
refs #5078
refs #5503
 2017-08-16 15:28:15 +02:00
Michael Friedrich a43ae941b6 Merge pull request #5497 from Icinga/fix/api-object-query-type-error 
API: Fix requested attrs/joins/meta type errors in object query response
 2017-08-15 12:52:33 +02:00
Simon Murray abc3652b00 Fix TLS Race Connecting to InfluxDB 
Rather than leaving stale connections about we tried to poll for data coming in
from InfluxDB and timeout if it didn't repond in a timely manner.  This introduced
a race where the timeout triggers, a context switch occurs where data is actually
available and the TlsStream spins trying to asynchronously notify that data is
available, but which never gets read.  Not only does this use up 100% of a core,
but it also slowly starves the system of handler threads at which point metrics
stop being delivered.

This basically removes the poll and timeout, any TLS socket erros should be
detected by TCP keep-alives.

Fixes #5460 #5469
 2017-08-14 16:20:49 +01:00
Gunnar Beutner 6bc79b6b37 Merge pull request #5503 from Icinga/fix/livestatus-stats-groups 
Fix grouping for Livestatus queries with 'Stats'
 2017-08-14 16:19:18 +02:00
Gunnar Beutner 5402c1d610 Fix grouping for Livestatus queries with 'Stats' 
refs #5078
 2017-08-14 15:30:06 +02:00
Noah Hilverling 5b9337e130 Process: Fix JSON parsing error on process helper crash 2017-08-14 08:27:04 +02:00
Stefar77 6b66e332fb API: Fix requested attrs/joins/meta type errors in object query response 
fixes #5377

Signed-off-by: Michael Friedrich <michael.friedrich@icinga.com>
 2017-08-11 16:23:29 +02:00
Gunnar Beutner 4d943c7f5c Implement additional functions for printing values with LLDB/GDB 2017-08-10 08:26:22 +02:00
Michael Friedrich eb5e299c4b Graphite: Remove deprecated legacy schema mode 
This commit includes some code cleanup too.

fixes #4992
 2017-08-09 18:52:35 +02:00
Michael Friedrich f6691b4936 Fix config validation for DB IDO categories 'DbCatEverything' 
refs #5238
 2017-08-09 16:31:03 +02:00
Michael Friedrich 3201d92fbd DB IDO: Fix host's unreachable state in history tables 
fixes #5405
 2017-08-07 11:10:02 +02:00
Michael I 3e54e34147 Update featurelistcommand.cpp 
refs #5431
 2017-07-25 13:35:20 +02:00
Gunnar Beutner c8b4fee843 Make rlimits configurable by adding three variables: RLimitFiles, RLimitProcesses and RLimitStack 
refs #5367
 2017-06-23 12:42:12 +02:00
Michael Friedrich 6397fedc3d Remove experimental redis feature before 2.7 release 2017-06-20 11:52:24 +02:00
Michael Friedrich 6ab5839f2f Merge pull request #5360 from Icinga/fix/wheezy-livestatus-dbl_max 
livestatus/minaggregator: Buildfix for Debian wheezy
 2017-06-19 17:27:11 +02:00
Markus Frosch e8681658b6 livestatus/minaggregator: Buildfix for Debian wheezy 2017-06-19 08:42:56 +02:00
mcktr 53908b7080 Fixed missing closing bracket in CLI command pki new-cert. 2017-06-18 15:13:16 +02:00
Michael Friedrich 67bd6d1813 Merge pull request #5316 from gitmopp/patch-1 
Fix for stats min operator

fixes #3410
 2017-06-16 21:02:17 +02:00
Michael Friedrich 6036ec20f5 Build fix for Debian Wheezy 
fixes #5350
 2017-06-16 16:57:05 +02:00
Michael Friedrich c6b375dcbd Merge pull request #5239 from Icinga/feature/check_nscp-4721 
Add NSCP API check plugin for NSClient++ HTTP API
 2017-06-13 21:56:58 +02:00
Jean Flach 39c24e9ec9 Add check_nscp_api plugin for NSClient++ API checks 
refs #4721
 2017-06-13 21:17:16 +02:00
Gunnar Beutner f9feb41877 Implement support for handling exceptions in user scripts 2017-06-13 14:03:41 +02:00
Michael Friedrich 2a4359d7e8 Windows build fix for InfluxdbWriter 
refs #5219
fixes #5334
 2017-06-07 14:16:15 +02:00
Michael Friedrich 89ac5b2fff GelfWriter: Add 'check_command' to CHECK RESULT/* NOTIFICATION/STATE CHANGE messages 
This allows for much more easy filtering in Graylog web
similar to Graphite or InfluxDB and their template dashboards.
 2017-06-06 20:23:26 +02:00
Michael Friedrich 41a400f552 Merge pull request #5330 from Icinga/feature/graphite-stats 
GraphiteWriter: Add 'connected' to stats; fix reconnect exceptions
 2017-06-06 20:13:33 +02:00
Michael Friedrich f42b820007 GraphiteWriter: Add 'connected' to stats; fix reconnect exceptions 2017-06-06 19:50:37 +02:00
Michael Friedrich f10815efa2 GelfWriter: Use async work queue and add feature metric stats 
fixes #4532
 2017-06-06 19:48:23 +02:00
gitmopp 65ed89c48d Fix for stats min operator 
Fix for bug #3410
 2017-06-01 19:30:04 +02:00
Gunnar Beutner 7ca485f63c Improve validation for attributes which must not be 'null' 2017-05-30 14:47:28 +02:00
Gunnar Beutner c9039e1850 Merge pull request #5292 from Icinga/fix/openssl-0.9.8-subjectaltname 
Build fix for OpenSSL 0.9.8 and stack_st_X509_EXTENSION

fixes #5292
 2017-05-29 09:45:34 +02:00
Gunnar Beutner 1fd2695e02 Fix compiler warnings 
refs #5287
 2017-05-29 09:13:19 +02:00
mcktr 9e1016dd4f Fix missing apostrophe in notification log 
refs #5294
 2017-05-26 17:58:04 +02:00
Michael Friedrich dab2522acc InfluxDB: Optimize work queue event handling 
refs #5219
 2017-05-26 17:11:13 +02:00
Michael Friedrich d0dcb8a658 ApiListener: Handle zero JSON-RPC WQs gracefully for stats 
refs #5266
refs #5133
 2017-05-26 17:02:36 +02:00
Michael Friedrich 28395b32f0 GraphiteWriter: Use a workqueue for event processing 
This also adds reconnect handling and exceptions.

refs #5132
refs #5133
refs #5280
 2017-05-26 15:18:14 +02:00
Michael Friedrich 79c45ea811 Build fix for OpenSSL 0.9.8 and stack_st_X509_EXTENSION 2017-05-26 13:16:20 +02:00
Michael Friedrich 647d82094f InfluxDB: Remove obsolete logger, now implemented in WorkQueue class 
refs #5280
refs #5133
 2017-05-24 17:01:46 +02:00
Michael Friedrich 3a5d4f3c8d DB IDO: Remove obsolete logger, now implemented in WorkQueue class 
refs #5280
refs #5133
 2017-05-24 16:52:15 +02:00
Michael Friedrich d366a63510 Add API & Cluster stats to /v1/status & icinga check performance metrics 
refs #5133
 2017-05-24 16:21:05 +02:00
Michael Friedrich b7358334fc Add feature stats to 'icinga' check as performance data metrics 2017-05-23 17:28:54 +02:00
Michael Friedrich 456cfdc636 Implement WorkQueue metric stats and periodic logging 
refs #5133
 2017-05-23 16:00:21 +02:00
Michael Friedrich 52d986d02b Revert "Add LogstashWriter feature" 
This reverts commit f5a971f5b0.

refs #4054
 2017-05-23 12:05:01 +02:00