Michael Friedrich
e27dee5476
Windows: Fix missing path for repository handler
...
fixes #11817
2016-05-21 13:05:35 +02:00
Gunnar Beutner
78705e74f3
Open the command pipe with O_RDWR
...
fixes #11807
2016-05-18 15:52:29 +02:00
Gunnar Beutner
b99b373b6f
Fix 100% CPU usage issue and incorrect pending checks accounting in CheckerComponent::CheckThreadProc
...
fixes #11806
2016-05-18 14:30:36 +02:00
Gunnar Beutner
bb69540b32
Fix exception in PerfdataWriter::RotateFile
...
fixes #11801
2016-05-18 14:01:32 +02:00
Gunnar Beutner
222b90107f
Fix crash in ConfigItem::Commit
...
fixes #11804
2016-05-18 12:53:41 +02:00
Gunnar Beutner
93da47a670
Fix PostgreSQL warnings on startup
...
fixes #11798
2016-05-17 10:32:38 +02:00
Gunnar Beutner
bc12d6c0d6
Fix race condition in ConfigObject::SetAuthority
...
fixes #11784
2016-05-12 14:06:28 +02:00
Gunnar Beutner
97a5091abc
Fix incorrect re-scheduling behavior for command_endpoint checks
...
refs #8137
2016-05-12 13:47:32 +02:00
Gunnar Beutner
de1b70cf44
Fix incorrect variable names for joined fields in filter expressions
...
fixes #11779
2016-05-12 10:24:15 +02:00
Michael Friedrich
3c852311e1
Fix possible crash in Add{Comment,Downtime}
...
refs #11112
2016-05-11 16:12:09 +02:00
Gunnar Beutner
1ad4d9cd27
Report failed reload attempts for the icinga check
...
fixes #9060
fixes #9997
fixes #11129
2016-05-11 16:07:28 +02:00
Gunnar Beutner
0b95be7b99
Fix incorrect calculation in Downtime::IsInEffect
...
fixes #11589
2016-05-11 14:13:43 +02:00
Michael Friedrich
90f102abf3
Ensure that program status updates are immediately updated in DB IDO
...
fixes #11767
2016-05-11 14:03:40 +02:00
Gunnar Beutner
0bc139af93
Improve timing behavior for UpdateObjectAuthority calls
...
refs #11765
2016-05-11 13:04:39 +02:00
Gunnar Beutner
fc1168ed3e
Only activate HARunOnce objects once there's a cluster connection
...
fixes #11765
2016-05-11 12:50:40 +02:00
Michael Friedrich
a529725a92
Fix overloaded command pipe errors
...
fixes #11390
2016-05-11 11:04:28 +02:00
Gunnar Beutner
2adfcb56fe
Improve error handling for TlsStream::Handshake
...
fixes #11046
2016-05-11 10:09:54 +02:00
Gunnar Beutner
b9fdb3bfd9
Make sure that object names aren't empty
...
fixes #9989
2016-05-11 09:48:18 +02:00
Jason Young
7dbd66535a
Throw exception if PerfdataWriter::RotateFile fails to rename from host_temp_path to host_perfdata_path (and same for service)
...
This can happen if the two paths are not on the same mount-point.
fixes #9236
Signed-off-by: Gunnar Beutner <gunnar.beutner@netways.de>
2016-05-11 09:29:32 +02:00
Gunnar Beutner
ed27130402
Fix: "day -X" time specifications are parsed incorrectly
...
fixes #11147
2016-05-11 09:23:55 +02:00
Gunnar Beutner
81a7a002b4
Improve validation for flow control statements
...
fixes #11622
2016-05-11 08:01:31 +02:00
Michael Friedrich
9a88185b12
API: Fix error handling for invalid JSON request body
...
fixes #11757
2016-05-10 15:16:35 +02:00
Michael Friedrich
1c6f09f44e
API: Fix error message handling for invalid attributes in PUT requests
...
refs #11396
2016-05-10 13:43:36 +02:00
Michael Friedrich
ba82d2eb20
Move CalculateExecutionTime and CalculateLatency into the CheckResult class
...
fixes #11751
2016-05-10 12:16:49 +02:00
Gunnar Beutner
f6f3bd1e4c
Implement support for limiting the number of concurrent checks
...
fixes #8137
2016-05-10 11:26:55 +02:00
Gunnar Beutner
eab2fb79ad
Fix crash in UnameHelper()
...
fixes #11714
2016-05-10 09:46:48 +02:00
Gunnar Beutner
1fb378ef4a
Remove unused cluster commands
...
fixes #11748
2016-05-10 07:05:10 +02:00
Michael Friedrich
8a65c4a776
API: Fix error message with PUT requests for existing objects
...
fixes #11396
2016-05-09 15:08:35 +02:00
Gunnar Beutner
b8e911b0e5
Make sure the dependency graph is properly updated when adding and removing objects
...
fixes #11686
fixes #11374
2016-05-09 14:30:12 +02:00
Lee Clemens
7050529976
Add SSL support for the IdoMysqlConnection feature
...
fixes #9725
Signed-off-by: Michael Friedrich <michael.friedrich@netways.de>
2016-05-03 15:01:32 +02:00
Simon Murray
79c1e883d1
Add InfluxDB Writer
...
Adds an Icinga2 object to directly interface with InfluxDB's native HTTP API.
This supports optional basic authorization, and TLS transport. InfluxDB didn't
appear to like having the TLS stream kept open, so instead this object buffers
data points which are then flushed to InfluxDB as a batch write, either driven
by a configurable timeout or threshold.
As InfluxDB is a schema-less database the host and service templates are user
configurable allowing both the measurement field and tags to be set by the
end user via macro expansion. This allows access to tag fields from arbitrary
data associated with host.vars or service.vars. If a particular value is
unable to be resolved, the tag will be dropped and not transmitted to InfluxDB.
Also alters URL handling to omit array brackets when only a single value is
attached to a key, otherwise InfluxDB has a strop with non-standard syntax.
fixes #10480
Signed-off-by: Michael Friedrich <michael.friedrich@netways.de>
2016-05-03 14:12:51 +02:00
Michael Friedrich
2faf121ff4
Remove commentsand downtimes with reference to deleted checkable objects
...
Silence the warning message and change the log level to notice as well.
fixes #10717
2016-05-03 11:30:02 +02:00
Michael Friedrich
23ab6cf78b
Fix: Expired downtimes are not removed
...
fixes #11711
2016-05-02 15:32:46 +02:00
Jean Flach
360e0ad548
Fix external commands comments crashing icinga
...
Now an exception will be thrown when AddSvcComment or AddHostComment are
run with and empty Author or comment
fixes #11112
2016-04-25 16:58:00 +02:00
Gunnar Beutner
93a09b874b
Remove the (unused) 'inherits' keyword
...
fixes #11659
2016-04-22 13:49:30 +02:00
Michael Friedrich
7442cd94f5
Fix crash with empty ScheduledDowntime 'ranges' attribute
...
fixes #11158
2016-04-22 11:00:21 +02:00
Gunnar Beutner
c54de4b615
Implement SNI support for the CLI commands
...
fixes #11651
2016-04-21 15:44:51 +02:00
Gunnar Beutner
8b7d59eb34
Implement support for subjectAltName in SSL certificates
...
fixes #11556
2016-04-21 15:25:57 +02:00
Gunnar Beutner
2d55cf1341
Implement validation for the Logger#severity attribute
...
fixes #11646
2016-04-21 13:50:47 +02:00
Gunnar Beutner
4a32211de2
Fix crash in Ido{Mysql,Pgsql}Connection::ExecuteMultipleQueries
...
fixes #11639
2016-04-21 09:17:40 +02:00
Michael Friedrich
d5c0d7366d
Fix: Failed assertion in IdoPgsqlConnection::FieldToEscapedString
...
fixes #11635
2016-04-20 18:21:39 +02:00
Gunnar Beutner
22cf939086
Build fix for Windows
...
refs #11612
2016-04-19 14:48:13 +02:00
Gunnar Beutner
d2cd4b6667
Improve performance for locks and value conversions
...
refs #11612
2016-04-19 09:38:22 +02:00
Gunnar Beutner
c6a015e317
Fix crash in Checkable::ExecuteCheck
...
fixes #11582
2016-04-19 09:37:04 +02:00
Gunnar Beutner
ab95670833
Build fix for older boost versions
...
refs #11612
2016-04-18 17:21:45 +02:00
Gunnar Beutner
3008d5ef31
Improve performance for field accesses
...
fixes #11612
2016-04-18 17:05:22 +02:00
Gunnar Beutner
955df528d7
Fix error message for the EventEngine variable
...
refs #11522
2016-04-18 15:02:02 +02:00
Gunnar Beutner
d8b0502d67
Make the socket event engine configurable
...
fixes #11522
2016-04-18 14:38:59 +02:00
Gunnar Beutner
09165e5ca6
Only hide navigational attributes which are not config/state
...
fixes #11567
2016-04-13 12:02:08 +02:00
Gunnar Beutner
974ca9f38b
Fix crash in Downtime::DowntimesExpireTimerHandler
...
fixes #11534
fixes #11559
2016-04-12 12:05:43 +02:00
Marius Sturm
15cb9c1c1a
Use check_result timestamp for GELF log messages
...
fixes #9184
Signed-off-by: Michael Friedrich <michael.friedrich@netways.de>
2016-04-11 14:48:16 +02:00
Michael Friedrich
2b2e250def
Implement support for overriding check command timeout
...
fixes #9283
2016-04-07 15:07:17 +02:00
Michael Friedrich
d2f5008557
API: Ensure that empty passwords w/ client_cn are properly checked
...
fixes #11482
2016-04-04 16:38:47 +02:00
Gunnar Beutner
327d12295c
Implement support for upgrading NSIS-based installations
...
refs #11449
2016-04-01 08:42:58 +02:00
Gunnar Beutner
6bf3225e84
Implement support for running custom install/uninstall actions
...
refs #11449
2016-03-31 14:53:54 +02:00
Michael Friedrich
027a23f468
Fix: Overwriting global type variables causes crash in ConfigItem::Commit()
...
fixes #11484
2016-03-31 11:43:16 +02:00
Michael Friedrich
83e0bcddce
IDO: Ensure that the notification insert id is passed to contactnotification inserts
...
We cannot add the notification insert id directly
to the following contactnotifications queries. Instead
we need to pass a DbValue reference which gets set after
the notification insert id is calculated.
The contactnotifications insert queries are fired as query
group calling CanExecuteQuery() and FieldToEscapedString().
If the notification id does not exist yet, the queries are
moved to the end of the queue.
Once the contactnotifications queries are fired the DbValue
reference is destroyed.
This patch also removes the old notification insert id cache
which was broken in many ways.
fixes #11387
2016-03-29 15:12:24 +02:00
Gunnar Beutner
112f024810
Build fix for GCC
...
refs #9839
2016-03-29 14:52:48 +02:00
Michael Friedrich
5dd685cef9
Fix socket exceptions while querying the API
...
fixes #11224
2016-03-29 13:52:37 +02:00
Gunnar Beutner
eb0892273e
Implement the DateTime class
...
fixes #9839
2016-03-29 13:27:20 +02:00
Michael Friedrich
12dadfdfb3
Fix: Downtimes/Comments not being synced to child zones
...
fixes #11227
2016-03-29 12:09:51 +02:00
Gunnar Beutner
016f47d6e6
Fix Utility::MkDirP on Windows
...
fixes #11455
2016-03-29 09:44:05 +02:00
Gunnar Beutner
796884343b
Another build fix for Win64
...
refs #11462
2016-03-29 08:42:02 +02:00
Gunnar Beutner
b863a84471
Build fix for Win64
...
refs #11462
2016-03-29 07:54:41 +02:00
Gunnar Beutner
5de9a988d9
Improve validation for arrays
...
fixes #11434
2016-03-24 09:15:39 +01:00
Michael Friedrich
0447e81d99
Ensure that the legacy_id attribute for comment/downtime objects is restored on restart
...
This has been changed when moving comments/downtimes to config objects
in 050c520b2a
It may cause trouble with DB IDO DELETE and UPDATE statements
depending on the old value.
refs #11382
2016-03-23 14:05:09 +01:00
Michael Friedrich
98e1d70dab
DB IDO: Fix that downtime is not in effect after restart
...
fixes #10843
2016-03-23 13:42:00 +01:00
Gunnar Beutner
0e18acbf9d
Don't use semi-colons in auto-generated config files
...
fixes #11438
2016-03-23 09:29:27 +01:00
Gunnar Beutner
b621b00e3a
Detect infinite recursion in the zone hierarchy graph
...
fixes #10937
2016-03-23 09:03:53 +01:00
Gunnar Beutner
6ba0c5fe01
Implement recursion limit for AST expressions which don't use a separate stack frame
...
fixes #11106
2016-03-23 09:03:49 +01:00
Gunnar Beutner
71060be89a
Follow symlinks in Utility::GlobRecursive
...
fixes #11347
2016-03-22 08:22:11 +01:00
Michael Friedrich
67b7df3189
DB IDO: Fix user notification type filters
...
fixes #10766
2016-03-15 14:50:43 +01:00
Michael Friedrich
a30cb86ca1
Only call UpdateNextCheck() for soft states
...
refs #11336
2016-03-15 14:02:19 +01:00
Michael Friedrich
d682f56c38
Use UpdateNextCheck() for determining the retry_interval in ProcessCheckResult()
...
This patch also moves the next check updates for passive
check results into ProcessCheckResult(). That way the
next check status updates for DB IDO work in a sane way
again.
refs #11336
2016-03-15 13:02:38 +01:00
Michael Friedrich
3bd6848763
Refactor patch for host recovery notifications
...
refs #10225
2016-03-15 09:47:59 +01:00
Gunnar Beutner
4066ab730a
Fix error handling for FeatureUtility::GetFeatures
...
fixes #11349
2016-03-14 08:45:12 +01:00
Gunnar Beutner
a8ee6b2009
Fix crash in ScheduledDowntime::TimerProc
...
fixes #11352
2016-03-14 08:37:13 +01:00
Michael Friedrich
4746b214d6
Fix: Common name in node wizard isn't case sensitive
...
fixes #11159
2016-03-11 14:22:24 +01:00
Michael Friedrich
3e050bd0cd
Fix: Volatile transitions from HARD NOT-OK->NOT-OK do not trigger notifications
...
fixes #11320
2016-03-11 13:19:03 +01:00
Michael Friedrich
7fb8bcd933
Use retry_interval on first OK -> NOT-OK state change
...
Only valid for active check results. The API actions were
missing that marker similar to the external command processor.
The initial OK -> NOT-OK transition should use the retry_interval
but nothing else.
fixes #11336
2016-03-11 12:00:30 +01:00
Michael Friedrich
5b6a6f86b1
Fix host recovery notifications for warning states
...
fixes #10225
2016-03-11 09:29:07 +01:00
Michael Friedrich
65cbf04454
Fix: MkDirP supports '/' and '\' on Windows
...
fixes #10231
2016-03-07 09:22:07 +01:00
Julian Brost
7439633965
Fix max number of args for DEL_DOWNTIME_BY_HOST_NAME
...
The RegisterCommand call for DEL_DOWNTIME_BY_HOST_NAME was missing the
max args parameter. This prevented the optional service name, start time
and comment arguments to be passed.
Signed-off-by: Michael Friedrich <michael.friedrich@netways.de>
fixes #11240
2016-03-05 18:43:02 +01:00
Michael Friedrich
ef532f20eb
Revert "Fix check scheduling w/ retry_interval"
...
This reverts commit a51e647cc7
.
This patch causes trouble with check results received
1) passively 2) throughout the cluster. A proper patch
for setting the retry_interval on NOT-OK state changes
is required.
refs #11248
refs #11257
refs #11273
(the old issue)
refs #7287
2016-03-05 18:16:49 +01:00
Michael Friedrich
b8e3d61820
Revert "Properly set the next check time for active and passive checks"
...
This reverts commit 2a11b27972
.
This patch does not properly work and breaks the check_interval setting
for passive checks. Requires a proper patch.
refs #11248
refs #11257
refs #11273
(the old issue)
refs #7287
2016-03-05 18:15:03 +01:00
Tobias von der Krone
ce3062904f
Use the server's preferred cipher for the API connection
...
When using SSL_OP_CIPHER_SERVER_PREFERENCE the server's preferred cipher
is used instead of the client preference, see
https://www.openssl.org/docs/manmaster/ssl/SSL_CTX_set_options.html
fixes #11290
2016-03-04 14:57:06 +01:00
Michael Friedrich
d14477c242
Fix MkDirP() on Windows
...
fixes #10231
2016-03-03 15:54:35 +01:00
Gunnar Beutner
47521904c1
Attempt to fix race condition problem with epoll_ctl()
...
refs #11289
2016-03-03 13:38:13 +01:00
Jean Flach
9cdea730a3
Fix delete object handler returning incorrect status codes
...
Now a 200 OK only gets returned if all objects could be deleted
fixes #10770
2016-03-01 16:53:52 +01:00
Vytenis Darulis
6729679f38
Try to queue all PROCESS_FILE commands instead of exploding the stack
...
fixes #10426
Signed-off-by: Michael Friedrich <michael.friedrich@netways.de>
2016-02-24 23:25:22 +01:00
Michael Friedrich
894aaaecb1
Ensure that config files are readable by the daemon
...
refs #11212
refs #11211
2016-02-24 14:24:08 +01:00
Michael Friedrich
47c5425137
Fix permissions for temporary files
...
fixes #11212
fixes #11211
2016-02-24 11:00:44 +01:00
Michael Friedrich
272d9541be
Fix wrong log message in 'node setup' cli command
...
fixes #11209
2016-02-23 16:55:45 +01:00
Sebastian Chrostek
83845e609e
Fix problem notifications while flapping is active
...
fixes #9969
fixes #9642
2016-02-23 16:27:22 +01:00
Michael Friedrich
4cb5b97e52
Fix unique creation of temp files
...
fixes #10948
2016-02-23 12:30:59 +01:00
Gunnar Beutner
74d1d68893
Fix: "node setup" tries to chown() files before they're created
...
fixes #11204
2016-02-23 08:42:05 +01:00
Michael Friedrich
5b30c9ed2c
DB IDO: PArtially revert change for *group_members
...
Otherwise the index breaks.
refs #11103
2016-02-22 20:23:18 +01:00
Gunnar Beutner
bc6d82c560
Build fix for CentOS 5
...
fixes #11179
2016-02-22 08:12:35 +01:00
Gunnar Beutner
9a8458fd67
Rename the IOTHREADS macro
...
refs #11014
2016-02-16 13:30:55 +01:00
Michael Friedrich
04a4049a4d
Increase query queue size for testing
...
refs #10963
2016-02-12 14:15:24 +01:00