Commit Graph

137 Commits

Author SHA1 Message Date
Gunnar Beutner 75e2473616 Clean up source lists in the CMakeLists.txt files 2018-01-03 11:47:46 +01:00
Gunnar Beutner 90496b5456 Build libraries as static libraries 2018-01-02 23:29:48 +01:00
Michael Insel 158ae2188e Change copyright header for 2018 2018-01-02 12:08:55 +01:00
Michael Insel 3171b9548b Fix check_swap build error 2017-12-21 19:13:48 +01:00
Jean Flach 2636e6a77a Whitespace fix
What does this change?
* Remove use of spaces for formatting
These could be found by using `grep -r -l -P '^\t+ +[^*]'
* Removal of training whitespaces
* A few lines longer than 120 chars
2017-12-20 14:53:52 +01:00
Gunnar Beutner 1bf12c9685
Merge pull request #5857 from Icinga/fix/compiler-warnings
Fix compiler warnings
2017-12-14 13:49:25 +01:00
Jean Flach 55aca4f3e5 Fix check_service returning Warning instead of Critical
fixes #5849
2017-12-14 11:22:43 +01:00
Gunnar Beutner 3c5af89d5f Fix compiler warnings 2017-12-14 09:15:37 +01:00
Gunnar Beutner 42744fde5b Remove extraneous whitespace 2017-12-14 08:50:09 +01:00
Gunnar Beutner 50b2d0ca72 Fix incorrect format strings 2017-12-14 08:50:09 +01:00
Gunnar Beutner 96e214221d Remove unused variables 2017-12-14 08:50:09 +01:00
Jean Flach 5af5d38c26 Replace boost foreach and bind
fixes #5821
2017-12-12 13:29:50 +01:00
Gunnar Beutner 6d09efc907 Use std::shared_ptr instead of boost::shared_ptr 2017-11-30 17:41:00 +01:00
Gunnar Beutner f3c825cb86
Merge pull request #5803 from Icinga/feature/cxx11-std-bind
Replace boost::bind/boost::function with std::bind/std::function
2017-11-29 08:28:44 +01:00
Gunnar Beutner 858873b940 Replace boost::bind/boost::function with std::bind/std::function 2017-11-27 15:15:11 +01:00
Jean Flach d1d1c2e2e8 Make --perf-syntax also change short message
refs #5418
2017-11-08 17:05:43 +01:00
Jean Flach 61a9eb13c1 Fix check_service not working with names
This change fixes check_service not working correctly when using
descriptions instead of names.
This should probably be in 2.8.0
2017-11-07 17:47:35 +01:00
Adam James ec28c56943 check_nscp_api: Allow arguments containing spaces 2017-08-30 17:07:11 +01:00
Jean Flach 3427aca7d2 Merge pull request #5435 from Icinga/feature/3891-service-description
Add -d option to check_service
2017-08-07 11:36:20 +02:00
Jean Flach 94f58f2c2e Add -d option to check_service 2017-07-26 17:02:18 +02:00
Jean Flach ba35e6cace Add ITL and documentation for new parameter 2017-07-24 10:14:15 +02:00
Jean Flach 1dc93d8910 Refactor code
refs #5421
2017-07-24 09:53:25 +02:00
mcktr 17866475ff Refactored code to add feature to check used space for check_disk 2017-07-20 19:16:42 +02:00
Michael Friedrich 6036ec20f5 Build fix for Debian Wheezy
fixes #5350
2017-06-16 16:57:05 +02:00
Jean Flach 39c24e9ec9 Add check_nscp_api plugin for NSClient++ API checks
refs #4721
2017-06-13 21:17:16 +02:00
Jean Flach 2932651b64 Fix incorrect state in check_ping
fixes #5223
2017-05-04 09:39:46 +02:00
Andreas Scherbaum 775bee8fe1 Replace http:// links with https:// links where a secure website exists
Leave out tests and third party tools, and license strings

fixes #5151

Signed-off-by: Michael Friedrich <michael.friedrich@icinga.com>
2017-04-20 11:33:27 +02:00
Jean Flach c3b0051360 Add --perf-syntax option to check_perfmon
fixes #4896
2017-02-20 09:22:58 +01:00
Michael Friedrich b7caf0820d Ensure that *.icinga.com is used everywhere
fixes #13897
fixes #13277
2017-01-10 17:19:12 +01:00
Jean Flach eabb54eab6 Spell ISATAP correctly and set noisatap in the ITL
refs #12155
2016-09-28 11:26:08 +02:00
Matthias Schales 8c35c821c6 Update perfdata; Add skipping of isatap interfaces with parameter
Also updates interface names to fix perfdata output

refs #12155
2016-09-28 11:20:42 +02:00
Jean Flach 0d71be774e Fail if perfdata is corrupted
Could not reproduce this myself, so no way to test

fixes #11604
2016-09-26 17:12:37 +02:00
Jean Flach abd99efae7 Add hostname support for check_ping
ipv6 resolving has not been tested thoroughly

fixes #9831
2016-09-12 17:55:14 +02:00
Jean Flach adad7180e0 Fix performance output of check_perfmon
fixes #10489
refs #12679
2016-09-08 16:57:59 +02:00
Jean Flach 3e7b943e36 Fix fmt-countertype in check_perfmon
All three options are now working as expected

fixes #10487
2016-09-08 16:37:09 +02:00
Per von Zweigbergk 5c18c1ed2d Fixed precision for percentage calculations with large units
The check_memory and check_swap plugins on Windows were incorrectly
rounding the memory/swap measurements to the nearest unit prior to
calculating a percentage. This was causing imprecise percentage
values when the unit selected meant that the values in question had
few significant figures.

fixes #10497

Signed-off-by: Jean Flach <jean-marcel.flach@netways.de>
2016-02-19 11:30:12 +01:00
Gunnar Beutner 599929b0f6 Update copyright headers for 2016 2016-01-12 08:29:59 +01:00
Per von Zweigbergk aa7ad721c7 Change B/s unit to B to comply with Nagios plugin spec
Unfortunately B/s is not a valid unit in the Nagios plugin specification. As a bit of a sad workaround, we set the unit to B, which is technically incorrect, but we can't really do much about that without amending the spec...

fixes #10544

Signed-off-by: Jean Flach <jean-marcel.flach@netways.de>
2016-01-05 15:18:34 +01:00
Per von Zweigbergk 370a1127e9 Fixed invalid quoting for network device names
Quoting needs to be with single quotes, not double quotes. Also single quotes need to be escaped.

refs #10544

Signed-off-by: Jean Flach <jean-marcel.flach@netways.de>
2016-01-05 15:18:22 +01:00
Michael Friedrich f7b5aa33ce Fix a couple of wrong white spaces 2015-09-18 13:04:09 +02:00
Gunnar Beutner 4fcb668b79 Ignore -W and -K arguments for check_disk on Windows
fixes #9913
2015-08-15 10:26:43 +02:00
Jean Flach c1bd76d759 Fix bug where -p was ignored
refs #9637
2015-07-16 13:07:19 +02:00
Jean Flach b182cf869e Remove thresholds from check_service.exe
They didn't make any sense anyways

fixes #9320
2015-06-23 13:37:13 +02:00
Jean Flach 21e072332c Add path exclusion to check_disk.exe
Also do some refactoring and make -m do something

fixes #9201
2015-06-23 13:15:55 +02:00
Jean Flach 88f004a356 Decide state based on single drives
fixes #9197
2015-06-23 13:14:27 +02:00
Jean Flach 3d7c2c2270 Add check_perfmon 2015-03-23 13:09:29 +01:00
Jean Flach 56f92f7846 Refactor plugin code 2015-03-23 13:07:02 +01:00
Jean Flach 62b2bae6b6 Update Window plugins' usage strings 2015-03-06 12:14:09 +01:00
Gunnar Beutner c426655c44 Remove redundant checks in check_service 2015-03-02 13:23:26 +01:00
Gunnar Beutner 3087be2567 Remove redundant checks in check_procs 2015-03-02 13:22:37 +01:00
Gunnar Beutner daaa446f58 Remove redundant check 2015-03-02 13:21:06 +01:00
Paul Richards 7ca3a3c5e9 Fix: check_memory tool shows incorrect memory size on windows
On a PC with >4GB of RAM, check_memory utility returns
an incorrect amount of RAM:

MEMORY OK - 100% free | memory=4096MB;;;0;4096

This patch uses GlobalMemoryStatusEx instead of GlobalMemoryStatus
[https://msdn.microsoft.com/en-us/library/windows/desktop/aa366586%28v=vs.85%29.aspx]

Following patch output of check_memory is as follows:

MEMORY OK - 32.4873% free | memory=5312MB;;;0;16351

fixes #8559

Signed-off-by: Gunnar Beutner <gunnar@beutner.name>
2015-03-01 22:29:54 +01:00
Jean-Marcel Flach 3f9ce38fd0 Fix whitespace 2015-02-27 15:13:07 +01:00
Jean Flach 377f66c403 Add some failsafes to the windows plugins 2015-02-17 15:54:23 +01:00
Jean Flach b7e991b1cc Improve check_service' reporting and performance
fixes #8186
2015-02-17 15:20:30 +01:00
Gunnar Beutner 0913a96460 Ignore the -X option for check_disk (on Windows)
fixes #8405
2015-02-10 09:46:24 +01:00
Jean Flach 04dbab2eac Fix output of check_ping 2015-02-09 09:03:03 +01:00
Jean Flach acff66875d Add check_memory, update check_swap, thresholds
Adds check_memory which works like check_swap which has been updated to work like check_memory
Both sport a -u(nit) option with MB as default, like their linux versions.
A possible bug with all plugins having the -u(nit) option when using -u kB has been fixed. Don't use icinga to monitor you commodore though.

refs #8287 #8060
2015-02-03 10:22:09 +01:00
Jean Flach 25f2636a77 Fix check_swap returning wrong status without thresholds. 2015-02-02 15:11:11 +01:00
Jean Flach 0e7b8d16e2 Fix check_uptime faulty behavior when using -u
fixes #8327
2015-02-02 13:30:10 +01:00
Jean Flach 4771f79f35 Change how check_swap works and a debug line in check_disk
check_swap should now be faster and more accurate, it also checks against free space instead of taken swap.
The output and CMakeLists have been updated accordingly.

fixes #8287 refs #8060
2015-02-02 11:21:44 +01:00
Jean Flach 9791a8b279 Fix check_network.exe always returning warning
fixes #8306
2015-02-02 09:21:46 +01:00
Jean Flach a4bfa99552 Change plugins output and update README
In their perfdata the plugins will now use absolute values for percentage thresholds.
Also the check_disks output is now more similar to the one of nagios/check_disk.
The README has also been improved.

refs #7886 #8060
2015-01-23 16:34:16 +01:00
Michael Friedrich 78bfd0204c Update copyright year 2015-01-22 12:00:23 +01:00
Tobias von der Krone 462d854d33 Fix typos in readme file for windows plugins
fixes #8223
2015-01-15 12:03:49 +01:00
Jean Flach 40cba8eb5d Fix another case where debug lines were displayed 2015-01-13 09:51:49 +01:00
Jean Flach fd6cdbbc01 Fix a debug line being displayed in non-debug mode 2015-01-13 09:41:53 +01:00
Jean Flach c11f2d5ca2 Add -d/--debug option for windows plugins
#fixes 8119
2015-01-12 15:53:25 +01:00
Jean Flach 844defd362 Update check_service help
fixes #8143
2015-01-09 13:20:22 +01:00
Jean Flach 2e9944f4bd Change some things up in the windows-plugins
refs #7886 #7778 #8060 #8115
2014-12-19 10:21:38 +01:00
Jean Flach 23acc2408d Fix a compiler warning
fixes #8114
2014-12-19 09:36:59 +01:00
Jean Flach 8f7d3a29cc Add files needed by last commit 2014-12-17 14:23:20 +01:00
Jean Flach 300dcbec79 Add windows-plugin check_ping
fixes #7879
2014-12-17 14:19:46 +01:00
Jean Flach a59bcdc26c Fix major bugs in windows plugins check_load and check_service
fixes #7881 #7992
2014-12-09 15:38:23 +01:00
Gunnar Beutner 023cfc15bb Some minor plugin fixes 2014-11-19 06:40:58 +01:00
Jean Flach 0054e78a58 Use <reinterpret_cast>() 2014-11-14 16:26:30 +01:00
Jean Flach e1b5954e62 Clean up check plugins more 2014-11-14 14:36:10 +01:00
Jean Flach 616716dc55 Clean up check plugins.
fixes #7670 #7669
2014-11-14 13:57:54 +01:00
Jean Flach 3d52acfe5d Clean up check_services
fixes #7666 #7665 #7664
2014-11-14 13:54:29 +01:00
Jean Flach 8557293ac4 Clean up check_procs
fixes #7667
2014-11-14 13:15:32 +01:00
Jean Flach e187f405d9 Improve readability and output of check_network
fixes #7668
2014-11-14 13:09:04 +01:00
Gunnar Beutner 979b99ea6f Build fix for the Windows plugins 2014-11-13 20:12:24 +01:00
Jean Flach f85be08480 Improve check argument parsing 2014-11-13 15:57:10 +01:00
Jean Flach 22e3e48669 Fix check_plugins dying with certain parameters 2014-11-10 14:39:12 +01:00
Jean Flach 70a28c05b3 Clean up plugins/CMakeLists.txt 2014-11-07 13:56:14 +01:00
Jean Flach 83e6fb3083 Make check plugins decent
fixes #7242
2014-11-06 16:36:42 +01:00
Jean Flach ea8fd12a07 Add Windows plugins
refs #7242
2014-11-06 15:17:08 +01:00