Michael Friedrich
bc05389a79
Improve error handling for unlinking files
...
refs #10578
2015-11-09 13:35:51 +01:00
Gunnar Beutner
25c490ecb6
Remove config file when object creation fails
...
fixes #10578
2015-11-09 12:33:37 +01:00
Gunnar Beutner
c44701068f
Fix: Detailed error message is missing when object creation via API fails
...
fixes #10580
2015-11-09 12:30:30 +01:00
Gunnar Beutner
679983dd9a
Rename $quit to $continue
...
refs #10559
2015-11-09 11:08:35 +01:00
Gunnar Beutner
fa034a96f8
Improve error message for 404s
...
refs #9447
2015-11-09 10:48:24 +01:00
Gunnar Beutner
5a74f69819
Fix memory leak for JSON-RPC/HTTP connections
...
fixes #10517
2015-11-09 10:22:52 +01:00
Gunnar Beutner
4bb9beda19
Don't send cluster config messages for objects with version 0
...
refs #9927
2015-11-08 21:22:06 +01:00
Gunnar Beutner
f8399e45db
Remove unused variable
...
refs #10563
2015-11-08 17:53:22 +01:00
Michael Friedrich
1d2606cbfe
Add filter targets for remove-{comment,downtime} actions
...
Drop remove-all-{comments,downtimes}. This is provided
by using host and service filters.
fixes #10561
2015-11-08 14:22:10 +01:00
Michael Friedrich
b7f923dd01
'api setup' must not override existing certificate and api-users.conf file
...
fixes #10560
2015-11-08 14:19:06 +01:00
Michael Friedrich
e6159ca86a
Fix: /v1/console should only use a single permission
...
fixes #10563
2015-11-08 14:17:13 +01:00
Michael Friedrich
1c8531fc0d
Fix: 'api setup' should create a user even when api feature is already enabled
...
fixes #10560
2015-11-08 14:06:36 +01:00
Gunnar Beutner
9830ea6ea7
Remove duplicate text in an error message
...
refs #10559
2015-11-07 10:31:09 +01:00
Gunnar Beutner
2c135d82c1
Fix incorrect variable names for joined objects in filters
...
fixes #10558
2015-11-07 10:28:34 +01:00
Gunnar Beutner
dcfc171c61
Improve messages for the debugger
...
refs #10559
2015-11-07 10:22:55 +01:00
Gunnar Beutner
a6c411c6cb
Fix: Autocompletion doesn't work in the debugger
...
fixes #10559
2015-11-07 10:17:55 +01:00
Gunnar Beutner
b89a7dbdb6
Rename 'object' to 'obj' in filters
...
refs #9077
2015-11-07 10:01:07 +01:00
Gunnar Beutner
64376dafeb
Make the main object available as 'object' in filter expressions
...
refs #9077
2015-11-07 09:59:00 +01:00
Gunnar Beutner
3a695742e3
Improve error handling when user specifies invalid method for /v1/console
...
refs #10387
2015-11-07 09:59:00 +01:00
Gunnar Beutner
d78a081727
Improve performance data for DB IDO
...
refs #9079
2015-11-07 07:51:41 +01:00
Michael Friedrich
64c936d387
API Actions: Remove -by-id from actions and require names for comments and downtimes
...
The documentation is updated as well. Furthermore actions provide
detailed error information in case of an exception.
Includes DB IDO schema updates.
fixes #10512
2015-11-06 17:06:12 +01:00
Gunnar Beutner
a177e5e05a
Change output format for object queries
...
fixes #10551
2015-11-06 14:45:38 +01:00
Michael Friedrich
3b902b51e2
Change session_token to integer timestamp
...
fixes #10529
2015-11-05 18:05:30 +01:00
Michael Friedrich
dda05f0322
Fix: Async mysql queries aren't logged in the debug log
...
fixes #10540
2015-11-05 15:43:09 +01:00
Michael Friedrich
7e5f5544fc
Require 'Accept' header for API requests (except for GET)
...
fixes #10548
2015-11-05 15:18:53 +01:00
Gunnar Beutner
7621870278
Implement a debugger for Icinga scripts
...
fixes #10547
2015-11-05 14:29:45 +01:00
Michael Friedrich
18e162da5e
Build fix
...
refs #10545
2015-11-05 11:55:07 +01:00
Gunnar Beutner
645f054980
Fix invalid field IDs in Type::GetField
...
refs #10387
2015-11-05 10:58:09 +01:00
Gunnar Beutner
783b58536f
Fix 'Invalid field ID' error when serializing Type objects
...
refs #10387
2015-11-05 10:52:25 +01:00
Gunnar Beutner
701961b73b
Fix the 'type' attribute for the Object class
...
refs #10387
2015-11-05 10:29:02 +01:00
Gunnar Beutner
a3fd33f8a1
Fix race condition in ConfigWriter::EmitIdentifier
...
fixes #10538
2015-11-04 19:05:47 +01:00
Gunnar Beutner
09b2b054f5
Don't validate custom attributes that aren't strings
...
fixes #10539
2015-11-04 19:04:33 +01:00
Gunnar Beutner
fe1c5e9507
Improve formatting for arrays
...
refs #10527
2015-11-04 17:06:33 +01:00
Gunnar Beutner
7378964f31
Fix indentation for nested dictionaries
...
refs #10527
2015-11-04 16:42:19 +01:00
Michael Friedrich
5d46f661ea
Implement 'console' cli command using the API
...
fixes #10387
2015-11-04 16:01:06 +01:00
Gunnar Beutner
a51bc4010a
Fix indentation for Dictionary::ToString
...
fixes #10527
2015-11-04 08:44:56 +01:00
Gunnar Beutner
51f473d08a
Implement the current_filename and current_line keywords
...
fixes #10243
2015-11-03 16:34:34 +01:00
Gunnar Beutner
ae23e456a6
Fix race condition in ConfigWriter::GetKeywords
...
fixes #10518
2015-11-03 09:46:45 +01:00
Gunnar Beutner
9c5758958c
Fix crash in JsonRpcClient::DataAvailableHandler
...
fixes #10495
2015-11-02 17:45:44 +01:00
Michael Friedrich
7589c61b38
Add missing override
...
refs #10508
refs #10509
2015-11-02 17:36:13 +01:00
Michael Friedrich
43976d3989
Add host.last_state_{up,down} and last_check attribute, hide *_raw attributes
...
fixes #10508
fixes #10509
2015-11-02 14:10:44 +01:00
Michael Friedrich
439dad5d6a
API actions: Check if removal of comments and downtimes was succesful
...
refs #9080
2015-11-01 16:33:43 +01:00
Gunnar Beutner
ed90d9a847
Fix race condition in CreatePipeOverlapped
...
fixes #10510
2015-11-01 12:59:57 +01:00
Gunnar Beutner
b2829ca522
Fix plural name for the Array type
...
fixes #10501
2015-11-01 10:35:31 +01:00
Michael Friedrich
1b9f0a8c77
Add the unique_id for comments/downtimes next to legacy_id to DB IDO
...
fixes #10431
2015-10-30 11:25:07 +01:00
Michael Friedrich
339c0b6d84
Fix missing field initializer in DB IDO
...
refs #10436
2015-10-29 22:27:09 +01:00
Michael Friedrich
6f8e25a349
Add doc URL to /v1 info page
...
refs #9105
2015-10-29 18:59:30 +01:00
Michael Friedrich
4d784dd075
DB IDO: Add an index for CV session delete
...
The DELETE statement might become painfully slow on
large installations.
refs #10436
2015-10-29 16:18:49 +01:00
Michael Friedrich
9485938d32
Fix: Unique constraint violation with multiple comment inserts in DB IDO
...
fixes #10491
2015-10-29 16:12:53 +01:00
Michael Friedrich
cf5735e3df
DB IDO: Remove deleted custom variables
...
We cannot clear the custom variable tables on startup and then re-insert
all known custom vars. Instead we "fixed" it by leaving them
in the database only updating their value if changed. We certainly
forgot about deleted custom vars at that point.
Since the older fix must stay in place, we'll use a session
token stored in the backend to check whether the custom
variable has been updated/inserted in the current session, or not.
If the session token does not match, the custom vars are deleted
at the end of the config dump. Ugly but fairly the only performant
solution as CVs don't have an object_id.
fixes #10436
2015-10-29 16:00:06 +01:00
Gunnar Beutner
e3efe208bb
Fix spelling mistake in 'node wizard'
2015-10-29 08:14:56 +01:00
Gunnar Beutner
15addb4e7c
Use the correct zone name for parent_zone when running 'icinga2 node update-config'
...
fixes #10479
2015-10-29 08:14:55 +01:00
Gunnar Beutner
0013d26425
Build fix for Windows
...
refs #9777
2015-10-29 08:14:55 +01:00
Gunnar Beutner
050c520b2a
Convert Comment/Downtime to config objects
...
fixes #9777
2015-10-28 17:56:29 +01:00
Michael Friedrich
de8aae90e4
DB IDO: Add object_id where clause for icinga_downtimehistory
...
fixes #10110
2015-10-28 17:12:23 +01:00
Gunnar Beutner
5ad0c67485
Fix: IDO tries to execute empty UPDATE queries
...
fixes #10473
2015-10-28 07:46:04 +01:00
Gunnar Beutner
4763dea571
Fix incorrect URL check in the InfoHandler class
...
refs #9105
2015-10-28 07:46:04 +01:00
Jean Flach
edfc0e3a38
Update error messages
...
Removes verboseError from httprequest and uses
HttpUtility::GetLastParameter() instead to find out whether verbose
errors are enabled. Also parsing an invalid URL will now not lead to a
stacktrace anymore.
refs #10194
2015-10-27 15:26:19 +01:00
Jean Flach
2fc042e231
Update API actions and documentation
...
refs #9080 #9105
2015-10-27 14:15:07 +01:00
Gunnar Beutner
23330150f4
Fix invalid delete in IndexerExpression::GetReference
...
fixes #10466
2015-10-26 18:01:39 +01:00
Gunnar Beutner
1ec20a1e8d
Fix: Line continuation is broken in 'icinga2 console'
...
fixes #10461
2015-10-26 13:04:03 +01:00
Gunnar Beutner
dd77863910
Implement Array::ToString and Dictionary::ToString
...
fixes #10329
2015-10-26 11:05:24 +01:00
Gunnar Beutner
de847d0b6f
Don't allow scripts to access FANoUserView attributes in sandbox mode
...
fixes #10457
2015-10-26 10:41:00 +01:00
Gunnar Beutner
13375d74fc
Fix: Changing a group's attributes causes duplicate rows in the icinga_*group_members table
...
fixes #10422
2015-10-26 09:36:13 +01:00
Mhd Sulhan
977d94839b
CLI: Hide "Command options" if command is null
...
Before this commit, if icinga2 command executed without any argument,
the program will print empty "Command options".
While at it, clean the whitespaces.
fixes #10439
Signed-off-by: Gunnar Beutner <gunnar@beutner.name>
2015-10-26 08:05:09 +01:00
Gunnar Beutner
618e031f46
Handle exceptions for NetString::WriteStringToStream in ApiListener::ReplayLog
...
fixes #10455
2015-10-26 07:56:58 +01:00
Gunnar Beutner
12015e0eca
Clean up the 'api setup' command a bit more
...
refs #9471
2015-10-26 07:03:41 +01:00
Gunnar Beutner
b72ba2b63a
Fix incorrect return value for ApiSetupUtility::SetupMaster
...
refs #9471
2015-10-25 19:57:57 +01:00
Gunnar Beutner
fd2cd7a3a5
Use operator[] instead of insert() for Dictionary::Set
...
refs #10428
2015-10-23 06:19:46 +02:00
Gunnar Beutner
f31837a6ba
Clean up the 'api setup' command
...
refs #9471
2015-10-22 16:03:26 +02:00
Michael Friedrich
d618762dad
Export original attributes in DB IDO and Livestatus
...
fixes #10392
2015-10-22 15:49:42 +02:00
Michael Friedrich
d516d16c9a
Fix restore_attribute not working in clusters
...
fixes #10386
2015-10-22 14:50:43 +02:00
Gunnar Beutner
1b8fd9637f
Add redirect for /
...
refs #9105
2015-10-22 13:29:31 +02:00
Gunnar Beutner
10bd3ed9b7
Implement URL handler for /v1
...
refs #9105
2015-10-22 12:15:32 +02:00
Jean Flach
be320b2f77
Update API actions
...
fixes #10180
refs #9080
2015-10-22 11:33:26 +02:00
Gunnar Beutner
4aa0165701
Add getter for endpoint 'connected' attribute
...
fixes #10394
2015-10-22 10:52:38 +02:00
Gunnar Beutner
3473731034
Remove api.cpp and api.hpp
...
fixes #10407
2015-10-22 10:26:56 +02:00
Gunnar Beutner
74ef3e3ce6
Turn includes into AST expressions
...
fixes #10008
2015-10-22 09:46:31 +02:00
Gunnar Beutner
fd5d6de52e
Improve performance for Livestatus queries
...
refs #10428
2015-10-22 08:28:40 +02:00
Michael Friedrich
62c3607531
Fix compiler warnings
...
refs #9078
2015-10-21 15:50:32 +02:00
Michael Friedrich
cb99402766
Fix filter permissions in event streams
...
refs #9078
2015-10-21 15:38:26 +02:00
Michael Friedrich
286538c17e
Implement api event streams
...
Documentation is not yet complete.
refs #9078
2015-10-21 15:34:26 +02:00
Gunnar Beutner
e93dd3cf15
Ensure that the main thread pool gets re-initialized properly after fork()
...
refs #10410
2015-10-21 09:18:52 +02:00
Gunnar Beutner
3c6f0e31d9
Make sure the timer thread is gone when calling fork()
...
refs #10410
2015-10-20 23:02:11 +02:00
Gunnar Beutner
438210651f
Build fix for OpenBSD
2015-10-20 22:54:58 +02:00
Jean Flach
6b92c6028b
Reword nodeutility output
...
The old comment had a few minor problems:
* Two spaces after 'named'
* No space between // and the begining of the message
* Incorrect capitalization
And one major:
* Incorrectly calling a zone a node
But all of this is subject to change through the use of the configwriter
anyways.
fixes #10406
2015-10-20 12:56:26 +02:00
Gunnar Beutner
d01f09f3ef
Hide internal attributes in the API
...
fixes #10393
2015-10-20 08:25:10 +02:00
Gunnar Beutner
b77c9edca0
Remove unnecessary default values
...
refs #9461
refs #8149
2015-10-20 08:06:25 +02:00
Gunnar Beutner
5aa91551a5
Improve validation for CIDR masks
...
fixes #10375
2015-10-19 10:40:48 +02:00
Michael Friedrich
f51a76e13d
Log a warning message on unauthorized http request
...
fixes #10388
2015-10-16 15:32:35 +02:00
Gunnar Beutner
a9f14f11e4
Fix query processing for Livestatus queries which use KeepAlive
...
fixes #9322
2015-10-16 15:12:05 +02:00
Michael Friedrich
ed00ab04c7
Fix OSX control sequence
...
refs #9095
2015-10-16 13:46:43 +02:00
Michael Friedrich
c3385e6e38
DB IDO should provide its connected state via /v1/status
...
fixes #10383
2015-10-16 13:02:41 +02:00
Michael Friedrich
6cc4f85c66
Disallow modify attribute for certain object attributes
...
fixes #9095
2015-10-16 12:44:08 +02:00
Michael Friedrich
498ff3c1ee
Add a debug log message for updating the program status table in DB IDO
...
fixes #10379
2015-10-15 18:43:30 +02:00
Michael Friedrich
10c306673d
Fix wrong connection log message for global zones
...
fixes #10377
2015-10-15 17:15:19 +02:00
Michael Friedrich
934fb64b9e
Fix log message formatting for object version
...
refs #10355
2015-10-15 16:52:49 +02:00
Michael Friedrich
8ebf087772
Improve error message for socket errors in Livestatus
...
fixes #10079
2015-10-15 14:58:21 +02:00
Michael Friedrich
5852a003d0
Ensure that modified attributes work with clients with local config and no zone attribute
...
fixes #10371
2015-10-15 14:05:39 +02:00
Michael Friedrich
a0631cd351
Fix wrong type for object version
...
refs #10355
2015-10-15 11:11:07 +02:00