Commit Graph

3849 Commits

Author SHA1 Message Date
Jan Beich e3ecf83bfb Explicitly use long with boost::posix_time 2018-04-16 15:39:57 +02:00
Jean Flach 08eb3ef991 Fix crash in api user command
Missing backport in support/2.8

fixes #6178
2018-03-23 12:13:41 +01:00
Michael Friedrich 1969a9071a Improve error handling for empty packages in /v1/config/packages
- If there is no package main directory, assume "empty packages".
- Catch exceptions thrown through GlobRecursive() and present a better http 500
to the user.

The packages directory tree is automatically created with the first
package creation, either from the user, or by the `_api` package.

fixes #6129
2018-03-13 11:03:02 +01:00
Gunnar Beutner ddab94feb3 Build fix 2018-03-07 09:57:08 +01:00
Jean Flach f357439485 Code style 2018-03-07 09:57:08 +01:00
Gunnar Beutner 6670024f62 Ensure that SetCorked() works properly 2018-03-06 09:35:57 +01:00
Gunnar Beutner 0b9869917f Fix incorrect argument type for JsonRpc::SendMessage 2018-03-06 09:02:05 +01:00
Jean Flach fda4faac06 Limit anonymous connections to 25 2018-03-06 08:53:52 +01:00
Noah Hilverling fdf2dc43d5 Limit JSON-RPC message size 2018-03-06 08:53:14 +01:00
Gunnar Beutner 622127276b Fix incorrect HTTP content length limits 2018-02-28 14:17:17 +01:00
Gunnar Beutner 85858e6a36 Add SetCorked() calls to the JsonRpcConnection class 2018-02-28 12:57:22 +01:00
Jean Flach 8b334fe259 Use cork in tlsstream and HTTP connection 2018-02-28 12:57:22 +01:00
Jean Flach 419103b407 Add cork 2018-02-28 12:50:49 +01:00
Gunnar Beutner 6e7421eab0 Fix null ptr dereference in HttpServerConnection::ProcessMessageAsync 2018-02-28 11:54:48 +01:00
Gunnar Beutner 6400a300cd Fix incorrect return value 2018-02-28 11:53:49 +01:00
Jean Flach 952e3616e5 Fix incorrect size of request limits
refs #6103
2018-02-23 14:44:44 +01:00
Jean Flach d4b336ad20 Remove need for RunAsUser/Group
They are now read form the sysconfig file which is owned by root
2018-02-23 14:01:43 +01:00
Jean Flach c6b86680a0 Add cli tool to send signals as Icinga user
fixes #5991
2018-02-23 14:01:09 +01:00
Gunnar Beutner 492b590a29 Remove debug output in ApiUserCommand::Run 2018-02-23 13:07:56 +01:00
Gunnar Beutner ed1dd36f09 Properly escape strings in ApiUserCommand::Run 2018-02-23 13:07:56 +01:00
Jean Flach aad44dfbb2 Improve api user command
--oneline can now be used to print out only the password hash string.
This can be used to update ApiUser passwords through the API. There is
also now a validation to make use salt does not contain a '$' which
would break verification.
2018-02-23 13:07:56 +01:00
Jean Flach 2e5aedd28a Fix crash when using incorrectly formatted password hash 2018-02-23 13:07:55 +01:00
Jean Flach 6387f5442e Move new password functions into tlsutility 2018-02-23 13:06:22 +01:00
Jean Flach 6504606e23 Hash API password and comparison
fixes #4920
2018-02-23 11:23:19 +01:00
Jean Flach adc054097d Build/Merge fixes 2018-02-23 10:27:55 +01:00
Jean Flach c5b92defec Minor codestyle and doc changes 2018-02-23 10:09:28 +01:00
Noah Hilverling 4b77afedcd Limit HTTP body size 2018-02-23 10:09:28 +01:00
Noah Hilverling 3fe818b44b Fix requests not being closed correctly 2018-02-23 10:09:28 +01:00
Jean Flach 70c81734c5 Add timeout for TLS handshakes 2018-02-23 10:09:26 +01:00
Jean Flach aa1ccd7ada Authenticate API user before parsing body 2018-02-23 10:08:24 +01:00
Jean Flach a46dc64e6a Only read body from authenticated connections
This means we are not allowing unauthenticated requests anymore
2018-02-23 09:52:54 +01:00
Jean Flach e1c46cedd1 Fix nullptr deref 2018-02-23 08:34:10 +01:00
Gunnar Beutner f5f8b90ec8 Add HTTP Header size limits 2018-02-23 08:31:28 +01:00
Gunnar Beutner 0339a2b827 Add validation for HTTP connection sizes 2018-02-23 08:31:28 +01:00
Jean Flach 9de36c0999 Rename macro RequireNotNull to REQUIRE_NOT_NULL 2018-02-22 15:07:36 +01:00
Noah Hilverling 71c420d501 Fix nullptr deref in cluster events 2018-02-22 14:55:44 +01:00
Noah Hilverling 3ba5090867 Add marco RequireNotNull
This is used to fix a number of possible nullptr dereferences
2018-02-22 14:55:42 +01:00
Gunnar Beutner 5dab779df6 Fix incorrect ::Start call 2018-01-24 12:04:53 +01:00
Noah Hilverling 6dba6a0bfb Add missing string escaping
fixes #5987
2018-01-17 15:02:33 +01:00
Noah Hilverling 157358c24f Fix HTTP response parsing for HTTP 1.1
refs #5987
2018-01-17 15:02:33 +01:00
Gunnar Beutner 7f92016e38 Fix performance issues for InfluxdbWriter 2018-01-17 15:02:33 +01:00
Gunnar Beutner 680939a289 Fix incorrect socket handling for the HTTP client 2018-01-17 15:02:33 +01:00
Michael Friedrich b4a0495239 Revert "Fix performance issues for InfluxdbWriter"
This reverts commit eea451ee94.

refs #5764
2018-01-16 10:45:20 +01:00
Michael Friedrich c3fe1a6323 Revert "Fix incorrect socket handling for the HTTP client"
This reverts commit 59da943548.

refs #5760
2018-01-16 10:44:31 +01:00
Michael Friedrich 2901c77d65 Fix wrong schema constraint for fresh 2.8.0 installations
This fix is only needed for a fresh 2.8.0 setup, older versions
and upgrades to current do not need this (can be applied as idempotent
update).

fixes #5947

refs #5986
2018-01-16 10:15:38 +01:00
Michael Friedrich 1256fb3356 Revert "Fix newline terminator for bulk requests in ElasticsearchWriter"
This reverts commit 806eb0d2d2.

refs #5840
2017-12-22 09:53:56 +01:00
Gunnar Beutner 59da943548 Fix incorrect socket handling for the HTTP client 2017-12-12 11:18:09 +01:00
Gunnar Beutner eea451ee94 Fix performance issues for InfluxdbWriter 2017-12-12 10:36:45 +01:00
Michael Friedrich 806eb0d2d2 Fix newline terminator for bulk requests in ElasticsearchWriter
This enables compatibility with 6.x.

This commit also fixes an incorrect HTTP response parsing
which could lead into false positives.

Analysis and fix in https://github.com/Icinga/icinga2/issues/5795#issuecomment-349920587

fixes #5795

refs #5840
2017-12-07 17:07:44 +01:00
Sven Nierlein 9ba5f30afa livestatus: custom variables return empty arrays instead of strings
livestatus queries for custom variables should return an empty list, ex: []
instead of an empty string if there are no variables.

Signed-off-by: Sven Nierlein <sven@nierlein.de>

refs #5746
2017-12-07 13:29:11 +01:00