icinga2/test/base-string.cpp
Julian Brost 784867b3f7 Avoid undefined behavior in string/vector_move test
vec[1] is equivalent to vec[vec.size()] at that point and thus not a valid
element of the vector, making the use of operator[] undefined behavior here.
With some compiler flags (like those used in package builds on RHEL and
similar), the compiler (rightfully) aborts the program on this out of bounds
access:

     68/178 Test  #68: base-base_string/vector_move ............................................***Failed    0.01 sec
    /usr/include/c++/14/bits/stl_vector.h:1130: std::vector<_Tp, _Alloc>::reference std::vector<_Tp, _Alloc>::operator[](size_type) [with _Tp = icinga::String; _Alloc = std::allocator<icinga::String>; reference = icinga::String&; size_type = long unsigned int]: Assertion '__n < this->size()' failed.
    Running 1 test case...
    unknown location(0): fatal error: in "base_string/vector_move": signal: SIGABRT (application abort requested)
    /builds/packages/icinga2/packaging/fedora/41/BUILD/icinga2-2.14.5+467.g206d7cda1-build/icinga2-2.14.5+467.g206d7cda1/test/base-string.cpp(120): last checkpoint
    *** 1 failure is detected in the test module "icinga2"

This commit fixes this by taking the indirection through .data() and using
plain pointer arithmetic instead.
2025-03-10 09:28:33 +01:00

147 lines
3.7 KiB
C++

/* Icinga 2 | (c) 2012 Icinga GmbH | GPLv2+ */
#include "base/string.hpp"
#include "base/value.hpp"
#include <vector>
#include <BoostTestTargetConfig.h>
using namespace icinga;
BOOST_AUTO_TEST_SUITE(base_string)
BOOST_AUTO_TEST_CASE(construct)
{
BOOST_CHECK(String() == "");
BOOST_CHECK(String(5, 'n') == "nnnnn");
}
BOOST_AUTO_TEST_CASE(equal)
{
BOOST_CHECK(String("hello") == String("hello"));
BOOST_CHECK("hello" == String("hello"));
BOOST_CHECK(String("hello") == String("hello"));
BOOST_CHECK(String("hello") != String("helloworld"));
BOOST_CHECK("hello" != String("helloworld"));
BOOST_CHECK(String("hello") != "helloworld");
}
BOOST_AUTO_TEST_CASE(clear)
{
String s = "hello";
s.Clear();
BOOST_CHECK(s == "");
BOOST_CHECK(s.IsEmpty());
}
BOOST_AUTO_TEST_CASE(append)
{
String s;
s += "he";
s += String("ll");
s += 'o';
BOOST_CHECK(s == "hello");
}
BOOST_AUTO_TEST_CASE(trim)
{
String s1 = "hello";
BOOST_CHECK(s1.Trim() == "hello");
String s2 = " hello";
BOOST_CHECK(s2.Trim() == "hello");
String s3 = "hello ";
BOOST_CHECK(s3.Trim() == "hello");
String s4 = " hello ";
BOOST_CHECK(s4.Trim() == "hello");
}
BOOST_AUTO_TEST_CASE(contains)
{
String s1 = "hello world";
String s2 = "hello";
BOOST_CHECK(s1.Contains(s2));
String s3 = " hello world ";
String s4 = " hello";
BOOST_CHECK(s3.Contains(s4));
String s5 = " hello world ";
String s6 = "world ";
BOOST_CHECK(s5.Contains(s6));
}
BOOST_AUTO_TEST_CASE(replace)
{
String s = "hello";
s.Replace(0, 2, "x");
BOOST_CHECK(s == "xllo");
}
BOOST_AUTO_TEST_CASE(index)
{
String s = "hello";
BOOST_CHECK(s[0] == 'h');
s[0] = 'x';
BOOST_CHECK(s == "xello");
for (char& ch : s) {
ch = 'y';
}
BOOST_CHECK(s == "yyyyy");
}
BOOST_AUTO_TEST_CASE(find)
{
String s = "hello";
BOOST_CHECK(s.Find("ll") == 2);
BOOST_CHECK(s.FindFirstOf("xl") == 2);
}
// Check that if a std::vector<icinga::String> is grown beyond its capacity (i.e. it has to reallocate the memory),
// it uses the move constructor of icinga::String (i.e. the underlying string storage stays the same).
BOOST_AUTO_TEST_CASE(vector_move)
{
std::vector<String> vec {
// std::string (which is internally used by icinga::String) has an optimization that small strings can be
// allocated inside it instead of in a separate heap allocation. In that case, the small string would still be
// copied even by the move constructor. Using sizeof() ensures that the string is long enough so that it must
// be allocated separately and can be used to test for the desired move to happen.
std::string(sizeof(String) + 1, 'A'),
};
void *oldAddr = vec[0].GetData().data();
// Sanity check that the data buffer is actually allocated outside the icinga::String instance.
BOOST_CHECK(!(vec.data() <= oldAddr && oldAddr < vec.data() + vec.size()));
// Force the vector to grow.
vec.reserve(vec.capacity() + 1);
// If the string was moved, the location of its underlying data buffer should not have changed.
void *newAddr = vec[0].GetData().data();
BOOST_CHECK_EQUAL(oldAddr, newAddr);
}
// Test that the move constructor of icinga::String actually moves the underlying std::string out of a Value instance.
// The constructor overload is only available on non-Windows platforms though, so we need to skip the test on Windows.
BOOST_AUTO_TEST_CASE(move_string_out_of_Value_type)
{
#ifndef _MSC_VER
Value value("Icinga 2");
String other = value.Get<String>(); // We didn't request a move, so this should just copy the string.
BOOST_CHECK_EQUAL("Icinga 2", value.Get<String>());
BOOST_CHECK_EQUAL("Icinga 2", other);
String newStr = std::move(value);
BOOST_CHECK_EQUAL("", value.Get<String>());
BOOST_CHECK_EQUAL(newStr, "Icinga 2");
#endif /* _MSC_VER */
}
BOOST_AUTO_TEST_SUITE_END()