icinga2/lib/base/dictionary.hpp
Julian Brost 0ebcd2662d No longer allow overriding the frozen attribute of containers
The Array, Dictionary, and Namespace types provide a Freeze() method that makes
them read-only. So far, there was the possibility to call some methods with
`overrideFrozen=true` which would then bypass the corresponding check and allow
modification of the data structures nonetheless.

With 24b57f0d3a222835178e88489eabd595755ed883, this possibility was already
removed from the Namespace type. However, for interface compatibility, it kept
the parameter and just ignores it, throwing an exception on any modification on
a frozen instance.

The only place using `overrideFrozen` was processing of the `-D`/`--define`
command line flag that allows setting additional variables in the DSL. At the
time it is evaluated, there are no user-created data structures yet that could
be frozen, so the only frozen objects that could be encountered are Namespaces
(Icinga doesn't freeze other types by itself) and for these, `overrideFrozen`
already has no effect.

Hence, there is no harm in removing `overrideFrozen` altogether. This
simplifies the code and also means that frozen objects are now indeed read-only
without exceptions, allowing further optimizations regarding locking in the
future.
2025-07-08 14:16:20 +02:00

92 lines
2.1 KiB
C++

/* Icinga 2 | (c) 2012 Icinga GmbH | GPLv2+ */
#ifndef DICTIONARY_H
#define DICTIONARY_H
#include "base/i2-base.hpp"
#include "base/object.hpp"
#include "base/value.hpp"
#include <boost/range/iterator.hpp>
#include <map>
#include <shared_mutex>
#include <vector>
namespace icinga
{
typedef std::vector<std::pair<String, Value> > DictionaryData;
/**
* A container that holds key-value pairs.
*
* @ingroup base
*/
class Dictionary final : public Object
{
public:
DECLARE_OBJECT(Dictionary);
/**
* An iterator that can be used to iterate over dictionary elements.
*/
typedef std::map<String, Value>::iterator Iterator;
typedef std::map<String, Value>::size_type SizeType;
typedef std::map<String, Value>::value_type Pair;
Dictionary() = default;
Dictionary(const DictionaryData& other);
Dictionary(DictionaryData&& other);
Dictionary(std::initializer_list<Pair> init);
Value Get(const String& key) const;
bool Get(const String& key, Value *result) const;
const Value * GetRef(const String& key) const;
void Set(const String& key, Value value);
bool Contains(const String& key) const;
Iterator Begin();
Iterator End();
size_t GetLength() const;
void Remove(const String& key);
void Remove(Iterator it);
void Clear();
void CopyTo(const Dictionary::Ptr& dest) const;
Dictionary::Ptr ShallowClone() const;
std::vector<String> GetKeys() const;
static Object::Ptr GetPrototype();
Object::Ptr Clone() const override;
String ToString() const override;
void Freeze();
Value GetFieldByName(const String& field, bool sandboxed, const DebugInfo& debugInfo) const override;
void SetFieldByName(const String& field, const Value& value, const DebugInfo& debugInfo) override;
bool HasOwnField(const String& field) const override;
bool GetOwnField(const String& field, Value *result) const override;
private:
std::map<String, Value> m_Data; /**< The data for the dictionary. */
mutable std::shared_timed_mutex m_DataMutex;
bool m_Frozen{false};
};
Dictionary::Iterator begin(const Dictionary::Ptr& x);
Dictionary::Iterator end(const Dictionary::Ptr& x);
}
extern template class std::map<icinga::String, icinga::Value>;
#endif /* DICTIONARY_H */