mirror of
				https://github.com/Icinga/icinga2.git
				synced 2025-11-04 05:34:12 +01:00 
			
		
		
		
	Calling `AsioTlsStream::async_shutdown()` performs a TLS shutdown which exchanges messages (that's why it takes a `yield_context`) and thus has the potential to block the coroutine. Therefore, it should be protected with a timeout. As `async_shutdown()` doesn't simply take a timeout, this has to be implemented using a timer. So far, these timers are scattered throughout the codebase with some places missing them entirely. This commit adds helper functions to properly shutdown a TLS connection with a single function call.
		
			
				
	
	
		
			170 lines
		
	
	
		
			5.2 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
			
		
		
	
	
			170 lines
		
	
	
		
			5.2 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
/* Icinga 2 | (c) 2012 Icinga GmbH | GPLv2+ */
 | 
						|
 | 
						|
#include "base/tlsstream.hpp"
 | 
						|
#include "base/application.hpp"
 | 
						|
#include "base/utility.hpp"
 | 
						|
#include "base/exception.hpp"
 | 
						|
#include "base/logger.hpp"
 | 
						|
#include "base/configuration.hpp"
 | 
						|
#include "base/convert.hpp"
 | 
						|
#include "base/defer.hpp"
 | 
						|
#include "base/io-engine.hpp"
 | 
						|
#include <boost/asio/ssl/context.hpp>
 | 
						|
#include <boost/asio/ssl/verify_context.hpp>
 | 
						|
#include <boost/asio/ssl/verify_mode.hpp>
 | 
						|
#include <iostream>
 | 
						|
#include <openssl/ssl.h>
 | 
						|
#include <openssl/tls1.h>
 | 
						|
#include <openssl/x509.h>
 | 
						|
#include <sstream>
 | 
						|
 | 
						|
using namespace icinga;
 | 
						|
 | 
						|
/**
 | 
						|
 * Checks whether the TLS handshake was completed with a valid peer certificate.
 | 
						|
 *
 | 
						|
 * @return true if the peer presented a valid certificate, false otherwise
 | 
						|
 */
 | 
						|
bool UnbufferedAsioTlsStream::IsVerifyOK()
 | 
						|
{
 | 
						|
	if (!SSL_is_init_finished(native_handle())) {
 | 
						|
		// handshake was not completed
 | 
						|
		return false;
 | 
						|
	}
 | 
						|
 | 
						|
	if (GetPeerCertificate() == nullptr) {
 | 
						|
		// no peer certificate was sent
 | 
						|
		return false;
 | 
						|
	}
 | 
						|
 | 
						|
	return SSL_get_verify_result(native_handle()) == X509_V_OK;
 | 
						|
}
 | 
						|
 | 
						|
/**
 | 
						|
 * Returns a human-readable error string for situations where IsVerifyOK() returns false.
 | 
						|
 *
 | 
						|
 * If the handshake was completed and a peer certificate was provided,
 | 
						|
 * the string additionally contains the OpenSSL verification error code.
 | 
						|
 *
 | 
						|
 * @return string containing the error message
 | 
						|
 */
 | 
						|
String UnbufferedAsioTlsStream::GetVerifyError()
 | 
						|
{
 | 
						|
	if (!SSL_is_init_finished(native_handle())) {
 | 
						|
		return "handshake not completed";
 | 
						|
	}
 | 
						|
 | 
						|
	if (GetPeerCertificate() == nullptr) {
 | 
						|
		return "no peer certificate provided";
 | 
						|
	}
 | 
						|
 | 
						|
	std::ostringstream buf;
 | 
						|
	long err = SSL_get_verify_result(native_handle());
 | 
						|
	buf << "code " << err << ": " << X509_verify_cert_error_string(err);
 | 
						|
	return buf.str();
 | 
						|
}
 | 
						|
 | 
						|
std::shared_ptr<X509> UnbufferedAsioTlsStream::GetPeerCertificate()
 | 
						|
{
 | 
						|
	return std::shared_ptr<X509>(SSL_get_peer_certificate(native_handle()), X509_free);
 | 
						|
}
 | 
						|
 | 
						|
void UnbufferedAsioTlsStream::BeforeHandshake(handshake_type type)
 | 
						|
{
 | 
						|
	namespace ssl = boost::asio::ssl;
 | 
						|
 | 
						|
	if (!m_Hostname.IsEmpty()) {
 | 
						|
		X509_VERIFY_PARAM_set1_host(SSL_get0_param(native_handle()), m_Hostname.CStr(), m_Hostname.GetLength());
 | 
						|
	}
 | 
						|
 | 
						|
	set_verify_mode(ssl::verify_peer | ssl::verify_client_once);
 | 
						|
 | 
						|
	set_verify_callback([](bool preverified, ssl::verify_context& ctx) {
 | 
						|
		(void) preverified;
 | 
						|
		(void) ctx;
 | 
						|
 | 
						|
		/* Continue the handshake even if an invalid peer certificate was presented. The verification result has to be
 | 
						|
		 * checked using the IsVerifyOK() method.
 | 
						|
		 *
 | 
						|
		 * Such connections are used for the initial enrollment of nodes where they use a self-signed certificate to
 | 
						|
		 * send a certificate request and receive their valid certificate after approval (manually by the administrator
 | 
						|
		 * or using a certificate ticket).
 | 
						|
		 */
 | 
						|
		return true;
 | 
						|
	});
 | 
						|
 | 
						|
#ifdef SSL_CTRL_SET_TLSEXT_HOSTNAME
 | 
						|
	if (type == client && !m_Hostname.IsEmpty()) {
 | 
						|
		String environmentName = Application::GetAppEnvironment();
 | 
						|
		String serverName = m_Hostname;
 | 
						|
 | 
						|
		if (!environmentName.IsEmpty())
 | 
						|
			serverName += ":" + environmentName;
 | 
						|
 | 
						|
		SSL_set_tlsext_host_name(native_handle(), serverName.CStr());
 | 
						|
	}
 | 
						|
#endif /* SSL_CTRL_SET_TLSEXT_HOSTNAME */
 | 
						|
}
 | 
						|
 | 
						|
/**
 | 
						|
 * Forcefully close the connection, typically (details are up to the operating system) using a TCP RST.
 | 
						|
 */
 | 
						|
void AsioTlsStream::ForceDisconnect()
 | 
						|
{
 | 
						|
	if (!lowest_layer().is_open()) {
 | 
						|
		// Already disconnected, nothing to do.
 | 
						|
		return;
 | 
						|
	}
 | 
						|
 | 
						|
	boost::system::error_code ec;
 | 
						|
 | 
						|
	// Close the socket. In case the connection wasn't shut down cleanly by GracefulDisconnect(), the operating system
 | 
						|
	// will typically terminate the connection with a TCP RST. Otherwise, this just releases the file descriptor.
 | 
						|
	lowest_layer().close(ec);
 | 
						|
}
 | 
						|
 | 
						|
/**
 | 
						|
 * Try to cleanly shut down the connection. This involves sending a TLS close_notify shutdown alert and terminating the
 | 
						|
 * underlying TCP connection. Sending these additional messages can block, hence the method takes a yield context and
 | 
						|
 * internally implements a timeout of 10 seconds for the operation after which the connection is forcefully terminated
 | 
						|
 * using ForceDisconnect().
 | 
						|
 *
 | 
						|
 * @param strand Asio strand used for other operations on this connection.
 | 
						|
 * @param yc Yield context for Asio coroutines
 | 
						|
 */
 | 
						|
void AsioTlsStream::GracefulDisconnect(boost::asio::io_context::strand& strand, boost::asio::yield_context& yc)
 | 
						|
{
 | 
						|
	if (!lowest_layer().is_open()) {
 | 
						|
		// Already disconnected, nothing to do.
 | 
						|
		return;
 | 
						|
	}
 | 
						|
 | 
						|
	{
 | 
						|
		Timeout::Ptr shutdownTimeout(new Timeout(strand.context(), strand, boost::posix_time::seconds(10),
 | 
						|
			[this](boost::asio::yield_context yc) {
 | 
						|
				// Forcefully terminate the connection if async_shutdown() blocked more than 10 seconds.
 | 
						|
				ForceDisconnect();
 | 
						|
			}
 | 
						|
		));
 | 
						|
		Defer cancelTimeout ([&shutdownTimeout]() {
 | 
						|
			shutdownTimeout->Cancel();
 | 
						|
		});
 | 
						|
 | 
						|
		// Close the TLS connection, effectively uses SSL_shutdown() to send a close_notify shutdown alert to the peer.
 | 
						|
		boost::system::error_code ec;
 | 
						|
		next_layer().async_shutdown(yc[ec]);
 | 
						|
	}
 | 
						|
 | 
						|
	if (!lowest_layer().is_open()) {
 | 
						|
		// Connection got closed in the meantime, most likely by the timeout, so nothing more to do.
 | 
						|
		return;
 | 
						|
	}
 | 
						|
 | 
						|
	// Shut down the TCP connection.
 | 
						|
	boost::system::error_code ec;
 | 
						|
	lowest_layer().shutdown(lowest_layer_type::shutdown_both, ec);
 | 
						|
 | 
						|
	// Clean up the connection (closes the file descriptor).
 | 
						|
	ForceDisconnect();
 | 
						|
}
 |