mirror of
https://github.com/Icinga/icinga2.git
synced 2025-09-29 04:28:44 +02:00
c40b18ef61
The old validation regex matched if the name consists only of invalid character, not that it does not contain them, i.e. something like "foo/bar" was considered valid. This commit replaces the regex with a check that all characters in the name are allowed characters.
26 lines
797 B
C++
26 lines
797 B
C++
/* Icinga 2 | (c) 2021 Icinga GmbH | GPLv2+ */
|
|
|
|
#include "remote/configpackageutility.hpp"
|
|
#include <vector>
|
|
#include <string>
|
|
#include <BoostTestTargetConfig.h>
|
|
|
|
using namespace icinga;
|
|
|
|
BOOST_AUTO_TEST_SUITE(remote_configpackageutility)
|
|
|
|
BOOST_AUTO_TEST_CASE(ValidateName)
|
|
{
|
|
std::vector<std::string> validNames {"foo", "foo-bar", "FooBar", "Foo123", "_Foo-", "123bar"};
|
|
for (const std::string& n : validNames) {
|
|
BOOST_CHECK_MESSAGE(ConfigPackageUtility::ValidateName(n), "'" << n << "' should be valid");
|
|
}
|
|
|
|
std::vector<std::string> invalidNames {"", ".", "..", "foo.bar", "foo/../bar", "foo/bar", "foo:bar"};
|
|
for (const std::string& n : invalidNames) {
|
|
BOOST_CHECK_MESSAGE(!ConfigPackageUtility::ValidateName(n), "'" << n << "' should not be valid");
|
|
}
|
|
}
|
|
|
|
BOOST_AUTO_TEST_SUITE_END()
|