tyler.durden/icingaweb2-module-director
1
0
Fork 0
mirror of https://github.com/Icinga/icingaweb2-module-director.git synced 2025-08-30 14:18:09 +02:00
Code Issues Packages Projects Releases Wiki Activity

OverrideHelper: centralize applying overrides

Browse Source
This commit is contained in:
Thomas Gelf 2022-07-20 08:52:10 +02:00
parent 6d0b9310c3
commit 1f3b039395
2 changed files with 46 additions and 36 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

44
application/clicommands/ServiceCommand.php
View File

@ -6,7 +6,8 @@ use Icinga\Cli\Params;
use Icinga\Module\Director\Cli\ObjectCommand;
use Icinga\Module\Director\DirectorObject\Lookup\ServiceFinder;
use Icinga\Module\Director\Objects\IcingaHost;
use RuntimeException;
use Icinga\Module\Director\Resolver\OverrideHelper;
use InvalidArgumentException;
/**
* Manage Icinga Services
@ -34,60 +35,31 @@ class ServiceCommand extends ObjectCommand
$this->params->shift('host');
self::checkForOverrideSafety($this->params);
$properties = $this->remainingParams();
self::applyOverriddenVars($host, $name, $properties);
OverrideHelper::applyOverriddenVars($host, $name, $properties);
$this->persistChanges($host, 'Host', $host->getObjectName() . " (Overrides for $name)", 'modified');
}
}
protected static function applyOverriddenVars(IcingaHost $host, $serviceName, $properties)
{
self::assertVarsForOverrides($properties);
$current = $host->getOverriddenServiceVars($serviceName);
foreach ($properties as $key => $value) {
if ($key === 'vars') {
foreach ($value as $k => $v) {
$current->$k = $v;
}
} else {
$current->{substr($key, 5)} = $value;
}
}
$host->overrideServiceVars($serviceName, $current);
}
protected static function checkForOverrideSafety(Params $params)
{
if ($params->shift('replace')) {
throw new RuntimeException('--replace is not available for Variable Overrides');
throw new InvalidArgumentException('--replace is not available for Variable Overrides');
}
$appends = self::stripPrefixedProperties($params, 'append-');
$remove = self::stripPrefixedProperties($params, 'remove-');
self::assertVarsForOverrides($appends);
self::assertVarsForOverrides($remove);
OverrideHelper::assertVarsForOverrides($appends);
OverrideHelper::assertVarsForOverrides($remove);
if (!empty($appends)) {
throw new RuntimeException('--append- is not available for Variable Overrides');
throw new InvalidArgumentException('--append- is not available for Variable Overrides');
}
if (!empty($remove)) {
throw new RuntimeException('--remove- is not available for Variable Overrides');
throw new InvalidArgumentException('--remove- is not available for Variable Overrides');
}
// Alternative, untested:
// $this->appendToArrayProperties($object, $appends);
// $this->removeProperties($object, $remove);
}
protected static function assertVarsForOverrides($properties)
{
if (empty($properties)) {
return;
}
foreach ($properties as $key => $value) {
if ($key !== 'vars' && substr($key, 0, 5) !== 'vars.') {
throw new RuntimeException("Only Custom Variables can be set based on Variable Overrides");
}
}
}
protected function load($name)
{
return parent::load($this->makeServiceKey($name));

38
library/Director/Resolver/OverrideHelper.php Normal file
View File

@ -0,0 +1,38 @@
<?php
namespace Icinga\Module\Director\Resolver;
use Icinga\Module\Director\Objects\IcingaHost;
use InvalidArgumentException;
class OverrideHelper
{
public static function applyOverriddenVars(IcingaHost $host, $serviceName, $properties)
{
static::assertVarsForOverrides($properties);
$current = $host->getOverriddenServiceVars($serviceName);
foreach ($properties as $key => $value) {
if ($key === 'vars') {
foreach ($value as $k => $v) {
$current->$k = $v;
}
} else {
$current->{substr($key, 5)} = $value;
}
}
$host->overrideServiceVars($serviceName, $current);
}
public static function assertVarsForOverrides($properties)
{
if (empty($properties)) {
return;
}
foreach ($properties as $key => $value) {
if ($key !== 'vars' && substr($key, 0, 5) !== 'vars.') {
throw new InvalidArgumentException("Only Custom Variables can be set based on Variable Overrides");
}
}
}
}