From 2237272b6bbb3a520d6c819853cceeebd4ba7da2 Mon Sep 17 00:00:00 2001
From: Thomas Gelf <thomas@gelf.net>
Date: Wed, 3 May 2017 11:24:22 +0200
Subject: [PATCH] SyncRule: do not allow to sync unless some...

...properties have been defined.

fixes #383
---
 application/views/scripts/syncrule/index.phtml | 10 ++++++++++
 library/Director/Objects/SyncRule.php          |  6 ++++++
 2 files changed, 16 insertions(+)

diff --git a/application/views/scripts/syncrule/index.phtml b/application/views/scripts/syncrule/index.phtml
index 66971da7..1687ce5f 100644
--- a/application/views/scripts/syncrule/index.phtml
+++ b/application/views/scripts/syncrule/index.phtml
@@ -4,6 +4,16 @@
 </div>
 
 <div class="content">
+<?php if (! $rule->hasSyncProperties()): ?>
+<p class="warning">
+<?= sprintf(
+    $this->translate('You need must define some %s before you can run this Sync rule'),
+    $this->qlink('Sync Properties', 'director/syncrule/property', array('rule_id' => $rule->id))
+)
+?>
+</p>
+</div>
+<?php return; endif ?>
 <?php if (! $this->run): ?>
 <p class="warning">
 <?= $this->translate('This Sync Rule has never been run before.') ?>
diff --git a/library/Director/Objects/SyncRule.php b/library/Director/Objects/SyncRule.php
index 42d9a296..e7dd7579 100644
--- a/library/Director/Objects/SyncRule.php
+++ b/library/Director/Objects/SyncRule.php
@@ -345,6 +345,12 @@ class SyncRule extends DbObject
         return $this->hasCombinedKey;
     }
 
+    public function hasSyncProperties()
+    {
+        $properties = $this->getSyncProperties();
+        return ! empty($properties);
+    }
+
     public function getSyncProperties()
     {
         if (! $this->hasBeenLoadedFromDb()) {