IcingaCommand: Allow command to be rendered as string

Icinga 2 allows this from the beginning.

application/forms/IcingaCommandForm.php

@@ -73,6 +73,21 @@ class IcingaCommandForm extends DirectorObjectForm
                 . ' specific unit (e.g. 1m or also 3m 30s).'
             )
         ));
+
+        $descIsString = [
+            $this->translate('Render the command as a plain string instead of an array.'),
+            $this->translate('This can not be used together with arguments.'),
+            $this->translate('It is disabled by default and should only be used in rare cases.'),
+        ];
+
+        $this->addBoolean(
+            'is_string',
+            array(
+                'label'       => $this->translate('Render as string'),
+                'description' => join(' ', $descIsString),
+            )
+        );
+
         $this->addDisabledElement();
         $this->addZoneSection();
         $this->setButtons();

library/Director/Objects/IcingaCommand.php

@@ -19,14 +19,19 @@ class IcingaCommand extends IcingaObject implements ObjectWithArguments, ExportI
     protected $type = 'CheckCommand';
 
     protected $defaultProperties = [
-        'id'                    => null,
+        'id'              => null,
-        'object_name'           => null,
+        'object_name'     => null,
-        'object_type'           => null,
+        'object_type'     => null,
-        'disabled'              => 'n',
+        'disabled'        => 'n',
-        'methods_execute'       => null,
+        'methods_execute' => null,
-        'command'               => null,
+        'command'         => null,
-        'timeout'               => null,
+        'timeout'         => null,
-        'zone_id'               => null,
+        'zone_id'         => null,
+        'is_string'       => null,
+    ];
+
+    protected $booleans = [
+        'is_string' => 'is_string',
     ];
 
     protected $supportsCustomVars = true;
@@ -288,16 +293,33 @@ class IcingaCommand extends IcingaObject implements ObjectWithArguments, ExportI
         $command = $this->get('command');
         $prefix = '';
         if (preg_match('~^([A-Z][A-Za-z0-9_]+\s\+\s)(.+?)$~', $command, $m)) {
-            $prefix  = $m[1];
+            $prefix = $m[1];
             $command = $m[2];
         } elseif (! $this->isAbsolutePath($command)) {
             $prefix = 'PluginDir + ';
             $command = '/' . $command;
         }
-        $parts = preg_split('/\s+/', $command, -1, PREG_SPLIT_NO_EMPTY);
+
-        array_unshift($parts, c::alreadyRendered($prefix . c::renderString(array_shift($parts))));
+        $inherited = $this->getInheritedProperties();
-        
+
-        return c::renderKeyValue('command', c::renderArray($parts));
+        if ($this->get('is_string') === 'y' || ($this->get('is_string') === null
+                && property_exists($inherited, 'is_string') && $inherited->is_string === 'y')) {
+            return c::renderKeyValue('command', $prefix . c::renderString($command));
+        } else {
+            $parts = preg_split('/\s+/', $command, -1, PREG_SPLIT_NO_EMPTY);
+            array_unshift($parts, c::alreadyRendered($prefix . c::renderString(array_shift($parts))));
+
+            return c::renderKeyValue('command', c::renderArray($parts));
+        }
+    }
+
+    /**
+     * @codingStandardsIgnoreStart
+     */
+    protected function renderIs_string()
+    {
+        // @codingStandardsIgnoreEnd
+        return '';
     }
 
     protected function isAbsolutePath($path)

schema/mysql-migrations/upgrade_160.sql

@@ -0,0 +1,6 @@
+ALTER TABLE icinga_command
+  ADD COLUMN is_string enum ('y', 'n') NULL;
+
+INSERT INTO director_schema_migration
+  (schema_version, migration_time)
+  VALUES (160, NOW());

schema/mysql.sql

@@ -320,6 +320,7 @@ CREATE TABLE icinga_command (
   disabled ENUM('y', 'n') NOT NULL DEFAULT 'n',
   methods_execute VARCHAR(64) DEFAULT NULL,
   command TEXT DEFAULT NULL,
+  is_string ENUM('y', 'n') NULL,
   -- env text DEFAULT NULL,
   -- vars text DEFAULT NULL,
   timeout SMALLINT UNSIGNED DEFAULT NULL,
@@ -1787,4 +1788,4 @@ CREATE TABLE icinga_timeperiod_exclude (
 
 INSERT INTO director_schema_migration
   (schema_version, migration_time)
-  VALUES (159, NOW());
+  VALUES (160, NOW());

schema/pgsql-migrations/upgrade_160.sql

@@ -0,0 +1,6 @@
+ALTER TABLE icinga_command
+  ADD COLUMN is_string enum_boolean NULL;
+
+INSERT INTO director_schema_migration
+  (schema_version, migration_time)
+  VALUES (160, NOW());

schema/pgsql.sql

@@ -415,6 +415,7 @@ CREATE TABLE icinga_command (
   disabled enum_boolean NOT NULL DEFAULT 'n',
   methods_execute character varying(64) DEFAULT NULL,
   command text DEFAULT NULL,
+  is_string enum_boolean NULL,
 -- env text DEFAULT NULL,
   timeout smallint DEFAULT NULL,
   zone_id integer DEFAULT NULL,
@@ -2086,4 +2087,4 @@ CREATE TABLE icinga_timeperiod_exclude (
 
 INSERT INTO director_schema_migration
   (schema_version, migration_time)
-  VALUES (158, NOW());
+  VALUES (160, NOW());