From d3f4625d7c0b5b1a55fda536ec9ba40d040f6a4e Mon Sep 17 00:00:00 2001 From: Thomas Gelf Date: Tue, 30 Jun 2015 11:37:35 +0200 Subject: [PATCH 1/2] DirectorObjectForm: workaround to move submit button --- library/Director/Web/Form/DirectorObjectForm.php | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/library/Director/Web/Form/DirectorObjectForm.php b/library/Director/Web/Form/DirectorObjectForm.php index 13ebd826..42b8368b 100644 --- a/library/Director/Web/Form/DirectorObjectForm.php +++ b/library/Director/Web/Form/DirectorObjectForm.php @@ -183,6 +183,11 @@ abstract class DirectorObjectForm extends QuickForm $this->addHidden('id'); } $this->setDefaults($this->object->getProperties()); + + if ($submit = $this->getElement('submit')) { + $this->removeElement('submit'); + } + if ($this->object->supportsGroups()) { $this->getElement('groups')->setValue( implode(', ', $this->object->groups()->listGroupNames()) @@ -201,6 +206,10 @@ abstract class DirectorObjectForm extends QuickForm } } + if ($submit) { + $this->addElement($submit); + } + if (! $this->hasBeenSubmitted()) { $this->beforeValidation($this->object->getProperties()); } From 3f9a19ac915ca1cc61111c18701c5ccc30f69a7f Mon Sep 17 00:00:00 2001 From: Thomas Gelf Date: Tue, 30 Jun 2015 15:41:59 +0200 Subject: [PATCH 2/2] schema: rename datalist_value to datalist_entry --- schema/mysql-changes/upgrade_21.sql | 15 +++++++++++++++ schema/mysql.sql | 8 ++++---- schema/pgsql-changes/upgrade_21.sql | 17 +++++++++++++++++ schema/pgsql.sql | 12 ++++++------ 4 files changed, 42 insertions(+), 10 deletions(-) create mode 100644 schema/mysql-changes/upgrade_21.sql create mode 100644 schema/pgsql-changes/upgrade_21.sql diff --git a/schema/mysql-changes/upgrade_21.sql b/schema/mysql-changes/upgrade_21.sql new file mode 100644 index 00000000..7c72b868 --- /dev/null +++ b/schema/mysql-changes/upgrade_21.sql @@ -0,0 +1,15 @@ +DROP TABLE director_datalist_value; + +CREATE TABLE director_datalist_entry ( + list_id INT(10) UNSIGNED NOT NULL, + entry_name VARCHAR(255) DEFAULT NULL, + entry_value TEXT DEFAULT NULL, + format enum ('string', 'expression', 'json'), + PRIMARY KEY (list_id, entry_name), + CONSTRAINT director_datalist_value_datalist + FOREIGN KEY datalist (list_id) + REFERENCES director_datalist (id) + ON DELETE CASCADE + ON UPDATE CASCADE +) ENGINE=InnoDB DEFAULT CHARSET=utf8; + diff --git a/schema/mysql.sql b/schema/mysql.sql index 9b97a1f4..ad7569f7 100644 --- a/schema/mysql.sql +++ b/schema/mysql.sql @@ -100,12 +100,12 @@ CREATE TABLE director_datalist ( UNIQUE KEY list_name (list_name) ) ENGINE=InnoDB DEFAULT CHARSET=utf8; -CREATE TABLE director_datalist_value ( +CREATE TABLE director_datalist_entry ( list_id INT(10) UNSIGNED NOT NULL, - value_name VARCHAR(255) DEFAULT NULL, - value_expression TEXT DEFAULT NULL, + entry_name VARCHAR(255) DEFAULT NULL, + entry_value TEXT DEFAULT NULL, format enum ('string', 'expression', 'json'), - PRIMARY KEY (list_id, value_name), + PRIMARY KEY (list_id, entry_name), CONSTRAINT director_datalist_value_datalist FOREIGN KEY datalist (list_id) REFERENCES director_datalist (id) diff --git a/schema/pgsql-changes/upgrade_21.sql b/schema/pgsql-changes/upgrade_21.sql new file mode 100644 index 00000000..1a4fc5a6 --- /dev/null +++ b/schema/pgsql-changes/upgrade_21.sql @@ -0,0 +1,17 @@ +DROP TABLE director_datalist_value; + +CREATE TABLE director_datalist_entry ( + list_id integer NOT NULL, + entry_name character varying(255) DEFAULT NULL, + entry_value text DEFAULT NULL, + format enum_property_format, + PRIMARY KEY (list_id, entry_name), + CONSTRAINT director_datalist_entry_datalist + FOREIGN KEY (list_id) + REFERENCES director_datalist (id) + ON DELETE CASCADE + ON UPDATE CASCADE +); + +CREATE INDEX datalist_entry_datalist ON director_datalist_entry (list_id); + diff --git a/schema/pgsql.sql b/schema/pgsql.sql index c5c7dee8..6ba9ad16 100644 --- a/schema/pgsql.sql +++ b/schema/pgsql.sql @@ -134,20 +134,20 @@ CREATE TABLE director_datalist ( CREATE UNIQUE INDEX datalist_list_name ON director_datalist (list_name); -CREATE TABLE director_datalist_value ( +CREATE TABLE director_datalist_entry ( list_id integer NOT NULL, - value_name character varying(255) DEFAULT NULL, - value_expression text DEFAULT NULL, + entry_name character varying(255) DEFAULT NULL, + entry_value text DEFAULT NULL, format enum_property_format, - PRIMARY KEY (list_id, value_name), - CONSTRAINT director_datalist_value_datalist + PRIMARY KEY (list_id, entry_name), + CONSTRAINT director_datalist_entry_datalist FOREIGN KEY (list_id) REFERENCES director_datalist (id) ON DELETE CASCADE ON UPDATE CASCADE ); -CREATE INDEX datalist_value_datalist ON director_datalist_value (list_id); +CREATE INDEX datalist_entry_datalist ON director_datalist_entry (list_id); CREATE TABLE director_datatype (