tyler.durden
/
icingaweb2-module-director
mirror of https://github.com/Icinga/icingaweb2-module-director.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Sync: start code cleanup 

We want to store sync history and show sync previews, code needs to
be prepared for those tasks
This commit is contained in:
Thomas Gelf 2015-10-20 23:29:29 +02:00
parent 29206188bf
commit 9ec520c788
1 changed files with 37 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

56
library/Director/Import/Sync.php
View File

@ -59,7 +59,7 @@ class Sync
return preg_replace_callback('/\${([A-Za-z0-9_-]+)}/', $func, $string);
}
protected function runWithRule(SyncRule $rule)
protected function prepareSyncForRule(SyncRule $rule)
{
$db = $rule->getConnection();
$properties = $rule->fetchSyncProperties();
@ -194,6 +194,42 @@ class Sync
}
$ignore = array();
foreach ($objects as $key => $object) {
if ($object->hasBeenLoadedFromDb() && $rule->purge_existing === 'y') {
$found = false;
foreach ($sources as $source) {
if (array_key_exists($object->$objectKey, $imported[$source->id])) {
$found = true;
break;
}
}
if (! $found) {
// TODO: temporarily disabled, "mark" them: $object->delete();
}
}
// TODO: This should be noticed or removed:
if (! $object->$objectKey) {
$ignore[] = $key;
}
}
foreach ($ignore as $key) {
unset($objects[$key]);
}
return $objects;
}
protected function runWithRule(SyncRule $rule)
{
$db = $rule->getConnection();
// TODO: Evaluate whether fetching data should happen within the same transaction
$objects = $this->prepareSyncForRule($rule);
$dba = $db->getDbAdapter();
$dba->beginTransaction();
foreach ($objects as $object) {
@ -208,24 +244,6 @@ class Sync
continue;
}
if ($object->hasBeenLoadedFromDb() && $rule->purge_existing === 'y') {
$found = false;
foreach ($sources as $source) {
if (array_key_exists($object->$objectKey, $imported[$source->id])) {
$found = true;
break;
}
}
if (! $found) {
$object->delete();
}
}
// TODO: This should be noticed or removed:
if (! $object->$objectKey) {
continue;
}
$object->store($db);
}