tyler.durden/icingaweb2-module-director
1
0
Fork 0
mirror of https://github.com/Icinga/icingaweb2-module-director.git synced 2025-07-30 09:14:09 +02:00
Code Issues Packages Projects Releases Wiki Activity

IcingaServiceForm: cleanup, no details without type

Browse Source
This commit is contained in:
Thomas Gelf 2016-03-07 18:39:19 +01:00
parent c8a95f1de6
commit a42be2a6e8
1 changed files with 39 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

69
application/forms/IcingaServiceForm.php
View File

@ -10,6 +10,7 @@ class IcingaServiceForm extends DirectorObjectForm
{
$this->addObjectTypeElement();
if (! $this->hasObjectType()) {
$this->groupObjectDefinition();
return;
}
@ -29,39 +30,24 @@ class IcingaServiceForm extends DirectorObjectForm
));
}
$this->addElement('extensibleSet', 'groups', array(
'label' => $this->translate('Groups'),
'multiOptions' => $this->optionallyAddFromEnum($this->enumServicegroups()),
'positional' => false,
'description' => $this->translate(
'Service groups that should be directly assigned to this service. Servicegroups can be useful'
. ' for various reasons. They are helpful to provided service-type specific view in Icinga Web 2,'
. ' either for custom dashboards or as an instrument to enforce restrictior. Service groups'
. ' can be directly assigned to single services or to service templates.'
)
));
$groups = $this->enumServicegroups();
if (! empty($groups)) {
$this->addElement('extensibleSet', 'groups', array(
'label' => $this->translate('Groups'),
'multiOptions' => $this->optionallyAddFromEnum($groups),
'positional' => false,
'description' => $this->translate(
'Service groups that should be directly assigned to this service. Servicegroups can be useful'
. ' for various reasons. They are helpful to provided service-type specific view in Icinga Web 2,'
. ' either for custom dashboards or as an instrument to enforce restrictior. Service groups'
. ' can be directly assigned to single services or to service templates.'
)
));
}
$this->addImportsElement();
$this->addDisabledElement();
$elements = array(
'object_type',
'object_name',
'display_name',
'imports',
'host_id',
'groups',
'disabled',
);
$this->addDisplayGroup($elements, 'object_definition', array(
'decorators' => array(
'FormElements',
array('HtmlTag', array('tag' => 'dl')),
'Fieldset',
),
'order' => 20,
'legend' => $this->translate('Service properties')
));
$this->groupObjectDefinition();
$this->addCheckCommandElements();
@ -96,6 +82,29 @@ class IcingaServiceForm extends DirectorObjectForm
$this->setButtons();
}
protected function groupObjectDefinition()
{
$elements = array(
'object_type',
'object_name',
'display_name',
'imports',
'host_id',
'groups',
'disabled',
);
$this->addDisplayGroup($elements, 'object_definition', array(
'decorators' => array(
'FormElements',
array('HtmlTag', array('tag' => 'dl')),
'Fieldset',
),
'order' => 20,
'legend' => $this->translate('Service properties')
));
}
protected function enumHostsAndTemplates()
{
return array(