ipl: code cleanup

library/vendor/ipl/Data/SimpleQueryPaginationAdapter.php

@@ -10,8 +10,6 @@ class SimpleQueryPaginationAdapter implements Paginatable
     /** @var SimpleQuery */
     private $query;
 
-    private $countQuery;
-
     public function __construct(SimpleQuery $query)
     {
         $this->query = $query;

library/vendor/ipl/Html/FormattedString.php

@@ -24,7 +24,9 @@ class FormattedString implements ValidHtml
     public static function create($string)
     {
         $args = func_get_args();
-        return new static(array_shift($args), $args);
+        array_shift($args);
+
+        return new static($string, $args);
     }
 
     public function render()

library/vendor/ipl/Web/Table/Extension/ZfSortablePriority.php

@@ -31,7 +31,7 @@ trait ZfSortablePriority
 
         if ($request->isPost() && $this->hasBeenSent($request)) {
             // $this->fixPriorities();
-            foreach ($request->getPost() as $key => $value) {
+            foreach (array_keys($request->getPost()) as $key) {
                 if (substr($key, 0, 8) === 'MOVE_UP_') {
                     $id = (int) substr($key, 8);
                     $this->moveRow($id, 'up');

library/vendor/ipl/Web/Table/QueryBasedTable.php

@@ -5,7 +5,6 @@ namespace dipl\Web\Table;
 use Countable;
 use Icinga\Application\Benchmark;
 use Icinga\Data\Filter\Filter;
-use Icinga\Exception\ProgrammingError;
 use dipl\Data\Paginatable;
 use dipl\Db\Zf1\FilterRenderer;
 use dipl\Html\Table;
@@ -29,12 +28,8 @@ abstract class QueryBasedTable extends Table implements Countable
 
     private $firstRow;
 
-    private $firstRowOnPage;
-
     private $lastRow = false;
 
-    private $lastRowOnPage = false;
-
     private $rowNumber;
 
     private $rowNumberOnPage;