From bf8108d937a7b13ab0851dc78aaeea1f3feb8eb4 Mon Sep 17 00:00:00 2001 From: Thomas Gelf Date: Thu, 25 Feb 2016 19:58:08 +0100 Subject: [PATCH] IcingaTimePeriodRanges: improve "modified" handling Seems to be currently unused nonetheless --- library/Director/Objects/IcingaTimePeriodRanges.php | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/library/Director/Objects/IcingaTimePeriodRanges.php b/library/Director/Objects/IcingaTimePeriodRanges.php index 11d582c1..4e20195d 100644 --- a/library/Director/Objects/IcingaTimePeriodRanges.php +++ b/library/Director/Objects/IcingaTimePeriodRanges.php @@ -89,7 +89,12 @@ class IcingaTimePeriodRanges implements Iterator, Countable, IcingaConfigRendere { foreach ($ranges as $range => $value) { if (array_key_exists($range, $this->ranges)) { - $this->ranges[$range]->timeperiod_value = $value; + if ($this->ranges[$range]->timeperiod_value === $value) { + continue; + } else { + $this->ranges[$range]->timeperiod_value = $value; + $this->modified = true; + } } else { $this->ranges[$range] = IcingaTimePeriodRange::create(array( 'timeperiod_id' => $this->object->id, @@ -102,6 +107,7 @@ class IcingaTimePeriodRanges implements Iterator, Countable, IcingaConfigRendere $toDelete = array_diff(array_keys($this->ranges), array_keys($ranges)); foreach ($toDelete as $range) { $this->remove($range); + $this->modified = true; } return $this; @@ -208,7 +214,7 @@ class IcingaTimePeriodRanges implements Iterator, Countable, IcingaConfigRendere public function toConfigString() { - if (empty($this->ranges) && $this->object->object_type == 'template') { + if (empty($this->ranges) && $this->object->object_type === 'template') { return ''; }