From ea8452d0e94eeac2f7a140a9efb8d897770dbde0 Mon Sep 17 00:00:00 2001 From: Thomas Gelf Date: Fri, 8 Jun 2018 16:39:34 +0200 Subject: [PATCH] ConfigHealthItemRenderer: be fail-safe Icinga Web 2 should catch errors, but seems that it doesn't --- .../Web/Navigation/Renderer/ConfigHealthItemRenderer.php | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/library/Director/Web/Navigation/Renderer/ConfigHealthItemRenderer.php b/library/Director/Web/Navigation/Renderer/ConfigHealthItemRenderer.php index c6b7399a..a17e559c 100644 --- a/library/Director/Web/Navigation/Renderer/ConfigHealthItemRenderer.php +++ b/library/Director/Web/Navigation/Renderer/ConfigHealthItemRenderer.php @@ -22,7 +22,14 @@ class ConfigHealthItemRenderer extends BadgeNavigationItemRenderer protected function hasProblems() { - $this->checkHealth(); + try { + $this->checkHealth(); + } catch (Exception $e) { + $this->directorState = self::STATE_UNKNOWN; + $this->count = 1; + $this->message = $e->getMessage(); + } + return $this->count > 0; }