From ef41022a73801ba7da1d9a989745a1f70e60ca76 Mon Sep 17 00:00:00 2001 From: Markus Frosch Date: Mon, 15 Apr 2019 16:35:40 +0200 Subject: [PATCH] IcingaArguments: Mark arguments for removal when setting empty Without the fix arguments will remain untouched in DB, but appear to be removed in activity log. fixes #1829 --- library/Director/Objects/IcingaArguments.php | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/library/Director/Objects/IcingaArguments.php b/library/Director/Objects/IcingaArguments.php index 048231da..6324d562 100644 --- a/library/Director/Objects/IcingaArguments.php +++ b/library/Director/Objects/IcingaArguments.php @@ -190,18 +190,8 @@ class IcingaArguments implements Iterator, Countable, IcingaConfigRenderer return $attrs; } - // TODO -> UNFINISHED!!! public function setArguments($arguments) { - if (empty($arguments)) { - if (count($this->arguments)) { - $this->arguments = []; - $this->modified = true; - } - - return $this; - } - $arguments = (array) $arguments; foreach ($arguments as $arg => $val) {