Commit Graph

4475 Commits

Author SHA1 Message Date
Thomas Widhalm 884118958e doc: add a note about director-global being reserver for Director 2019-07-04 12:08:25 +02:00
Eric Lippmann d9b75c4a86 pgsql: Fix unexpected removal of current deployment
The director automatically removes uncollected deployments if they're
older than the running one. Deployments are uncollected if Icinga 2 did
not write a status file or startup log (yet). This happens when you
manage to ship a deployment while Icinga 2 is already preparing to
restart with a deployed configuration. It also removes deployments
which were forgotten by Icinga 2 because of bugs in previous versions.

If there are uncollected deployments, the check whether they are older
than the running one is based on string comparison of the deployments'
start time. While this works for MySQL and MariaDB where the output of
timestamps is always ISO, it may fail for PostgreSQL because there the
output format is configurable. If the output format is set to report
the day first, the string comparison "fails" and removes every first
deployment of a month:

Deployment timestamp: 01-JUN-19 00:03:37 -07:00
Running timestamp: 31-MAY-19 23:54:53 -07:00

The string comparison now reports the deployment as older than the
running one and removes it.

The fix is as easy as to use timestamps for the comparison.
2019-07-01 15:04:19 +02:00
Thomas Gelf f9ee098f06 ArrayCustomVariablesFilter: accept lists with...
..."Array" target data type

fixes #1241
2019-06-11 11:39:54 +02:00
Thomas Gelf 77bc311c42 DataTypeDatalist: allow strict list item to be...
...NULL at the beginning - or with wrong values. Otherwise the first one
would be chosen
2019-05-29 08:53:49 +02:00
Thomas Gelf 0d405cba98 SyncruleCommand: show number of expected changes
Sample output when there are changes:

    icingaweb2@web:~$ icingacli director syncrule check --id 36
    There are pending changes for this Sync Rule. You should  trigger a new Sync Run.
    Expected modifications: 2x create, 0x modify, 0x delete
    icingaweb2@web:~$ echo $?
    1

...when there are no changes:

    icingaweb2@web:~$ icingacli director syncrule check --id 34
    This Sync Rule is in sync
    icingaweb2@web:~$ echo $?
    0

...and when something failes:

    icingaweb2@web:~$ icingacli director syncrule check --id 32
    This Sync Rule failed: No data has been imported for "Benutzergruppen aus Nagios" yet
    icingaweb2@web:~$ echo $?
    2

fixes #1849
2019-05-27 17:46:43 +02:00
Thomas Gelf 7533334de9 SyncruleController: fix typo 2019-05-27 17:30:42 +02:00
Thomas Gelf cc15cae34a Basket: allow to add external commands and...
...command templates
2019-05-27 17:27:18 +02:00
Thomas Gelf 5839945101 Basket: fix nesting error when modifying baskets 2019-05-27 13:40:27 +02:00
Thomas Gelf e255471984 IcingaObjectFieldForm: propose command arguments
...for Host and Service Templates
2019-05-27 13:24:33 +02:00
Thomas Gelf 523cd7f0e5 doc: raise requirements, dependencies 2019-05-22 17:59:26 +02:00
Thomas Gelf 6bf1c30c2f Sync: use string keys for object_name 2019-05-22 17:06:24 +02:00
Markus Frosch 4b68d68554 ActivityLogInfo: Fix loading newProperties for deleted objects
refs #1816
2019-05-21 12:32:46 +02:00
Thomas Gelf 3e80115692 DataTypeDatalist: fix typo 2019-05-20 11:06:08 +02:00
Thomas Gelf a80bdd833e ExtensibleSet: fix exception parameters 2019-05-20 11:04:56 +02:00
Thomas Gelf e148d2523b Merge branch 'feature/configurable-datalist-field' 2019-05-06 21:30:03 +02:00
Thomas Gelf 6a1c3d211f doc/changelog: mention configurable datalist fields 2019-05-06 21:29:24 +02:00
Thomas Gelf a14ab4d8a1 ExtensibleSet: do not override validators 2019-05-06 21:25:44 +02:00
Thomas Gelf db8895ae10 DataTypeDatalist: allow to customize behavior
Available options:
* strict: select box
* suggest_strict: auto-completion, allow only list values
* suggest_optional: Allow for values not on the list
* suggest_extend: Extend the list with new values

fixes #1846
2019-05-06 21:25:44 +02:00
Bernhard Friedreich 7177d489ec Fix wrong links for hosts/apply rules based on <something> (#1864) 2019-05-06 21:24:09 +02:00
Thomas Gelf d68c0a0c03 ApplyRulesTable: fix non-service tables...
...as they have no apply_for column

fixes #1866
2019-05-06 21:22:12 +02:00
Thomas Gelf c3ca6408f1
Merge pull request #1863 from friesoft/master
Sort list of applied services by object_name
2019-05-06 21:08:41 +02:00
Bernhard Friedreich 08266a4b92 Sort list of applied services by object_name (#1862) 2019-05-06 19:43:26 +02:00
Thomas Gelf 644853f7a0
Merge pull request #1860 from Icinga/feature/apply-exists
Implement AssignFilterHelper to improve apply/assign matching
2019-05-06 17:07:36 +02:00
Markus Frosch 73ee660567
IcingaConfig: Deprecate magic_apply_for as config feature (#1852)
IcingaConfig: Deprecate magic_apply_for as config feature
2019-05-06 14:40:36 +02:00
Markus Frosch 767296ce6a Display apply_for in apply listings 2019-05-06 14:38:17 +02:00
Markus Frosch 83245f2dd4 IcingaHostAppliedServicesTable: Fix assign rendering 2019-05-06 14:33:07 +02:00
Thomas Gelf df509262e8
Merge pull request #1801 from WuerthPhoenix/add-configuration-basket-documentation
Add documentation for configuration baskets
2019-05-06 14:28:52 +02:00
Thomas Gelf ab6a211631 doc/changelog: mention changes related to v1.7 2019-05-06 14:24:27 +02:00
Markus Frosch 4037e22709 Implement AssignFilterHelper to improve apply/assign matching
* is set / is not set - fixes #1483 fixes #1387
* case-insensitive matching when using wildcards '*'
  like match() in Icinga 2
2019-05-06 14:19:29 +02:00
Markus Frosch 92f2f9f44d IcingaConfig: Deprecate magic_apply_for as config feature
fixes #1850
2019-04-30 12:41:53 +02:00
Thomas Gelf baa3ae248f Datafield: fix links and redirections
fixes #1847
2019-04-29 10:45:30 +02:00
Markus Frosch 2fc79e1ecb schema: Fix migration 163 for certain MySQL versions
MySQL 5.6 won't accept NULL defaults with NOT NULL...

refs #1840
2019-04-26 10:13:44 +02:00
Thomas Gelf fe53dee21d
Merge pull request #1845 from dgoetz/fix/930-servicegroup_assign_optional
ServiceGroup: Make assign optional
2019-04-24 16:47:58 +02:00
Markus Frosch 7153d8059b
Ensure MySQL data supports timezones (#1840)
Ensure MySQL data supports timezones
2019-04-24 15:18:52 +02:00
Markus Frosch 72d9d47a1b Migrations: Disable max_execution_time on apply 2019-04-24 15:04:08 +02:00
Dirk Goetz b70bf7659e ServiceGroup: Make assign optional
fixes #930
2019-04-24 14:02:32 +02:00
Thomas Gelf 099c53a008
Merge pull request #1843 from gianlucapiccolo/deploy-hook
Add deployment hooks
2019-04-24 13:38:43 +02:00
Gianluca Piccolo 4a4808eea5 Add deployment hooks 2019-04-24 12:17:31 +02:00
Thomas Gelf 6bcb4a461e CoreApi: fix method call 2019-04-24 11:21:16 +02:00
Thomas Gelf da909907fd IcingaMultiEditForm: use IcingaObjectFormHook 2019-04-24 11:20:40 +02:00
Thomas Gelf 93a882f8c5
Merge pull request #1841 from Icinga/feature/generic-object-form-hook
IcingaObjectFormHook: new generic hook
2019-04-23 18:22:35 +02:00
Thomas Gelf cdb500134d IcingaObjectFormHook: new generic hook 2019-04-23 18:16:35 +02:00
Markus Frosch d96dde10bb schema: Migrate all DATETIME to TIMESTAMP in MySQL
This addresses various timezone issues, that don't exist with the pgsql schema.
2019-04-23 15:39:00 +02:00
Thomas Gelf db6deb2a72 QuickForm: allow to call callbacks on success 2019-04-18 17:29:46 +02:00
Thomas Gelf 96ae3451a4 js: fix autocompletion position when scrolled...
...away
2019-04-18 16:53:46 +02:00
Markus Frosch d3fa347ec2
Merge pull request #1836 from Icinga/bugfix/clear-prefetch
Avoid caching between multiple runs of sync
2019-04-17 10:59:34 +02:00
Markus Frosch a30a28a7a1 Sync: Purge TemplateRepository cache before sync 2019-04-17 10:47:43 +02:00
Markus Frosch 6d3702a893 PrefetchCache: Purge any object cache on forget or initialize 2019-04-17 10:47:16 +02:00
Markus Frosch ef41022a73 IcingaArguments: Mark arguments for removal when setting empty
Without the fix arguments will remain untouched in DB, but appear to be removed in activity log.

fixes #1829
2019-04-15 16:35:40 +02:00
Thomas Gelf fd27d25df3
Merge pull request #1834 from nbuchwitz/patch-2
Fix schema migration from CREATE to ALTER TABLE
2019-04-15 10:27:01 +02:00