Commit Graph

400 Commits

Author SHA1 Message Date
Thomas Gelf f874a79bb4 IcingaObjectFieldLoader: no mandatory field on cmd
fixes #12644
2017-01-13 16:05:34 +01:00
Thomas Gelf 9b6eda4e97 IcingaObjectFieldLoader: cleanup, improve handling 2017-01-13 15:24:50 +01:00
Thomas Gelf 7a3a845570 Forms: try to give dev UI more hints on fluent...
...code
2017-01-13 13:15:01 +01:00
Thomas Gelf 9fc3957f11 QuickForm: fix broken submit button 2017-01-02 10:49:14 +01:00
Thomas Gelf 87f88bf0c7 DirectorObjectForm: allow to hook custom code...
...after fields have been added
2017-01-02 10:17:49 +01:00
Thomas Gelf c9929f7b17 QuickForm: postpone default submit button creation
This gives more possibilities to override them at a late stage
2017-01-02 10:14:30 +01:00
Thomas Gelf 990e3fc04b DirectorObjectFrom: set every property we get
fixes #13659
fixes #13673
2016-12-19 14:32:52 +01:00
Thomas Gelf 3d8ccf2448 DirectorObjectForm: skip empty related sets...
...provides as objects

fixes #13605
2016-12-15 11:44:52 +01:00
Thomas Gelf 65181ca67e ExtensibleSet: be strict on values...
...and provide a meaningful Exception in case something fails

refs #13605
2016-12-15 11:43:56 +01:00
Thomas Gelf 15b031272e IcingaObjectFieldLoader: pass db to resolved...
...flat object

refs #13583
2016-12-14 22:44:56 +01:00
Thomas Gelf e85c13ae13 DirectorObjectForm: some more steps to simplify...
...this old monster

fixes #13583
2016-12-14 21:07:07 +01:00
Thomas Gelf a30f34a026 DirectorObjectForm: be careful when continuing...
...after an exception
2016-12-14 20:59:26 +01:00
Thomas Gelf cbb3c7aa88 DirectorObjectForm: remove unused parameter for...
...object() helper method
2016-12-14 20:48:59 +01:00
Thomas Gelf 145e1fc6a9 DirectorObjectForm: add has_agent to early props 2016-12-14 20:27:52 +01:00
Thomas Gelf 7e7e2601d3 ObjectFields: prefix filters, respect inheritance
refs #13253
2016-12-14 17:33:13 +01:00
Thomas Gelf 5847913987 Fields: add a possibility to show fields based...
...on filter rules
2016-12-14 16:36:33 +01:00
Thomas Gelf 4c1ab4dae6 php: just some comments and cleanup 2016-12-13 18:25:14 +01:00
Thomas Gelf 2cfa78af14 FieldLoader: do not fail missing fields
One might have toggled template or command, sent values for missing fields
might therefore be perfectly legal and should be silently ignored

refs #13241
2016-12-13 16:57:32 +01:00
Thomas Gelf e60fdb31b8 DirectorObjectForm: move check_command to main
fixes #13551
2016-12-13 16:57:05 +01:00
Thomas Gelf e207bb2bc9 DirectorObjectForm: resolve ids 2016-12-13 16:34:31 +01:00
Thomas Gelf bb25de6126 FieldLoader: fix field handling issues
fixes #13241
fixes #13259
2016-12-13 16:34:31 +01:00
Thomas Gelf c1e80afff4 Boolean: fix multiedit-related issues
fixes #13131
2016-12-13 16:04:09 +01:00
Thomas Gelf 7c6a10013f AssignFilter: add 'contains' operator
fixes #13133
2016-12-13 14:49:36 +01:00
Thomas Gelf d2adc1b4ec IcingaObjectFieldLoader: attach fields to form...
...before adding them to a display group. Many thanks to Marc DeTrano for
troubleshooting this tricky issue.

fixes #13279
2016-12-13 12:46:45 +01:00
Thomas Gelf b39e7efce7 ObjectForm: allow to preset imports 2016-11-16 16:02:28 +01:00
Thomas Gelf 698d523c88 js: put focus on first form element 2016-11-16 13:20:31 +01:00
Thomas Gelf 63bf607a1d IcingaObjectFieldLoader: allow exotic var names
fixes #12094
fixes #12962
2016-11-08 02:00:38 +01:00
Thomas Gelf ee0def7d2b Lots of files: make IDE users happy 2016-11-01 18:28:36 +01:00
Thomas Gelf f41d453448 DeployConfigForm: provide link-like form for...
...deployments

fixes #11854
2016-10-30 10:52:14 +00:00
Thomas Gelf 78b01091eb DirectorObjectForm: deal with subform values 2016-10-27 19:39:40 +00:00
Thomas Gelf 27634fe722 QuickBaseForm: allow for multiple module-related...
...prefix paths
2016-10-27 18:17:21 +00:00
Thomas Gelf 2b094067a5 QuickBaseForm: add missing use statement 2016-10-27 17:33:35 +00:00
Thomas Gelf bab23c8f9b Form: split constructor to make tests easier 2016-10-27 16:31:04 +00:00
Thomas Gelf d59604bd93 ServiceSet: rework sets, allow for vars and...
...all other service properties when adding services to a set
2016-10-25 23:12:23 +00:00
Thomas Gelf 1724a78da5 DirectorObjectForm: do not set null values 2016-10-25 23:12:23 +00:00
Thomas Gelf c41009992e IcingaObjectFieldLoader: allow to combine objects 2016-10-25 23:12:23 +00:00
Thomas Gelf f87e80989d DirectorObjectForm: persist the field loader 2016-10-25 23:12:23 +00:00
Thomas Gelf 0db659cc4e IcingaObjectFieldLoader: check for fields support 2016-10-25 23:12:23 +00:00
Thomas Gelf 00f21f838b DirectorObjectForm: simplify inhertance code 2016-10-25 23:12:23 +00:00
Thomas Gelf 0d86c24cd8 Huge change, getting rid of legacy assignment...
...code. All objects should work with the new code base right now
2016-10-24 03:41:37 +00:00
Thomas Gelf aeafec37d7 FormDataFilter: simplify HTML, Code and style 2016-10-23 04:23:38 +00:00
Thomas Gelf 24478ede12 DataFilter: json_en/decode when passing to form 2016-10-23 03:14:52 +00:00
Thomas Gelf 8f2b9fea07 DataFilter: automagic fix for not(multiple) 2016-10-22 07:02:09 +00:00
Thomas Gelf a819e7c92c DataFilter: attribs are no longer needed 2016-10-22 07:02:09 +00:00
Thomas Gelf 8ade496fdc DataFilter: refactor the whole class(es) 2016-10-22 07:02:09 +00:00
Thomas Gelf 037c588d26 FormDataFilter: change icon for expression 2016-10-22 07:02:09 +00:00
Thomas Gelf 9349ba0f2a FormDataFilter: new implementation for assignments
First prototype
2016-10-22 07:02:09 +00:00
Thomas Gelf 7c31b37f27 IcingaServiceForm: remove duplicate code
Elements in this list are optional and may be used in various forms,
so keeping this in the base class is preferrable here
2016-10-22 06:09:00 +00:00
Thomas Gelf 0791b900f3 QuickBaseForm: allow translation tools find 'None' 2016-10-22 06:08:44 +00:00
Corentin Ardeois e7bd4343b5 Add support for Apply for rules in services
Apply for rules are defined through `apply_for` property
Only Array custom variables will be eligible in apply_for dropdown.

API Example:
```bash
 ./director-curl POST director/service?name=my_service '{"apply_for": "for (checked_tcp_port in host.vars.checked_tcp_ports)" }'
 ```

 Will render as:
 ```
  apply Service "my_service" for (checked_tcp_port in host.vars.checked_tcp_ports) {
      ...
  }
  ```
Feature: https://dev.icinga.org/issues/11976

Depends-On: https://github.com/Icinga/icingaweb2-module-director/pull/20
refs #11976
2016-10-22 06:00:54 +00:00
Thomas Gelf b62b602f7d DirectorObjectForm: move imports below name 2016-10-20 02:22:34 +00:00
Thomas Gelf d5234f723d HostController: no loop check for 'fake' services
Inherited services do not exist in the db. As many services would
carry their template's name, the fallback to a name-based loop check
would trigger an erraneous error. So we trigger no preliminary loop
check for those now.

fixes #12938
2016-10-20 01:09:34 +00:00
Thomas Gelf edbda2c592 IcingaObjectFieldLoader: silently ignore setValues
...when called for an object without custom var support
2016-10-17 16:57:25 +00:00
Thomas Gelf 23ef9a707c MultiEdit: make it independent of an object type 2016-10-14 18:32:34 +00:00
Thomas Gelf 6a54e00402 MultiEdit: code cleanup, add custom var support
fixes #12465
fixes #12906
fixes #11614
2016-10-14 17:17:07 +00:00
Thomas Gelf 6f46e6b496 YesNo: new boolean-like form fields
fixes #12927
2016-10-14 13:39:43 +00:00
Thomas Gelf 98708e6496 Forms: better error handling
fixes #12926
2016-10-14 13:35:30 +00:00
Thomas Gelf 2df7144240 TemplateResolver: no more false alarms...
...when multiple paths lead to the same template

refs #11803
2016-10-14 11:26:41 +00:00
Thomas Gelf 041fd52174 FieldLoader, TemplateResolver: more cleanup
A few fixes related to modified imports for unstored objects

refs #12922
2016-10-14 09:59:08 +00:00
Thomas Gelf e04acbc55f IcingaObjectFieldLoader: do not fail on emtpy...
...parents
2016-10-14 08:33:58 +00:00
Thomas Gelf 913c2687b6 IcingaObjectFieldLoader: first implementation
Should already replace all former functionality

refs #12904
2016-10-13 21:25:03 +00:00
Markus Frosch f527e31b14 Merge branch 'bugfix/endpoint-remove-import-12920'
fixes #12920
2016-10-13 16:54:34 +02:00
Markus Frosch cc61831258 DirectorObjectForm: Allow form to select if imports are required
refs #12920
2016-10-13 16:37:49 +02:00
Thomas Gelf 71b3459540 DirectorDatafieldForm: allow to wipe all related...
...custom variables when removing a field

fixes #12916
2016-10-13 14:02:51 +00:00
Thomas Gelf 0e45429196 ObjectForm: do not allow to choose type...
...when one is already given
2016-10-13 11:55:53 +00:00
Thomas Gelf e99568fffc DirectorObjectForm: add unique error message...
...without adding an error in case we detect a loop. Also improve
resolve cache invalidation and clean up old imports-related code

refs #11803
2016-10-12 15:23:54 +00:00
Thomas Gelf 7993724dcb IcingaTemplateResolver: detect and throw nesting..
...errors

fixes #11803
2016-10-12 14:16:19 +00:00
Thomas Gelf 70b8a9ea02 DirectorObjectForm: improve Exception error message 2016-10-05 18:03:07 +00:00
Thomas Gelf 04cae6f8f8 DirectorObjectForm: fix forgotten variable 2016-09-09 21:38:49 +00:00
Thomas Gelf f52cd5ea77 DirectorDatafield: simplify usage 2016-09-09 21:32:26 +00:00
Thomas Gelf 217fb38517 IcingaObject: implement supportsAssignRules 2016-09-09 09:06:31 +00:00
Thomas Gelf 1144b5d55f DirectorObjectForm: fix legacy range field 2016-09-05 18:52:22 +00:00
Thomas Gelf 336257680c Settings: remove settings logic from DB...
...and keep helper method for easy instantiation
2016-08-27 13:20:03 +00:00
Thomas Gelf 77c915c897 DirectorObjectForm: normalize command field values...
...with special data types even when filled at services level

fixes #12400
fixes #11692
fixes #11477
2016-08-26 13:48:44 +00:00
Thomas Gelf 5355558519 DirectorObjectForm: place failed command fields...
...into the correct display group
2016-08-26 13:34:57 +00:00
Thomas Gelf 89d8536a92 IconHelper: start to separate concerns in forms
One new small helper class for this purpose
2016-08-05 12:49:11 +00:00
Thomas Gelf 14b5e74bb2 DirectorObjectForm: skip timeperiod range params...
...on redirect after removal. TimeperiodRange::getOnDeleteUrl would
be a better place for this, but I do not like that solution either :p

fixes #12316
2016-08-04 18:29:18 +00:00
Thomas Gelf c2f3609cc6 DirectorObjectForm: provide event command for...
...hosts and services

fixes #12117
fixes #12126
2016-07-20 17:53:19 +02:00
Thomas Gelf 5e2de81767 DirectorObjectForm: prefer sent over inherited 2016-06-27 23:04:02 +02:00
Thomas Gelf 3b4b85374d QuickForm: fully respect false submit label 2016-06-26 14:02:21 +02:00
Thomas Gelf 97e52b231d ImportsourceController: fix redirect after delete 2016-06-25 23:39:28 +02:00
Thomas Gelf 7438b07c91 DirectorObjectForm: remove superfluous outdated...
...imported objects refresh
2016-06-17 20:42:12 +02:00
Thomas Gelf 35d4a08632 DirectorObjectForm: add extra properties
fixes #11579
2016-06-17 09:38:48 +02:00
Thomas Gelf 271dc6add5 DirectorObjectForm: addd brackets to be on the...
...safe side for all PHP versions
2016-06-16 17:00:09 +02:00
Thomas Gelf 144b20afc8 DirectorObjectForm: getSentOrObjectValue should...
...not fail on missing elements
2016-06-16 14:17:40 +02:00
Thomas Gelf 04a9a12d84 ExtensibleSet: fix phpcs complaint 2016-06-12 11:14:12 +02:00
Thomas Gelf cc9f5037f4 IcingaNotificationForm: enforce & render apply to
fixes #11895
2016-06-09 23:49:02 +02:00
Thomas Gelf baf6d8f62f DirectorObjectForm: hardcode boolean handling 2016-05-25 15:25:21 +02:00
Thomas Gelf d01194a7b4 QuickForm: optimize runtime order 2016-05-24 20:25:16 +02:00
Thomas Gelf 0ce8a29b52 Boolean: form sends '' for null value 2016-05-24 19:59:02 +02:00
Thomas Gelf d435ca37f7 IcingaNotificationForm: fix timeperiod loading
fixes #11576
2016-05-23 13:00:32 +02:00
Thomas Gelf dca6cc8a01 ExtensibleSet: respect strings when filtering 2016-05-20 10:46:01 +02:00
Thomas Gelf eb52918711 ExtensibleSet: do not array-filter when null 2016-05-20 10:40:58 +02:00
Thomas Gelf 5952de5841 DirectorObjectForm: make use of element filters 2016-05-20 08:37:46 +02:00
Thomas Gelf 0a475e3bcb DirectorObjectForm: remove imports exception...
...this is already handled by the object itself
2016-05-20 08:37:02 +02:00
Thomas Gelf df2a5899f6 ExtensibleSet: remove empty strings at filter time 2016-05-20 08:13:13 +02:00
Thomas Gelf 7622200f2e Element/Boolean: ignore PHPCS violation as of ZF1 2016-05-19 20:54:18 +02:00
Thomas Gelf 8a6f7c0e38 ExtensibleSet: remove empty components
fixes #11360
2016-05-19 15:02:30 +02:00
Thomas Gelf 41731241c5 DataTypeBoolean: provide a new data type
fixes #11594
2016-05-19 14:59:25 +02:00
Thomas Gelf da5ee55abf ViewHelperRaw: add new form decorator showing...
...raw, unfiltered values
2016-05-19 14:53:41 +02:00
Thomas Gelf 728c0745ae DirectorObjectForm: provide setSentValue helper 2016-05-13 14:13:48 +02:00
Thomas Gelf 32009ce458 DirectorObjectForm: require imports for all...
...non-template objects
2016-04-03 21:32:49 +02:00
Thomas Gelf e4b609c647 DirectorObjectForm: allow missing elements...
...when defining display groups, but only specific ones. I still want
to see exceptions for all the others
2016-03-30 19:51:29 +02:00
Thomas Gelf d6be2e777c DirectorObjectForm: add max_check_attempts 2016-03-30 19:19:00 +02:00
Thomas Gelf f25b47e1bc DirectorObjectForm: fix exception on no data 2016-03-29 18:50:52 +02:00
Thomas Gelf f2dc9c59e5 DirectorObjectForm: provide check_period element 2016-03-27 23:58:44 +02:00
Thomas Gelf fd1bc38609 DirectorObjectForm: blacklist ids not names...
...when fetching allowed templates
2016-03-27 12:55:05 +02:00
Thomas Gelf aee65a706a QuickSubForm: one more forgotten file 2016-03-26 16:21:23 +01:00
Thomas Gelf ec97306e66 DirectorObjectForm: handle data from/for assigns 2016-03-24 11:42:58 +01:00
Thomas Gelf b09593ff75 DirectorObjectForm: move valueIsEmpty to QuickBase 2016-03-24 02:27:10 +01:00
Thomas Gelf 5fc16f393d QuickBaseForm: take over parts of QuickForm 2016-03-24 01:59:50 +01:00
Thomas Gelf 324e15e2b5 QuickForm: add helper for shorter display group...
...definitions
2016-03-22 23:43:47 +01:00
Thomas Gelf 1ca627f66c DirectorObjectForm: use valueIsEmpty 2016-03-22 02:56:10 +01:00
Thomas Gelf 16bc8bf6b3 QuickForm: add missing beforeSetup hook 2016-03-22 02:09:37 +01:00
Thomas Gelf 5faf7c8612 IcingaHostForm: just a lame form field 2016-03-22 02:02:25 +01:00
Thomas Gelf 712dc6c9b7 DirectorObjectForm: handle ordering before setup 2016-03-22 01:34:21 +01:00
Thomas Gelf afde1806f7 QuickForm: add beforeSetup hook 2016-03-22 01:26:44 +01:00
Thomas Gelf 747fd966d2 DirectorObjectForm: refactor getSentOrObjectValue 2016-03-22 00:22:54 +01:00
Thomas Gelf 5e540880e5 Revert "DirectorObjectForm: do not set null defaults"
This reverts commit ce7b6031ff.

Broke quite some forms
2016-03-21 22:51:03 +01:00
Thomas Gelf 75f8872962 QuickForm: allow for named hints
This is necessary as I want to refer to them in display groups
2016-03-21 19:08:21 +01:00
Thomas Gelf ce7b6031ff DirectorObjectForm: do not set null defaults 2016-03-21 13:20:16 +01:00
Thomas Gelf 99302d40f4 IcingaService: fix redirection for host services 2016-03-20 12:04:06 +01:00
Thomas Gelf 65a881ca80 DirectorObjectForm: fix lost pointer issue
This has been a scary one :p

fixes #11409
fixes #11410
2016-03-18 21:16:25 +01:00
Thomas Gelf 0a022644b4 DirectorObjectForm: require imports for objects 2016-03-18 15:04:23 +01:00
Thomas Gelf 4417d58349 DirectorObjectForm: do not allow external objects 2016-03-18 14:39:00 +01:00
Thomas Gelf 906644cb18 DirectorObjectForm: no object type change allowed 2016-03-18 14:36:57 +01:00
Thomas Gelf 574cb91093 DirectorObjectForm: add form field ordering 2016-03-18 13:01:27 +01:00
Thomas Gelf 85b26822c0 DirectorObjectForm: failsafe check for object_type 2016-03-18 11:38:08 +01:00
Thomas Gelf 2c8b16893c DirectorObjectForm: fix strange notifications
...like "The operty has been modified"
2016-03-17 08:47:59 +01:00
Thomas Gelf 6ea94dd7a2 DirectorObjectForm: no elements for unknown vars 2016-03-17 02:27:06 +01:00
Thomas Gelf 0119e0f4a2 DirectorObjectForm: add and use isNew helper 2016-03-17 01:42:57 +01:00
Thomas Gelf 6e5fa49e1a DirectorObjectForm: fix booleans 2016-03-16 23:20:36 +01:00
Thomas Gelf 433cb887c0 IcingaNotificationForm: add related user(-groups) 2016-03-16 14:07:09 +01:00
Thomas Gelf 7209f162b2 IcingaNotificationForm: add times to main group 2016-03-12 01:44:28 +01:00
Thomas Gelf f971839f82 Notification: form and rendering improvements 2016-03-12 01:35:24 +01:00
Thomas Gelf b6dc8e5faf Db, DirectorObjectForm: support notifications 2016-03-11 09:07:22 +01:00
Thomas Gelf 98ffe3628d DirectorObjectForm: commands -> templates, not obj 2016-03-10 21:14:20 +01:00
Thomas Gelf d3957c276c application/forms: more object form abstraction 2016-03-10 20:44:12 +01:00
Thomas Gelf e8a28a12da DirectorObjectForm: replace state filter helpers 2016-03-10 19:32:29 +01:00
Thomas Gelf 5a5587eaab DirectorObjectForm: style 2016-03-10 19:06:02 +01:00
Thomas Gelf be637551be application/forms: unify and clean up group forms 2016-03-09 20:55:26 +01:00
Thomas Gelf a3c7e57333 DirectorObjectForm: fix typo 2016-03-09 19:37:50 +01:00
Thomas Gelf 6105ae4386 FormExtensibleSet: fix add button 2016-03-09 09:45:06 +01:00
Thomas Gelf fda920d3ad DirectorObjectForm: inheritance error for arrays 2016-03-09 09:26:36 +01:00
Thomas Gelf 1d4b508ff3 different files: style 2016-03-08 22:30:12 +01:00
Thomas Gelf 572ac3ad4c DirectorObjectForm: lazy relations only for Icinga 2016-03-07 18:22:19 +01:00
Thomas Gelf 2826408c72 DirectorObjectForm: improve 'imports' element 2016-03-07 14:54:06 +01:00
Thomas Gelf da29da0065 forms/Icinga*: choose type first, then go on 2016-03-07 14:20:58 +01:00
Thomas Gelf aa53d57ec8 DirectorObjectForm: no default object_type 2016-03-07 14:14:52 +01:00
Thomas Gelf 8da2991e76 DirectorObjectForm: object knows redirect params 2016-03-07 13:41:30 +01:00