5439 Commits

Author SHA1 Message Date
Johannes Meyer
c65369602f
Phpstan: Fix deprecated function param types (#2858) 2024-02-05 16:17:32 +01:00
Sukhwinder Dhillon
9cccd9067e phpstan: Scan all available modules 2024-02-05 16:05:24 +01:00
Sukhwinder Dhillon
bcdb8911f9 Update phpstan-baseline 2024-02-05 16:05:24 +01:00
Sukhwinder Dhillon
d879186f0e Fix wrong method param types and add var type hints 2024-02-05 16:05:24 +01:00
Sukhwinder Dhillon
3fc16910f7 Ini_set() #param 2 must be string (php < 8.1) 2024-02-05 16:05:24 +01:00
Sukhwinder Dhillon
2acfdecb8d RestApiClient: Remove curl's return type hint and wrong curl_error() param
Php >= 8 returns CurlHandle instead of resource, which confuses phpstan.
2024-02-05 16:05:24 +01:00
Sukhwinder Dhillon
cc3bfd5437 BranchHelper: Define method return types 2024-02-05 16:05:24 +01:00
Sukhwinder Dhillon
c9e78ba7d5 IcingaObjectLegacyAssignments: Fix incorrect if condition 2024-02-05 16:05:23 +01:00
Sukhwinder Dhillon
bb8076a09d var_export() expects #param 2 to be bool 2024-02-05 16:05:23 +01:00
Sukhwinder Dhillon
deddcde0dd phpstan: Relax unmatched ignore errors for certain messages 2024-02-05 16:05:23 +01:00
Sukhwinder Dhillon
9f58dcf8d9 phpstan: Strict check function/class name-case and fix violations 2024-02-05 16:05:23 +01:00
Johannes Meyer
35c6086db3
Support Content-Security-Policy (#2857)
resolves #2845
2024-01-25 10:44:48 +01:00
Sukhwinder Dhillon
28d8f0e7d1 ImportsourceController: Remove unnecessary inline js for collapse 2024-01-19 15:17:41 +01:00
Sukhwinder Dhillon
be6447874c Remove not in use class ReadOnlyFormAvpTable 2024-01-19 15:17:41 +01:00
Sukhwinder Dhillon
c25a66b484 Avoid inline css style 2024-01-19 15:17:41 +01:00
Sukhwinder Dhillon
72f44c326f Remove unnecessary and unused code 2024-01-19 15:17:41 +01:00
Sukhwinder Dhillon
708b4dbe8f Remove unnecessary inline style 2024-01-19 15:17:41 +01:00
Thomas Gelf
6e57e6dc98 IcingaObjectGroup: no membership refresh w/o assign
fixes #2784
2024-01-19 12:29:18 +01:00
Johannes Meyer
0493f93a74
Fix form field suggestions (#2840)
Other available fields should be suggested when no check command has
been chosen for service template.

fixes #2826, #2815
2024-01-16 16:56:46 +01:00
raviks789
80d566f42d PHPStan: Exclude static analysis of tests 2024-01-16 15:30:05 +01:00
raviks789
a0fba398a1 Set up mockery library for php unit test 2024-01-16 15:30:05 +01:00
raviks789
0ea0a8fd83 Fix zone creation and deletion for tests 2024-01-16 15:27:27 +01:00
Johannes Meyer
58e2a8fca6 Change parent class of BaseTestCase to \Icinga\Test\BaseTestCase 2024-01-16 14:33:49 +01:00
raviks789
0ff6c8ee62 FormFieldSuggestionTest: Add tests for nullable command argument 2024-01-16 12:38:19 +01:00
raviks789
c0e870d543 Fix form field suggestions
Other available fields should be suggested when no check command has been
chosen for service template.
2024-01-16 12:38:19 +01:00
Johannes Meyer
6851778863
add support for icingadb as only icingaweb2 data backend (#2635) 2024-01-16 11:16:08 +01:00
Sukhwinder Dhillon
a850ff13d7 IcingadbBackend: Remove isAvailable method and property
As it is only used internally now, it is no more required
2024-01-16 10:27:10 +01:00
Sukhwinder Dhillon
2461724271 IcingadbBackend: Drop icingadb restriction check and only check for director restrictions
Monitoring does the same.
2024-01-16 09:51:47 +01:00
Sukhwinder Dhillon
147170e58a phpstan: Add icingadb module 2024-01-16 09:51:47 +01:00
Sukhwinder Dhillon
d30a56a385 Fix phpcs issues 2024-01-16 09:51:47 +01:00
Sukhwinder Dhillon
d26a619577 ServiceController: Use given properties to get host/service name 2024-01-16 09:51:47 +01:00
Sukhwinder Dhillon
4ef7f5664a ActionController::backend(): Add condition to check which backend should be used
- If both are available
2024-01-16 09:51:47 +01:00
Sukhwinder Dhillon
f52d05de31 IcingadbBackend: Apply director restrictions properly 2024-01-16 09:51:47 +01:00
Sukhwinder Dhillon
8a489bcc46 HostController: Move ServiceFinder::getRedirectionUrl() method code to findserviceAction()
- This helps to detect backend easily, and was only called in this method anyway.
- Add and use helping method getServicesReadOnlyPermission()
-
2024-01-16 09:51:47 +01:00
Sukhwinder Dhillon
4e6528e862 ServiceController: Remove redudant if condition 2024-01-16 09:51:47 +01:00
Sukhwinder Dhillon
26f8769d28 Icingadb (Host/Service)Actions: Fix permissions and code style 2024-01-16 09:51:47 +01:00
Sukhwinder Dhillon
1048c33fa4 configuration.php: Only provide monitoring/icingadb permissions/restrictions if module exists 2024-01-16 09:51:47 +01:00
Sukhwinder Dhillon
a272b0d242 Introduce icingadb permissions/restrictions 2024-01-16 09:51:47 +01:00
Sukhwinder Dhillon
db7181c29e Backend: Remove unnecessary calls to isAvailable() 2024-01-16 09:51:47 +01:00
Sukhwinder Dhillon
eeaf87741a IcingadbBackend: Always check if module is available 2024-01-16 09:51:47 +01:00
Sukhwinder Dhillon
677f5dc72a Monitoring/IcingadbBackend: Handle if $hostName or $serviceName is null 2024-01-16 09:51:47 +01:00
Sukhwinder Dhillon
956cce84cb Cleanup code
- Remove superfluous methods/usages
- Simplify the code
2024-01-16 09:51:44 +01:00
Sukhwinder Dhillon
8ea8a62ef4 BackendInterface: Add phpDocs 2024-01-15 16:25:05 +01:00
Sukhwinder Dhillon
604667ca65 Relocate Backend classes 2024-01-15 16:25:02 +01:00
Sukhwinder Dhillon
9baa3c4341 Remove redudant class MonitorBackendMonitoring and adjuct code accordigly
- Use class `Monitoring` instead
- Remove not in use methods from `MonitorBackend` interface and from classes that implements this interface
- Add param types and return type hint to methods
2024-01-15 16:24:27 +01:00
Sukhwinder Dhillon
89134e0366 Remove obsolate class Backend and its usages
- Create the backend directly in ActionController::backend()
- Simplify the code
2024-01-15 16:24:25 +01:00
Tobias Tiederle
b28b36f815 move classes into subfolder
fix some problems and mark TODO
2023-12-04 10:12:54 +01:00
Tobias Tiederle
1c6090193d add support for icingadb as only icingaweb2 data backend 2023-12-04 10:12:54 +01:00
Sukhwinder Dhillon
12cca3ebcf
Phpstan: Streamline vendor file location with local dev-env (#2838) 2023-12-04 10:12:04 +01:00
Sukhwinder Dhillon
4edf4b43a9 Github Actions: Add checks for php 8.3 2023-12-01 10:56:12 +01:00