Commit Graph

454 Commits

Author SHA1 Message Date
Thomas Gelf e752d7f7ae Changelog: prepare for v1.4.0 2017-09-11 15:17:29 +02:00
Thomas Gelf 04a72fbc5a ExtensibleSetElement: no autocomplete for...
...existing options - might be confusing
2017-09-04 12:27:48 +02:00
Thomas Gelf 71057ef47a DirectorObjectForm: do not set imports from...
...choices when there are no such.

fixes #1111
2017-09-03 10:41:57 +02:00
Thomas Gelf fd400977f2 IcingaObject: do not resolve imports when...
...resolving related objects
2017-08-26 16:17:07 +02:00
Thomas Gelf 84b6196e79 QuickBaseForm: allow for ipl elements in Html 2017-08-25 17:30:29 +02:00
Thomas Gelf 8edb7e50fb DirectorObjectForm: do not sort sets when removing
...entries

fixes #1099
2017-08-25 15:16:16 +02:00
Thomas Gelf fbcf206b3a IcingaObjectFieldLoader: cleanup 2017-08-25 10:52:02 +02:00
Thomas Gelf bd0ccc6ca4 FieldLoader: do not add NULL id to list of objects
fixes #1102
2017-08-25 09:28:47 +02:00
Thomas Gelf e05c3a8556 IcingaHostForm: fix bug with no available tpl...
...and improve element ordering

fixes #1108
2017-08-24 22:42:01 +02:00
Thomas Gelf 6a60b3942c DirectorObjectForm: allow for string imports...
...and deal with empty choices
2017-08-23 23:52:59 +02:00
Thomas Gelf b3ae6ea68b ExtensibleSet: make sure to stop on errors...
...that have been "manually" set
2017-08-22 17:43:25 +02:00
Thomas Gelf ab69e1c55f DirectorObjectForm: improve error handling
Template resolving has been changed, adjust error handling accordingly
2017-08-22 10:13:37 +02:00
Thomas Gelf 10391cab8e ExtensibleSetElement: implement optgroups
fixes #1037
2017-08-21 22:54:38 +02:00
Thomas Gelf 8402f58610 DirectorObjectForm: work with string imports 2017-08-21 21:35:11 +02:00
Thomas Gelf b55541097e QuickForm: helper for exception message text 2017-08-21 21:00:41 +02:00
Thomas Gelf 7b2e13f9c1 DirectorObjectForm, TemplateTree: more fixes...
...related to inheritance and fields
2017-08-21 15:15:06 +02:00
Thomas Gelf 45111ac622 DirectorObjectForm: fix issue with pre-set imports 2017-08-21 14:49:13 +02:00
Thomas Gelf fa3042c39f Boolean: keep value when validating
Might fix weird issues related to booleans
2017-08-18 16:15:30 +02:00
Thomas Gelf b8d3487350 ExtensibleSetElement: move "add" option out of...
...tab order
2017-08-18 10:49:42 +02:00
Thomas Gelf f65275bda7 DirectorObjectForm: use new inheritance helpers 2017-08-16 13:56:04 +02:00
Thomas Gelf 38ebf2dd2d IcingaObjectFieldLoader: use new repository-based
...inheritance helper methods
2017-08-13 12:05:03 +02:00
Thomas Gelf 74a887f5af DirectorObjectForm: fix redirectionUrl for...
...objects without id

fixes #1043
2017-07-28 22:40:16 +02:00
Thomas Gelf b2736e1776 ObjectForms: fix weird issues with 'add' forms 2017-07-28 18:46:11 +02:00
Thomas Gelf 098cd0a57a Sync: completely refactor table, form, controller 2017-07-25 17:53:59 +02:00
Thomas Gelf fadbde5e9b HostForm: take over logic from base form, clean up 2017-07-25 10:18:07 +02:00
Thomas Gelf c295218a5c HostController: code cleanup, little fixes, tabs 2017-07-24 10:52:36 +02:00
Thomas Gelf e6a9b1197d QuickForm: allow options for submit button helpers 2017-07-19 18:29:16 +02:00
Thomas Gelf 953baf5b95 DataFilter: code cleanup 2017-07-14 13:21:42 +02:00
Thomas Gelf 8f8f9a508e QuickForm: split method, new helpers for buttons 2017-07-14 13:21:42 +02:00
Thomas Gelf b9fd1f42d9 DirectorObjectForm: fallback, static auth 2017-07-14 13:21:42 +02:00
Thomas Gelf 4a0e8df2f2 Host,Service: add check_timeout property
fixes #546
2017-07-14 13:21:42 +02:00
Thomas Gelf b11c6b9f34 Boolean: hardcode isValid for true/false
Not perfect, but should do the job unless we move to better forms

fixes #690
2017-07-14 13:21:42 +02:00
Thomas Gelf 2e0e601cee QuickBaseForm: less code 2017-07-14 13:21:42 +02:00
Thomas Gelf e562d00a50 QuickForm: improve REST API support
refs #486
2017-07-14 13:21:42 +02:00
Thomas Gelf 15942f93f7 DirectorForm: new base class, should get logic...
...useful to all Director forms, even for those not dealing with a DbObject
2017-07-14 13:21:42 +02:00
Thomas Gelf 6aaae3c445 TimePeriods: do not enforce template 2017-07-14 13:21:42 +02:00
Thomas Gelf ed6a77af5d ExtensibleSet: allow to hide elements, for choices 2017-07-14 13:21:42 +02:00
Thomas Gelf ceebe08ecd TemplateChoice: work without form loader 2017-07-14 13:21:42 +02:00
Thomas Gelf 0b89c222eb IcingaTemplateChoice: take over code generating...
...the choice form element
2017-07-14 13:21:42 +02:00
Thomas Gelf d7422fa55c DirectorObjectForm: adjust choice loading to fit
...new class names
2017-07-14 13:21:42 +02:00
Thomas Gelf 2f8ec92722 DirectorObjectForm: implement choices 2017-07-14 13:21:42 +02:00
Thomas Gelf 6f3c76c4f2 IconHelper: add new icons 2017-07-14 13:21:42 +02:00
Thomas Gelf 04e22f5a23 ExtensibleSet: completely refactored based on ipl 2017-07-14 13:21:42 +02:00
Thomas Gelf 4590fa1d73 QuickForm: guess what? We are ValidHtml! 2017-07-14 13:21:42 +02:00
Thomas Gelf d84a3c68e0 QuickForm: no role and tabindex for fake submit 2017-07-14 13:21:42 +02:00
Thomas Gelf 02a3652c86 Restrictriction: add simple hostgroup restrictions
refs #832
2017-07-14 13:21:42 +02:00
Thomas Gelf 220d15c523 IcingaObjectFieldLoader: return early...
...and save CPU-cycles
2017-04-27 15:45:17 +02:00
Thomas Gelf 82e79c810f IcingaServiceSetForm: redirect to host services...
...when adding a set to a single host

fixes #804
2017-02-17 16:35:13 +01:00
Thomas Gelf 099eca0d0b IcingaCommandForm: allow to configure zones
fixes #802
2017-02-17 16:08:57 +01:00
Thomas Gelf 164b5bd93d Fields: fix inheriting fields from commands
refs #712
refs #731
2017-01-19 13:50:50 +01:00
Thomas Gelf 44866c5176 IcingaObjectFieldLoader: force values related...
...to filtered data fields to be removed. This also changes field order and
places fields without filter first
2017-01-18 11:20:59 +01:00
Thomas Gelf 3bbf06d6b7 DirectorObjectForm: simplify method call
FieldLoader already has the object
2017-01-18 11:04:23 +01:00
Thomas Gelf b7a10d296c phpcs: mostly new PSR-2 SpacingAfter/Before checks 2017-01-13 20:54:52 +01:00
Thomas Gelf 9e771f2d5a Fix phpcs complaints 2017-01-13 19:47:54 +01:00
Thomas Gelf f874a79bb4 IcingaObjectFieldLoader: no mandatory field on cmd
fixes #12644
2017-01-13 16:05:34 +01:00
Thomas Gelf 9b6eda4e97 IcingaObjectFieldLoader: cleanup, improve handling 2017-01-13 15:24:50 +01:00
Thomas Gelf 7a3a845570 Forms: try to give dev UI more hints on fluent...
...code
2017-01-13 13:15:01 +01:00
Thomas Gelf 9fc3957f11 QuickForm: fix broken submit button 2017-01-02 10:49:14 +01:00
Thomas Gelf 87f88bf0c7 DirectorObjectForm: allow to hook custom code...
...after fields have been added
2017-01-02 10:17:49 +01:00
Thomas Gelf c9929f7b17 QuickForm: postpone default submit button creation
This gives more possibilities to override them at a late stage
2017-01-02 10:14:30 +01:00
Thomas Gelf 990e3fc04b DirectorObjectFrom: set every property we get
fixes #13659
fixes #13673
2016-12-19 14:32:52 +01:00
Thomas Gelf 3d8ccf2448 DirectorObjectForm: skip empty related sets...
...provides as objects

fixes #13605
2016-12-15 11:44:52 +01:00
Thomas Gelf 65181ca67e ExtensibleSet: be strict on values...
...and provide a meaningful Exception in case something fails

refs #13605
2016-12-15 11:43:56 +01:00
Thomas Gelf 15b031272e IcingaObjectFieldLoader: pass db to resolved...
...flat object

refs #13583
2016-12-14 22:44:56 +01:00
Thomas Gelf e85c13ae13 DirectorObjectForm: some more steps to simplify...
...this old monster

fixes #13583
2016-12-14 21:07:07 +01:00
Thomas Gelf a30f34a026 DirectorObjectForm: be careful when continuing...
...after an exception
2016-12-14 20:59:26 +01:00
Thomas Gelf cbb3c7aa88 DirectorObjectForm: remove unused parameter for...
...object() helper method
2016-12-14 20:48:59 +01:00
Thomas Gelf 145e1fc6a9 DirectorObjectForm: add has_agent to early props 2016-12-14 20:27:52 +01:00
Thomas Gelf 7e7e2601d3 ObjectFields: prefix filters, respect inheritance
refs #13253
2016-12-14 17:33:13 +01:00
Thomas Gelf 5847913987 Fields: add a possibility to show fields based...
...on filter rules
2016-12-14 16:36:33 +01:00
Thomas Gelf 4c1ab4dae6 php: just some comments and cleanup 2016-12-13 18:25:14 +01:00
Thomas Gelf 2cfa78af14 FieldLoader: do not fail missing fields
One might have toggled template or command, sent values for missing fields
might therefore be perfectly legal and should be silently ignored

refs #13241
2016-12-13 16:57:32 +01:00
Thomas Gelf e60fdb31b8 DirectorObjectForm: move check_command to main
fixes #13551
2016-12-13 16:57:05 +01:00
Thomas Gelf e207bb2bc9 DirectorObjectForm: resolve ids 2016-12-13 16:34:31 +01:00
Thomas Gelf bb25de6126 FieldLoader: fix field handling issues
fixes #13241
fixes #13259
2016-12-13 16:34:31 +01:00
Thomas Gelf c1e80afff4 Boolean: fix multiedit-related issues
fixes #13131
2016-12-13 16:04:09 +01:00
Thomas Gelf 7c6a10013f AssignFilter: add 'contains' operator
fixes #13133
2016-12-13 14:49:36 +01:00
Thomas Gelf d2adc1b4ec IcingaObjectFieldLoader: attach fields to form...
...before adding them to a display group. Many thanks to Marc DeTrano for
troubleshooting this tricky issue.

fixes #13279
2016-12-13 12:46:45 +01:00
Thomas Gelf b39e7efce7 ObjectForm: allow to preset imports 2016-11-16 16:02:28 +01:00
Thomas Gelf 698d523c88 js: put focus on first form element 2016-11-16 13:20:31 +01:00
Thomas Gelf 63bf607a1d IcingaObjectFieldLoader: allow exotic var names
fixes #12094
fixes #12962
2016-11-08 02:00:38 +01:00
Thomas Gelf ee0def7d2b Lots of files: make IDE users happy 2016-11-01 18:28:36 +01:00
Thomas Gelf f41d453448 DeployConfigForm: provide link-like form for...
...deployments

fixes #11854
2016-10-30 10:52:14 +00:00
Thomas Gelf 78b01091eb DirectorObjectForm: deal with subform values 2016-10-27 19:39:40 +00:00
Thomas Gelf 27634fe722 QuickBaseForm: allow for multiple module-related...
...prefix paths
2016-10-27 18:17:21 +00:00
Thomas Gelf 2b094067a5 QuickBaseForm: add missing use statement 2016-10-27 17:33:35 +00:00
Thomas Gelf bab23c8f9b Form: split constructor to make tests easier 2016-10-27 16:31:04 +00:00
Thomas Gelf d59604bd93 ServiceSet: rework sets, allow for vars and...
...all other service properties when adding services to a set
2016-10-25 23:12:23 +00:00
Thomas Gelf 1724a78da5 DirectorObjectForm: do not set null values 2016-10-25 23:12:23 +00:00
Thomas Gelf c41009992e IcingaObjectFieldLoader: allow to combine objects 2016-10-25 23:12:23 +00:00
Thomas Gelf f87e80989d DirectorObjectForm: persist the field loader 2016-10-25 23:12:23 +00:00
Thomas Gelf 0db659cc4e IcingaObjectFieldLoader: check for fields support 2016-10-25 23:12:23 +00:00
Thomas Gelf 00f21f838b DirectorObjectForm: simplify inhertance code 2016-10-25 23:12:23 +00:00
Thomas Gelf 0d86c24cd8 Huge change, getting rid of legacy assignment...
...code. All objects should work with the new code base right now
2016-10-24 03:41:37 +00:00
Thomas Gelf aeafec37d7 FormDataFilter: simplify HTML, Code and style 2016-10-23 04:23:38 +00:00
Thomas Gelf 24478ede12 DataFilter: json_en/decode when passing to form 2016-10-23 03:14:52 +00:00
Thomas Gelf 8f2b9fea07 DataFilter: automagic fix for not(multiple) 2016-10-22 07:02:09 +00:00
Thomas Gelf a819e7c92c DataFilter: attribs are no longer needed 2016-10-22 07:02:09 +00:00
Thomas Gelf 8ade496fdc DataFilter: refactor the whole class(es) 2016-10-22 07:02:09 +00:00
Thomas Gelf 037c588d26 FormDataFilter: change icon for expression 2016-10-22 07:02:09 +00:00
Thomas Gelf 9349ba0f2a FormDataFilter: new implementation for assignments
First prototype
2016-10-22 07:02:09 +00:00
Thomas Gelf 7c31b37f27 IcingaServiceForm: remove duplicate code
Elements in this list are optional and may be used in various forms,
so keeping this in the base class is preferrable here
2016-10-22 06:09:00 +00:00
Thomas Gelf 0791b900f3 QuickBaseForm: allow translation tools find 'None' 2016-10-22 06:08:44 +00:00
Corentin Ardeois e7bd4343b5 Add support for Apply for rules in services
Apply for rules are defined through `apply_for` property
Only Array custom variables will be eligible in apply_for dropdown.

API Example:
```bash
 ./director-curl POST director/service?name=my_service '{"apply_for": "for (checked_tcp_port in host.vars.checked_tcp_ports)" }'
 ```

 Will render as:
 ```
  apply Service "my_service" for (checked_tcp_port in host.vars.checked_tcp_ports) {
      ...
  }
  ```
Feature: https://dev.icinga.org/issues/11976

Depends-On: https://github.com/Icinga/icingaweb2-module-director/pull/20
refs #11976
2016-10-22 06:00:54 +00:00
Thomas Gelf b62b602f7d DirectorObjectForm: move imports below name 2016-10-20 02:22:34 +00:00
Thomas Gelf d5234f723d HostController: no loop check for 'fake' services
Inherited services do not exist in the db. As many services would
carry their template's name, the fallback to a name-based loop check
would trigger an erraneous error. So we trigger no preliminary loop
check for those now.

fixes #12938
2016-10-20 01:09:34 +00:00
Thomas Gelf edbda2c592 IcingaObjectFieldLoader: silently ignore setValues
...when called for an object without custom var support
2016-10-17 16:57:25 +00:00
Thomas Gelf 23ef9a707c MultiEdit: make it independent of an object type 2016-10-14 18:32:34 +00:00
Thomas Gelf 6a54e00402 MultiEdit: code cleanup, add custom var support
fixes #12465
fixes #12906
fixes #11614
2016-10-14 17:17:07 +00:00
Thomas Gelf 6f46e6b496 YesNo: new boolean-like form fields
fixes #12927
2016-10-14 13:39:43 +00:00
Thomas Gelf 98708e6496 Forms: better error handling
fixes #12926
2016-10-14 13:35:30 +00:00
Thomas Gelf 2df7144240 TemplateResolver: no more false alarms...
...when multiple paths lead to the same template

refs #11803
2016-10-14 11:26:41 +00:00
Thomas Gelf 041fd52174 FieldLoader, TemplateResolver: more cleanup
A few fixes related to modified imports for unstored objects

refs #12922
2016-10-14 09:59:08 +00:00
Thomas Gelf e04acbc55f IcingaObjectFieldLoader: do not fail on emtpy...
...parents
2016-10-14 08:33:58 +00:00
Thomas Gelf 913c2687b6 IcingaObjectFieldLoader: first implementation
Should already replace all former functionality

refs #12904
2016-10-13 21:25:03 +00:00
Markus Frosch f527e31b14 Merge branch 'bugfix/endpoint-remove-import-12920'
fixes #12920
2016-10-13 16:54:34 +02:00
Markus Frosch cc61831258 DirectorObjectForm: Allow form to select if imports are required
refs #12920
2016-10-13 16:37:49 +02:00
Thomas Gelf 71b3459540 DirectorDatafieldForm: allow to wipe all related...
...custom variables when removing a field

fixes #12916
2016-10-13 14:02:51 +00:00
Thomas Gelf 0e45429196 ObjectForm: do not allow to choose type...
...when one is already given
2016-10-13 11:55:53 +00:00
Thomas Gelf e99568fffc DirectorObjectForm: add unique error message...
...without adding an error in case we detect a loop. Also improve
resolve cache invalidation and clean up old imports-related code

refs #11803
2016-10-12 15:23:54 +00:00
Thomas Gelf 7993724dcb IcingaTemplateResolver: detect and throw nesting..
...errors

fixes #11803
2016-10-12 14:16:19 +00:00
Thomas Gelf 70b8a9ea02 DirectorObjectForm: improve Exception error message 2016-10-05 18:03:07 +00:00
Thomas Gelf 04cae6f8f8 DirectorObjectForm: fix forgotten variable 2016-09-09 21:38:49 +00:00
Thomas Gelf f52cd5ea77 DirectorDatafield: simplify usage 2016-09-09 21:32:26 +00:00
Thomas Gelf 217fb38517 IcingaObject: implement supportsAssignRules 2016-09-09 09:06:31 +00:00
Thomas Gelf 1144b5d55f DirectorObjectForm: fix legacy range field 2016-09-05 18:52:22 +00:00
Thomas Gelf 336257680c Settings: remove settings logic from DB...
...and keep helper method for easy instantiation
2016-08-27 13:20:03 +00:00
Thomas Gelf 77c915c897 DirectorObjectForm: normalize command field values...
...with special data types even when filled at services level

fixes #12400
fixes #11692
fixes #11477
2016-08-26 13:48:44 +00:00
Thomas Gelf 5355558519 DirectorObjectForm: place failed command fields...
...into the correct display group
2016-08-26 13:34:57 +00:00
Thomas Gelf 89d8536a92 IconHelper: start to separate concerns in forms
One new small helper class for this purpose
2016-08-05 12:49:11 +00:00
Thomas Gelf 14b5e74bb2 DirectorObjectForm: skip timeperiod range params...
...on redirect after removal. TimeperiodRange::getOnDeleteUrl would
be a better place for this, but I do not like that solution either :p

fixes #12316
2016-08-04 18:29:18 +00:00
Thomas Gelf c2f3609cc6 DirectorObjectForm: provide event command for...
...hosts and services

fixes #12117
fixes #12126
2016-07-20 17:53:19 +02:00
Thomas Gelf 5e2de81767 DirectorObjectForm: prefer sent over inherited 2016-06-27 23:04:02 +02:00
Thomas Gelf 3b4b85374d QuickForm: fully respect false submit label 2016-06-26 14:02:21 +02:00
Thomas Gelf 97e52b231d ImportsourceController: fix redirect after delete 2016-06-25 23:39:28 +02:00
Thomas Gelf 7438b07c91 DirectorObjectForm: remove superfluous outdated...
...imported objects refresh
2016-06-17 20:42:12 +02:00
Thomas Gelf 35d4a08632 DirectorObjectForm: add extra properties
fixes #11579
2016-06-17 09:38:48 +02:00
Thomas Gelf 271dc6add5 DirectorObjectForm: addd brackets to be on the...
...safe side for all PHP versions
2016-06-16 17:00:09 +02:00
Thomas Gelf 144b20afc8 DirectorObjectForm: getSentOrObjectValue should...
...not fail on missing elements
2016-06-16 14:17:40 +02:00
Thomas Gelf 04a9a12d84 ExtensibleSet: fix phpcs complaint 2016-06-12 11:14:12 +02:00
Thomas Gelf cc9f5037f4 IcingaNotificationForm: enforce & render apply to
fixes #11895
2016-06-09 23:49:02 +02:00
Thomas Gelf baf6d8f62f DirectorObjectForm: hardcode boolean handling 2016-05-25 15:25:21 +02:00
Thomas Gelf d01194a7b4 QuickForm: optimize runtime order 2016-05-24 20:25:16 +02:00
Thomas Gelf 0ce8a29b52 Boolean: form sends '' for null value 2016-05-24 19:59:02 +02:00
Thomas Gelf d435ca37f7 IcingaNotificationForm: fix timeperiod loading
fixes #11576
2016-05-23 13:00:32 +02:00
Thomas Gelf dca6cc8a01 ExtensibleSet: respect strings when filtering 2016-05-20 10:46:01 +02:00
Thomas Gelf eb52918711 ExtensibleSet: do not array-filter when null 2016-05-20 10:40:58 +02:00
Thomas Gelf 5952de5841 DirectorObjectForm: make use of element filters 2016-05-20 08:37:46 +02:00
Thomas Gelf 0a475e3bcb DirectorObjectForm: remove imports exception...
...this is already handled by the object itself
2016-05-20 08:37:02 +02:00
Thomas Gelf df2a5899f6 ExtensibleSet: remove empty strings at filter time 2016-05-20 08:13:13 +02:00