From 032ca7ae50db1f970df667f613c3ee49fe225aeb Mon Sep 17 00:00:00 2001 From: Johannes Meyer <johannes.meyer@icinga.com> Date: Tue, 16 Apr 2019 12:01:49 +0200 Subject: [PATCH] SimpleQuery: Fail in case of missing order columns refs #3414 --- library/Icinga/Data/SimpleQuery.php | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/library/Icinga/Data/SimpleQuery.php b/library/Icinga/Data/SimpleQuery.php index 2831bde7c..2d0eeef6f 100644 --- a/library/Icinga/Data/SimpleQuery.php +++ b/library/Icinga/Data/SimpleQuery.php @@ -369,9 +369,7 @@ class SimpleQuery implements QueryInterface, Queryable, Iterator $column = $this->flippedColumns[$column]; } - // TODO: throw Exception if column is missing - //$res = strnatcmp(strtolower($a->$column), strtolower($b->$column)); - $result = @strcmp(strtolower($a->$column), strtolower($b->$column)); + $result = strcmp(strtolower($a->$column), strtolower($b->$column)); if ($result === 0) { return $this->compare($a, $b, ++$orderIndex); }