tyler.durden
/
icingaweb2
mirror of https://github.com/Icinga/icingaweb2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

monitoring/API: Require a filter when scheduling service downtimes 

refs #9606
This commit is contained in:
Eric Lippmann 2015-08-25 09:23:36 +02:00
parent 146ea971c4
commit 04ae298c0c
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
modules/monitoring/application/controllers/ActionsController.php
View File

@ -72,11 +72,15 @@ class Monitoring_ActionsController extends Controller
*/ */
public function scheduleServiceDowntimeAction() public function scheduleServiceDowntimeAction()
{ {
// @TODO(el): Require a filter $filter = Filter::fromQueryString((string) $this->params);
/** @var Filter $filter */
if ($filter->isEmpty()) {
$this->httpBadRequest('Filter must not be empty');
}
// @TODO(el): $this->backend->list('service')->handleRequest()->fetchAll() // @TODO(el): $this->backend->list('service')->handleRequest()->fetchAll()
$serviceList = new ServiceList($this->backend); $serviceList = new ServiceList($this->backend);
$this->applyRestriction('monitoring/filter/objects', $serviceList); $this->applyRestriction('monitoring/filter/objects', $serviceList);
$serviceList->addFilter(Filter::fromQueryString((string) $this->params)); $serviceList->addFilter($filter);
if (! $serviceList->count()) { if (! $serviceList->count()) {
// @TODO(el): Use ApiResponse class for unified response handling. // @TODO(el): Use ApiResponse class for unified response handling.
$this->getResponse()->sendJson(array( $this->getResponse()->sendJson(array(