tyler.durden
/
icingaweb2
mirror of https://github.com/Icinga/icingaweb2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix filter tests not taking whitespaces into account 

refs #8777
This commit is contained in:
Eric Lippmann 2015-04-08 10:18:42 +02:00
parent a185107927
commit 09acddb3b7
1 changed files with 46 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

55
test/php/library/Icinga/Data/Filter/FilterTest.php
View File

@ -198,16 +198,53 @@ class FilterTest extends BaseTestCase
$this->assertNotEquals((string) $c, (string) $d); $this->assertNotEquals((string) $c, (string) $d);
} }
public function testLeadingAndTrailingWhitespacesSanitizing() public function testLeadingAndTrailingWhitespaces()
{ {
$columnHasWhitespaces = Filter::where(' host ', 'localhost'); $columnWithWhitespaces = Filter::where(' host ', 'localhost');
$expressionHasWhitespaces = Filter::where('host', ' localhost '); $this->assertTrue($columnWithWhitespaces->matches((object) array(
$bothHaveWhitespaces = Filter::fromQueryString(' host = localhost '); 'host' => 'localhost'
$withArray = Filter::where(' host ', array(' no match ', ' localhost ')); )),
$this->assertTrue($columnHasWhitespaces->matches($this->sampleData[0])); 'Filter doesn\'t remove leading and trailing whitespaces from columns'
$this->assertTrue($expressionHasWhitespaces->matches($this->sampleData[0])); );
$this->assertTrue($bothHaveWhitespaces->matches($this->sampleData[0])); $expressionWithLeadingWhitespaces = Filter::where('host', ' localhost');
$this->assertTrue($withArray->matches($this->sampleData[0])); $this->assertTrue($expressionWithLeadingWhitespaces->matches((object) array(
'host' => ' localhost'
)),
'Filter doesn\'t take leading whitespaces of expressions into account'
);
$this->assertFalse($expressionWithLeadingWhitespaces->matches((object) array(
'host' => ' localhost '
)),
'Filter doesn\'t take trailing whitespaces of expressions into account'
);
$expressionWithTrailingWhitespaces = Filter::where('host', 'localhost ');
$this->assertTrue($expressionWithTrailingWhitespaces->matches((object) array(
'host' => 'localhost '
)),
'Filter doesn\'t take trailing whitespaces of expressions into account'
);
$this->assertFalse($expressionWithTrailingWhitespaces->matches((object) array(
'host' => ' localhost '
)),
'Filter doesn\'t take leading whitespaces of expressions into account'
);
$expressionWithLeadingAndTrailingWhitespaces = Filter::where('host', ' localhost ');
$this->assertTrue($expressionWithLeadingAndTrailingWhitespaces->matches((object) array(
'host' => ' localhost '
)),
'Filter doesn\'t take leading and trailing whitespaces of expressions into account'
);
$this->assertFalse($expressionWithLeadingAndTrailingWhitespaces->matches((object) array(
'host' => ' localhost '
)),
'Filter doesn\'t take leading and trailing whitespaces of expressions into account'
);
$queryStringWithWhitespaces = Filter::fromQueryString(' host = localhost ');
$this->assertTrue($queryStringWithWhitespaces->matches((object) array(
'host' => ' localhost '
)),
'Filter doesn\'t take leading and trailing whitespaces of expressions in query strings into account'
);
} }
private function row($idx) private function row($idx)