monitoring: Fix unused local variable 'stateType' in the ListController

This commit is contained in:
Eric Lippmann 2015-01-20 16:14:56 +01:00
parent f5acd0c7b5
commit 0b557b7b29

View File

@ -91,12 +91,10 @@ class Monitoring_ListController extends Controller
} }
// Handle soft and hard states // Handle soft and hard states
$stateType = $this->params->shift('stateType', 'soft'); if (strtolower($this->params->shift('stateType', 'soft')) === 'hard') {
if ($stateType == 'hard') {
$stateColumn = 'host_hard_state'; $stateColumn = 'host_hard_state';
$stateChangeColumn = 'host_last_hard_state_change'; $stateChangeColumn = 'host_last_hard_state_change';
} else { } else {
$stateType = 'soft';
$stateColumn = 'host_state'; $stateColumn = 'host_state';
$stateChangeColumn = 'host_last_state_change'; $stateChangeColumn = 'host_last_state_change';
} }
@ -164,14 +162,12 @@ class Monitoring_ListController extends Controller
} }
// Handle soft and hard states // Handle soft and hard states
$stateType = $this->params->shift('stateType', 'soft'); if (strtolower($this->params->shift('stateType', 'soft')) === 'hard') {
if ($stateType == 'hard') {
$stateColumn = 'service_hard_state'; $stateColumn = 'service_hard_state';
$stateChangeColumn = 'service_last_hard_state_change'; $stateChangeColumn = 'service_last_hard_state_change';
} else { } else {
$stateColumn = 'service_state'; $stateColumn = 'service_state';
$stateChangeColumn = 'service_last_state_change'; $stateChangeColumn = 'service_last_state_change';
$stateType = 'soft';
} }
$this->addTitleTab('services', $this->translate('Services')); $this->addTitleTab('services', $this->translate('Services'));