tyler.durden/icingaweb2
1
0
Fork 0
mirror of https://github.com/Icinga/icingaweb2.git synced 2025-07-31 01:34:09 +02:00
Code Issues Packages Projects Releases Wiki Activity

Don't destroy links by adding zero width space characters to plugin output

Browse Source 
refs #11796
This commit is contained in:
Alexander A. Klimov 2016-05-19 18:38:36 +02:00
parent 695d2fdaf6
commit 10d2b9c51d
1 changed files with 35 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

41
modules/monitoring/application/views/helpers/PluginOutput.php
View File

@ -27,6 +27,16 @@ class Zend_View_Helper_PluginOutput extends Zend_View_Helper_Abstract
'@@@@@@', '@@@@@@',
); );
/**
* @var string
*/
protected $zeroWidthSpace;
public function __construct()
{
$this->zeroWidthSpace = html_entity_decode('​', ENT_NOQUOTES, 'UTF-8');
}
public function pluginOutput($output, $raw = false) public function pluginOutput($output, $raw = false)
{ {
if (empty($output)) { if (empty($output)) {
@ -50,15 +60,11 @@ class Zend_View_Helper_PluginOutput extends Zend_View_Helper_Abstract
); );
$isHtml = false; $isHtml = false;
} }
$output = $this->fixLinks($output); $output = $this->fixLinksAndWrapping($output);
// Help browsers to break words in plugin output // Help browsers to break words in plugin output
$output = trim($output); $output = trim($output);
// Add space after comma where missing // Add space after comma where missing
$output = preg_replace('/,[^\s]/', ', ', $output); $output = preg_replace('/,[^\s]/', ', ', $output);
// Add zero width space after ')', ']', ':', '.', '_' and '-' if not surrounded by whitespaces
$output = preg_replace('/([^\s])([\\)\\]:._-])([^\s])/', '$1$2​$3', $output);
// Add zero width space before '(' and '[' if not surrounded by whitespaces
$output = preg_replace('/([^\s])([([])([^\s])/', '$1​$2$3', $output);
if (! $raw) { if (! $raw) {
if ($isHtml) { if ($isHtml) {
@ -70,13 +76,14 @@ class Zend_View_Helper_PluginOutput extends Zend_View_Helper_Abstract
return $output; return $output;
} }
protected function fixLinks($html) protected function fixLinksAndWrapping($html)
{ {
$ret = array(); $ret = array();
$dom = new DOMDocument; $dom = new DOMDocument;
$dom->loadXML('<div>' . $html . '</div>', LIBXML_NOERROR | LIBXML_NOWARNING); $dom->loadXML('<div>' . $html . '</div>', LIBXML_NOERROR | LIBXML_NOWARNING);
$dom->preserveWhiteSpace = false; $dom->preserveWhiteSpace = false;
$links = $dom->getElementsByTagName('a'); $links = $dom->getElementsByTagName('a');
foreach ($links as $tag) foreach ($links as $tag)
{ {
@ -93,6 +100,9 @@ class Zend_View_Helper_PluginOutput extends Zend_View_Helper_Abstract
} }
//$ret[$tag->getAttribute('href')] = $tag->childNodes->item(0)->nodeValue; //$ret[$tag->getAttribute('href')] = $tag->childNodes->item(0)->nodeValue;
} }
$this->fixWrappingRecursive($dom);
return substr($dom->saveHTML(), 5, -7); return substr($dom->saveHTML(), 5, -7);
} }
@ -119,4 +129,23 @@ class Zend_View_Helper_PluginOutput extends Zend_View_Helper_Abstract
} }
return self::$purifier; return self::$purifier;
} }
/**
* Add zero width space to all text in the DOM to make wrapping easier for the user agent
*
* @param DOMNode $node
*/
protected function fixWrappingRecursive(DOMNode $node)
{
if ($node instanceof DOMText) {
// Add zero width space after ')', ']', ':', '.', '_' and '-' if not surrounded by whitespaces
$data = preg_replace('/([^\s])([\\)\\]:._-])([^\s])/', '$1$2' . $this->zeroWidthSpace . '$3', $node->data);
// Add zero width space before '(' and '[' if not surrounded by whitespaces
$node->data = preg_replace('/([^\s])([([])([^\s])/', '$1' . $this->zeroWidthSpace . '$2$3', $data);
} elseif ($node->childNodes !== null) {
foreach ($node->childNodes as $childNode) {
$this->fixWrappingRecursive($childNode);
}
}
}
} }